RE: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver

2008-08-23 Thread Shyam_Iyer
Andrew Morton wrote: + * + * Written by: Karen Xie ([EMAIL PROTECTED]) */ + +#include cxgb3i.h + +#define DRV_MODULE_NAME cxgb3i +#define DRV_MODULE_VERSION 1.0.0 I'd suggest that the version number just be removed. It becomes meaningless (and often misleading) once

RE: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver

2008-08-23 Thread Shyam_Iyer
David Miller wrote: Andrew Morton wrote: I'd suggest that the version number just be removed. It becomes meaningless (and often misleading) once a driver is in the mainline kernel. People will update the driver without changing the version number. Code external to the driver but

RE: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver

2008-08-23 Thread Shyam_Iyer
Look, what you're suggesting is to change existing practice and that doesn't belong in the discussion of the review of a specific driver. If you want to bring that up as a topic and change globally how that is handled, bring that up as a seperate topic on linux-kernel. Sounds reasonable. Don't

Re: [PATCH] iscsi: ‘err’ may be used uninitialized in iscsi_add_session

2008-08-23 Thread Mike Christie
Benny Halevy wrote: gcc 4.3.0 prints this warning: drivers/scsi/scsi_transport_iscsi.c: In function ‘iscsi_add_session’: drivers/scsi/scsi_transport_iscsi.c:703: warning:\ ‘err’ may be used uninitialized in this function I'm not sure how exactly this can happen with ISCSI_MAX_TARGET

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Andrew Morton
On Fri, 22 Aug 2008 11:38:32 -0700 Karen Xie [EMAIL PROTECTED] wrote: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI From: Karen Xie [EMAIL PROTECTED] Create a per port sysfs entry to pass an IP address to the NIC driver, and a control call for the iSCSI driver to grab

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Andrew Morton
On Fri, 22 Aug 2008 14:17:18 -0500 Steve Wise [EMAIL PROTECTED] wrote: Andrew Morton wrote: + unsigned long octet; + const char *parse = buf; + char *endp; + int i; + + for (i = 1; i = 4; i++) { + octet = simple_strtoul(parse, endp, 10); + if (endp == buf

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Steve Wise
Andrew Morton wrote: +unsigned long octet; +const char *parse = buf; +char *endp; +int i; + +for (i = 1; i = 4; i++) { +octet = simple_strtoul(parse, endp, 10); +if (endp == buf || octet 255 || +(i 4 *endp != '.') || +

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Steve Wise
Andrew Morton wrote: On Fri, 22 Aug 2008 14:17:18 -0500 Steve Wise [EMAIL PROTECTED] wrote: Andrew Morton wrote: + unsigned long octet; + const char *parse = buf; + char *endp; + int i; + + for (i = 1; i = 4; i++) { + octet = simple_strtoul(parse, endp, 10); +

Re: [PATCH 2/4 2.6.28] cxgb3 - handle ARP replies for private iSCSI IP address

2008-08-23 Thread Andrew Morton
On Fri, 22 Aug 2008 11:39:08 -0700 Karen Xie [EMAIL PROTECTED] wrote: [PATCH 2/4 2.6.28] cxgb3 - handle ARP replies for private iSCSI IP address From: Karen Xie [EMAIL PROTECTED] stg can be tricky ... [adding @adapter in cxgb3_arp_process doxygen header] The accelerated iSCSI traffic

Re: [PATCH 0/4 2.6.28] cxgb3i - Add iSCSI driver

2008-08-23 Thread Jeff Garzik
Karen Xie wrote: Hi, everyone, Please review our new version of the iSCSI Initiator drivers for Chelsio S3 adapters. The cxgb3i driver provides iscsi acceleration (PDU digest offload and payload direct-placement) to the open-iscsi initiator. It accesses the hardware through the cxgb3

EqualLogic SAN events

2008-08-23 Thread william . ring
I am getting this event on my SAN every minute, its obviously a mistaken assignment somewhere but i can't seem to find it on any of the blades or VM servers. I would just like a method to stop the events somehow. any comments ERROR 8/22/08 3:46:57 PM USEVTSANC02 iSCSI login to target

Re: [PATCH 1/4 2.6.28] cxgb3 - manage a private ip address for iSCSI

2008-08-23 Thread Herbert Xu
On Fri, Aug 22, 2008 at 07:08:51PM +, Andrew Morton wrote: +static ssize_t iscsi_ipaddr_attr_store(struct device *d, +const char *buf, size_t len) +{ + struct port_info *pi = netdev_priv(to_net_dev(d)); + __be32 a = 0; There's not really

Re: [PATCH 4/4 2.6.28] cxgb3i - cxgb3i iscsi driver

2008-08-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Sat, 23 Aug 2008 14:37:53 +0530 Exactly. And I am also suggesting that the driver version is not standard among different vendors. It should not be standardized because every driver maintainer works differently, and every driver is developed differently, and

RE: EqualLogic SAN events

2008-08-23 Thread Don Williams
Once a volume is discovered it's stored in the NVRAM of the Qlogic card. Under Configuration-Storage Adapters-vmhbaX-Properties-Static Mappings You'll find that volume and can remove it from the card. I suspect that's a volume you deleted? Regards, Don -Original Message- From: