Re: [PATCHv2 0/3] iscsiuio: Update autoconf
On 1/29/14 1:51 PM, Hannes Reinecke wrote: On 01/29/2014 07:27 PM, Eddie Wai wrote: The patchset works great on my system. Forcing an autoreconf and untrack all autogen files makes sense. Thanks for the work. Although I would be more inclined to put all .gitignore entries into a single .gitignore file in the trunk, separating them out is fine too. That's what I've tried, but somehow git would like it. Hence the split. There's actually an error in the autoconf files, which I discovered later during testing; in iscsiuio/src/uip/Makefile.am the statement lib_iscsi_uip_a_CFLAGS = is missing an $(AM_CFLAGS). Should I send an incremental patch or re-do the patchset? Don't worry about it. I just did a patch on top of your set. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
Re: [PATCHv2 0/3] iscsiuio: Update autoconf
On 1/29/14 2:27 AM, Hannes Reinecke wrote: Hi Eddie, as discussed here is a patchset to remove the auto-generated files from tracking. And I've updated the autoconf files so the current autoreconf doesn't complain. The first version actually had an error here, so that autoconf wouldn't install all required files. That's fixed now. And I've added .gitignore files so that the autogenerated files won't show up anymore. Please note I've attached the patches as a tarball; I've found that sending them via 'git send-email' leads to corruption due to mime-encoding as the original files have binary ^M embedded. Bah. Hannes Reinecke (3): iscsiuio: Remove autogenerated files from tracking iscsiuio: Update automake files iscsiuio: Add .gitignore files Merged. Thanks! -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
Re: [PATCHv2 0/3] iscsiuio: Update autoconf
The patchset works great on my system. Forcing an autoreconf and untrack all autogen files makes sense. Thanks for the work. Although I would be more inclined to put all .gitignore entries into a single .gitignore file in the trunk, separating them out is fine too. Acked-by: Eddie Wai eddie@broadcom.com On Wed, 2014-01-29 at 09:27 +0100, Hannes Reinecke wrote: Hi Eddie, as discussed here is a patchset to remove the auto-generated files from tracking. And I've updated the autoconf files so the current autoreconf doesn't complain. The first version actually had an error here, so that autoconf wouldn't install all required files. That's fixed now. And I've added .gitignore files so that the autogenerated files won't show up anymore. Please note I've attached the patches as a tarball; I've found that sending them via 'git send-email' leads to corruption due to mime-encoding as the original files have binary ^M embedded. Bah. Hannes Reinecke (3): iscsiuio: Remove autogenerated files from tracking iscsiuio: Update automake files iscsiuio: Add .gitignore files -- Dr. Hannes Reinecke zSeries Storage h...@suse.de+49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
Re: [PATCHv2 0/3] iscsiuio: Update autoconf
On 01/29/2014 07:27 PM, Eddie Wai wrote: The patchset works great on my system. Forcing an autoreconf and untrack all autogen files makes sense. Thanks for the work. Although I would be more inclined to put all .gitignore entries into a single .gitignore file in the trunk, separating them out is fine too. That's what I've tried, but somehow git would like it. Hence the split. There's actually an error in the autoconf files, which I discovered later during testing; in iscsiuio/src/uip/Makefile.am the statement lib_iscsi_uip_a_CFLAGS = is missing an $(AM_CFLAGS). Should I send an incremental patch or re-do the patchset? Cheers, Hannes -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/groups/opt_out.
