Re: comment on ipaccess-find: Work without providing an interface name

2011-05-17 Thread Holger Freyther
On 05/17/2011 08:08 PM, Pablo Neira Ayuso wrote: > Hi Holger, > > I think this patch is wrong: > > http://cgit.osmocom.org/cgit/openbsc/commit/?id=d3080be1317cfa0269b1c12c8f28ffe2c1855f98 > > ifname should be set if argc == 2, but it seems to be set if argc < 2, > in that case argv[1] is always

Re: Problems suspected to be related to _output() rework

2011-05-18 Thread Holger Freyther
On 05/18/2011 01:01 AM, Pablo Neira Ayuso wrote: > thanks, I'll keep investigating this tomorrow. This tastes like a memory > corruption, but not sure that this occurs in the _output() function. > > I'll try to get a fix for this by tomorrow. > The easiest guess is that we either need the va_st

Re: fix missing all logging command option

2011-05-18 Thread Holger Freyther
On 05/19/2011 01:04 AM, Pablo Neira Ayuso wrote: > Hi Holger, > > Thanks for fixing this, I missed it: > > http://cgit.osmocom.org/cgit/libosmocore/commit/?id=952a18ed19f531b82e26108f8c46ef225fddef43 > > However, this fix is incomplete: Hi, thanks for the review (*blushing*). I think we should

Re: Welcome Message Upon first Connect / Trigger to External Server for LUR

2017-05-15 Thread Holger Freyther
> On 15. May 2017, at 17:35, Ron wrote: > > Hi All, > > Is there the an equivalent configuration from OpenBTS’ > Control.LUR.!OpenRegistration.Message in OSMO? This is the welcome SMS to the > devices when they attached to an open registration network. > > What we are trying to do is replica

Re: Voice audio testing in osmo-gsm-tester

2017-05-29 Thread Holger Freyther
> On 30. May 2017, at 08:23, Harald Welte wrote: > > Hi Mychaela, > > > If I remember correctly, it was the Gemalto EHS-6, which can disable the > GPS uart and re-cycle that UART for the audio frames. It might also > have been a Quectel UC-20. Now that I think more about it, I think it > was

Re: Voice audio testing in osmo-gsm-tester

2017-05-29 Thread Holger Freyther
> On 30. May 2017, at 09:43, Mychaela Falconia > wrote: > > Holger Freyther wrote: Hi > What exactly are the bits which you send and receive every 40 ms? Do > you get two 260-bit GSM 06.10 codec frames every 40 ms, with the > ability to send your own arbitrary bit

libosmo-sccp: Build breakage on --disable-static

2017-06-02 Thread Holger Freyther
Hi, I just looked into a build breakage when --disable-static is passed. The first failure is because of: libosmo_sigtran_la_LDFLAGS = -version-info $(LIBVERSION) \ -no-undefined \ -export-symbols-regex '^osmo

Re: libosmo-sccp: Build breakage on --disable-static

2017-06-03 Thread Holger Freyther
> On 3. Jun 2017, at 16:40, Harald Welte wrote: > > Hi Holger, Hi, > I actually really liked the idea as an elegant way to have test cases > access more "private" / "low-end" functions inside the implementation, > while ensuring only proper APIs are exposed to actual applications > (which us

Re: Accelerate3g5 Problem in cellphone attach procedure

2017-06-06 Thread Holger Freyther
> On 6. Jun 2017, at 19:25, Neels Hofmeyr wrote: > > So everything looks good from these logs. Cannot tell why this procedure would > repeat over and over? Does it? Is a TMSI assigned? What is the TMSI? @Lin: Please make a trace of two/three loops and attach it to the mail. holger

Re: Accelerate3g5 Problem in cellphone attach procedure

2017-06-06 Thread Holger Freyther
> On 7. Jun 2017, at 10:48, 雪碧 0xroot wrote: > > Thanks for the quick reply. I wondered if I need to clarify but then assumed it would be obvious enough. With trace I meant packet trace to capture what is being sent between the different components. > > >Is a TMSI assigned? What is the T

Re: jenkins: Osmocom_Sanitizer build fails

2017-06-18 Thread Holger Freyther
> On 18. Jun 2017, at 22:18, Neels Hofmeyr wrote: Hi! > Today I noticed that the Osmocom_Sanitizer build has been broken for a long > time, failing at libosmocore/src/viterbi_sse.c. But that seems like the fault > of the way the Osmocom_Sanitizer builds: can you think of a way to help us "sp

Re: jenkins plugin question

2017-06-22 Thread Holger Freyther
> On 22. Jun 2017, at 15:49, Max wrote: > > Hi. > > > I'd like to install this plugin onto our jenkins and convert above mentioned > jobs to > use it. Opinions, other ideas? See the conversation when blobb proposed to use it? I think many of the arguments still apply? holger

Re: legacy codecs / mixing rates and versions

2017-07-18 Thread Holger Freyther
> On 18. Jul 2017, at 12:05, Harald Welte wrote: > Hey! > I completely understand that there is a point to having a policy that > can be configured at the BSC to restrict its supported codecs for > whatever local policy/configuration reason. This makes complete sense. > > I however don't un

osmo-pcap[master]: Rename osmo_pcap_{client_server} executables to osmo-pcap-{c...

2017-07-21 Thread Holger Freyther
-PatchSet: 1 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No

osmo-pcap[master]: Rename osmo_pcap_{client_server} executables to osmo-pcap-{c...

2017-07-21 Thread Holger Freyther
: If1e3ce76f93266e0f01c801204769432b571fdb1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No

osmo-pcap[master]: Use TCP port numbers for VTY that don't overlap with other O...

2017-07-21 Thread Holger Freyther
https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I638ac0534517931d0987ce9f72f5db4f5b6c16b7 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No

osmo-pcap[master]: sock_src_init(): Don't freeaddrinfo() undefined src_result

2017-07-21 Thread Holger Freyther
https://gerrit.osmocom.org/3324 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6778d9110583ecb1daec59ef2c86465d5818b9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger

osmo-pcap[master]: Rename osmo_pcap_{client_server} executables to osmo-pcap-{c...

2017-07-21 Thread Holger Freyther
Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No

osmo-pcap[master]: Use TCP port numbers for VTY that don't overlap with other O...

2017-07-21 Thread Holger Freyther
://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I638ac0534517931d0987ce9f72f5db4f5b6c16b7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments

osmo-pcap[master]: sock_src_init(): Don't freeaddrinfo() undefined src_result

2017-07-21 Thread Holger Freyther
it https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b6778d9110583ecb1daec59ef2c86465d5818b9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer:

osmo-pcap[refs/meta/config]: Edit Project Config

2017-07-21 Thread Holger Freyther
/config Gerrit-Owner: Holger Freyther Gerrit-Reviewer: Holger Freyther Gerrit-HasComments: No

[PATCH] osmo-pcap[refs/meta/config]: Edit Project Config

2017-07-21 Thread Holger Freyther
rg/3328 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I343a8f967e7d07d543807f292e5be60af61a0c97 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcap Gerrit-Branch: refs/meta/config Gerrit-Owner: Holger Freyther

[PATCH] osmo-pcap[refs/meta/config]: Edit Project Config

2017-07-21 Thread Holger Freyther
smocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I343a8f967e7d07d543807f292e5be60af61a0c97 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcap Gerrit-Branch: refs/meta/config Gerrit-Owner: Holger Freyther

osmo-pcap[refs/meta/config]: Edit Project Config

2017-07-21 Thread Holger Freyther
Gerrit-Branch: refs/meta/config Gerrit-Owner: Holger Freyther Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Holger Freyther Gerrit-HasComments: No

Re: Ring Back Tone Missing during Call Setup

2017-07-29 Thread Holger Freyther
> On 27. Jul 2017, at 18:30, Ron wrote: > > Hi All, > > I’m not sure if this is a valid question but still I’m going to try. > > I just updated from my old version of OSMOCOM to the latest one. > > Upon trying to test the updated version, it seems that the ring back tone, > the one that ring

Re: paging priority

2017-08-09 Thread Holger Freyther
> On 9. Aug 2017, at 16:37, robert wrote: > > Hi, Hey! > I have noticed that when there are many MS connecting to my BTS if I try to > page (call or send SMS) a specific MS it takes a long time and sometimes just > fails. Is there a way to give a higher priority for paging under high networ

Re: Ring Back Tone Missing during Call Setup

2017-08-11 Thread Holger Freyther
> On 11. Aug 2017, at 14:47, Ron wrote: > > Hi Holger, Hey! > > As tested, we had confirmed that the updated version of osmo-sip-connector > has an issue regarding the Ring Back Tone. > > The version that we had confirmed with Ring Back Tone is the > "4649746798fe3074edab720302d135c74dcf3

Re: libosmocore and SSE

2017-08-15 Thread Holger Freyther
> On 15. Aug 2017, at 07:24, Neels Hofmeyr wrote: > > It's the build host 'cumulus3' running on opensuse.org, I assume we have no / > cannot get any shell access easily. cat /proc/cpuinfo cat config.log objdump -d tests/.libs/foo? to see which SSE routines were generated? from the debian ru

Re: Jenkins now executing M3UA, SUA and GGSN testuite

2017-08-21 Thread Holger Freyther
> On 21. Aug 2017, at 04:41, Harald Welte wrote: > > 4) archiving logs. It would be great to keep the logs of not only the > last test execution around. Sure, jenkins has stdout (of the tester) > and junit-xml (of the tester). But things like the log file > generated by the IUT is curre

Re: jenkins build slaves: Rationale for some builds in docker vs. some not?

2017-08-25 Thread Holger Freyther
> On 25. Aug 2017, at 19:15, Harald Welte wrote: > > Hi! Hi! > > We have some builds that happen inside a docker, and some that happen natively > on the (Debian 8) build slave. Can somebody involved with this illustrate > why that is the case, and what's the rationale here? historically I w

Re: jenkins build slaves: Rationale for some builds in docker vs. some not?

2017-08-31 Thread Holger Freyther
> On 27. Aug 2017, at 16:28, Neels Hofmeyr wrote: > > Hey! > Unfortunately, documenting the jenkins setup while tweaking it is time > consuming and tends to become outdated quickly. I think documenting our entire > setup is nontrivial. I did so for the osmo-gsm-tester jobs, which takes up a

Re: cgit.osmocom.org was down / ezjail disk quota managed by zfs

2017-09-02 Thread Holger Freyther
, but the others seem not to. > How does it work, set a huge quota to allow space for snapshots, and limit the > fs itself by a refquota? quota -> refquota is a good thing. Let's do it. I think we ran into this not because the actual jail size was > 10GB but the cache was re-written

Re: cgit.osmocom.org was down / ezjail disk quota managed by zfs

2017-09-03 Thread Holger Freyther
> On 3. Sep 2017, at 02:08, Neels Hofmeyr wrote: > >> when are snapshots used? > > I'm not entirely sure. Holger? They are automatically created by "zfsnap" and are a safety net for us to allow a quick rollback or find older files. holger -- Holger

Re: cgit.osmocom.org was down / ezjail disk quota managed by zfs

2017-09-04 Thread Holger Freyther
f URLs. Luckily with git the rendering of a specific commit will not change... * have crawler specific robots.txt to disable the SEO ones.. what do you think? holger -- Holger Freyther http://www.sysmocom.de/ === *

Re: RFC: gerrit verifcations as Jenkins Job Builder YAML file

2017-09-12 Thread Holger Freyther
> On 12. Sep 2017, at 20:25, André Boddenberg wrote: > > Hi all, Hey! > > > I've created a prototyp'ish JJB YAML file [1] that holds all current > gerrit verification jobs on jenkins.osomocom.org. Holger and Lynxis > suggested to explore this way of managing Jenkins jobs in the "jenkins >

Re: VTY tests still causing build failures

2017-09-13 Thread Holger Freyther
> On 13. Sep 2017, at 07:41, Neels Hofmeyr wrote: > Hi! > On Mon, Sep 11, 2017 at 09:09:06PM +0200, Harald Welte wrote: >> In https://gerrit.osmocom.org/3899 which has failed in >> https://jenkins.osmocom.org/jenkins/job/OpenBSC-gerrit/2451/ and >> https://jenkins.osmocom.org/jenkins/job/Open

Re: ctrl interface: GET a variable with parameter

2017-09-27 Thread Holger Freyther
> On 26. Sep 2017, at 22:00, Neels Hofmeyr wrote: > > Experimenting a bit, I found that for GET commands, any tokens sent after > the variable name are ignored, dropped on the floor and cause neither an > error nor are evaluated. IIRC it was modeled like a property/sysctl. E.g. kernel.sched_do

Re: randomness of identifiers

2017-09-27 Thread Holger Freyther
> On 27. Sep 2017, at 19:57, Harald Welte wrote: > > For TMSI allocation, my "cryptographic gut feeling"[tm] is that something > like rand() or any other pseudo-random generator of significantly large > period is sufficient *if* it is seeded by a non-predictable value. So > something like seed

Re: Osmo_IuH_building_problems

2017-09-29 Thread Holger Freyther
> On 29. Sep 2017, at 23:11, Popovic Goran wrote: > > Hi, Hi! > > I tried this time from the scratch with > git://git.osmocom.org/osmo-dev > > Curently stucked with I haven't looked at the test results but the pretty first idea is that you installed the Osmocom libraries in a nonstand

Re: Osmo_IuH_building_problems

2017-09-29 Thread Holger Freyther
> On 29. Sep 2017, at 23:27, Popovic Goran wrote: > > Hi Holger, Hi, > Thanks for response, > From tesfailure log this error is seen > > +/home/popovicg/osmo-dev/make-3G+2G-default+iu/osmo-msc/tests/sms_queue/sms_queue_test: > error while loading shared libraries: libsmpp34.so.0: cannot ope

Re: randomness of identifiers

2017-10-05 Thread Holger Freyther
> On 5. Oct 2017, at 15:35, Harald Welte wrote: > > Hi Holger, Hi, >> Picking something like RAND_bytes of OpenSSL for TMSIs seems to be the >> best way. It will re-seed itself (and we are not forking). > > Ok, then let's do that. Maybe to expand on the "forking" part. OpenSSL didn't (and

Re: Integrating openBSC with 3rd party MSC

2017-10-08 Thread Holger Freyther
> On 9. Oct 2017, at 02:55, Neels Hofmeyr wrote: > > On Sat, Oct 07, 2017 at 05:09:47PM +0530, Anindya Sankar Roy wrote: >> <0021> socket.c:258 unable to connect socket: (null):2905: Connection >> refused >> <002d> osmo_ss7.c:1215 0: Unable to open stream client for ASP >> asp-clnt-msc-0 > > os

Re: osmo-bsc access lists semantics are confusing

2017-11-08 Thread Holger Freyther
> On 9. Nov 2017, at 12:40, Neels Hofmeyr wrote: > > My questions are: > > - Is it implemented this way for performance considerations? The performance consideration doesn't have anything to do with the order of matches. Not to use longest matching rule might be considered a performance consid

Re: OsmoDevCon 2018 schedule planning

2017-12-04 Thread Holger Freyther
> On 4. Dec 2017, at 12:23, Harald Welte wrote: > > Hi! thanks for organizing this once again! It is always a pleasure to attend. > I propose the following date for OsmoDevCon 2018: > April 20 - April 23rd, 2018 Not that I think it should be postponed because of me but all of April

Re: gerrit load

2017-12-19 Thread Holger Freyther
> On 19. Dec 2017, at 16:56, Harald Welte wrote: > > Hi Neels, > > there are projects with much larger gerrit pending patch queue, so I'd > be surprised if we cannot drive it with more patches than we currently do. I share this sentiment. CPU and RAM are so cheap we should be able to tolerate

Re: Jenkins integration of OsmoBSC TTCN-3 test suite

2017-12-19 Thread Holger Freyther
> On 17. Dec 2017, at 18:49, Harald Welte wrote: > > Dear all, Hey! > I'll stop working on the test coverage for now and focus on other areas > of testing first (as well as fixing some of the now-known bugs). Any > help is greatly appreciated. congrats. Nice findings! Some are known limita

Approach to system testing for Osmocom stack

2018-01-09 Thread Holger Freyther
Hi, the lua binding code was added to be able to automate OpenBSC tests. In theory we should be able to do this for SMS and UpdateLocation (call handling with MNCC exposing is left as a todo) but in practice we miss a piece of software to coordinate this and run the test. We miss it because it

Re: Approach to system testing for Osmocom stack

2018-01-10 Thread Holger Freyther
> On 10. Jan 2018, at 11:55, Harald Welte wrote: > > Hi Holger, > Sure, I understand. However, it is definitely a part that we're very > much looking forward to have :) me too... I dislike not having made progress here. > One might also think of a more structured format to return the data,

Re: Approach to system testing for Osmocom stack

2018-01-21 Thread Holger Freyther
> On 10. Jan 2018, at 23:39, Harald Welte wrote: > Hi! > If you reuse osmo-gsm-tester code for templates or the like, then it should > probably go there. If not, OsmocomBB seems like the more logical place. > Would be great if in that case it is some kind of python library/module > and a sma

Re: Approach to system testing for Osmocom stack

2018-01-28 Thread Holger Freyther
> On 21. Jan 2018, at 20:16, Holger Freyther wrote: > Hey! some more progress. I had to learn a bit about asyncio and in the end will be forced to use a stream socket[1] and will end up using the IPA and add a reservation for JSON events. I will probably push my unfinished code to gerr

Re: Approach to system testing for Osmocom stack

2018-01-29 Thread Holger Freyther
> On 29. Jan 2018, at 10:50, Harald Welte wrote: > > Hi Holger, > > thanks for your status update. Looking forward to the related code. hehe. It is just a couple of hundred lines so far. It should bring us far enough. Will continue with it in a few minutes. For simplicity I am not segmenting

Re: Approach to system testing for Osmocom stack

2018-02-04 Thread Holger Freyther
> On 29. Jan 2018, at 21:52, Holger Freyther wrote: > Hey, I wish I had better news. Instead of an end to end test I realize that picking "asyncio" was a grave mistake. Besides the lack AF_UNIX SOCK_DGRAM support, the process support is dangerous and doesn't scale.

Re: Approach to system testing for Osmocom stack

2018-02-07 Thread Holger Freyther
> On 4. Feb 2018, at 22:35, Holger Freyther wrote: Hi, > * SIGCHLD arrives > * Something will be written into one end of a socketpair[1] > * In the python code on wait(2) will be called on every registered process > (https://github.com/python/cpython/blob/3.6/Lib/asyncio/unix

Test please ignore..

2018-02-10 Thread Holger Freyther

Re: Approach to system testing for Osmocom stack

2018-02-25 Thread Holger Freyther
> On 7. Feb 2018, at 09:31, Holger Freyther wrote: > Hey, > Knowing what I know now I would have gone for Go. It is made for the kind of > concurrency where python seems unusable. I hesitated to build my own event > loop but will build something that looks like our C apps in

GSM tester scenarios and beyond

2018-03-05 Thread Holger Freyther
Hey neels, pespin, while looking at configuration handling for the MS driver I started to have sone questions about scenarios. I see that we have multiple yaml files and through scenarios can control ciphering, the timeslot configuration, which BTS model to test, and more. What would it take t

MS driver: GSM tester config integration

2018-03-05 Thread Holger Freyther
Hey, pespin left a good comment about the question of how the MS driver and the GSM tester could be better integrated. I was about to write some argparse code for the MS driver but I think it is best to make this configurable as a scenario. In terms of scenario knobs I can see: - #MS - CDF f

Re: GSM tester scenarios and beyond

2018-03-06 Thread Holger Freyther
> On 6. Mar 2018, at 10:59, Neels Hofmeyr wrote: > > The only benefit here is that a number of test cases don't each setup and > tear down the core net, so they would be a bit faster. And there's also > the drawback of complexity about handling situations where one test > manages to crash a p

Re: MS driver: GSM tester config integration

2018-03-07 Thread Holger Freyther
> On 6. Mar 2018, at 12:20, Pau Espin Pedrol wrote: > > Hi, Hey Neels, Pau, > I guess you are referring to my comment in [1]. You can reuse suite and > resources management utilities already present in osmo-gsm-tester. The > easiest way to do that would be to create a new implementation f

Re: OsmoHLR understanding/documentation/testing

2018-05-16 Thread Holger Freyther
> On 15. May 2018, at 21:49, Mykola Shchetinin wrote: > >> Why are you particularly interested in the HLR? > > We are going to write a simple proxy which converts from GSUP to MAP > and vice versa. > While that is not going to be easy, we have enough time and motivation for > that. https://g

Re: OsmoHLR understanding/documentation/testing

2018-05-16 Thread Holger Freyther
> On 16. May 2018, at 19:17, Mykola Shchetinin wrote: > Wow, thank you very much. Actually, I thought that Smalltalk is dead > (Or I was narrow-minded?). But it seems to be alive! :) Hehe. Well, it is not as hyped as PHP or NodeJS but that is not a bad thing. ;)

Re: React to IMSI Attach but not PERIODIC

2018-05-30 Thread Holger Freyther
> On 28. May 2018, at 19:14, Keith Whyte wrote: > > > > For the moment, what I've done is extend the SMPP availability statuses > and send a different status for IMSI_ATTACH to PERIODIC > The my SMPP listener is reacting differently depending on the status.. > This works for the moment for t

Re: Rationale behind ipa_ccm_idtag_parse_off() ?

2018-07-29 Thread Holger Freyther
> On 29. Jul 2018, at 10:33, Harald Welte wrote: > > > I'm getting back to the following libosmocore commit introduced in 2015: > >> commit f558ed4bb9c0f00997b8f97c2b251a574c1a64c4 >> Author: Holger Hans Peter Freyther >> Date: Tue Jun 2 15:52:06 2015 +0200 > > I can see what you are doi

Re: Rationale behind ipa_ccm_idtag_parse_off() ?

2018-07-29 Thread Holger Freyther
> On 29. Jul 2018, at 11:51, Harald Welte wrote: > > Hi Holger, > > > I think the pointer to ipaccess-find was sufficient, thanks. One more thing came to mind. It was when I implemented the sysmobts-mgr. sysmobts_mgr_nl.c has this comment: /* * The TLV structure in IPA messages in UDP p

Re: Rationale behind ipa_ccm_idtag_parse_off() ?

2018-07-30 Thread Holger Freyther
> On 30. Jul 2018, at 21:03, Harald Welte wrote: > > Hi Holger, > Hey! > I think the solution to the problem is that your test case parses the > IDENTITY REQUESET format, which has 8bit length fields, while the function > is normally (without the offset) used for the IDENTITY RESPONSE packe

shellcheck for our shell scripts?

2018-09-15 Thread Holger Freyther
Hey, I recently stumbled across shellcheck[1] and think we should make it a goal that our shell scripts don't produce errors/warnings with it. Some of the examples in the GSM tester: In jenkins-build-common.sh line 76: cd "$base" ^-- SC2164: Use 'cd ... || exit' or 'cd ... || return' in cas

Re: BSC / MSC volatile state / restart handling

2018-10-13 Thread Holger Freyther
> On 11. Oct 2018, at 20:59, Keith wrote: > > Hi All. Hi! > This is very brief, but something that's been on my mind to make a > ticket about. > > I realise maybe it's better to ask first if there is a plan. no plans but just some other generic approaches... If we ignore "crashes" and

Re: Rationale for having master builds in docker containers?

2018-12-06 Thread Holger Freyther
> On 6. Dec 2018, at 12:12, Tomcsányi, Domonkos wrote: > > Hi Neels, > > 2018. dec. 6. dátummal, 13:38 időpontban Neels Hofmeyr > írta: > >> >> Those are the projects that run the python-based external tests, which >> involve >> opening up VTY and CTRL ports among others, because we star

Scaling up virtual bts tests for the BTS test - how I hold it wrong?

2018-12-30 Thread Holger Freyther
After a lot of work[1] the gsm tester can finally: * Start a virtual bts * Mobile/virtphy processes * Complete LUs for 10 MS. The next step (besides having a proper test verdict) is scaling this beyond what a simple physical set-up can provide. Let's go to 100+ BTS and 10

Re: Scaling up virtual bts tests for the BTS test - how I hold it wrong?

2019-01-03 Thread Holger Freyther
> On 30. Dec 2018, at 23:21, Pau Espin Pedrol wrote: > > Hi Holger, Hey Pau, thank you for the instant response! > One can similarly do the same to request allocation of 100 sysmoBTS: > > bts: > - type: osmo-bts-sysmo > times: 100 ah great! That's a good interim solution. > I'd like

Declaratively describing network topology (WAS Re: Scaling up virtual bts tests for the BTS test - how I hold it wrong?)

2019-01-03 Thread Holger Freyther
> On 3. Jan 2019, at 15:13, Pau Espin Pedrol wrote: > Hi! let me spin this into a new thread. >> What we can't do with the above is simulate movements of subscribers (but we >> can't do that easily right now and can review it if that becomes a genuine >> requirement). We currently need t

Re: Declaratively describing network topology (WAS Re: Scaling up virtual bts tests for the BTS test - how I hold it wrong?)

2019-01-22 Thread Holger Freyther
> On 4. Jan 2019, at 02:36, Holger Freyther wrote: > Hey Pau! Please take your time to respond to this. I understand that this will stall for some time now. > > Does this change anything for you? When looking at the p4[1][2] examples I noticed they are in a similar si

Reset GSM tester state?

2019-01-28 Thread Holger Freyther
A wild guess but can any of you check if the GSM tester state is corrupt again? My test with virtual equipment failed the last two times I tried with no IP addresses available and the production run seems broken as well. thank you! holger

Re: Reset GSM tester state?

2019-01-29 Thread Holger Freyther
> On 28. Jan 2019, at 20:30, Pau Espin Pedrol wrote: > > Hi, Hi! I don't know how the state works but have you considered: * Adding stale detection, either in code or jenkins? * far fetched.. look if subreaper can be of any help? cheers holger > > that happens from time to time becau

Re: coding style: fixed indenting vs align-with-brace

2019-02-07 Thread Holger Freyther
> On 6. Feb 2019, at 12:34, Harald Welte wrote: > > I would appreciate if we could keep it that way and focus our energy on actual > implementation work. Of course, if you guys want to discuss it, you are free. > The above is just my point of view. I have been using clang-format for a while

Re: libosmocore wishlist

2019-03-25 Thread Holger Freyther
> On 20. Mar 2019, at 10:13, Harald Welte wrote: > > While working on the talloc context patches, I was wondering if we should > spend a bit of time to further improve libosmocore and collect something > like a wishlist. > I would currently identify the following areas: > > 1) initializati

Re: Missing git tags in osmo-pcap

2019-07-04 Thread Holger Freyther
> On 4. Jul 2019, at 01:41, Pau Espin Pedrol wrote: > > Hi Holger, > > So, I want to ask if there's some explanation for those tags missing or you > simply forgot to push them when creating the releases (or they got somehow > lost in the server). > > Do you happen to have the tags locally

Re: Missing git tags in osmo-pcap

2019-07-07 Thread Holger Freyther
> On 5. Jul 2019, at 19:06, Pau Espin Pedrol wrote: > > > On 7/4/19 12:55 PM, Holger Freyther wrote: >> I don't have them locally either. Feel free to add them retro-actively. > > > Done, I pushed tags 0.0.7 .. 0.0.11, and submitted a new releas

[PATCH 1/5] sms: Kill the sms->sender and use addr/ton/npi throughout the code

2014-04-25 Thread Holger Freyther
From: Holger Hans Peter Freyther This is an incompatible database schema change. Store the type of the address in the database for both the sender and the receiver. Currently it is possible to use SMPP to store a SMS and the NPI and TON will be lost on the delivery of the SMS. The schema is chan

[PATCH 2/5] db: Add testcase for storing/loading/comparing a sms

2014-04-25 Thread Holger Freyther
From: Holger Hans Peter Freyther Use the already created subscriber, create a sms and read it back from the subscriber. --- openbsc/tests/db/db_test.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/openbsc/tests/db/db_test.c b/openbsc/tests/db

[PATCH 3/5] sms: Do not store received id in the SMS database.

2014-04-25 Thread Holger Freyther
From: Alexander Chemeris That was a bad idea from the very beginning. A visible result of this is a wrong SMS routing when you change subscriber extensions, while having queued SMS. It's also a very wrong thing from the code layering perspective. I think the next logical step should be to remove

[PATCH 5/5] db: Add testcase for the db migration.

2014-04-25 Thread Holger Freyther
From: Holger Hans Peter Freyther --- openbsc/src/libmsc/db.c | 2 ++ openbsc/tests/db/Makefile.am | 2 +- openbsc/tests/db/db_test.c | 34 ++ openbsc/tests/db/db_test.err | 2 ++ openbsc/tests/db/hlr.sqlite3 | Bin 0 -> 29696 bytes openbsc/tests/test

[PATCH 4/5] sms: Add code to migrate the database to the new schema

2014-04-25 Thread Holger Freyther
From: Holger Hans Peter Freyther This is mostly based on Alexander's migration code. The code adds transaction handling and some sanity checks and cleanups to the code. We made the decision to fork the sms_from_result method and freeze it to that version. This way sms_from_result can move forward

[PATCH] misc: Address style issues pointed out by the cppcheck application

2014-05-15 Thread Holger Freyther
From: Holger Hans Peter Freyther Use the variable only in the scope it is actually used. This could reduce the used stack space but that does not really matter to us right now. [src/gprs/gb_proxy.c:739]: (style) The scope of the variable 'peer' can be reduced. [src/libbsc/abis_nm.c:281]: (style

[PATCH] ctrl: Introduce a macro for read-only attributes and use it

2014-05-15 Thread Holger Freyther
From: Holger Hans Peter Freyther Certain attributes are read-only. Add a macro to make it more easy to define those. --- openbsc/include/openbsc/control_cmd.h | 20 ++ openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 38 +++ 2 files changed, 23 insertions(+

Re: git.osmocom.org cgit improvements

2017-03-19 Thread Holger Freyther
> On 18 Mar 2017, at 16:09, Neels Hofmeyr wrote: > > Hi, > All in all these are excellent improvements! > Holger, what's the status of your promise, made one day in a chat, to make > redmine catch the OS#123s? lol, I love how we go from a private chat to this CC list. I have not looked at

Re: gerrit openid login: osmocom.org vs. projects.osmocom.org

2017-03-22 Thread Holger Freyther
> On 20 Mar 2017, at 05:30, Neels Hofmeyr wrote: > > Has someone made osmocom.org login redirect to projects.osmocom.org? > Because since recently I observe this: > > > I go to osmocom.org, click on "Sign in". > It *redirects* me to projects.osmocom.org/login. > I log in. hmm... I did this h

osmo-pcap[master]: debian: Make a new release with the new feature

2017-03-23 Thread Holger Freyther
Gerrit-Owner: Holger Freyther Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

[MERGED] osmo-pcap[master]: debian: Add -dbg packages for the osmo-pcap-client and osmo-...

2017-03-23 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. Change subject: debian: Add -dbg packages for the osmo-pcap-client and osmo-pcap-server .. debian: Add -dbg packages for the osmo-pcap-client and osmo-pcap-server

[MERGED] osmo-pcap[master]: debian: Make a new release with the new feature

2017-03-23 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. Change subject: debian: Make a new release with the new feature .. debian: Make a new release with the new feature Change-Id

osmo-pcap[master]: debian: Add -dbg packages for the osmo-pcap-client and osmo-...

2017-03-23 Thread Holger Freyther
Gerrit-Owner: Holger Freyther Gerrit-Reviewer: Holger Freyther Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-HasComments: No

Re: gerrit openid login: osmocom.org vs. projects.osmocom.org

2017-03-23 Thread Holger Freyther
> On 22 Mar 2017, at 12:05, Neels Hofmeyr wrote: > > but httP://osmocom.org/login still does to httpS://PROJECTS.osmocom.org/login curl -v httP://osmocom.org/login 2>&1 | grep Loca < Location: https://osmocom.org/login => your browser has the redirect cached? holger

Re: python on FreeBSD in libosmocore

2017-03-23 Thread Holger Freyther
> On 23 Mar 2017, at 10:18, Harald Welte wrote: > > Hi, > > On Wed, Mar 22, 2017 at 10:21:19PM +0100, Thorsten Alteholz wrote: > >> as python2 will disappear sooner or later, I tried to replace all python2 >> references in libosmocore by the generic "python" [1]. >> Unfortunately the build fai

Re: GSM Audio Problems and

2017-03-24 Thread Holger Freyther
> On 24 Mar 2017, at 15:49, Edwin Reed-Sanchez wrote: > > Dear Osmocom list > > We are getting several audio problems and dropped calls. > The audio sounds like static. We are also getting large frame correction in > the logs, and SACCH deactivation timeout. > > Any ideas what could be the

Re: GSM Audio Problems and

2017-03-25 Thread Holger Freyther
> On 24 Mar 2017, at 16:09, Edwin Reed-Sanchez wrote: > > Holger, > > classic radio interference? > > - could this be caused by having amplifiers to high, and being close to > another BTS? Should I attenuate the amplification in Osmotrx? Difficult to say. You can look at the RSL measurement

Re: RFC: speed up gerrit verifications by using dependency artifacts

2017-03-30 Thread Holger Freyther
> On 30. Mar 2017, at 10:17, Harald Welte wrote: > > Hi Andre, Hey! > just a heads-up about my complete absence from jenkins/CI related > discussions: That doesn't mean I'm not interested, it just means that > I'm happy to defer the decisions on this to those who understand > anything about i

Re: commit python script to openbsc/contrib

2017-03-30 Thread Holger Freyther
> On 30. Mar 2017, at 20:47, Keith Whyte wrote: > > Hi all. > > I have a python script I'd like to commit to openbsc/contrib. > > It reads the SMS table, gives stats and retrieves individual messages. > - should maybe go in openbsc/contrib/sms ? > > Anyway, should I submit this via gerrit + c

Re: jenkins / Re: gerrit trouble "Change is New"

2017-04-10 Thread Holger Freyther
> On 10. Apr 2017, at 14:49, Harald Welte wrote: > > Hi all, Hey! > it now gets even more mysterious: I don't have an answer for the "Change is New" but this problem is "easy" to understand. > http://jenkins.osmocom.org/jenkins/job/libosmo-sccp-gerrit/311/ > but then that link is dead. > >

Using repo to make 'regular' releases

2017-04-23 Thread Holger Freyther
Hi, for the topic of making "releases" I wondered if we want to explore using "repo" to tie the different Osmocom repositories into a single "release". Below is an example "default.xml" that would make up a release. The default.xml would be maintained in a git repository that we could tag, e.g.

Re: gerrit trouble "Change is New"

2017-04-23 Thread Holger Freyther
> On 19. Apr 2017, at 13:30, Neels Hofmeyr wrote: > > --- or so I thought! There has been activity on this ticket since I last > looked at it, it seems they've actually fixed the problem in 2.12.6, yay! > > I will upgrade gerrit one of these days... the upgrade occurred yesterday. Please have

  1   2   3   4   5   6   7   >