Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-02-02 Thread Andrej Valek
Hello Marek, I think, we have to stop the discussion now, because it is not leading into any conclusion. Anyway, both of us have a different opinion. Maybe rewriting into python will solve it, I won't do that. Cheers, Andrej On Wed, 2022-02-02 at 09:17 +0100, Marek Vasut wrote: > On 2/2/22

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-02-02 Thread Marek Vasut
On 2/2/22 07:51, Valek, Andrej wrote: Marek, Hello Andrej, Sorry, but these are still not an arguments, why to do that. I'm sorry, I am lost and confused ... what part of the email are you referring to ? On Mon, 2022-01-31 at 10:39 +0100, Marek Vasut wrote: On 1/31/22 08:01, Valek,

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-02-01 Thread Andrej Valek
Marek, Sorry, but these are still not an arguments, why to do that. On Mon, 2022-01-31 at 10:39 +0100, Marek Vasut wrote: > On 1/31/22 08:01, Valek, Andrej wrote: > > Hi, > > Hello Andrej, > > (please avoid top-posting) > > > Sorry, but personally I don't like your idea. What's the benefit of

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-31 Thread Marek Vasut
On 1/31/22 08:01, Valek, Andrej wrote: Hi, Hello Andrej, (please avoid top-posting) Sorry, but personally I don't like your idea. What's the benefit of reverting this? I would keep the ${} for bitbake and $ for shell. The {} has to be placed only for variables like $a${b}c. That's exactly

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-30 Thread Andrej Valek
Hi, Sorry, but personally I don't like your idea. What's the benefit of reverting this? I would keep the ${} for bitbake and $ for shell. The {} has to be placed only for variables like $a${b}c. We should respect the workflow on all recipes otherwise we're braking the "unwritten" rules. Regards,

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut
On 1/29/22 03:01, Peter Kjellerstedt wrote: Hi, [...] Personally I do not see it as inconsistent, it is just the way shell handles variables. It is just something to get used to (I also had a colleague who would review any shell code changes we made and comment on every single unnecessary

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Peter Kjellerstedt
> -Original Message- > From: Marek Vasut > Sent: den 29 januari 2022 02:39 > To: Peter Kjellerstedt ; openembedded- > c...@lists.openembedded.org > Cc: Andrej Valek ; Richard Purdie > > Subject: Re: [OE-core] [PATCH] Revert "featimage: refactor style&

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut
] Revert "featimage: refactor style" This reverts commit f44bb458884da64356ee188917094b5515d3b159. The reverted patch attempted to perform some sort of clean up, however it only brought in style inconsistencies like this: ``` conf_desc="$conf_desc${sep}setup" ``` The c

Re: [OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Peter Kjellerstedt
ubject: [OE-core] [PATCH] Revert "featimage: refactor style" > > This reverts commit f44bb458884da64356ee188917094b5515d3b159. > > The reverted patch attempted to perform some sort of clean up, however > it only brought in style inconsistencies like this: > > ``` &

[OE-core] [PATCH] Revert "featimage: refactor style"

2022-01-28 Thread Marek Vasut
This reverts commit f44bb458884da64356ee188917094b5515d3b159. The reverted patch attempted to perform some sort of clean up, however it only brought in style inconsistencies like this: ``` conf_desc="$conf_desc${sep}setup" ``` The curly brackets around variables were placed in the