Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Trevor Woerner]

On Mon 2018-05-21 @ 11:10:59 AM, Andre McCurdy wrote:
> It hasn't been updated to give ordering for PACKAGECONFIG or
> BBCLASSEXTEND but the conventions for those (based on recipes in
> oe-core) seem to be:
> 
>  - PACKAGECONFIG lines go between "inherit ..." and EXTRA_OECONF
>  - BBCLASSEXTEND goes at the end of the recipe

Done.

Thanks for the pointers/tips :-)
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Andre McCurdy]

On Sat, May 19, 2018 at 12:35 PM, Trevor Woerner  wrote:
> On Sat, May 19, 2018 at 7:59 AM, Peter Kjellerstedt
>  wrote:
>>
>> If you do, I think you should spin the patches for the clean ups as well.
>> At least I agree with (most) of them, and on a whole they definitely
>> improve the recipes.
>>
>> And I also agree with Andre, that in general it is too much trouble to
>> generate clean up patches in their own, which is why it might be better
>> to allow some clean ups together with actual changes. Otherwise they will
>> not happen, which in the long run deteriorate the overall state of the
>> recipes.
>
> I'm happy to slowly go through the recipes and make formatting changes. What
> is the accepted canonical order of variables and segments in a recipe file?

The OE style guide states that it should be considered the canonical
reference (rather than for example contrib/oe-stylize.py):

  http://www.openembedded.org/wiki/Styleguide

If you stick to non-controversial changes such as ordering of
variables then I think it's a pretty good set of guidelines.

It hasn't been updated to give ordering for PACKAGECONFIG or
BBCLASSEXTEND but the conventions for those (based on recipes in
oe-core) seem to be:

 - PACKAGECONFIG lines go between "inherit ..." and EXTRA_OECONF
 - BBCLASSEXTEND goes at the end of the recipe

> Oh, and did we agree on tabs, or spaces?

No, probably never will :-)

Best approach would be to not mess with indent - unless you find a
line indented with spaces between two lines indented with tabs (or
vice versa).
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[André Draszik]

meta-openembedded has oe-stylize.py, which is helpful for arranging things
in the preferred order.

Cheers,
A.

On Sat, 19 May 2018, 20:35 Trevor Woerner,  wrote:

> On Sat, May 19, 2018 at 7:59 AM, Peter Kjellerstedt <
> peter.kjellerst...@axis.com> wrote:
>
> > If you do, I think you should spin the patches for the clean ups as well.
> > At least I agree with (most) of them, and on a whole they definitely
> > improve the recipes.
> >
> > And I also agree with Andre, that in general it is too much trouble to
> > generate clean up patches in their own, which is why it might be better
> > to allow some clean ups together with actual changes. Otherwise they will
> > not happen, which in the long run deteriorate the overall state of the
> > recipes.
> >
>
> I'm happy to slowly go through the recipes and make formatting changes.
> What is the accepted canonical order of variables and segments in a recipe
> file? Oh, and did we agree on tabs, or spaces?
>
> /me ducks...
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Trevor Woerner]

On Sat, May 19, 2018 at 7:59 AM, Peter Kjellerstedt <
peter.kjellerst...@axis.com> wrote:

> If you do, I think you should spin the patches for the clean ups as well.
> At least I agree with (most) of them, and on a whole they definitely
> improve the recipes.
>
> And I also agree with Andre, that in general it is too much trouble to
> generate clean up patches in their own, which is why it might be better
> to allow some clean ups together with actual changes. Otherwise they will
> not happen, which in the long run deteriorate the overall state of the
> recipes.
>

I'm happy to slowly go through the recipes and make formatting changes.
What is the accepted canonical order of variables and segments in a recipe
file? Oh, and did we agree on tabs, or spaces?

/me ducks...
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Peter Kjellerstedt]

> -Original Message-
> From: openembedded-devel-boun...@lists.openembedded.org
> [mailto:openembedded-devel-boun...@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: den 19 maj 2018 06:53
> To: Trevor Woerner <twoer...@gmail.com>; Andre McCurdy
> <armccu...@gmail.com>
> Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on
> cmake.bbclass to put cmake package files in dev package
> 
> On 5/18/18 7:37 PM, Trevor Woerner wrote:
> > On Fri, May 18, 2018 at 6:28 PM, Andre McCurdy <armccu...@gmail.com
> > <mailto:armccu...@gmail.com>> wrote:
> >
> > On Fri, May 18, 2018 at 2:01 PM, Khem Raj <raj.k...@gmail.com
> > <mailto:raj.k...@gmail.com>> wrote:
> > > On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy
> <armccu...@gmail.com <mailto:armccu...@gmail.com>> wrote:
> > >> On Thu, May 17, 2018 at 6:56 PM, Khem Raj <raj.k...@gmail.com
> <mailto:raj.k...@gmail.com>> wrote:
> > >>> Hi Andre
> > >>>
> > >>> This series is fine, except that it has some formatting
> changes mixed with
> > >>> cmake related changes. It would be preferable to have them as
> separate
> > >>> pulls. I reckon that both types of changes are good.
> > >>
> > >> The formatting cleanups are all minor and probably not worth
> > >> submitting on their own.
> > >>
> > >
> > > OK thats fine, drop then in v2
> >
> > They are not worth reworking the patch set to create a v2 either
> :-)
> >
> >
> > It would be wonderful if we could agree on formatting; if we could,
> I'd
> > certainly help by taking on some of the reformatting task.
> >
> > Unfortunately, all such past attempts of which I'm aware never got
> > anywhere, and if I remember correctly, the Yocto folks and the OE
> folks
> > each have their own ideas of what is "correct".
> >
> > In any case, if these won't get in as is, if Andre doesn't want to
> spin
> > a v2 without the formatting changes, and everyone is okay with it, I
> > could spin a v2 without the formatting changes.
> 
> Please do.

If you do, I think you should spin the patches for the clean ups as well. 
At least I agree with (most) of them, and on a whole they definitely 
improve the recipes.

And I also agree with Andre, that in general it is too much trouble to 
generate clean up patches in their own, which is why it might be better 
to allow some clean ups together with actual changes. Otherwise they will 
not happen, which in the long run deteriorate the overall state of the 
recipes.

//Peter

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Khem Raj]

On 5/18/18 7:37 PM, Trevor Woerner wrote:
On Fri, May 18, 2018 at 6:28 PM, Andre McCurdy > wrote:


On Fri, May 18, 2018 at 2:01 PM, Khem Raj > wrote:
> On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy > wrote:
>> On Thu, May 17, 2018 at 6:56 PM, Khem Raj > wrote:
>>> Hi Andre
>>>
>>> This series is fine, except that it has some formatting changes mixed 
with
>>> cmake related changes. It would be preferable to have them as separate
>>> pulls. I reckon that both types of changes are good.
>>
>> The formatting cleanups are all minor and probably not worth
>> submitting on their own.
>>
>
> OK thats fine, drop then in v2

They are not worth reworking the patch set to create a v2 either :-)


It would be wonderful if we could agree on formatting; if we could, I'd 
certainly help by taking on some of the reformatting task.


Unfortunately, all such past attempts of which I'm aware never got 
anywhere, and if I remember correctly, the Yocto folks and the OE folks 
each have their own ideas of what is "correct".


In any case, if these won't get in as is, if Andre doesn't want to spin 
a v2 without the formatting changes, and everyone is okay with it, I 
could spin a v2 without the formatting changes.


Please do.
--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Trevor Woerner]

On Fri, May 18, 2018 at 6:28 PM, Andre McCurdy  wrote:

> On Fri, May 18, 2018 at 2:01 PM, Khem Raj  wrote:
> > On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy 
> wrote:
> >> On Thu, May 17, 2018 at 6:56 PM, Khem Raj  wrote:
> >>> Hi Andre
> >>>
> >>> This series is fine, except that it has some formatting changes mixed
> with
> >>> cmake related changes. It would be preferable to have them as separate
> >>> pulls. I reckon that both types of changes are good.
> >>
> >> The formatting cleanups are all minor and probably not worth
> >> submitting on their own.
> >>
> >
> > OK thats fine, drop then in v2
>
> They are not worth reworking the patch set to create a v2 either :-)
>

It would be wonderful if we could agree on formatting; if we could, I'd
certainly help by taking on some of the reformatting task.

Unfortunately, all such past attempts of which I'm aware never got
anywhere, and if I remember correctly, the Yocto folks and the OE folks
each have their own ideas of what is "correct".

In any case, if these won't get in as is, if Andre doesn't want to spin a
v2 without the formatting changes, and everyone is okay with it, I could
spin a v2 without the formatting changes.
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Andre McCurdy]

On Fri, May 18, 2018 at 2:01 PM, Khem Raj  wrote:
> On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy  wrote:
>> On Thu, May 17, 2018 at 6:56 PM, Khem Raj  wrote:
>>> Hi Andre
>>>
>>> This series is fine, except that it has some formatting changes mixed with
>>> cmake related changes. It would be preferable to have them as separate
>>> pulls. I reckon that both types of changes are good.
>>
>> The formatting cleanups are all minor and probably not worth
>> submitting on their own.
>>
>
> OK thats fine, drop then in v2

They are not worth reworking the patch set to create a v2 either :-)

>>> On 5/17/18 6:30 PM, Andre McCurdy wrote:

 The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
 ${datadir}/cmake end up in the dev package, so recipes no longer need
 to provide custom packaging rules to handles these files.


 http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93

 Signed-off-by: Andre McCurdy 
 ---
   meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 -
   1 file changed, 1 deletion(-)

 diff --git
 a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
 b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
 index 9354799..6b9c545 100644
 --- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
 +++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
 @@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] =
 "-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,
 PACKAGES =+ "${PN}-testapps"
   -FILES_${PN}-dev += "${libdir}/cmake"
   FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"

>>>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Khem Raj]

On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy  wrote:
> On Thu, May 17, 2018 at 6:56 PM, Khem Raj  wrote:
>> Hi Andre
>>
>> This series is fine, except that it has some formatting changes mixed with
>> cmake related changes. It would be preferable to have them as separate
>> pulls. I reckon that both types of changes are good.
>
> The formatting cleanups are all minor and probably not worth
> submitting on their own.
>

OK thats fine, drop then in v2

>> On 5/17/18 6:30 PM, Andre McCurdy wrote:
>>>
>>> The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
>>> ${datadir}/cmake end up in the dev package, so recipes no longer need
>>> to provide custom packaging rules to handles these files.
>>>
>>>
>>> http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93
>>>
>>> Signed-off-by: Andre McCurdy 
>>> ---
>>>   meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git
>>> a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>>> b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>>> index 9354799..6b9c545 100644
>>> --- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>>> +++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>>> @@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] =
>>> "-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,
>>> PACKAGES =+ "${PN}-testapps"
>>>   -FILES_${PN}-dev += "${libdir}/cmake"
>>>   FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"
>>>
>>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Andre McCurdy]

On Thu, May 17, 2018 at 6:56 PM, Khem Raj  wrote:
> Hi Andre
>
> This series is fine, except that it has some formatting changes mixed with
> cmake related changes. It would be preferable to have them as separate
> pulls. I reckon that both types of changes are good.

The formatting cleanups are all minor and probably not worth
submitting on their own.

> On 5/17/18 6:30 PM, Andre McCurdy wrote:
>>
>> The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
>> ${datadir}/cmake end up in the dev package, so recipes no longer need
>> to provide custom packaging rules to handles these files.
>>
>>
>> http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93
>>
>> Signed-off-by: Andre McCurdy 
>> ---
>>   meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git
>> a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>> b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>> index 9354799..6b9c545 100644
>> --- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>> +++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
>> @@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] =
>> "-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,
>> PACKAGES =+ "${PN}-testapps"
>>   -FILES_${PN}-dev += "${libdir}/cmake"
>>   FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"
>>
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Khem Raj]

Hi Andre

This series is fine, except that it has some formatting changes mixed 
with cmake related changes. It would be preferable to have them as 
separate pulls. I reckon that both types of changes are good.


On 5/17/18 6:30 PM, Andre McCurdy wrote:

The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
${datadir}/cmake end up in the dev package, so recipes no longer need
to provide custom packaging rules to handles these files.

   
http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93

Signed-off-by: Andre McCurdy 
---
  meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 -
  1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb 
b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
index 9354799..6b9c545 100644
--- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
+++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
@@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] = 
"-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,
  
  PACKAGES =+ "${PN}-testapps"
  
-FILES_${PN}-dev += "${libdir}/cmake"

  FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"


--
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[oe] [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package

[Andre McCurdy]

The cmake.bbclass in oe-core now ensures that ${libdir}/cmake and
${datadir}/cmake end up in the dev package, so recipes no longer need
to provide custom packaging rules to handles these files.

  
http://git.openembedded.org/openembedded-core/commit/?id=d91dc483a96e9d03cbbd21b8a546f9069c93

Signed-off-by: Andre McCurdy 
---
 meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb 
b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
index 9354799..6b9c545 100644
--- a/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
+++ b/meta-oe/recipes-connectivity/libwebsockets/libwebsockets_2.1.0.bb
@@ -24,5 +24,4 @@ PACKAGECONFIG[testapps] = 
"-DLWS_WITHOUT_TESTAPPS=OFF,-DLWS_WITHOUT_TESTAPPS=ON,
 
 PACKAGES =+ "${PN}-testapps"
 
-FILES_${PN}-dev += "${libdir}/cmake"
 FILES_${PN}-testapps += "${datadir}/libwebsockets-test-server/*"
-- 
1.9.1

-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel