On Fri, Apr 22, 2022 at 11:08:01AM +0700, Quan Nguyen wrote:
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
>
> Thanks Dan for the copy_from_user() fix in the link below.
This is much better, the
On Thu, Apr 21, 2022 at 08:09:41AM -0700, Yu Zhe wrote:
> remove unnecessary void* type castings.
Thanks, queued for next release.
-corey
>
> Signed-off-by: Yu Zhe
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
> drivers/char/ipmi/ipmi_ssif.c | 6 +++---
> 2 files changed, 6
On Thu, Apr 21, 2022 at 10:08:35AM +, Wei Yongjun wrote:
> KASAN report null-ptr-deref as follows:
>
> KASAN: null-ptr-deref in range [0x0008-0x000f]
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1
> 04/01/2014
> RIP:
On Fri, Apr 01, 2022 at 11:27:45AM +0800, Haowen Bai wrote:
> msg could be null without checking null and return, but still dereference
> msg->rsp[2] and will lead to a null pointer trigger.
Actually:
If you look at the big picture (how the rest of the code works), it's
not possible for msg
On Wed, Mar 30, 2022 at 10:44:50PM +0800, chenchacha wrote:
> > @@ -2298,6 +2309,14 @@ static int i_ipmi_request(struct ipmi_user *user,
> > struct ipmi_recv_msg *recv_msg;
> > int rv = 0;
> > + if (user) {
> > + if (atomic_add_return(1, >nr_msgs) > max_msgs_per_user) {
> >
On Wed, Mar 30, 2022 at 11:29:12AM +0200, Wolfram Sang wrote:
> On Thu, Mar 24, 2022 at 06:11:59PM +0100, Stephen Kitt wrote:
> > The i2c probe functions here don't use the id information provided in
> > their second argument, so the single-parameter i2c probe function
> > ("probe_new") can be
On Mon, Mar 28, 2022 at 11:27:06PM +0800, chenchacha wrote:
>
> > Anyway, a better solution for the kernel side of things, I think, would
> > be to add limits on the number of users and the number of messages per
> > user. That's more inline with what other kernel things do. I know of
> >
On Mon, Mar 28, 2022 at 12:47:41AM +0800, Chen Guanqiao wrote:
> At present, a scenario has been found that there are too many ipmi messages
> in a
> short period of time, and a large number of users and messages are blocked in
> the ipmi modules, resulting in a large amount of system memory
over IPMB (I2c) is modified to allow it to
take a separate sender and receiver device. The Raspberry Pi has an
I2C slave device that cannot send.
Corey Minyard (3):
ipmi: Add the git repository to the MAINTAINERS file
On Sun, Mar 20, 2022 at 06:59:54AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> Clang static analysis reports this issue
> ipmi_ssif.c:1731:3: warning: 4th function call
> argument is an uninitialized value
> dev_info(_info->client->dev,
> ^
>
> The
snip...
> > > +
> > > +static void response_timeout(struct timer_list *t)
> > > +{
> > > + struct ssif_bmc_ctx *ssif_bmc = from_timer(ssif_bmc, t, response_timer);
> > > + unsigned long flags;
> > > +
> >
> > Is there a possible race here? The timeout can happen at the same time
> > as a
On Thu, Mar 10, 2022 at 06:41:16PM +0700, Quan Nguyen wrote:
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
Thanks for the update, and removing slave_enable().
I spent some quality time with this,
On Mon, Feb 28, 2022 at 04:58:40PM +1030, Joel Stanley wrote:
> It's been a few releases since we depreciated the "v1" bindings. Remove
> support from the driver as all known device trees have been updated to
> use the new bindings.
It always feels good to get rid of old stuff you don't need :-).
I've been working on a project to allow a Raspberry Pi to be a
management controller on an IPMB. I have a working driver now for the
I2C slave interface for the Pis that works on many of the Pi boards.
Unfortunatly, it's not a general I2C slave driver; it won't for as a
normal I2C slave because
On Mon, Feb 21, 2022 at 05:33:51PM +1030, Joel Stanley wrote:
> The AST2600 is already described in the bindings, but the driver never
> gained a compatible string.
Thanks, this is in my queue.
-corey
>
> Signed-off-by: Joel Stanley
> ---
> drivers/char/ipmi/kcs_bmc_aspeed.c | 1 +
> 1 file
On Wed, Feb 02, 2022 at 06:14:57PM +, Verdun, Jean-Marie wrote:
> > This is far too big for a single patch. It needs to be broken into
> > functional chunks that can be reviewed individually. Each driver and
> > each device tree change along with it's accompanying code need to be
> > done in
On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote:
> From: Nick Hawkins
>
> GXP is the name of the HPE SoC.
> This SoC is used to implement BMC features of HPE servers
> (all ProLiant, Synergy, and many Apollo, and Superdome machines)
> It does support many features including:
The following changes since commit 12119cfa1052d512a92524e90ebee85029a918f8:
Merge tag 'vfio-v5.16-rc4' of git://github.com/awilliam/linux-vfio
(2021-12-03 12:27:08 -0800)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.16-3
for you to
On Wed, Dec 22, 2021 at 11:27:07AM +0800, Jason Wang wrote:
> The strlcpy should not be used because it doesn't limit the source
> length. So that it will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and
On Tue, Dec 21, 2021 at 03:00:34PM +0800, Wu Bo wrote:
> Hi,
>
> When testing install and uninstall of ipmi_si.ko and ipmi_msghandler.ko,
> the system crashed.
Thanks for the fix, it's in my queue. I'll try to get it up soon.
-corey
>
> The log as follows:
> [ 141.087026] BUG: unable to
I believe this has already been fixed by change 1d49eb91e 'ipmi: Move
remove_work to dedicated workqueue' by moving to a dedicated workqueue.
Can you test against the bleeding edge kernel and see?
Thanks,
-corey
On Mon, Dec 20, 2021 at 02:55:20PM +0800, Wu Bo wrote:
> Hi,
>
> When testing
ork to dedicated workqueue")
> Signed-off-by: Thadeu Lima de Souza Cascardo
> Cc: Corey Minyard
> Cc: Ioanna Alifieraki
> Cc: sta...@vger.kernel.org
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
On Wed, Dec 08, 2021 at 10:32:39AM +0100, Mian Yousaf Kaukab wrote:
> During probe ssif_info->client is dereferenced in error path. However,
> it is set when some of the error checking has already been done. This
> causes following kernel crash if an error path is taken:
>
> [ 30.645593][
shutdown.
Move to a private workqueue to avoid that problem.
Corey Minyard (2):
ipmi: fix IPMI_SMI_MSG_TYPE_IPMB_DIRECT response length checking
ipmi:ipmb: Fix unknown command response
Ioanna Alifieraki (1):
ipmi: Move
On Sun, Nov 28, 2021 at 11:01:54PM +0100, Rikard Falkeborn wrote:
> ident is not modified and can be made const to allow the compiler to put
> it in read-only memory.
In my queue for next release. Thanks.
-corey
>
> Signed-off-by: Rikard Falkeborn
> ---
> drivers/char/ipmi/ipmi_watchdog.c |
On Thu, Nov 25, 2021 at 07:05:43AM -0800, Jakub Kicinski wrote:
> On Thu, 25 Nov 2021 08:21:40 -0600 Corey Minyard wrote:
> > On Wed, Nov 24, 2021 at 01:03:23PM -0800, Jakub Kicinski wrote:
> > > We're hitting OOB accesses in handle_ipmb_direct_rcv_rsp() (memcpy of
> > >
On Wed, Nov 24, 2021 at 01:04:13PM -0800, Jakub Kicinski wrote:
> We check if response is the right size but if it's not we jump
> to return_unspecified which creates a response of size 3.
> We need size 4 to prevent OOB in handle_ipmb_direct_rcv_rsp().
> Was this supposed to override the message
On Wed, Nov 24, 2021 at 01:03:23PM -0800, Jakub Kicinski wrote:
> We're hitting OOB accesses in handle_ipmb_direct_rcv_rsp() (memcpy of
> size -1) after user space generates a message. Looks like the message
> is incorrectly assumed to be of the new IPMB type, because type is never
> set and
On Tue, Nov 23, 2021 at 08:36:18AM +, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
> symbol 'remove_work_wq' was not declared. Should it be static?
>
> This symbol is not used outside of ipmi_msghandler.c, so
> marks it
On Mon, Nov 15, 2021 at 03:16:45PM +0200, Ioanna Alifieraki wrote:
> Currently when removing an ipmi_user the removal is deferred as a work on
> the system's workqueue. Although this guarantees the free operation will
> occur in non atomic context, it can race with the ipmi_msghandler module
>
On Fri, Nov 12, 2021 at 06:54:13PM +0200, Ioanna Alifieraki wrote:
> Currently when removing an ipmi_user the removal is deferred as a work on
> the system's workqueue. Although this guarantees the free operation will
> occur in non atomic context, it can race with the ipmi_msghandler module
>
Minor updates for building, and a few bug fixes for SoL. You should
upgrade if you can.
-corey
___
Openipmi-developer mailing list
Openipmi-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openipmi-developer
On Tue, Nov 02, 2021 at 08:20:37PM -0500, Rob Herring wrote:
> On Tue, 02 Nov 2021 13:37:16 -0700, jae.hyun@intel.com wrote:
> > From: Jae Hyun Yoo
> >
> > Add 'clocks' as a required property.
> >
> > Signed-off-by: Jae Hyun Yoo
> > ---
> > v1 -> v2:
> > Changes sinve v1:
> > - Added
On Tue, Nov 02, 2021 at 01:37:11PM -0700, jae.hyun@intel.com wrote:
> From: Jae Hyun Yoo
>
> Hello all,
>
> This series is for appliying below fix to all Aspped LPC sub drivers.
> https://lore.kernel.org/all/20201208091748.1920-1-wangzhiqiang...@bytedance.com/
Ok, I've added this to my
On Mon, Nov 01, 2021 at 11:36:38PM +, Joel Stanley wrote:
> On Mon, 1 Nov 2021 at 23:18, wrote:
> >
> > From: Jae Hyun Yoo
> >
> > Hello all,
> >
> > This series is for appliying below fix to all Aspped LPC sub drivers.
> >
of
'kcs_bmc_serio_add_device()'
Colin Ian King (1):
ipmi: ipmb: Fix off-by-one size check on rcvlen
Corey Minyard (12):
ipmi:watchdog: Set panic count to proper value on a panic
ipmi: Disable some operations during a panic
ipmi:devintf: Return a proper error when recv buffer too small
On Tue, Sep 07, 2021 at 11:06:32PM +0200, Christophe JAILLET wrote:
> In the unlikely event where 'devm_kzalloc()' fails and 'kzalloc()'
> succeeds, 'port' would be leaking.
>
> Test each allocation separately to avoid the leak.
Yeah, looks reasonable. It's in my queue.
-corey
>
> Fixes:
On Wed, Oct 27, 2021 at 01:59:09PM -0400, Sasha Levin wrote:
> On Mon, Sep 20, 2021 at 09:41:46AM -0500, Corey Minyard wrote:
> > On Mon, Sep 20, 2021 at 04:12:31PM +0200, Anton Lundin wrote:
> > > On 20 September, 2021 - Corey Minyard wrote:
> > >
> > >
On Tue, Oct 26, 2021 at 11:50:09AM -0500, Corey Minyard wrote:
> On Tue, Oct 26, 2021 at 10:58:34AM +0800, Kunkun Li wrote:
> > During multipart test, cmd(6,7,8) or cmd(6,7,7) will
> > be sent continuously.
>
> This is not useful information, we don't have acc
On Tue, Oct 26, 2021 at 10:58:34AM +0800, Kunkun Li wrote:
> During multipart test, cmd(6,7,8) or cmd(6,7,7) will
> be sent continuously.
This is not useful information, we don't have access to your tests, so
this is meaningless to us.
>
> The pressure test found some BMC systems cannot process
On Sun, Oct 24, 2021 at 09:22:06PM -0400, Wan Jiabing wrote:
> There are 5 duplicated 'if' conditions to judge the 'run_to_completion',
> which looks redundant. And there is no function to modify this variable.
It's modified in panic_event().
>
> Reduce the 'if' conditions from 5 times to 1
On Thu, Oct 21, 2021 at 11:06:08AM +, cgel@gmail.com wrote:
> From: Ye Guojin
>
> coccicheck complains about the use of snprintf() in sysfs show
> functions:
> WARNING use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
> sense.
Yes, I
PMI_IPMB=m
>
> Fixes: 63c4eb347164 ("ipmi:ipmb: Add initial support for IPMI over IPMB")
> Signed-off-by: Randy Dunlap
> Cc: Corey Minyard
> Cc: openipmi-developer@lists.sourceforge.net
> Cc: Arnd Bergmann
> Cc: Greg Kroah-Hartman
> ---
> drivers/char/ipm
On Thu, Oct 07, 2021 at 06:37:00AM +, Joel Stanley wrote:
> On Tue, 7 Sept 2021 at 19:09, Rob Herring wrote:
> >
> > On Fri, 03 Sep 2021 11:23:14 +0930, Joel Stanley wrote:
> > > The AST2600 has the same register set as the previous generation SoCs.
> > >
> > > Signed-off-by: Joel Stanley
>
On Tue, Oct 05, 2021 at 04:16:11PM +0100, Colin King wrote:
> From: Colin Ian King
>
> There is an off-by-one bounds check on the rcvlen causing a potential
> out of bounds write on iidev->rcvmsg. Fix this by using the >= operator
> on the bounds check rather than the > operator.
Got it,
On Mon, Oct 04, 2021 at 06:27:34PM -0700, Randy Dunlap wrote:
> Hi,
Thanks, all issues addressed.
-corey
>
> On 10/4/21 5:40 PM, miny...@acm.org wrote:
> > From: Corey Minyard
> >
> > This provides access to the management controllers on an IPMB bus to a
> &g
On Mon, Sep 20, 2021 at 04:12:31PM +0200, Anton Lundin wrote:
> On 20 September, 2021 - Corey Minyard wrote:
>
> > Well, that was dumb. Fix follows...
> >
> > Thanks for working on this. On your approval, I'll send this to Linus.
>
> Winner winner chicken din
ceive messages when in an oops")
was added, but the watchdog code had a bug where it didn't set the value
properly.
Reported-by: Anton Lundin
Cc: # v5.4+
Fixes: 2033f6858970 ("ipmi: Free receive messages when in an oops")
Signed-off-by: Corey Minyard
---
drivers/char/ipmi/ipmi_watch
On Fri, Sep 17, 2021 at 02:55:25PM +0200, Anton Lundin wrote:
> On 17 September, 2021 - Corey Minyard wrote:
>
> > On Fri, Sep 17, 2021 at 12:14:19PM +0200, Anton Lundin wrote:
> > > On 16 September, 2021 - Corey Minyard wrote:
> > >
> > > > On Thu, Sep
On Fri, Sep 17, 2021 at 12:14:19PM +0200, Anton Lundin wrote:
> On 16 September, 2021 - Corey Minyard wrote:
>
> > On Thu, Sep 16, 2021 at 04:53:00PM +0200, Anton Lundin wrote:
> > > Hi.
> > >
> > > I've just done a upgrade of the kernel we're using in
's a good idea, in general, to do as little as
possible in the panic path, this should cover a multitude of issues.
Thanks for the report.
-corey
>
> I tested just reverting that and both dumps to pstore and the panic
> reboot timer started working again.
>
>
> //Anton
commit e
he following changes since commit 8baef6386baaefb776bdd09b5c7630cf057c51c6:
Merge tag 'drm-fixes-2021-07-23' of git://anongit.freedesktop.org/drm/drm
(2021-07-22 20:32:13 -0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.15-1
for
On Sat, Aug 28, 2021 at 12:08:05AM +0200, Pavel Cahyna wrote:
> On Thu, Aug 26, 2021 at 07:18:24PM -0500, Corey Minyard wrote:
> > On Fri, Aug 27, 2021 at 01:27:17AM +0200, Pavel Cahyna wrote:
> > > On Thu, Aug 26, 2021 at 05:05:27PM -0500, Corey Minyard wrote:
> > > &
On Fri, Aug 27, 2021 at 01:27:17AM +0200, Pavel Cahyna wrote:
> On Thu, Aug 26, 2021 at 05:05:27PM -0500, Corey Minyard wrote:
> > On Thu, Aug 26, 2021 at 10:26:34PM +0200, Pavel Cahyna wrote:
> > > Hello Corey,
> > >
> > > On Wed, Aug 25, 2021 at 0
On Thu, Aug 26, 2021 at 10:26:34PM +0200, Pavel Cahyna wrote:
> Hello Corey,
>
> On Wed, Aug 25, 2021 at 08:31:13PM -0500, Corey Minyard wrote:
> > On Wed, Aug 25, 2021 at 08:24:05PM +0200, Pavel Cahyna wrote:
> > > at a quick glance at header file diffs, it seems to me th
On Wed, Aug 25, 2021 at 08:24:05PM +0200, Pavel Cahyna wrote:
> Hello Corey,
>
> at a quick glance at header file diffs, it seems to me that the Windows
> DLL changes are introducing library API changes even for non-Windows
> builds. Specifically, commit:
>
>
On Thu, Aug 12, 2021 at 09:39:43AM +0200, Wolfram Sang wrote:
> Hi all,
>
> On Wed, Jul 14, 2021 at 10:38:31AM +0700, Quan Nguyen wrote:
> > Slave needs time to prepare the response data before Master could
> > enquiry via read transaction. However, there is no mechanism for
> > i2c-aspeed Slave
On Fri, Aug 06, 2021 at 11:39:38AM +0200, Uwe Kleine-König wrote:
> The caller of this function (parisc_driver_remove() in
> arch/parisc/kernel/drivers.c) ignores the return value, so better don't
> return any value at all to not wake wrong expectations in driver authors.
>
> The only function
On Fri, Jul 30, 2021 at 11:59:51AM +0530, Dwaipayan Ray wrote:
> Instead of open coding DEVICE_ATTR, use the helper macro
> DEVICE_ATTR_RO to replace DEVICE_ATTR with 0444 octal
> permissions.
Looks good, this is queued for the next release.
-corey
>
> This was detected as a part of checkpatch
On Fri, Jul 30, 2021 at 06:08:01PM +0300, Dan Carpenter wrote:
> I accidentally introduced a bug in my previous patch. The "ret"
> variable needs to be initialized to prevent returning uninitialized
> data.
Thanks Dan, it's queued.
-corey
>
> Fixes: f9714eb04364 ("ipmi: ssif_bmc: Return
si IPI0001:00: Could not set the global enables: 0xc1.
> [46318028.298288] ipmi_si IPI0001:00: Could not set the global enables: 0xc1.
> [46318029.363302] ipmi_si IPI0001:00: Could not set the global enables: 0xc1.
>
> Signed-off-by: Wen Yang
> Cc: Baoyou Xie
> Cc: Corey Minyard
&
On Fri, Jul 23, 2021 at 11:44:59AM +0300, Dan Carpenter wrote:
> The copy_from_user() function returns the number of bytes remaining to
> be copied but we should return -EFAULT here.
Yep, this is in my queue.
Thanks,
-corey
>
> Fixes: 007888f365c9 ("ipmi: ssif_bmc: Add SSIF BMC driver")
>
On Wed, Jul 14, 2021 at 10:38:30AM +0700, Quan Nguyen wrote:
> This series add support the SSIF BMC driver which is to perform in-band
> IPMI communication with their host in management (BMC) side.
>
> SSIF BMC driver in this series is tested with Aspeed AST2500.
Ok, I have queued this and added
On Wed, Jul 14, 2021 at 06:29:27AM +0700, Quan Nguyen wrote:
> On 13/07/2021 22:44, Corey Minyard wrote:
> > On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
> > > This series add support the SSIF BMC driver which is to perform in-band
> > > IPMI co
On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
> This series add support the SSIF BMC driver which is to perform in-band
> IPMI communication with their host in management (BMC) side.
Per the kernel build robot, looks like patch 3 introduces slave_enable()
but patch 1 uses it.
The following changes since commit d72cd4ad4174cfd2257c426ad51e4f53bcfde9c9:
Merge tag 'scsi-misc' of
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi (2021-04-28 17:22:10
-0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git
On Wed, Jun 16, 2021 at 05:29:13PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The comparisons of the unsigned int hw_type to less than zero always
> false because it is unsigned. Fix this by using an int for the
> assignment and less than zero check.
Thanks, I added this to my tree.
On Tue, Jun 08, 2021 at 08:17:41PM +0930, Andrew Jeffery wrote:
>
> Hello,
>
> This is the 4th spin of the series refactoring the keyboard-controller-style
> device drivers in the IPMI subsystem.
Ok, no comments and everything looks good, I have this queued for the
next Linux release.
Thanks,
On Mon, May 24, 2021 at 10:23:36AM +0930, Andrew Jeffery wrote:
>
>
> On Sat, 22 May 2021, at 02:44, Corey Minyard wrote:
> > On Mon, May 10, 2021 at 03:12:02PM +0930, Andrew Jeffery wrote:
> > > Make the KCS device drivers responsible for allocating their own memory
On Mon, May 10, 2021 at 03:11:57PM +0930, Andrew Jeffery wrote:
> Hello,
>
> This is the 3rd spin of the series refactoring the keyboard-controller-style
> device drivers in the IPMI subsystem.
This is a nice set of cleanups outside of just allowing raw access.
I'll let you handle Zev's comments
On Mon, May 10, 2021 at 03:12:07PM +0930, Andrew Jeffery wrote:
> Soon it will be possible for one KCS device to have multiple associated
> chardevs exposed to userspace (for IPMI and raw-style access). However,
> don't prevent userspace from:
>
> 1. Opening more than one chardev at a time, or
>
On Mon, May 10, 2021 at 03:12:02PM +0930, Andrew Jeffery wrote:
> Make the KCS device drivers responsible for allocating their own memory.
>
> Until now the private data for the device driver was allocated internal
> to the private data for the chardev interface. This coupling required
> the
On Thu, May 20, 2021 at 04:21:31PM +0930, Andrew Jeffery wrote:
> Hi Corey,
>
> On Mon, 10 May 2021, at 15:11, Andrew Jeffery wrote:
> > Hello,
> >
> > This is the 3rd spin of the series refactoring the keyboard-controller-style
> > device drivers in the IPMI subsystem.
> >
> > v2 can be found
On Wed, May 19, 2021 at 02:49:27PM +0700, Quan Nguyen wrote:
> This series add support for the Aspeed specific SSIF BMC driver which
> is to perform in-band IPMI communication with the host in management
> (BMC) side.
>
> v3:
> + Switched binding doc to use DT schema format [Rob]
> + Splited
On Wed, May 19, 2021 at 02:49:29PM +0700, Quan Nguyen wrote:
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
>
> Signed-off-by: Quan Nguyen
> ---
> v3:
> + Removed redundant license info [Joel]
>
On Thu, May 13, 2021 at 02:26:36PM +0200, Petr Pavlu wrote:
> When an IPMI watchdog timer is being stopped in ipmi_close() or
> ipmi_ioctl(WDIOS_DISABLECARD), the current watchdog action is updated to
> WDOG_TIMEOUT_NONE and _ipmi_set_timeout(IPMI_SET_TIMEOUT_NO_HB) is called
> to install this
On Tue, May 04, 2021 at 01:59:49PM -0700, Ryan O'Leary wrote:
> Hi, please let me know if there's anything missing for review.
Only my negligence.
Unfortunately I can't add anything to my next tree at the moment, I have
to wait until the merge window closes.
Anyway, on the patch, if you look at
The following changes since commit a74e6a014c9d4d4161061f770c9b4f98372ac778:
Merge tag 's390-5.12-3' of
git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2021-03-10 13:15:16
-0800)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git
On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote:
> Hi Corey,
>
> On Fri, 19 Mar 2021, at 16:49, Andrew Jeffery wrote:
> > Hello,
> >
> > This series is a bit of a mix of things, but its primary purpose is to
> > expose BMC KCS IPMI devices to userspace in a way that enables
On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote:
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
>
> This commits adds support specifically for Aspeed AST2500 which commonly
> used as
On Wed, Apr 07, 2021 at 08:09:50PM +0700, Quan Nguyen wrote:
> Hi Corey,
>
> Thank you for reviewing
> I'll put my respond inline below.
>
> -Quan
>
> On 02/04/2021 21:21, Corey Minyard wrote:
> > On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote:
b folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
For the IPMI portion:
Acked-by: Corey Minyard
>
> Signed-off-by: Andy Shevchenko
> ---
> arch/powerpc/kernel/setup-common.c | 1
On Fri, Apr 02, 2021 at 08:43:24PM +0300, Andy Shevchenko wrote:
> The series contains set of clean ups, main parts of which are:
> - use ne platform_get_mem_or_io() API
> - use match_string() API
As I have already said, a very nice set of cleanups. Thank you.
These are applied and in the ipmi
On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote:
> This series add support for the Aspeed specific SSIF BMC driver which
> is to perform in-band IPMI communication with the host in management
> (BMC) side.
I don't have any specific feedback for this, but I'm wondering if it's
really
On Tue, Mar 30, 2021 at 09:16:45PM +0300, Andy Shevchenko wrote:
> Instead of making the comparison one by one, reuse si_to_str array
> in ipmi_hardcode_init_one() in conjunction with match_string() API.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/char/ipmi/ipmi_si.h | 3 +++
>
On Tue, Mar 30, 2021 at 09:16:44PM +0300, Andy Shevchenko wrote:
> Instead of twice repeat the constant literals, introduce
> panic_event_str array. It allows to simplify the code with
> help of match_string() API.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/char/ipmi/ipmi_msghandler.c |
On Tue, Mar 30, 2021 at 09:16:40PM +0300, Andy Shevchenko wrote:
> Switch to use new platform_get_mem_or_io() instead of home grown analogue.
> Note, we also introduce ipmi_set_addr_data_and_space() helper here.
You didn't send a part 0 that I saw, so just using this. This is a nice
cleanup set,
On Tue, Mar 30, 2021 at 09:16:42PM +0300, Andy Shevchenko wrote:
> By one of the previous clean up change we got a temporary variable to hold
> a device pointer. It can be utilized in other calls in the ->probe() and
> save a bit of LOCs.
The description here isn't accurate, there is no previous
r instead
> of timeout. Isnt that correct expectation ?
It depends. I think most BMCs will ignore packets with authentication
issues, so the client can't tell if it's a password issue or a
non-existent BMC.
-corey
>
> Thanks
>
> On Thu, Mar 25, 2021 at 9:37 AM Corey Minyard wrot
On Wed, Mar 24, 2021 at 08:08:05PM +0530, Maneesh Singhal wrote:
> Hello Team
>
> We built our code based on ipmicmd.c (The ipmi specifics are all same). The
> commands that we are using are Power On (0x01) and Power Off (0x00) and we
> are facing 16777411 error which I believe is timeout error.
On Thu, Mar 04, 2021 at 12:03:12PM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
Ok, this has been queued for next release.
Thanks,
This looks ok, it's queued for 5.12.
Thanks,
-corey
On Mon, Mar 01, 2021 at 10:05:15PM +0800, Liguang Zhang wrote:
> This function actually needs no return value. So remove the unneeded
> check and make it void.
>
> Signed-off-by: Liguang Zhang
> ---
> drivers/char/ipmi/ipmi_ssif.c | 81
This is queued for 5.12.
Thanks!
-corey
On Wed, Feb 24, 2021 at 08:50:27PM -0800, Jae Hyun Yoo wrote:
> From: Terry Duncan
>
> Rarely but still failures are observed while getting BMC device ID
> so this commit changes the condition to retry to get device id
> when cc is not IPMI_CC_NO_ERROR.
On Mon, Feb 22, 2021 at 08:41:58AM -0800, Jae Hyun Yoo wrote:
> From: Terry Duncan
>
> Rarely but still failures are observed while getting BMC device ID
> so this commit adds more conditions to retry to get device id.
I suppose this is ok. Any more and I'd say just retry on any error.
-corey
The following changes since commit 76c057c84d286140c6c416c3b4ba832cd1d8984e:
Merge branch 'parisc-5.11-2' of
git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2021-01-27
11:06:15 -0800)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git
seems apropriate to use a
> temporary client struct. Because we are answering a request we recieved
> when being a client ourselves. So, convert the code to use a temporary
> client and use the block-write function of the I2C core.
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Asmaa M
IPMI SOL fixes. If you use serial over LAN, you should upgrade.
If you use gensio or ser2net, you need to upgrade those, too.
I've been playing around with Windows support. Nothing complete yet,
and I'm not sure how to proceed. I might look at basing this on top of
gensio, since that would
On Tue, Jan 12, 2021 at 05:41:29PM +0100, Wolfram Sang wrote:
> The block-write function of the core was not used because there was no
> client-struct to use. However, in this case it seems apropriate to use a
> temporary client struct. Because we are answering a request we recieved
> when being a
Some very minor fixes. One came it today, but it was just changing
some commas to semicolons. The rest have been lying around a month or
more.
The following changes since commit 9ff9b0d392ea08090cd1780fb196f36dbb586529:
Merge tag 'net-next-5.10' of
I've been busy on the gensio library getting IPMI SoL up to snuff, and
it shows here. There are some general fixes in various places, but this
is mostly a complete rewrite the Serial Over LAN code to simplify it and
improve stability.
If you care about Serial Over LAN, you should upgrade.
-corey
101 - 200 of 979 matches
Mail list logo
