On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
I've created a small sample app (a screenshot is available in the
GitHub PR discussion at https://github.com/openjdk/jfx/pull/433), and
it seems to me that, while understanding the intricacies of
isTextBaseline and isPrefBaseline might be a bit tricky, from an
application developer's perspective it
This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS
streams (unfortunately I was not able to find repro case and more details on
why it was added) in gstappsink.c line 659-678 to store current caps which can
be lost during seek/flush. However, this workaround broke code
On Fri, 16 Apr 2021 09:25:47 GMT, Ambarish Rapte wrote:
> These are 2 corner case test cases for getRenderRoot() method.
> 1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1,
> -1)
> 2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect is
> of zero d
On Thu, 15 Apr 2021 17:37:08 GMT, Alexander Scherbatiy
wrote:
>> This is a proposal for cross compiling JavaFX base modules (excluding media
>> and webkit) for Windows AArch64 (ARM64).
>>
>> Main changes:
>> - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition
>> - HOST_ARCH a
On Thu, 15 Apr 2021 09:19:00 GMT, Ambarish Rapte wrote:
>> Each test in RegionBackgroundImageUITest makes several calls to
>> `robot.getPixelColor()` on App thread. Due to this each test requires more
>> than **60** seconds for execution.
>>
>> Fix is to save a screen capture of Scene (on App
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with direction
On Fri, 16 Apr 2021 10:35:29 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Combined rotation and direction
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 46:
>
>> 44
On Thu, 15 Apr 2021 16:43:08 GMT, Matthias Bläsing
wrote:
>> The functions from FileSystemJava are called from different threads the
>> root problem manifests because the JNI FindClass function behaves
>> differently when called from a context that is the ancestor of a java
>> frame compared to
On Sun, 4 Apr 2021 16:36:27 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Sun, 4 Apr 2021 16:36:27 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger wrote:
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
> reproduc
On Mon, 12 Apr 2021 14:45:58 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (an
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote:
> Issue: Java application (with WebView) will completely freeze after using it
> for a while.
>
> Fix: Use native isMainThread functions instead of JNI call.
Tested on all three platforms. Looks good.
-
Marked as reviewed by kc
On Fri, 16 Apr 2021 08:49:19 GMT, Arun Joseph wrote:
>> modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cpp
>> line 45:
>>
>>> 43: #elif OS(WINDOWS)
>>> 44: static ThreadIdentifier mainThread { 0 };
>>> 45: #endif
>>
>> Both here and below, where the `isMainThread` is def
Good, since these are the sort of behavioral changes we almost always
avoid. That change in the default behavior likely would not have been
approved.
As for the rest, I'll need some time to fully understand the impact of
the proposed behavior for propagating isTextBaseline up the tree, and
ho
That's true, and it also seems like outside of synthetic tests, the
benefit from this optimization diminishes in larger scene graphs. So I
will revert this change.
Am Fr., 16. Apr. 2021 um 16:28 Uhr schrieb Scott Palmer :
>
> “ I've changed the default alignment for
> Label to TOP_LEFT (the defau
On Fri, 16 Apr 2021 14:10:48 GMT, Kevin Rushforth wrote:
> A non-debug build crashes for me on startup in the
> `com.sun.webkit.WebPage.twkCreatePage` method on both Windows and Mac.
Never mind. This was a build error on my part. I've correct my mistake and will
rerun the test. Sorry for the n
“ I've changed the default alignment for
Label to TOP_LEFT (the default alignment of the base class Labeled is
CENTER_LEFT).”
How can you do that without breaking things? Even though it may be uncommon to
set minHeight or prefHeight, that isn’t the point. It still breaks existing
code.
Scott
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote:
> Issue: Java application (with WebView) will completely freeze after using it
> for a while.
>
> Fix: Use native isMainThread functions instead of JNI call.
A non-debug build crashes for me on startup in the
`com.sun.webkit.WebPage.twkCrea
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote:
> This PR introduces a refactory for VirtualFlow, fixing a number of issues
> reported about inconsistent scrolling speed (see
> https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues) i
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in related issu
On Fri, 16 Apr 2021 08:46:49 GMT, Johan Vos wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1305:
>>
>>> 1303: // Otherwise, our goal is to leave the index of the cell
>>> at the
>>> 1304: // top consistent, with the sa
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Fri, 16 Apr 2021 10:45:18 GMT, Johan Vos wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in related issu
> This PR introduces a refactory for VirtualFlow, fixing a number of issues
> reported about inconsistent scrolling speed (see
> https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues) is that the
> VirtualFlow implementation depends on
On Fri, 16 Apr 2021 10:03:07 GMT, Ajit Ghaisas wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>
On Fri, 16 Apr 2021 09:00:19 GMT, Johan Vos wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in related issu
On Fri, 16 Apr 2021 08:47:42 GMT, Johan Vos wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>> line 1315:
>>
>>> 1313: s1 = sb.getLayoutY();
>>> 1314: newDelta = newPosition - position;
>>> 1315: System.err.
These are 2 corner case test cases for getRenderRoot() method.
1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1, -1)
2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect is of
zero dimensions, for example (20, 20, 0, 0)
- emptyDirtyRegion(): When the
> This PR introduces a refactory for VirtualFlow, fixing a number of issues
> reported about inconsistent scrolling speed (see
> https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues) is that the
> VirtualFlow implementation depends on
On Thu, 15 Apr 2021 23:41:02 GMT, Kevin Rushforth wrote:
>> Issue: Java application (with WebView) will completely freeze after using it
>> for a while.
>>
>> Fix: Use native isMainThread functions instead of JNI call.
>
> modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cp
On Thu, 15 Apr 2021 07:53:50 GMT, Ajit Ghaisas wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 130
On Mon, 12 Apr 2021 13:10:44 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line
On Thu, 15 Apr 2021 07:22:29 GMT, Ajit Ghaisas wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java
>
35 matches
Mail list logo
