Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2021-12-17 Thread Kevin Rushforth
On Wed, 15 Dec 2021 21:30:41 GMT, Martin Fox wrote: > I've decided that if this PR goes forward we should abandon #672. The changes > in #672 would be bypassed for KeyEvents generated by physical keystrokes. For > a while I thought it would be useful for handling KeyEvents created via the >

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Kevin Rushforth
On Tue, 14 Dec 2021 07:27:50 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrapper was introduced which

Integrated: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes

2021-12-17 Thread Kevin Rushforth
On Sat, 12 Sep 2020 17:16:38 GMT, Kevin Rushforth wrote: > This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-12-17 Thread Kevin Rushforth
On Fri, 26 Nov 2021 19:49:37 GMT, Abhinay Agarwal wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Alexander Matveev
On Fri, 17 Dec 2021 17:15:22 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v5] > >

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v9]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 15:18:51 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-12-17 Thread Kevin Rushforth
On Wed, 24 Nov 2021 14:39:57 GMT, yosbits wrote: >> But why? The initialization block of a `for` statement is exactly where >> you'd put loop-scoped variables. > > This change significantly improves performance because the BitSet's size () > method is an O (N) implementation. You may be

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v3]

2021-12-17 Thread Kevin Rushforth
On Fri, 26 Nov 2021 19:49:37 GMT, Abhinay Agarwal wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the

Re: RFR: DRAFT 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v4]

2021-12-17 Thread Martin Fox
On Mon, 13 Dec 2021 19:40:47 GMT, Martin Fox wrote: >> There was a mismatch between the way `get_glass_key` generated the Java key >> code for a given key press and how `getKeyCodeForChar` determined the key >> code for the matching character. For example, when pressing the plus sign on >> a

Re: RFR: DRAFT 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2021-12-17 Thread Martin Fox
On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote: > The code that maps from a Windows virtual key code to a Java key code in > `getKeyCodeForChar` did not match the similar code in > `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable > punctuation and symbols in

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Johan Vos
On Tue, 14 Dec 2021 07:27:50 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrapper was introduced which

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-12-17 Thread Kevin Rushforth
On Sat, 11 Dec 2021 03:20:54 GMT, Alexander Matveev wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v3] > >

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Kevin Rushforth
On Tue, 14 Dec 2021 07:27:50 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrapper was introduced which

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v9]

2021-12-17 Thread Michael Strauß
On Fri, 17 Dec 2021 15:18:51 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v9]

2021-12-17 Thread Nir Lisker
On Fri, 17 Dec 2021 15:18:51 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v9]

2021-12-17 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 14:15:32 GMT, Nir Lisker wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor updates > > CONTRIBUTING.md line 204: > >> 202: section of the Code Review Policies doc, we also need a >>

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 14:24:01 GMT, Nir Lisker wrote: >> CONTRIBUTING.md line 18: >> >>> 16: >>> 17: >>> 18: If you find yourself wishing for a feature that doesn't exist in >>> OpenJFX, you are probably not alone. There are bound to be others out there >>> with similar needs.

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Nir Lisker
On Fri, 17 Dec 2021 14:08:23 GMT, Michael Strauß wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor updates > > CONTRIBUTING.md line 18: > >> 16: >> 17: >> 18: If you find yourself wishing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Nir Lisker
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Integrated: 8278860: Streamline properties for Monocle

2021-12-17 Thread Johan Vos
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Michael Strauß
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Nir Lisker
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8278860: Streamline properties for Monocle [v2]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 13:54:10 GMT, Johan Vos wrote: >> Base decisions in prism for embedded cases on the same glass.platform >> property that is also used in glass. >> This PR replaces the property `embedded` with the property `glass.platform` . >> >> There is only 1 place where the property

Re: RFR: 8278860: Streamline properties for Monocle [v2]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 00:20:06 GMT, Michael Strauß wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add space after comma > > modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 67: > >> 65: >> 66:

Re: RFR: 8278860: Streamline properties for Monocle [v2]

2021-12-17 Thread Johan Vos
> Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property `embedded` was read, which is in the > PlatformUtil.java. >

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 13:43:43 GMT, Johan Vos wrote: > I therefore recommend to integrate this, and have other issues being > discussed in follow-up issues Agreed. I think I've addressed all comments made in this PR. @aghaisas @arapte @nlisker can one of you be the second reviewer?

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 13:33:57 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v8]

2021-12-17 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v7]

2021-12-17 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v6]

2021-12-17 Thread Johan Vos
On Fri, 17 Dec 2021 12:56:40 GMT, Kevin Rushforth wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More review comments >> >> 1. Renamed "Contributing to...codebase" section to "Coding style and >> testing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v6]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 12:46:07 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v6]

2021-12-17 Thread Kevin Rushforth
> This PR updates the `CONTRIBUTING.md` guide to address the following: > > 1. Clarify the process for adding new features / API changes, specifically > that they must be discussed on the mailing list as the first step. > 2. Add a link to the mailing list in the section regarding contributing

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-17 Thread Kevin Rushforth
On Fri, 17 Dec 2021 12:21:37 GMT, Johan Vos wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor updates to address pending review comments that I did last year, but >> forgot to push > > CONTRIBUTING.md line

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v5]

2021-12-17 Thread Johan Vos
On Thu, 16 Dec 2021 21:26:29 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: Scene builder crash in IntelliJ 2021.3 and JDK 17.0.1

2021-12-17 Thread Davide Perini
PS: I have this problem on both Windows 11 and Linux Ubuntu 20.04. Il 16/12/2021 17:01, Davide Perini ha scritto: As title. Using IntelliJ 2021.3 and JDK 17.0.1 with JavaFX 17.0.1. As soon as I open an .fxml it ask me to install scene builder, I installed it and now Intellij crashes as soon