On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote:
> This PR fixes an issue with selection of multiple items in TableView and
> TreeTableView controls that gets moved unexpectedly when new items are added
> even way below the selected items.
>
> A couple of tests have been ad
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote:
> This PR fixes an issue with selection of multiple items in TableView and
> TreeTableView controls that gets moved unexpectedly when new items are added
> even way below the selected items.
>
> A couple of tests have been ad
ed
> item gets deselected, and table anchor gets moved), and pass with this PR
> (first selected item keeps selected, and table anchor remains at the same
> place).
Jose Pereda has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two c
On Fri, 6 May 2022 10:16:41 GMT, Jose Pereda wrote:
> This PR extends the check if a treeItem is expanded to all its ancestors, as
> in case one ancestor is collapsed, all its children will be hidden.
>
> 4 tests are included, two for TreeView and two for TreeTableView.
This pull
On Wed, 20 Apr 2022 18:26:06 GMT, Jose Pereda wrote:
> This PR updates the screen for each window even for the case where the old
> screen has been disposed but there is a new screen instance found for such
> window.
>
> This is the case of Android, where the lifecycle of
when the app goes to the background, and
> providing a new native screen, in case it comes back to the foreground.
> Before this PR, the screen for the window wasn't updated after returning from
> the background, and if orientation changes happened, the dimensions were
> wrong.
Jo
This PR extends the check if a treeItem is expanded to all its ancestors, as in
case one ancestor is collapsed, all its children will be hidden.
4 tests are included, two for TreeView and two for TreeTableView.
-
Commit messages:
- Check if treeItem and all its ancestors are
This PR fixes an issue with selection of multiple items in TableView and
TreeTableView controls that gets moved unexpectedly when new items are added
even way below the selected items.
A couple of tests have been added. They fail without this PR (first selected
item gets deselected, and table
when the app goes to the background, and
> providing a new native screen, in case it comes back to the foreground.
> Before this PR, the screen for the window wasn't updated after returning from
> the background, and if orientation changes happened, the dimensions were
> wrong.
Jo
On Wed, 4 May 2022 16:03:20 GMT, Jose Pereda wrote:
>> This PR updates the screen for each window even for the case where the old
>> screen has been disposed but there is a new screen instance found for such
>> window.
>>
>> This is the case of Android, where th
when the app goes to the background, and
> providing a new native screen, in case it comes back to the foreground.
> Before this PR, the screen for the window wasn't updated after returning from
> the background, and if orientation changes happened, the dimensions were
> wrong.
Jo
On Mon, 14 Mar 2022 14:49:41 GMT, Jose Pereda wrote:
> This PR fixes
> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also
> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and verifies
> that the tests mentioned in
> [JDK
t; were already passing, after removing some obsolete asserts, even without this
> PR.
Jose Pereda has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commits:
- Fix spacing in tests
- Merge branch 'master' into 8193442-tree
This PR updates the screen for each window even for the case where the old
screen has been disposed but there is a new screen instance found for such
window.
This is the case of Android, where the lifecycle of the application allows
destroying the native screen when the app goes to the
On Fri, 7 Jan 2022 20:00:27 GMT, Jose Pereda wrote:
> This PR converts the change's `from` field from a list of tablePositions into
> a list of selected indices of rows.
>
> It includes two tests for TableView and one for TreeTableView (the second
> test wasn't included due
On Mon, 4 Apr 2022 13:31:52 GMT, Kevin Rushforth wrote:
>> This PR fixes
>> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also
>> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and
>> verifies that the tests mentioned in
>>
t; were already passing, after removing some obsolete asserts, even without this
> PR.
Jose Pereda has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request cont
On Tue, 15 Mar 2022 18:57:50 GMT, Kevin Rushforth wrote:
>> This PR fixes
>> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also
>> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and
>> verifies that the tests mentioned in
>>
This PR fixes JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442),
but also [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and
verifies that the tests mentioned in
[JDK-8088157](https://bugs.openjdk.java.net/browse/JDK-8088157) are working
(with a minor fix).
On Fri, 14 Jan 2022 20:18:57 GMT, Jose Pereda wrote:
>> This PR converts the change's `from` field from a list of tablePositions
>> into a list of selected indices of rows.
>>
>> It includes two tests for TableView and one for TreeTableView (the second
>
browse/JDK-8232825] with key
> navigation), that pass with this PR and fail without it.
Jose Pereda has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- Merge branch 'master' into 8273339-changefrom
- Apply change onl
On Fri, 7 Jan 2022 19:36:45 GMT, Jose Pereda wrote:
> This PR adds a predicate to TableView and TreeTableView selection models
> order to remove rows from the selection only when there are no selected cells
> in that given row, when cell selection is enabled.
>
> Two tests
his PR and pass with it.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedback from reviewer
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/709/files
- new: https://git.openjdk.java.net/jfx/pull/709/files/fe9
On Fri, 4 Feb 2022 17:33:18 GMT, Michael Strauß wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewer
>
> modules/javafx.controls/src/main/java/javafx/s
his PR and pass with it.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedback from reviewer
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/709/files
- new: https://git.openjdk.java.net/jfx/pull/709/files/344
On Sat, 5 Feb 2022 05:08:54 GMT, yosbits wrote:
>> This PR adds a predicate to TableView and TreeTableView selection models
>> order to remove rows from the selection only when there are no selected
>> cells in that given row, when cell selection is enabled.
>>
>> Two tests have been added as
On Wed, 19 Jan 2022 19:43:38 GMT, Martin Fox wrote:
>> When a window is closed while handling performKeyEquivalent the same NSEvent
>> might be passed to the new key window causing it to being processed twice.
>> Long ago a fix was put in for this case; when the GlassWindow was closed a
>>
On Wed, 19 Jan 2022 16:25:17 GMT, Martin Fox wrote:
>> When a window is closed while handling performKeyEquivalent the same NSEvent
>> might be passed to the new key window causing it to being processed twice.
>> Long ago a fix was put in for this case; when the GlassWindow was closed a
>>
On Tue, 18 Jan 2022 17:26:15 GMT, Martin Fox wrote:
>> When a window is closed while handling performKeyEquivalent the same NSEvent
>> might be passed to the new key window causing it to being processed twice.
>> Long ago a fix was put in for this case; when the GlassWindow was closed a
>>
browse/JDK-8232825] with key
> navigation), that pass with this PR and fail without it.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Apply change only when cell selection is enabled
-
Changes:
- all: https://git.openjdk.
On Wed, 12 Jan 2022 18:34:19 GMT, Martin Fox wrote:
>> I don't know. I'm always skeptical of 0 size rectangles. I'd either leave it
>> as-is or maybe use a `(0,0,1,1)` rectangle.
>
> The initial size should not matter since it will be re-sized to the window's
> content bounds. But I would
On Wed, 12 Jan 2022 16:56:12 GMT, Martin Fox wrote:
>> The OS crashes if the contentView of a window is set to nil while handling
>> processKeyEquivalent. With this PR we just set the contentView to a basic
>> do-nothing NSView for the interim.
>
> Martin Fox has updated the pull request
On Tue, 11 Jan 2022 22:18:53 GMT, Martin Fox wrote:
> The OS crashes if the contentView of a window is set to nil while handling
> processKeyEquivalent. With this PR we just set the contentView to a basic
> do-nothing NSView for the interim.
This PR fixes the JDK-8242544 issue as intended.
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight about what actually
This PR converts the change's `from` field from a list of tablePositions into a
list of selected indices of rows.
It includes two tests for TableView and one for TreeTableView (the second test
wasn't included due to an
[issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with key
This PR adds a predicate to TableView and TreeTableView selection models order
to remove rows from the selection only when there are no selected cells in that
given row, when cell selection is enabled.
Two tests have been added as well, that fail without this PR and pass with it.
-
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
This pull request has now been integrated.
Changeset: b257647e
Author: Jose Pereda
URL:
https://git.openjdk.java.net/jfx/
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
No problem, I just pushed the minor change.
-
PR: https://git.openjdk.java.net/jfx/pull/664
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedback
-
Changes:
- all: https://git.openjdk.java.net/jfx/pu
On Thu, 25 Nov 2021 00:29:36 GMT, Kevin Rushforth wrote:
>> As indicated in the bug report, WebView needs to call to
>> `CookieManager::getDefault` within a `doPrivileged` block so that it will
>> work when a security manager is enabled. There are two calls in
>>
On Wed, 24 Nov 2021 23:05:05 GMT, Kevin Rushforth wrote:
> As indicated in the bug report, WebView needs to call to
> `CookieManager::getDefault` within a `doPrivileged` block so that it will
> work when a security manager is enabled. There are two calls in
>
On Wed, 24 Nov 2021 10:35:50 GMT, Jose Pereda wrote:
> This PR improves drag and drop events on a WebView node, by generating the
> content from the dragboard only when the drag events starts, and not for
> every drag over event.
>
> A manual test is included that shows how th
On Mon, 15 Nov 2021 11:19:13 GMT, Jose Pereda wrote:
> This PR fixes an exception that can happen when dragging an image from a
> WebView on macOS.
>
> Dragging an image that is directly included like ``
> works fine, without exception. However, there are (at least) two othe
en dragging online images, as the time between each
> consecutive drag over event drops from hundreds of ms to tens of ms or even
> lower.
>
> This PR is somehow blocked by #668, as dragging some images fails on macOS.
Jose Pereda has updated the pull request incrementally wit
On Wed, 24 Nov 2021 17:23:30 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebV
On Wed, 24 Nov 2021 16:53:12 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> tests/system/src/test/java/test/com/sun/glass/ui/mac/Mac
t;
> which leads to `ByteArrayFromPixels` being called with a null byte array.
>
> The included test reproduces the case by directly pushing the `MacPasteboard`
> content (instead of adding a more complex test with a webView and a drag and
> drop gesture).
Jose Pereda has updated t
This PR improves drag and drop events on a WebView node, by generating the
content from the dragboard only when the drag events starts, and not for every
drag over event.
A manual test is included that shows how the drag and drop experience improves,
especially when dragging online images, as
On Tue, 23 Nov 2021 11:00:51 GMT, Jose Pereda wrote:
> This PR fixes a memory leak, as a follow-up of
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840).
>
> The tests pass on desktop (Linux/macOS/Windows) and there is no regression on
> Android (see [JDK
On Tue, 23 Nov 2021 11:00:51 GMT, Jose Pereda wrote:
> This PR fixes a memory leak, as a follow-up of
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840).
>
> The tests pass on desktop (Linux/macOS/Windows) and there is no regression on
> Android (see [JDK
On Tue, 23 Nov 2021 11:00:51 GMT, Jose Pereda wrote:
> This PR fixes a memory leak, as a follow-up of
> [JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840).
>
> The tests pass on desktop (Linux/macOS/Windows) and there is no regression on
> Android (see [JDK
This PR fixes a memory leak, as a follow-up of
[JDK-8241840](https://bugs.openjdk.java.net/browse/JDK-8241840).
The tests pass on desktop (Linux/macOS/Windows) and there is no regression on
Android (see [JDK-8254605](https://bugs.openjdk.java.net/browse/JDK-8254605)).
-
Commit
On Wed, 10 Nov 2021 18:20:11 GMT, Jose Pereda wrote:
> This PR enables intersection observer support for WebKit, and includes a
> system test.
Worth pointing out that
[JDK-8273558](https://bugs.openjdk.java.net/browse/JDK-8273558) gets fixed with
this PR.
-
PR:
This PR fixes an exception that can happen when dragging an image from a
WebView on macOS.
Dragging an image that is directly included like ``
works fine, without exception. However, there are (at least) two other cases
when the IAE is thrown:
- Dragging an image that is part of an
On Thu, 11 Nov 2021 09:57:21 GMT, Jose Pereda wrote:
> After https://bugs.openjdk.java.net/browse/JDK-8275723 and the fix applied to
> `GlassApplication.m` for macOS, this PR is a follow-up and applies the same
> fix to `GlassApplication.m` on iOS to prevent the crash.
>
> I
After https://bugs.openjdk.java.net/browse/JDK-8275723 and the fix applied to
`GlassApplication.m` for macOS, this PR is a follow-up and applies the same fix
to `GlassApplication.m` on iOS to prevent the crash.
I've only tested on iOS 15.0 building from macOS 11.6, but it should fix the
crash
This PR enables intersection observer support for WebKit, and includes a system
test.
-
Commit messages:
- Include html file
- Enable intersection observer support, including system test
Changes: https://git.openjdk.java.net/jfx/pull/664/files
Webrev:
On Tue, 26 Oct 2021 11:07:50 GMT, Jose Pereda wrote:
> After [JDK-8245053](https://bugs.openjdk.java.net/browse/JDK-8245053) for
> Android, this PR applies the same approach on iOS: tapping on a text input
> control on iOS shows the keyboard, which hides after the control loses the
After [JDK-8245053](https://bugs.openjdk.java.net/browse/JDK-8245053) for
Android, this PR applies the same approach on iOS: tapping on a text input
control on iOS shows the keyboard, which hides after the control loses the
focus.
Now, both platforms have the same behaviour.
Tested on an iOS
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote:
> As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and
> `ES2Graphics` are now identical, which should have been the case all along.
> The fact that they weren't identical was the source of a bug that was only
> discovered
On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote:
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothin
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In li
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In li
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In li
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
>> The other option, as you mention,
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Thu, 9 Sep 2021 08:52:31 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with th
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Wed, 8 Sep 2021 21:08:40 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewers
>
> modules/javafx.web/src/main/java/com/sun
On Wed, 8 Sep 2021 22:37:18 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line 707:
>>
>>> 705: * level of transparency.
>>> 706: *
>>> 707: * However, if the HTML content being loaded sets its own
>>
>> I looked at the generated
On Wed, 8 Sep 2021 16:15:36 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with th
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Tue, 7 Sep 2021 10:40:01 GMT, Michael Strauß wrote:
>> This PR fixes the exception thrown by the sample code in
>> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
>> the incorrect behavior in the scenario described.
>
> Michael Strauß has updated the pull
On Tue, 7 Sep 2021 10:40:01 GMT, Michael Strauß wrote:
>> This PR fixes the exception thrown by the sample code in
>> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
>> the incorrect behavior in the scenario described.
>
> Michael Strauß has updated the pull
On Tue, 7 Sep 2021 09:42:43 GMT, Ambarish Rapte wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added test
>
> The exception can be observed in one other similar scenario.
> 1. Run the program attached to
>
On Mon, 6 Sep 2021 13:30:46 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
>> The other option, as you mention,
On Fri, 3 Sep 2021 21:11:48 GMT, Kevin Rushforth wrote:
>> I guess the assumption might be the other way around? Since the fill color
>> was not transparent, there was no need to clear the area, when rendering the
>> same solid rect at the new position?
>>
>> If you check this
>>
On Fri, 3 Sep 2021 21:19:09 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use color to int32 converter instead of hash
>
> modules/javafx.web/src/main/java/com/s
On Fri, 3 Sep 2021 18:19:45 GMT, Michael Strauß wrote:
> This PR fixes the exception thrown by the sample code in
> [8273324](https://bugs.openjdk.java.net/browse/JDK-8273324), while retaining
> the incorrect behavior in the scenario described.
Marked as reviewed by jpereda (Committer).
On Fri, 27 Aug 2021 13:05:24 GMT, Kevin Rushforth wrote:
>> Initially, this was needed when there was some level of transparency: when
>> scrolling the old content was not cleared and you could see it at its old
>> position.
>>
>> For the full transparency case, this is still the case, but
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Fri, 27 Aug 2021 13:06:18 GMT, Kevin Rushforth wrote:
>> Yes, that makes total sense.
>>
>> In fact, there was also the need to add a new
>> [method](https://github.com/openjdk/jfx/pull/563/files#diff-b80bc720bf639cde38c5197a7619561221abcd34fb9ff7a933f4b932a1f36735R2579)
>> in `WebPage`
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Wed, 25 Aug 2021 23:24:35 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/webkit/We
On Wed, 25 Aug 2021 23:23:00 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/pri
On Wed, 25 Aug 2021 23:49:10 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.web/src/main/java/javafx/scene/web/We
On Wed, 25 Aug 2021 23:20:37 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update cssref.html
>
> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2Grap
On Tue, 24 Aug 2021 22:12:01 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In li
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
On Thu, 12 Aug 2021 21:33:57 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set since 18
>
> The API for the new property looks fine. I left a couple comments o
On Thu, 12 Aug 2021 21:28:53 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Set since 18
>
> modules/javafx.web/src/main/java/javafx/scene/web/WebView.java line
upport for setting the background color of a WebPage, by adding a `pageFill`
> property, and a CSR is required.
>
> The color for the background, that can be opaque, transparent or with any
> level of opacity, can be set via code or via CSS using `-fx-page-fill`.
>
> Unit tests and a sy
could happen in rare occasions, mainly due
> to constrains applied by the native layer, so it doesn't add any overhead.
>
> A system test for MacOS is included.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedbac
On Sat, 17 Jul 2021 12:23:47 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewer
>
> tests/system/src/test/java/test/javafx/stage/St
On Thu, 15 Jul 2021 15:48:18 GMT, Ambarish Rapte wrote:
>> On Windows, with two monitors with different DPI settings, if a JavaFX
>> application changes screens (either by dragging or programmatically) there
>> is a resize event to adjust the view to its new platform scale.
>>
>> Note that
On Thu, 15 Jul 2021 15:48:18 GMT, Ambarish Rapte wrote:
>> On Windows, with two monitors with different DPI settings, if a JavaFX
>> application changes screens (either by dragging or programmatically) there
>> is a resize event to adjust the view to its new platform scale.
>>
>> Note that
As described in the issue, when the stage is moved to the screen top position,
it is moved below the system menu bar. However, doing it twice doesn't trigger
a native callback to the Java layer, and the stage yPosition doesn't get
updated with the actual position of the application. This has
On Windows, with two monitors with different DPI settings, if a JavaFX
application changes screens (either by dragging or programmatically) there is a
resize event to adjust the view to its new platform scale.
Note that there is already a
On Fri, 2 Jul 2021 11:01:56 GMT, Jose Pereda wrote:
> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
> the class is not public. Therefore, public API is needed in `WebView` to
> allow developers access to it.
>
> In line with the `fontSmoothin
1 - 100 of 233 matches
Mail list logo
