On Mon, 28 Feb 2022 16:02:42 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`. I tested this along with the other VS 2019 and
> WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
This pull request has now been integrated.
Changeset: 2f2a07a9
Author: Kevin Rushfort
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and
WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
-
Commit messages:
- 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start
Changes:
Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in mainline
jfx. I tested this along with the other VS 2019 and WebKit 613.1 fixes together
in the `test-kcr-11.0.15` branch.
-
Commit messages:
- 8265399: Update to Visual Studio 2019 version 16.9.3
Changes:
On Sun, 27 Feb 2022 07:10:25 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add
On Sun, 27 Feb 2022 05:35:23 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>>
On Sun, 27 Feb 2022 05:43:27 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>>
On Wed, 16 Feb 2022 16:46:47 GMT, Kevin Rushforth wrote:
> The `javafx.graphics` module has a number of native libraries, including the
> redistributable Microsoft DLLs on Windows. When running an application using
> the standalone JavaFX SDK, we load all of the needed DLLs from the
On Mon, 7 Feb 2022 08:14:50 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>>
On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed
On Fri, 25 Feb 2022 07:21:57 GMT, Jay Bhaskar wrote:
>> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
>> appending mime types in pasteboard operation like setPlainText, Hence it
>> will append duplicate mime types in m_availMimeTypes , in this case the
>> length
On Fri, 25 Feb 2022 13:27:42 GMT, Kevin Rushforth wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor variable names and update the formatting
>
> tests/system/src/t
On Fri, 25 Feb 2022 11:15:23 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed
On Thu, 24 Feb 2022 23:59:29 GMT, Kevin Rushforth wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.Th
On Thu, 24 Feb 2022 18:46:21 GMT, Hima Bindu Meda wrote:
> Basically, buttons property is a mask which represents the button/buttons
> clicked on the mouse.
> It is observed that event.buttons property is set to 0 when there is
> mouse press or drag event.This behaviour is observed only
On Thu, 24 Feb 2022 18:46:21 GMT, Hima Bindu Meda wrote:
> Basically, buttons property is a mask which represents the button/buttons
> clicked on the mouse.
> It is observed that event.buttons property is set to 0 when there is
> mouse press or drag event.This behaviour is observed only
On Thu, 24 Feb 2022 21:46:20 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. I tested the backports of
> [JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
> [JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
> [JDK-82
Clean backport to `jfx17u`. I tested the backports of
[JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
[JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
[JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) together in the
`test-kcr-17.0.3` branch.
On Thu, 24 Feb 2022 19:31:18 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. I tested the backports of
> [JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
> [JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
> [JDK-82
On Thu, 24 Feb 2022 19:13:36 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`. This will enable
> [JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) to then be
> backported cleanly, once that fix is integrated into `jfx` mainline.
This pull request has
On Thu, 24 Feb 2022 19:12:09 GMT, Kevin Rushforth wrote:
> Clean backport of this test-only fix to `jfx11u`.
This pull request has now been integrated.
Changeset: 9d0b5f8d
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/com
Clean backport to `jfx17u`. I tested the backports of
[JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
[JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
[JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) together in the
`test-kcr-17.0.3` branch.
Clean backport to `jfx11u`. This will enable
[JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) to then be
backported cleanly, once that fix is integrated into `jfx` mainline.
-
Commit messages:
- 8223377: JavaFX can crash due to loading the wrong native libraries if
Clean backport of this test-only fix to `jfx11u`.
-
Commit messages:
- 8242505: Some WebKit tests might fail because Microsoft libraries are not
loaded
Changes: https://git.openjdk.java.net/jfx11u/pull/73/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=73=00
Issue:
I don't know of a way to determine whether the text of a labeled is
currently being displayed truncated with ellipses. There isn't a
(read-only) overrun or displayedText property, either of which would
allow an app to know.
The only thing I can think of to work around this is to estimate the
I spent a fair bit of time simulating and testing the
D3DERR_DEVICEREMOVED cases for RDP disconnect to fix JDK-8239589 [1],
but detaching a screen, which will change the number of active adapters,
is a somewhat different case (I'm not sure how easy it would be to
simulate it). It's very likely
On Thu, 23 Dec 2021 17:43:19 GMT, Florian Kirmaier
wrote:
> Fixing memoryleak, related to touch events in ScrollPaneWhen touchDetected or
> mouseDown is true, the sbTouch animation is running,
> and the node is removed from the Scene, then the animation will never stop,
> causing a memory
On Mon, 21 Feb 2022 06:02:32 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add
On Mon, 21 Feb 2022 01:57:29 GMT, Jay Bhaskar wrote:
>> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
>> 105:
>>
>>> 103: Platform.runLater(() -> {
>>> 104: webView = new WebView();
>>> 105: Scene scene = new Scene(webView,80,60);
On Mon, 21 Feb 2022 05:30:36 GMT, Jay Bhaskar wrote:
>> The bounding rect.x rect.y is top left corner, and line is being drawn below
>> the bottom, so height and thickness need to be considered.
>
> for (int i = line_start_y; i <= (width - line_start_y -6); i++) { , this
> meets the condition
On Tue, 22 Feb 2022 17:15:19 GMT, Ambarish Rapte wrote:
> Include additional stabilization fixes of WebKit 613.1
> Sanity testing did not show any concerns.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/740
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote:
>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous
> commits have been removed. Incremental views are not
On Tue, 22 Feb 2022 12:43:37 GMT, Jay Bhaskar wrote:
>> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
>> cause a JS trap in WebView
>
> Jay Bhaskar has refreshed the contents of this pull request, and previous
> commits have been removed. Incremental views are not
On Sat, 19 Feb 2022 03:52:41 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add
On Sat, 19 Feb 2022 11:43:00 GMT, Jay Bhaskar wrote:
> Fix YarrJIT backtrackCharacterClassNonGreedy breakpoint() Certain regex can
> cause a JS trap in WebView
The fix looks good. I confirm that the new test fails without the fix and
passes with the fix.
-
Marked as reviewed by
On Fri, 18 Feb 2022 15:21:49 GMT, Alexander Scherbatiy
wrote:
> There is the bouncing when scrolling a node on a ScrollPane to the
> right/bottom (the node on the scroll pane is scrolled further than its
> width/height so the background is visible and then automatically is scrolled
> back to
On Fri, 18 Feb 2022 17:04:08 GMT, Alexander Scherbatiy
wrote:
> Zoomed/Rotated with two fingers rectangle flickers (unexpectedly becomes
> pretty small or large and then returns back to previous size several times
> during zooming/rotating) on a Raspberry Pi with Touchscreen.
>
> The log
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote:
>> Include additional stabilization fixes of WebKit 613.1
>> Sanity testing did not show any concerns.
>
> Ambarish Rapte has updated the pull request incrementally with one additional
> commit since the last revision:
>
> correct
On Wed, 16 Feb 2022 13:08:04 GMT, Ambarish Rapte wrote:
>> Include additional stabilization fixes of WebKit 613.1
>> Sanity testing did not show any concerns.
>
> Ambarish Rapte has updated the pull request incrementally with one additional
> commit since the last revision:
>
> correct
tps://bugs.openjdk.java.net/browse/JDK-8208532
On Mon, 14 Feb 2022 at 02:34, Scott Palmer wrote:
Would it be a custom doclet that was part of the OpenJFX project
and require no changes to the javadoc tool?
Scott
> On Feb 12, 2022, at 9:52 AM, Kevin Rushforth
wrote:
>
The `javafx.graphics` module has a number of native libraries, including the
redistributable Microsoft DLLs on Windows. When running an application using
the standalone JavaFX SDK, we load all of the needed DLLs from the SDK `bin`
directory and everything works as expected.
When creating the
On Wed, 16 Feb 2022 13:40:23 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`.
This pull request has now been integrated.
Changeset: fdb50f28
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/commit/fdb50f281732f6192068aa45050ef823c5f11228
Stats: 4 li
On Wed, 16 Feb 2022 13:39:59 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`.
This pull request has now been integrated.
Changeset: eec13f7f
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/commit/eec13f7fac079e8ed8cfa7b7e9bac0626b51
Stats: 68 li
On Wed, 16 Feb 2022 13:39:14 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`.
This pull request has now been integrated.
Changeset: 6ab043f9
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/commit/6ab043f96699e8c9accf8191cc93854595114742
Stats: 101 li
Clean backport to `jfx11u`.
-
Commit messages:
- 8242544: CMD+ENTER key event crashes the application when invoked on dialog
Changes: https://git.openjdk.java.net/jfx11u/pull/72/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=72=00
Issue:
Clean backport to `jfx11u`.
-
Commit messages:
- 8278260: JavaFX shared libraries not stripped on Linux or macOS
Changes: https://git.openjdk.java.net/jfx11u/pull/71/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=71=00
Issue:
Clean backport to `jfx11u`.
-
Commit messages:
- 8277457: AccessControlException: access denied ("java.net.NetPermission"
"getCookieHandler")
Changes: https://git.openjdk.java.net/jfx11u/pull/70/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=70=00
Issue:
On Sun, 13 Feb 2022 07:35:32 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add
I thought that JavaFX
uses a modified javadoc tool.
On Sat, Feb 12, 2022 at 4:52 PM Kevin Rushforth
wrote:
While something like this could be handy, I doubt that adding this
much
knowledge of JavaFX into the javadoc tool would gain any traction.
-- Kevin
On 2/9/2022 7:
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness
While something like this could be handy, I doubt that adding this much
knowledge of JavaFX into the javadoc tool would gain any traction.
-- Kevin
On 2/9/2022 7:11 AM, Nir Lisker wrote:
Hi,
When reviewing the docs changes to TabPane, I saw that some properties
mention the CSS that is
On Sat, 12 Feb 2022 01:00:46 GMT, Kevin Rushforth wrote:
> 2. The text is always drawn as a thin line...
That should be "the text _underline or line-through_ is always drawn as a thin
line...".
-
PR: https://git.openjdk.java.net/jfx/pull/731
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness
On Fri, 11 Feb 2022 18:35:37 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u.
This pull request has now been integrated.
Changeset: 9bf1feb0
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/commit/9bf1feb0abf9a4f28c80f655aa1e63325b6383ab
Stats: 20 li
Clean backport to jfx17u.
-
Commit messages:
- 8281459: WebKit 613.1 build broken on M1
Changes: https://git.openjdk.java.net/jfx17u/pull/34/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=34=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8281459
Stats: 20
On Fri, 11 Feb 2022 16:48:47 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u. CI build passed on three platforms. Tested locally
> on macOS.
This pull request has now been integrated.
Changeset: 4c944064
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/
On Fri, 11 Feb 2022 16:48:35 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u. CI build passed on three platforms. Tested locally
> on macOS.
This pull request has now been integrated.
Changeset: b0ae8b6b
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/
On Fri, 11 Feb 2022 16:48:27 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u. CI build passed on three platforms. Tested locally
> on macOS.
This pull request has now been integrated.
Changeset: f52ded76
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/
On Fri, 11 Feb 2022 16:48:20 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u. CI build passed on three platforms. Tested locally
> on macOS.
This pull request has now been integrated.
Changeset: 0ab83722
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/
On Fri, 11 Feb 2022 16:48:47 GMT, Kevin Rushforth wrote:
> Clean backport to jfx17u. CI build passed on three platforms. Tested locally
> on macOS.
Skara didn't mark this one as clean, although it is. See
[SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). I double-c
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on
macOS.
-
Commit messages:
- 8278980: Update WebKit to 613.1
Changes: https://git.openjdk.java.net/jfx17u/pull/33/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=33=00
Issue:
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on
macOS.
-
Commit messages:
- 8242544: CMD+ENTER key event crashes the application when invoked on dialog
Changes: https://git.openjdk.java.net/jfx17u/pull/32/files
Webrev:
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on
macOS.
-
Commit messages:
- 8278260: JavaFX shared libraries not stripped on Linux or macOS
Changes: https://git.openjdk.java.net/jfx17u/pull/31/files
Webrev:
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on
macOS.
-
Commit messages:
- 8277457: AccessControlException: access denied ("java.net.NetPermission"
"getCookieHandler")
Changes: https://git.openjdk.java.net/jfx17u/pull/30/files
Webrev:
On Fri, 11 Feb 2022 14:19:08 GMT, Kevin Rushforth wrote:
> Merge `jfx18` into `master`.
This pull request has now been integrated.
Changeset: 2561e313
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx/commit/2561e3137f955ba151a84ae49bed683b96280406
Stats: 325 li
Merge `jfx18` into `master`.
-
Commit messages:
- Merge jfx18
- 8271085: TabPane: Redundant API docs
- 8279345: Realign class docs of LightBase and subclasses
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
Changes:
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote:
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Thu, 10 Feb 2022 05:56:47 GMT, Hima Bindu Meda wrote:
>> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version
>> 3.32.3.
>>
>> Website : https://www.sqlite.org/index.html
>> Source code can be found from https://www.sqlite.org/download.html at
>>
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote:
> This seems like a bad merge issue.
> There were duplicate copies of four methods in `MacroAssemblerARM64.h` which
> caused WebKit build failure on Mac M1 machines.
> Just removing the methods removes the error.
> With the changes in
On Wed, 9 Feb 2022 04:40:49 GMT, Hima Bindu Meda wrote:
>> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version
>> 3.32.3.
>>
>> Website : https://www.sqlite.org/index.html
>> Source code can be found from https://www.sqlite.org/download.html at
>>
On Wed, 9 Feb 2022 13:06:58 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
> 738:
>
>>
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote:
>> Changelog for this MarlinFX 0.9.4.5 release:
>>
>> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path
>> clipper:
>> - improved Stroker to handle huge coordinates, up to 1E15
>> - improved PathClipFilter (filler)
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote:
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote:
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary
On Sat, 5 Feb 2022 15:15:26 GMT, Jay Bhaskar wrote:
>> 1. My point was that if you initially check for `m_localStorage` being
>> non-null, without the check for `isClosing` (see my earlier comment), then
>> you don't need to check it here.
>>
>> 2. Regarding the enabling of local storage in
On Sat, 5 Feb 2022 05:41:25 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2011, 2020, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Copyright should be a single year
On Sat, 5 Feb 2022 12:54:43 GMT, Jay Bhaskar wrote:
>> We must check if localstorage setting is disabled, then return nullptr
>> first.,as below
>> if (!page->settings().localStorageEnabled())
>> return nullptr;
>>
>> and there after the section
>> if (page->isClosing() &&
On Fri, 28 Jan 2022 00:09:11 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of attenuation and direction up to
On Fri, 4 Feb 2022 17:19:36 GMT, yosbits wrote:
> Why not use BitSet instead of ArrayList?
Can you be more specific? The only use of `ArrayList` that I see in the patch
is in code that uses a few already-existing lists. Changing that to some other
data structure would be an unrelated change
To: OpenJFX Developers
As a reminder, JavaFX 18 is now in Rampdown Phase Two (RDP2). [1]
P1-P2 bugs, and test or doc bugs of any priority, can be fixed during
RDP2. Explicit approval is needed for bug fixes (except for doc and test
fixes), and all enhancements to go in to the jfx18 branch.
On Thu, 3 Feb 2022 11:38:55 GMT, Jeanette Winzenburg
wrote:
> the issue was commented asserts in a test methods - they had been failing due
> to incorrect usage of registering an edit commit handler
>
> fix was to correct the registration and uncomment the assert (ListViewTest).
> For
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote:
>> Update JavaFX WebKit to GTK WebKit 2.34 (613.1).
>>
>> Verified the updated version build, tests run and sanity testing.
>> This does not cause any issues except a unit test failure
>> `IrresponsiveScriptTest`.
>> It is recorded and
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote:
> The change file contains changes that are not related to the WebKit upgrade.
Thanks for pointing this out! It looks like the patch was applied incorrectly.
@arapte please fix this.
-
PR: https://git.openjdk.java.net/jfx/pull/723
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote:
> Update JavaFX WebKit to GTK WebKit 2.34 (613.1).
>
> Verified the updated version build, tests run and sanity testing.
> This does not cause any issues except a unit test failure
> `IrresponsiveScriptTest`.
> It is recorded and ignored
Based on your description, it seems fine to combine them. To do this,
just closed one of the (probably 8187473) as a duplicate of the other,
and add any information from the closed bug into the other one,
adjusting the title of the bug if needed.
-- Kevin
On 1/31/2022 6:57 AM, Jeanette
On Thu, 27 Jan 2022 19:57:13 GMT, Nir Lisker wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of attenuation and direction up to
On Mon, 27 Dec 2021 09:31:08 GMT, Jay Bhaskar wrote:
> Issue: The current implementation of DOMWindow ::localStorage(..) returns
> null pointer in case of page is being closed.
> Fix: It should not return nullptr , as per the [w3c web storage
>
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote:
>> Changelog for this MarlinFX 0.9.4.5 release:
>>
>> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path
>> clipper:
>> - improved Stroker to handle huge coordinates, up to 1E15
>> - improved PathClipFilter (filler)
On Thu, 27 Jan 2022 17:28:15 GMT, Nir Lisker wrote:
>> Now that the standard concrete light types were added, there is an
>> opportunity to rearrange and rewrite some of the class docs. Here is a
>> summary of the changes:
>>
>> * Moved the explanations of attenuation and direction up to
On Thu, 27 Jan 2022 17:14:51 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/LightBase.java line 119:
>>
>>> 117: *The transparency (alpha) component of a light is ignored.
>>> 118: *
>>> 119: * There are no guarantee that these behaviors will not change.
>>
On Thu, 27 Jan 2022 15:45:44 GMT, Michael Strauß wrote:
>> What examples would you use?
>>
>> If a light in a room is strong it will barely cast shadows since its
>> reflections from all directions eliminate them.
>>
>> Maybe I should mention that Ambient light can be used with a dark color
On Wed, 26 Jan 2022 05:36:07 GMT, meghanEmbrace wrote:
>> With a touch-enabled device, the scrollbar disappears a short while after
>> it's used. During the layout, updateHbar() checks the hbar visibility and
>> resets the clip, causing the user to be scrolled fully to the left when
>> trying
On Wed, 26 Jan 2022 05:36:07 GMT, meghanEmbrace wrote:
>> With a touch-enabled device, the scrollbar disappears a short while after
>> it's used. During the layout, updateHbar() checks the hbar visibility and
>> resets the clip, causing the user to be scrolled fully to the left when
>> trying
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote:
> I have an AMD Radeon VII (vega20) series GPU which is identifying with a
> vendor string of "AMD".
>
> This is not present in the `X11GLFactory` list of `preQualificationFilter`
> vendor names, so my system (and probably any other vega20 based
On Mon, 20 Dec 2021 17:48:19 GMT, Paul wrote:
> I have an AMD Radeon VII (vega20) series GPU which is identifying with a
> vendor string of "AMD".
>
> This is not present in the `X11GLFactory` list of `preQualificationFilter`
> vendor names, so my system (and probably any other vega20 based
On Tue, 21 Dec 2021 08:09:08 GMT, Paul wrote:
> I thought it was one OCA for all things Oracle?
It is. There is a manual step to verify the connection between a user's GitHub
account and their OCA, but it ordinarily happens quickly. Given that we are
close to the holidays, there may be a
On Tue, 25 Jan 2022 01:19:11 GMT, Kevin Rushforth wrote:
> Bump release version in `jfx17u` repo to 17.0.3 for the start of a new
> release.
This pull request has now been integrated.
Changeset: d4973293
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/
201 - 300 of 4743 matches
Mail list logo
