Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-13 Thread Alexander Kouznetsov
Hi Steve, In general it looks good but I want to correct some parts of it. How should I proceed in this case? Best regards, Alexander Kouznetsov (408) 276-0387 On 3 янв 2014 21:44, Stephen F Northover wrote: Hi Alex, Samples were changed to support Android. Apparently, hitting escape

Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-13 Thread Alexander Kouznetsov
Hi Stefan, Thank you for this summary. As an android user I would say that #2 is not a good options for Ensemble. #3 is better than #1. However, it usually responds to the second key press only within a short period of time. About the time a notice message is shown. Best regards, Alexander

Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-13 Thread Stephen F Northover
What ever the decision on this, if there is further action, please enter a JIRA. If not, then the discussion is lost to ether. Steve On 2014-01-13 8:49 AM, Alexander Kouznetsov wrote: Hi Stefan, Thank you for this summary. As an android user I would say that #2 is not a good options for

Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-13 Thread Stephen F Northover
Fix it. You own the code. If you can test on an Android device, then great. Otherwise, get Stefan or Johan to test your changes. Steve On 2014-01-13 8:46 AM, Alexander Kouznetsov wrote: Hi Steve, In general it looks good but I want to correct some parts of it. How should I proceed in

Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-04 Thread tomas.branda...@oracle.com
Hi, back button is really tricky one. I don't think that for javafx apps it should map to how back button works in native android applications. On Android it moves to previous activity or exits (if the last activity has been reached) in webkit it goes one page back but this is not that

Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-03 Thread Stephen F Northover
Hi Alex, Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code. Anyhow, I'll let

Re: Post commit review: [Re: hg: openjfx/8u-dev/rt: RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android]

2014-01-03 Thread Stephen F Northover
If you feel that further work needs to be done here, please enter a JIRA and include this discussion. Thanks, Steve On 2014-01-03 2:43 PM, Stefan Fuchs wrote: Hi, well, the back button is always used to go back one dialog level, until the start screen has be reached. (Dialogs are canceled,