On Thu, 15 Apr 2021 12:55:56 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LambdaMultiplePropertyChangeListenerHandler.java
>> line 63:
>>
>>> 61: */
>>> 62: public final class LambdaMultiplePropertyChangeListenerHandler {
>>> 63: // FIXME:
On Wed, 24 Mar 2021 23:51:37 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
>
On Wed, 24 Mar 2021 23:30:03 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
>
On Mon, 29 Mar 2021 15:39:58 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java
>> line 268:
>>
>>> 266: *
>>> 267: * @param observable The observable for which all listeners should
>>> be removed.
>>> 268: * @return A
On Tue, 30 Mar 2021 13:31:36 GMT, Jeanette Winzenburg
wrote:
>>> hmm ... failing checks, why?
>>
>> The failure on Windows is because your branch isn't up-to-date with
>> `master`, and is missing a recent fix to the Window build. You can either
>> `git merge master` (after updating your
On Tue, 30 Mar 2021 12:43:41 GMT, Kevin Rushforth wrote:
>
> The failure on Windows is because your branch isn't up-to-date with `master`,
> and is missing a recent fix to the Window build. You can either `git merge
> master` (after updating your `master` branch from the upstream repo) or
>
On Tue, 30 Mar 2021 10:06:58 GMT, Jeanette Winzenburg
wrote:
> hmm ... failing checks, why?
The failure on Windows is because your branch isn't up-to-date with `master`,
and is missing a recent fix to the Window build. You can either `git merge
master` (after updating your `master` branch
On Thu, 25 Mar 2021 14:07:24 GMT, Jeanette Winzenburg
wrote:
>> I see. I recommend that they be improved in this PR. I don't know if this
>> will need to be part of the CSR, though.
>
> @nlisker and @Kevin so we agree, thanks :)
>
> my plan:
>
> - will work on the exact doc along the lines
On Mon, 29 Mar 2021 15:17:22 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java
>> line 250:
>>
>>> 248: *
>>> 249: * @param observable the observable to observe for invalidation
>>> events
>>> 250: * @param consumer the
On Wed, 24 Mar 2021 23:28:47 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
>
On Wed, 24 Mar 2021 23:39:13 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
>
On Wed, 24 Mar 2021 23:18:25 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
>
On Thu, 25 Mar 2021 13:52:20 GMT, Nir Lisker wrote:
>>>
>>>
>>> Can you list the other affected methods?
>>
>> at line 211 (in the changed skinBase)
>>
>> /**
>> * Subclasses can invoke this method to register that they want to
>> listen to
>> * property change events for the
On Thu, 25 Mar 2021 13:52:20 GMT, Nir Lisker wrote:
>>>
>>>
>>> Can you list the other affected methods?
>>
>> at line 211 (in the changed skinBase)
>>
>> /**
>> * Subclasses can invoke this method to register that they want to
>> listen to
>> * property change events for the
On Thu, 25 Mar 2021 13:29:44 GMT, Jeanette Winzenburg
wrote:
>> Can you list the other affected methods?
>
>>
>>
>> Can you list the other affected methods?
>
> at line 211 (in the changed skinBase)
>
> /**
> * Subclasses can invoke this method to register that they want to listen
>
On Thu, 25 Mar 2021 13:14:45 GMT, Nir Lisker wrote:
>
>
> Can you list the other affected methods?
at line 211 (in the changed skinBase)
/**
* Subclasses can invoke this method to register that they want to listen to
* property change events for the given property. Registered
On Thu, 25 Mar 2021 11:25:18 GMT, Jeanette Winzenburg
wrote:
>> I reviewed only the public API methods.
>
> @nlisker thanks for the detailed doc review - I really like your suggestions,
> which I think are considerable improvements (I did part of it in the
> respective methods of the handler)
On Wed, 24 Mar 2021 23:53:24 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> I reviewed only the public API methods.
@nlisker thanks
On Tue, 23 Feb 2021 12:06:08 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api
On Tue, 23 Mar 2021 15:18:06 GMT, Kevin Rushforth wrote:
>> wondering about the sequence of next steps: should I create the csr before
>> or after (partial) review of this? Doing before feels like expecting
>> duplicate work (whenever doc changes are required, I'll have to change the
>> code
On Tue, 23 Mar 2021 11:41:23 GMT, Jeanette Winzenburg
wrote:
>> Not yet reviewed. All of the new API methods need to have an `@since 17`
>> javadoc tag.
>
> wondering about the sequence of next steps: should I create the csr before or
> after (partial) review of this? Doing before feels like
On Mon, 22 Feb 2021 20:29:29 GMT, Kevin Rushforth wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> Not yet reviewed. All of the new API methods need to
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from
23 matches
Mail list logo
