On Fri, 12 Mar 2021 14:18:59 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXLaunchTest.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Minor year
On Fri, 12 Mar 2021 14:27:44 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java
>> line 96:
>>
>>> 94: } catch (Exception e) {
>>> 95: throw e;
>>> 96: }
>>
>> line 91: is non reachable code and
On Wed, 10 Mar 2021 23:02:07 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
On Fri, 12 Mar 2021 14:31:17 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java
>> line 80:
>>
>>> 78: System.out.println("Finished launch!");
>>> 79: Assert.fail("Error: No Exception was thrown
On Fri, 12 Mar 2021 11:52:24 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
> Suggested minor changes.
I've seperated the
On Fri, 12 Mar 2021 14:49:41 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with two additional
commits since the last revision:
- JDK-8263322
Small changes based on codereview
- JDK-8263322
Some small cleanups
On Fri, 12 Mar 2021 09:01:49 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
On Wed, 10 Mar 2021 23:10:06 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8263322
Seperated the unit-tests into seperate files
-
Changes:
-
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8263322
fixed the copyright headers, based on codereview
-
Changes:
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:40:26 GMT, Kevin Rushforth wrote:
>> I've now added the new Exception to the JavaDoc of the Application.
>
> The API spec changes look good. You can add that to the Specification section
> of the CSR. You can either paste the diffs for the javadoc comments, or else
>
On Wed, 10 Mar 2021 22:32:26 GMT, Florian Kirmaier
wrote:
>> Regarding the CSR, it is only concerned with the public API, including the
>> specification (javadoc-generated API documentation), and any behavioral
>> changes.
>>
>> You can leave the CSR in the Draft state until there is
On Wed, 10 Mar 2021 22:10:04 GMT, Kevin Rushforth wrote:
>>> About the CSR:
>>> This commit actually restores original behavior, when JavaFX was called
>>> with Application.launch, so it's not really a change in the API, it's more
>>> like a fix for a regression.
>>
>> Not quite. See my
On Wed, 10 Mar 2021 22:03:52 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>removed unused imports, added missing change
>> - JDK-8263322
>>Updated the
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8263322
updated the javadoc to mention the new case.
-
Changes:
-
On Wed, 10 Mar 2021 17:30:21 GMT, Kevin Rushforth wrote:
>> About the CSR:
>> This commit actually restores original behavior, when JavaFX was called with
>> Application.launch, so it's not really a change in the API, it's more like a
>> fix for a regression.
>> How would I create a CSR? Just
On Wed, 10 Mar 2021 21:54:32 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - JDK-8263322
>
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with three
additional commits since the last revision:
- JDK-8263322
removed unused imports, added missing change
- JDK-8263322
Updated
On Wed, 10 Mar 2021 16:42:41 GMT, Florian Kirmaier
wrote:
> About the CSR:
> This commit actually restores original behavior, when JavaFX was called with
> Application.launch, so it's not really a change in the API, it's more like a
> fix for a regression.
Not quite. See my reply above.
>
On Wed, 10 Mar 2021 17:24:47 GMT, Kevin Rushforth wrote:
>> `Initalize the FX runtime via Platform.startup and then launch an
>> Application on another thread (should succeed)`
>> I don't think that should succeed. I would expect it to throw an exception.
>> If that would be the case, then
On Wed, 10 Mar 2021 17:00:41 GMT, Florian Kirmaier
wrote:
> Initalize the FX runtime via Platform.startup and then launch an Application
> on another thread (should succeed)
I don't think that should succeed. I would expect it to throw an exception. If
that would be the case, then both
On Wed, 10 Mar 2021 15:29:37 GMT, Florian Kirmaier
wrote:
> Contribution.MD states, that it's automatically checked for whitespace
> errors? Is this not true?
Yes, Skara's jcheck does basic sanity checking (tabs, trailing white space,
line endings). Why do you ask? I didn't raise this as a
On Wed, 10 Mar 2021 16:01:42 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
>> 65:
>>
>>> 63: } catch (Exception e) {
>>> 64: System.out.println("got exception: " + e);
>>> 65:
On Wed, 10 Mar 2021 16:42:41 GMT, Florian Kirmaier
wrote:
>> I forgot to commit a part of the fix, which is why the second test hang.
>> It's now part of the PR.
>
> About the CSR:
> This commit actually restores original behavior, when JavaFX was called with
> Application.launch, so it's not
On Wed, 10 Mar 2021 16:23:53 GMT, Florian Kirmaier
wrote:
>> Contribution.MD states, that it's automatically checked for whitespace
>> errors? Is this not true?
>>
>> As a clarification, this PR restores the previous behavior before
>> Platform.startup. With this PR Application.launch and
On Wed, 10 Mar 2021 13:15:43 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>Added missing change
>> - JDK-8263322
>>Small changes based on code review
>> -
On Wed, 10 Mar 2021 15:29:37 GMT, Florian Kirmaier
wrote:
>>> * Initalize the FX runtime via Platform.startup and then launch an
>>> Application on another thread (should throw ISE)
>>
>> That should be:
>>
>> * Initalize the FX runtime via Platform.startup and then launch an
>> Application
On Wed, 10 Mar 2021 13:50:02 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - JDK-8263322
>>Added missing change
>> - JDK-8263322
>>Small changes based on code review
>> -
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with three
additional commits since the last revision:
- JDK-8263322
Added missing change
- JDK-8263322
Small changes based on code
On Wed, 10 Mar 2021 13:19:03 GMT, Kevin Rushforth wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
> 65:
>
>> 63: } catch (Exception e) {
>> 64:
On Wed, 10 Mar 2021 13:14:15 GMT, Kevin Rushforth wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> tests/system/src/test/java/test/javafx/scene/InitializeJavaFXTest.java line
> 24:
>
>> 22: }
>> 23:
>> 24: public static void
On Wed, 10 Mar 2021 14:17:57 GMT, Kevin Rushforth wrote:
>> The idea behind the fix is good. A few changes are needed:
>>
>> 1. The check should be split into two separate `if` statements, each with
>> their own error message (see inline).
>>
>> 2. This should be documented in the API docs
On Wed, 10 Mar 2021 13:54:14 GMT, Kevin Rushforth wrote:
> * Initalize the FX runtime via Platform.startup and then launch an
> Application on another thread (should throw ISE)
That should be:
* Initalize the FX runtime via Platform.startup and then launch an Application
on the FX
On Tue, 9 Mar 2021 21:49:36 GMT, Florian Kirmaier wrote:
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
The idea behind the fix is good. A few changes are needed:
1. The check should be split into two separate `if` statements, each with their
own
Fixing deadlock when calling Application.launch in the FXThread after
Platform.startup
-
Commit messages:
- JDK-8263322
Changes: https://git.openjdk.java.net/jfx/pull/421/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=421=00
Issue:
39 matches
Mail list logo
