On Fri, 12 Mar 2021 14:18:59 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXLaunchTest.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Minor year
On Fri, 12 Mar 2021 14:27:44 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java
>> line 96:
>>
>>> 94: } catch (Exception e) {
>>> 95: throw e;
>>> 96: }
>>
>> line 91: is non reachable code and
On Wed, 10 Mar 2021 23:02:07 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
On Fri, 12 Mar 2021 14:31:17 GMT, Florian Kirmaier
wrote:
>> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java
>> line 80:
>>
>>> 78: System.out.println("Finished launch!");
>>> 79: Assert.fail("Error: No Exception was thrown
On Fri, 12 Mar 2021 11:52:24 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
> Suggested minor changes.
I've seperated the
On Fri, 12 Mar 2021 09:01:49 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
On Wed, 10 Mar 2021 23:10:06 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
>
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:35:31 GMT, Florian Kirmaier
wrote:
>> Fixing deadlock when calling Application.launch in the FXThread after
>> Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> JDK-8263322
>
On Wed, 10 Mar 2021 22:40:26 GMT, Kevin Rushforth wrote:
>> I've now added the new Exception to the JavaDoc of the Application.
>
> The API spec changes look good. You can add that to the Specification section
> of the CSR. You can either paste the diffs for the javadoc comments, or else
>
On Wed, 10 Mar 2021 22:32:26 GMT, Florian Kirmaier
wrote:
>> Regarding the CSR, it is only concerned with the public API, including the
>> specification (javadoc-generated API documentation), and any behavioral
>> changes.
>>
>> You can leave the CSR in the Draft state until there is
On Wed, 10 Mar 2021 22:10:04 GMT, Kevin Rushforth wrote:
>>> About the CSR:
>>> This commit actually restores original behavior, when JavaFX was called
>>> with Application.launch, so it's not really a change in the API, it's more
>>> like a fix for a regression.
>>
>> Not quite. See my
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8263322
updated the javadoc to mention the new case.
-
Changes:
-
14 matches
Mail list logo
