Re: Repositories, AdoptOpenJDK and github

In my view, the difference between accepting a PR into GitHub versus into OpenJFX is probably mainly time-based. When there is an agreement about a PR, it can be merged in GitHub, but there are more steps required (webrev) before it can formally be pushed into OpenJFX, so the reviewer may choose

Re: Repositories, AdoptOpenJDK and github

In my opinion we need a bot that does a few things to automate the GitHub to OpenJFX contribution workflow. One of those things is we can, upon getting a new pull request from someone we haven't seen before, go over the OCA list and see if a username matches their Github username. If it does, the

Re: Repositories, AdoptOpenJDK and github

Am 03.03.18 um 19:35 schrieb Nir Lisker: I'm still not sure about all the steps. In order to submit a PR I need GitHub permissions? Can you know if I signed the OCA? There is a publicly available list of people which have signed the OCA here:

Re: Repositories, AdoptOpenJDK and github

> > Accepting a PR in github does not require the *formal* process of creating > webrevs etc, but it requires discussion about the issue with reviewers of > OpenJFX. Doesn't that mean that accepting a fix into GitHub is equivalent to accepting it into OpenJFX? In that case there shouldn't be any

Re: Repositories, AdoptOpenJDK and github

I agree with this approach. Having a small number of JBS bugs that are low hanging fruit will be good to see how the flow works. Eugene created an easy one: https://bugs.openjdk.java.net/browse/JDK-8198795 - Johan On Wed, Feb 28, 2018 at 9:52 AM Laurent Bourgès wrote:

Re: Repositories, AdoptOpenJDK and github

Johan, I am following the long discussion and I mostly agree what was said. Maybe it is time to start working on github on few minor / trivial bugs... to test all the new process. I propose to extract few JBS bugs (small) with high ROI (agile /scrum approach) and create shadow copies into github

Re: Repositories, AdoptOpenJDK and github

That is the difficult point indeed. But why would a PR to OpenJFX be rejected after it was approved in the github mirror? I would assume the main reason for this is because the PR did not what it was supposed to do. In that case, it makes sense to remove the commits from the github mirror as well.

Re: Repositories, AdoptOpenJDK and github

Nir Lisker wrote: Johan's thinking was to allow Committers to approve the PR on GitHub -- meaning they could be merged on GitHub before an actual Review has happened. Are you proposing to change that? What if the PR is rejected at review? We'll end up with conflicts between the

Re: Repositories, AdoptOpenJDK and github

> > Johan's thinking was to allow Committers to approve the PR on GitHub -- > meaning they could be merged on GitHub before an actual Review has > happened. Are you proposing to change that? What if the PR is rejected at review? We'll end up with conflicts between the repos. And supposed someone

Re: Repositories, AdoptOpenJDK and github

This seems a good start in formalizing the process. It will need a little tweaking in a couple of areas. Regarding JBS access, even though I want to relax the requirement to become an Author (get a JBS account), it will likely end up somewhere between "an intention to contribute" and "two

Re: Repositories, AdoptOpenJDK and github

Iv'e given the pipeline some thought. I'm purposely ignoring current role names (Author, Contributor...). My suggestions: Potential contributor wants to contribute... 1. Formal process a. If the issue is not in the JBS, they submit it via bugreport. b. They send an email on the mailing list

Re: Repositories, AdoptOpenJDK and github

Johan Vos wrote: On Thu, Feb 15, 2018 at 4:09 AM Kevin Rushforth > wrote: A global reference in JBS would indeed be very good to track back the work in a PR to a real issue. It can also be very useful as there are many

Re: Repositories, AdoptOpenJDK and github

On Thu, Feb 15, 2018 at 4:09 AM Kevin Rushforth wrote: > > As I said before, we need to be careful where the discussion is made. PRs > on GitHub have their own thread and there's also the mailing list. Maybe > someone from Oracle already has done work related to the

Re: Repositories, AdoptOpenJDK and github

As I said before, we need to be careful where the discussion is made. PRs on GitHub have their own thread and there's also the mailing list. Maybe someone from Oracle already has done work related to the PR, and this will only be known if a JBS issue is submitted or a mailing list thread is

Re: Repositories, AdoptOpenJDK and github

As far as the bug goes, I think it would be better to do it the other way around. If we adopt a policy that a PR should reference a bug in JBS, then that part of the problem will go away. I'm not convinced that merging a random PR, for what is essentially just "a good idea" if it isn't backed

Re: Repositories, AdoptOpenJDK and github

Having a bot that creates a webrev, verifies OCA is signed for the commit author, and a generates a JBS/java bug report template would be ideal IMO. We can use something like AWS Lambda that runs every X minutes and checks for PRs to the openjdk-jfx GitHub repository. If a new PR is seen, or a PR

Re: Repositories, AdoptOpenJDK and github

Thank you! My concerns (not complaints) and questions: 1. Developer forks the github repo, enhances it, and creates a PR. 2. He discusses it with a committer, and eventually the PR is accepted. As I said before, we need to be careful where the discussion is made. PRs on GitHub have their own

Re: Repositories, AdoptOpenJDK and github

Hi Michael, That is great! Using Travis CI will clearly help keeping the project in a good shape. I added a comment, and I hope others with more experience with Travis than me will jump in. Thanks, - Johan On Wed, Feb 14, 2018 at 9:21 PM Michael Ennen wrote: > Thanks

Re: Repositories, AdoptOpenJDK and github

Thanks for taking the initiative, Johan. I have opened two PRs that add support for Travis CI and Appveyor continuous integration (which can be used to build pull requests and the master branch after a merge (or using a cron-timer) automatically). This will allow sandboxers to test their code on

Re: Repositories, AdoptOpenJDK and github

Johan, Thank‘s so much for all the effort you‘ve put into OpenJFX...it is highly appreciated  Keep up the great work, Cheers, Gerrit Gerrit Grunwald Westfalenstr. 93 48165 Münster Germany tel: +49 (0)2501 24321 mob: +49 (0)171 1745350 web: http://www.harmonic-code.org Am 14. Feb. 2018,

Re: Repositories, AdoptOpenJDK and github

Nice! Thanks for your hard work on this, Johan. -- Kevin Johan Vos wrote: Hi, I did 2 things: * I talked to the fine and great people at AdoptOpenJDK ( https://adoptopenjdk.net/) and they are happy to have their build farm being used to create OpenJFX modules (including the native

Repositories, AdoptOpenJDK and github

Hi, I did 2 things: * I talked to the fine and great people at AdoptOpenJDK ( https://adoptopenjdk.net/) and they are happy to have their build farm being used to create OpenJFX modules (including the native libraries). We are currently looking at the scripts that are being used for syncing and