[9] Review request: JDK-8168306 Iconswap program used by the packager is flagged as malware by Windows Defender

Kevin, Victor, Please review this change to do away with the tools iconswap.exe and versioninfoswap.exe by folding them into javapackager.exe to avoid the problems of these being copied as a resource out of the Java Packager into executing from the temporary directory. JIRA: https

Re: [9] Review request: JDK-8170979: Update for Jigsaw etc. the openFX functional tests

A gentle reminder. Without this change, we have to make All Test Run out of the makeshift workspace. Thanks, -yan On 12/09/2016 02:02 PM, Yuri Nesterenko wrote: Colleagues, please review this test bug fix: http://cr.openjdk.java.net/~yan/8170979/webrev.00/ Bug: https://bugs.openjdk.java.net

[webkit] [9] Review request for 8132675: VBox.setVgrow and HBox.setHgrow corrupt following controls when window resized

Hello Kevin, Guru, Murali, Please review the fix for JDK-8132675 <https://bugs.openjdk.java.net/browse/JDK-8132675>. http://cr.openjdk.java.net/~arajkumar/8132675/webrev <http://cr.openjdk.java.net/~arajkumar/8132675/webrev> Thanks,

[9] Review request for JDK-8171513: Fix typo in API doc for AnimationTimer

JBS: https://bugs.openjdk.java.net/browse/JDK-8171513 The fix is small so the patch is included inline below... ...jim --- diff -r 2bae8f04958b modules/javafx.graphics/src/main/java/javafx/animation/AnimationTimer.java ---

[webkit] [9] Review request for 8168887: [WebView] ComboBox and DropDownList - Render fragments of the scrollbar are visible

Hello Kevin, Guru, Murali, Please review the fix for JDK-8168887 <https://bugs.openjdk.java.net/browse/JDK-8168887>. http://cr.openjdk.java.net/~arajkumar/8168887/webrev <http://cr.openjdk.java.net/~arajkumar/8168887/webrev> Thanks, Arun

[9] Review request for JDK-8146920: [hidpi] Multi-Monitor issue with HiDpi scaling and undecorated stages

JBS: https://bugs.openjdk.java.net/browse/JDK-8146920 webrev: http://cr.openjdk.java.net/~flar/JDK-8146920/webrev.03/ Details are in the JBS comments. I'm tagging Kevin here on the review, but any engineers with more than a passing familiarity with Glass should review the changes

[9] URGENT Review request: 8171450: JavaFX native libraries are no longer loaded after fix for JDK-8066474

Dave H, Please review this urgent request for P1 bug: https://bugs.openjdk.java.net/browse/JDK-8171450 http://cr.openjdk.java.net/~kcr/8171450/webrev.00/ The fix is as we discussed. -- Kevin

[9] Review request: JDK-8157913: Launcher can not find path to libpackager.so

Chris, Please review the changes about getting path to libpackager.so JIRA: https://bugs.openjdk.java.net/browse/JDK-8157913 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8157913/webrev.00/ --Victor

review: Failure to fallback to sw pipeline with remote connections

Now that cr is back online a small fix to error detection, enabling fallback. jbs: https://bugs.openjdk.java.net/browse/JDK-8171403 webrev: http://cr.openjdk.java.net/~ddhill/8171403/ -- David Hill Java Embedded Development "A man's feet should be planted in his

[9] Review request for 8171393: Integrate precision fixes for Marlin

Laurent sent these webrevs to Kevin and I earlier to evaluate for JDK9. We're testing them and planning to integrate them so I thought I should send out the official review request, though it is really Laurent's work and he'll be the eventual author listed on the changeset: JBS: https

[9] Review request for 8171330: Issues with transparent stage and GTK

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8171330 webrev: http://cr.openjdk.java.net/~ssadetsky/8171330/webrev.00/ By the logic of scene painting the compositing method should be "source over destination" in both cases

[9] Review request: JDK-8171352 javapackager throws "Exception: jdk.tools.jlink.plugin.PluginException: java.lang.IllegalArgumentException: No modules to add" when bundled with NormalJar

Kevin, Please review this minor change to build.gradle as a follow on to JDK-8170198. The location of the redistributable.list was incorrect and my testing didn’t catch it. JIRA: https://bugs.openjdk.java.net/browse/JDK-8171352 <https://bugs.openjdk.java.net/browse/JDK-8171352> Webrev

[9] Review request: JDK-8170134: Linux Ant Swing Test Fails

Chris, Please review the changes about Linux Ant Swing Test. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170134 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8170134/webrev.00/ --Victor

review: update compareBuilds script

Kevin, an update to a utility script that compares build outputs jbs: https://bugs.openjdk.java.net/browse/JDK-8171326 webrev: http://cr.openjdk.java.net/~ddhill/8171326.1 -- David Hill Java Embedded Development "A

[9] Code Review Request For 8170500: Interminate ProgressIndicator no longer animates if scene is set on stage before content is added

Hi Jonathan, Please review the proposed fix and investigation in the JIRA. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170500 Thanks, - Chien

[9] Review request: JDK-8170198 Static Redistributable Module List

Kevin, Please review this change to no longer generate the Java Packager’s redistributable module list instead use a static list since the programmatically generated list uses the boot JDK’s list of modules and that can vary between builds. JIRA: https://bugs.openjdk.java.net/browse/JDK

[9] Review request for 8166147: Ubuntu 16.04: expandable content goes outside of the alert dialog

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8166147 webrev: http://cr.openjdk.java.net/~ssadetsky/8166147/webrev.00/ XLib size requests and hints was mixed up with GTK ones. --Semyon

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

main reasons for the deprecation are: >>>> >>>> 1. Self signed jars are blocked and sign as blob is a self signed jars. >>>> >>>> 2. There will be a replacement for modules that will be better. >>>> >>>> Chris >>>&g

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

natives? How do I sign a webstart application? Stefan David, Please review these changes to deprecate the blob signing from the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8169443 <https://bugs.openjdk.java.net/browse/JDK-8169443> Webrev: http://cr.openjdk.java.net/~c

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

be better. >> >> Chris >> >> >>> On Dec 12, 2016, at 11:56 PM, Stefan Fuchs <snfu...@gmx.de> wrote: >>> >>> Hi, >>> >>> so blog signing as deprecated. >>> >>> What are the reasons for deprecating blo

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

I sign a webstart application? Stefan David, Please review these changes to deprecate the blob signing from the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8169443 <https://bugs.openjdk.java.net/browse/JDK-8169443> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-81694

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

:56 PM, Stefan Fuchs <snfu...@gmx.de> wrote: > > Hi, > > so blog signing as deprecated. > > What are the reasons for deprecating blog signing? Are there alternatives? > How do I sign a webstart application? > > Stefan > >> David, >> >>

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

Hi, so blog signing as deprecated. What are the reasons for deprecating blog signing? Are there alternatives? How do I sign a webstart application? Stefan David, Please review these changes to deprecate the blob signing from the Java Packager. JIRA: https://bugs.openjdk.java.net/browse

[9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

David, Please review these changes to deprecate the blob signing from the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8169443 <https://bugs.openjdk.java.net/browse/JDK-8169443> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8169443/webrev.00/ <http://cr.openjdk

[9] Review request: JDK-8167388: value for key "LSApplicationCategoryType" is not set in Info.plist when trying to set through javapackager -BapplicationCategory=""

Chris, Please review the changes about ApplicationCategory (Info.plist) JIRA: https://bugs.openjdk.java.net/browse/JDK-8167388 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8167388/webrev.00/ --Victor

[9] Review request: JDK-8170851: Secondary Launchers picks wrong main class from module

Chris, Please review the changes about picking wrong main class from module. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170851 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8170851/webrev.00/ --Victor

[9] Review request for 8170938: Memory leak in JavaFX WebView

  Hi Kevin, Arun, Guru Please review the simple fix for JDK-8170938. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170938 Webrev: http://cr.openjdk.java.net/~mbilla/8170938/webrev.00/   Thanks, Murali

Re: [9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

...jim On 12/9/16 8:46 AM, Laurent Bourgès wrote: Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170030 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170030.0/ PS: I will provide asap a Marlin2D patch incorporating c

[9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170030 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170030.0/ PS: I will provide asap a Marlin2D patch incorporating changes made in MarlinFX (including this one) Cheers, Laurent

[9] Review request for 8166414: Scene returns incorrect coordinates

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8166414 webrev: http://cr.openjdk.java.net/~ssadetsky/8166414/webrev.00/ According to GTK iib documentation on X11 WMs the gtk_window_get_position() function doesn't return the exact wi

[9] Review request: JDK-8170979: Update for Jigsaw etc. the openFX functional tests

Colleagues, please review this test bug fix: http://cr.openjdk.java.net/~yan/8170979/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8170979 The changes are mostly in tests/functional/. This is a merge of current testbase in http://hg.openjdk.java.net/openjfx/9-dev/tests and whatever

[9] Review request: JDK-8170883 Add Class Path to Examples

Kevin, Victor, Please review changes to the Java Packager examples and a new example mixing modular jars and non modular jars. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170883 <https://bugs.openjdk.java.net/browse/JDK-8170883> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8

[9] Review request: JDK-8168407 javapackager throws "java.lang.ClassNotFoundException: testapp.util.Util" when bundle is built through ANT for unnamed module depending on named module scenario

Kevin, Please review this change to allow a non modular jar main app to use and bundle modular jars into the runtime image. JIRA: https://bugs.openjdk.java.net/browse/JDK-8168407 <https://bugs.openjdk.java.net/browse/JDK-8168407> Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8168407/

[9] Review request for 8170930: WebView unit test crashes in 32-bit mode

  Hi Kevin, Please review the backout fix for JDK-8164792. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170930 Webrev: http://cr.openjdk.java.net/~mbilla/8170930/webrev.00/   Thanks, Murali

[9] Review request: JDK-8170879 Fix Quad / Cubic BND constants for Marlin (FX)

Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170879 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170879.0/ As mentioned in JBS, I studied both quality & performance and MarlinFX is now slightly better than openpisces (1.6 vs

Re: [9,8u] Review request: JDK-8088857 Menu slow to respond after resizing a window multiple times with animation running

The fix applied cleanly to 8u-dev and fixed the same pair of bugs so this is now also a backport request. 8u-specific webrev: http://cr.openjdk.java.net/~flar/JDK-8088857/webrev.8u.rt.00/ ...jim On 12/7/16 8:06 AM, Jim Graham wrote: JBS:

[9] Review request: JDK-8088857 Menu slow to respond after resizing a window multiple times with animation running

JBS: https://bugs.openjdk.java.net/browse/JDK-8088857 webrev: http://cr.openjdk.java.net/~flar/JDK-8088857/webrev.rt.00/ Fix is as we discussed. I'll investigate applying it to 8u-dev soon... ...jim

Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

> On Dec 6, 2016, at 8:10 AM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > Chien & Dave, > > Please review the preliminary webrev to allow building JavaFX with jdk-9+148 > and later: > > https://bugs.openjdk.java.net/browse/JDK-8170485 >

Re: [9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

On 06/12/2016 16:10, Kevin Rushforth wrote: Chien & Dave, Please review the preliminary webrev to allow building JavaFX with jdk-9+148 and later: https://bugs.openjdk.java.net/browse/JDK-8170485 http://cr.openjdk.java.net/~kcr/8170485/webrev.00/ The updates to the module-info.

[9] Review request: JDK-8170485: Switch to building JavaFX with new module-info syntax

Chien & Dave, Please review the preliminary webrev to allow building JavaFX with jdk-9+148 and later: https://bugs.openjdk.java.net/browse/JDK-8170485 http://cr.openjdk.java.net/~kcr/8170485/webrev.00/ The details are in the JBS issue and also in the "HEADS-UP" message [1] I

[9] Review request: JDK-8165794: javapackager throws "No application jars found" when "-srcfiles" is omitted in CLI

Chris, Please review the changes about "No application jars found" exception. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165794 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165794/webrev.00/ --Victor

[9] Review request: JDK-8170609: Show Error When Mac AppStore Certificate Expired

Victor, Please review the changes to show an error when the MacApp Store certificate has expired. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170609 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170609/webrev.00/ Chris

[9] Review request: JDK-8088064: Enhance Launcher to Support Long File Names

Chris, Please review the changes about enhancing support of long file names. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088064 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8088064/webrev.00/ --Victor

JDK-8169649 Review request

Hello, everyone. Please have a look at my review request for new small test: Jira issue: https://bugs.openjdk.java.net/browse/JDK-8169649 Webrev: http://cr.openjdk.java.net/~arusakov/8169649/webrev.00/ Thanks in advance.

[9] Review request for 8151170: WINDOW_MODAL dialog does not popup when restoring iconified owner window, which causes application freeze

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8151170 webrev: http://cr.openjdk.java.net/~ssadetsky/8151170/webrev.00/ Win32 API ::GetWindowRect() call returns fake -32000,-32000 location for iconified window. Solution: skip WM_

[webkit] [9] Review request for 8170450: Crash while loading wordpress.com in HiDPI / Retina display

Hello Kevin, Guru, Murali, Please review the fix for JDK-8170450 <https://bugs.openjdk.java.net/browse/JDK-8170450>. Analysis: While applying a filter, WebCore get's ImageData from ImageDataJava using getPremultipliedImageData method. Our current implementation doesn't con

[9] Code Review Request For 8170421: Ensemble8 black flash at startup on b145+

Jim or Kevin, Please review this simple fix posted in the JIRA: https://bugs.openjdk.java.net/browse/JDK-8170421 Thanks, - Chien

[9] Review request: JDK-8170295 fx:jvmarg is not set

Victor, Please review this change to fix setting of jvmarg options: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170295 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170295/webrev.00/ Chris

[9] Review request: JDK-8170122 Packager Tests

Victor, Please review these Java Packager examples: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.01/ Chris

[9] Review request: JDK-8166281: -Bidentifier="" not working for modules in MAC

Chris, Please review the changes about fixing the -Bidentifier for backward compatibility: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166281 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8166281/webrev.00/ --Victor

[9] Review request: JDK-8168089, Secondary Launchers (*.exe files) are not generated

Chris, Please review the changes about secondary launchers: JIRA: https://bugs.openjdk.java.net/browse/JDK-8168089 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168089/webrev.00/ --Victor

[9] Review request for 8164792: Memory leak in JavaFX WebView

  Hi Kevin, Arun, Guru, Please review the below leak fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164792 Webrev: http://cr.openjdk.java.net/~mbilla/8164792/webrev.00/   Thanks, Murali

Review request for JDK-8170140: rendering anomaly with MarlinFX renderer

Jim & Kevin, Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170140.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8170140 Ths bug fix seems very simple in MaskMarlinAlphaConsumer: +// ensure last block flag = 0 to process final b

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

classpath and may be potentially loaded in future with another GTK version (which will cause the process crash). The rest scenarios are covered by the 8156491 fix which I just posted for review. --Semyon Tom On 22.11.16 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

n instance of FXCanvas SWT must have been loaded already (You need to pass a parent Composite) so the native gtk-libs are there already loaded. Tom On 22.11.16 14:51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/brow

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

low really correct? >> >> in JFX embeded into SWT scenarios JFX loads GTK primarily ... >> >> If you create an instance of FXCanvas SWT must have been loaded already >> (You need to pass a parent Composite) so the native gtk-libs are there >> already loaded.

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

) so the native gtk-libs are there >> already loaded. > That's right concern. Actually the fix covers the scenario when swt.jar > is on the classpath and may be potentially loaded in future with another > GTK version (which will cause the process crash). The rest scenarios are > covered b

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

51, Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

at's right concern. Actually the fix covers the scenario when swt.jar is on the classpath and may be potentially loaded in future with another GTK version (which will cause the process crash). The rest scenarios are covered by the 8156491 fix which I just posted for review. --Semyon Tom On 22.1

[9] Review request for 8156491: Autodetect GTK version for JFX

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8156491 webrev: http://cr.openjdk.java.net/~ssadetsky/8156491/webrev.00/ The fix implements the autodetect feature which protects JFX Glass toolkit from the crash caused by loading dynamic

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

scenarios JFX loads GTK primarily ... If you create an instance of FXCanvas SWT must have been loaded already (You need to pass a parent Composite) so the native gtk-libs are there already loaded. Tom On 22.11.16 14:51, Semyon Sadetsky wrote: > Hello Kevin & David, > > Please review

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

16 г. 15:51 ч., Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot b

Re: [9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Hi, I think this line is incorrect: if (ver < 2 && ver > 3) { It should be || instead of && On 22.11.2016 г. 15:51 ч., Semyon Sadetsky wrote: Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev:

[9] Review request: 8170122: Packager Tests

Kevin, Adding Java Packager examples/tests. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.00/ Chris

[9] Review request for 8150175: Need replacement in FXDnD for DropTargetContext::addNotify, removeNotify

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8150175/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8150175 -- Thanks, Alexander.

[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Hello Kevin & David, Please review the fix for jfx9: bug: https://bugs.openjdk.java.net/browse/JDK-8157002 webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/ In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK version cannot be detected using the c

Re: initial webrev for review

On 11/21/16, 2:37 PM, David Hill wrote: updated: http://cr.openjdk.java.net/~ddhill/8163496.1 This fixed the popup issue I was seeing. Kevin, Chien, Semyon, Here is the initial webrev for reworking libglass addressing GTK issues. I am calling it inital because I have not finished the large

initial webrev for review

Kevin, Chien, Semyon, Here is the initial webrev for reworking libglass addressing GTK issues. I am calling it inital because I have not finished the large amount of testing it needs, plus I may need to rework a small number of entry points (6) to make them dynamic. I am asking my reviewers

[Review request] 8169642: IndexOutOfBoundsException when sorting TreeTableView with multi-selection enabled

Vadim, Please review the following issue: https://bugs.openjdk.java.net/browse/JDK-8169642 http://cr.openjdk.java.net/~jgiles/8169642/ Thanks! -- -- Jonathan

[9] Review request: JDK-8168501 javapackager system wide installation is failed when bundled through ANT in windows operating system

Chris, Please review the changes about system wide installation (bundled through ANT). JIRA: https://bugs.openjdk.java.net/browse/JDK-8168501 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8168501/webrev.00/ <http://cr.openjdk.java.net/%7Evdrozdov/JDK-8168501/webrev.00/> --Victor

[9] Review request: 8169396: Include sources for javafx.* modules in src.zip

corrected the subject line Kevin Rushforth wrote: Please review the following change to include the sources for javafx.* modules into the JDK 9 src.zip. https://bugs.openjdk.java.net/browse/JDK-8169396 http://cr.openjdk.java.net/~kcr/8169396/webrev.00/ -- Kevin

[9] Code Review Request For 8166932: Fix @Deprecated annotations for deprecated JavaFX methods

Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166932 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166932/webrev.00/ Thanks, - Chien

review: javac @compile.args does not pick up changes in local build

Kevin: https://bugs.openjdk.java.net/browse/JDK-8169747 http://cr.openjdk.java.net/~ddhill/8169747 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

[9] Review request: JDK-8167508 ant-javafx.jar and jdk.packager runtime version check

Kevin, Please review this change to have ant-javafx.jar check the version of Java that is running it and match the version it was intended to run with by comparing against a version string that is stored in the jar file. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167508 Webrev: http

[9] Review request: 8169683: Incremental build of WebKit native library is broken

Dave, Please review: https://bugs.openjdk.java.net/browse/JDK-8169683 The patch is in JBS. It is a simple one-line change to restore the behavior for native WebKit builds prior to the recent build changes to build with a Jigsaw-aware javac. -- Kevin

Re: [9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Correct links: JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ <http://cr.openjdk.java.net/%7Evdrozdov/JDK-8162693/webrev.00/> --Victor Chris, Please review the changes about WinAppBundler. JIRA:

[9] Review request: JDK-8162693 javapackager returns null if com.oracle.tools.packager.windows.WinAppBundler called twice

Chris, Please review the changes about WinAppBundler. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162693 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162693/webrev.00/ --Victor

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

background color for it. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net

Re: [9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/01/ Thanks, Alexander. On 8/4/16 3:40 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00 for the issue https://bugs.openjdk.java.net/browse/JDK

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

n.y...@oracle.com>: Hi Jim and Kevin, Please review the proposed fix: JIRA:https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev:http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

[9] Review request: JDK-8165522 Remove #ifndef USE_JLI_LAUNCH from native launcher

Chris, Please review the changes about removing native packager JNI code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165522 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8165522/webrev.00/ --Victor

[9] Review request: JDK-8162923 Error: Unknown Argument thrown by javpackager when argument values are passed with multiple words with in quotation

Chris, Please review the changes about argument quotation for javapackager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162923 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8162923/webrev.00/ --Victor

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang wrote: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang

Review request for JDK-8169270: Leverage new Java2D Marlin rasterizer for JavaFX

Jim & Kevin, Sorry to announce this code review in late, I thought JBS would have sent such email from the comment. Please review the marlin-FX webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8169270.0/ JBS: https://bugs.openjdk.java.net/browse/JDK-8169270 Reviewers: flar,

review: fix old jar list in build.gradle

Kevin, would you review: https://bugs.openjdk.java.net/browse/JDK-8169552 diff is inside the bug. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

10.11.2016 um 02:35 schrieb Chien Yang <chien.y...@oracle.com>: Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

is always white? Tom Von meinem iPhone gesendet > Am 10.11.2016 um 02:35 schrieb Chien Yang <chien.y...@oracle.com>: > > Hi Jim and Kevin, > > Please review the proposed fix: > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 > Webrev: http://cr.openjd

[9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

review: correct concatenation of dependencies/*/*.extra files

Kevin, if you would review JBS: https://bugs.openjdk.java.net/browse/JDK-8169511 diff inline. -- David Hill<david.h...@oracle.com> Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: [9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

+1 I did a quick test on Mac and it worked for me. Chris > On Nov 8, 2016, at 4:11 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > Hi, > > Please review the following fix to include jake-compatible versions of > module-info.java with ou

Re: [9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

Looks good to me. Mandy > On Nov 8, 2016, at 4:11 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> > wrote: > > Hi, > > Please review the following fix to include jake-compatible versions of > module-info.java with our input bundles: > > https://bugs.op

Re: Review request for 8169294:

On 11/7/2016 1:14 PM, Laurent Bourgès wrote: The only difference in Path2D.java I noted is that the Java2D version has an EXPAND_MIN which is 10, but you re-use INIT_SIZE, which is 20, here for the same purpose. You're right; I think I didn't want to add an extra constant but if you prefer

Re: Review request for 8169294:

I'll review the test tomorrow (I'm a little backed up on my code reviews given the impending change to build with jigsaw JDK). -- Kevin Laurent Bourgès wrote: Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham <james.gra...@oracle.com <mailto:james.gra...@oracle.com>>: I'd like

Re: Review request for 8169294:

Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham <james.gra...@oracle.com>: > I'd like to see Kevin review the test as I'm not the best expert on our > JUnit framework. > I just added @Test annotations and kept the jtreg tags in header (for information). I could add asserts but JUnit

Re: Review request for 8169294:

I'd like to see Kevin review the test as I'm not the best expert on our JUnit framework. It looks like it is mostly just going to emit some printouts about performance (using echo() and log()) and verify that we don't get any ArrayBounds related exceptions (or worse, OOME)? The only

Re: [webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

Hello Kevin, Phil, I have incorporated review comments, Please take a look. http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/ <http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/> Thanks, Arun > On 04-Oct-2016, at 12:15 AM, Arunprasad Rajkumar > <arunprasad.rajk

[9] Review request for 8169309: Migrate SwingNode to the new float API of JLightweightFrame

Hello Kevin & Jim, Please review the fix for jfx9: webrev: http://cr.openjdk.java.net/~ssadetsky/8169309/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8153522 --Semyon

Review request for 8169294:

Hi, Please review this Path2D fix improving its storage growth algorithm as done in java2d: JBS: https://bugs.openjdk.java.net/browse/JDK-8169294 Webrev: http://cr.openjdk.java.net/~lbourges/fx/path2D/ PS: I converted the former jtreg test to JUnit test for OpenJFX. I hope it is correct, as I

<    3   4   5   6   7   8   9   10   11   12   >