hg: openjfx/8u-dev/rt: RT-38278 [ScrollPane] minViewport{Height, Width} are taking effect only after changing prefViewport{Height, Width}

2014-08-18 Thread martin . sladecek
Changeset: 36a242b77366
Author:Martin Sladecek 
Date:  2014-08-19 08:37 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/36a242b77366

RT-38278 [ScrollPane] minViewport{Height,Width} are taking effect only after 
changing prefViewport{Height,Width}
Reviewed by: jgiles

! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ScrollPaneSkin.java



hg: openjfx/8u-dev/rt: RT-38344 [Ensemble] Add TextField with formatter sample to Ensemble

2014-08-18 Thread martin . sladecek
Changeset: b5b649ef6d8d
Author:Martin Sladecek 
Date:  2014-08-19 08:36 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b5b649ef6d8d

RT-38344 [Ensemble] Add TextField with formatter sample to Ensemble
Reviewed by: kselle

! apps/samples/Ensemble8/src/generated/java/ensemble/generated/Samples.java
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.fdt
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.fdx
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.fnm
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.frq
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.nrm
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.prx
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.tii
! apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/_0.tis
! 
apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/listAll.txt
! 
apps/samples/Ensemble8/src/generated/resources/ensemble/search/index/segments_1
+ 
apps/samples/Ensemble8/src/samples/java/ensemble/samples/controls/text/textformatter/TextFormatterApp.java
+ 
apps/samples/Ensemble8/src/samples/resources/ensemble/samples/controls/text/textformatter/preview.png



hg: openjfx/8u-dev/rt: RT-38283: [Controls, Spinner] Add key binding to increment and decrement the Spinner

2014-08-18 Thread jonathan . giles
Changeset: b87aff6ddefa
Author:jgiles
Date:  2014-08-19 15:31 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b87aff6ddefa

RT-38283: [Controls, Spinner] Add key binding to increment and decrement the 
Spinner

! 
modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/SpinnerBehavior.java
! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/SpinnerSkin.java



hg: openjfx/8u-dev/rt: RT-38322: [Dialogs] Externalise default graphic file references

2014-08-18 Thread jonathan . giles
Changeset: 7c9dd9130dac
Author:jgiles
Date:  2014-08-19 13:33 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/7c9dd9130dac

RT-38322: [Dialogs] Externalise default graphic file references

! modules/controls/src/main/java/javafx/scene/control/Alert.java
! modules/controls/src/main/java/javafx/scene/control/ChoiceDialog.java
! modules/controls/src/main/java/javafx/scene/control/DialogPane.java
! modules/controls/src/main/java/javafx/scene/control/TextInputDialog.java
! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css



hg: openjfx/8u-dev/rt: 2 new changesets

2014-08-18 Thread jonathan . giles
Changeset: c3a8124d5cd6
Author:jgiles
Date:  2014-08-19 12:50 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c3a8124d5cd6

RT-38321: [Dialogs] Fix layout issues

! modules/controls/src/main/java/javafx/scene/control/ChoiceDialog.java
! modules/controls/src/main/java/javafx/scene/control/Dialog.java
! modules/controls/src/main/java/javafx/scene/control/DialogPane.java
! modules/controls/src/main/java/javafx/scene/control/TextInputDialog.java
! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css

Changeset: 323fe1d9f2b8
Author:jgiles
Date:  2014-08-19 12:50 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/323fe1d9f2b8

[TOYS ONLY] Fix bad image file reference in HelloDialogs sample code which was 
refactored incorrectly yesterday.

! apps/toys/Hello/src/main/java/hello/dialog/dialogs/FontSelectorDialog.java



8u40 review request: RT-38315 - Lighting effect causes rendering bugs

2014-08-18 Thread Jim Graham

webrev: http://cr.openjdk.java.net/~flar/RT-38315/webrev.0/
Jira: https://javafx-jira.kenai.com/browse/RT-38315

...jim


hg: openjfx/8u-dev/rt: [TOYS ONLY] Fix bad image file references in HelloDialogs sample code which was refactored incorrectly yesterday.

2014-08-18 Thread jonathan . giles
Changeset: 348f681e0717
Author:jgiles
Date:  2014-08-19 10:46 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/348f681e0717

[TOYS ONLY] Fix bad image file references in HelloDialogs sample code which was 
refactored incorrectly yesterday.

! apps/toys/Hello/src/main/java/hello/dialog/dialogs/CommandLinksDialog.java
! apps/toys/Hello/src/main/java/hello/dialog/dialogs/ExceptionDialog.java
! apps/toys/Hello/src/main/java/hello/dialog/wizard/Wizard.java



hg: openjfx/8u-dev/rt: RT-38347: [Dialogs] HelloAlert ESC and (x) do not close dialog that only has 'OK'

2014-08-18 Thread jonathan . giles
Changeset: 916da7f77a61
Author:jgiles
Date:  2014-08-19 10:32 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/916da7f77a61

RT-38347: [Dialogs] HelloAlert ESC and (x) do not close dialog that only has 
'OK'

! modules/controls/src/main/java/javafx/scene/control/HeavyweightDialog.java



hg: openjfx/8u-dev/rt: Fix to RT-38351: [Gtk] Remove "Failed in XOpenDisplay" warning message

2014-08-18 Thread chien . yang
Changeset: ffedbb480817
Author:Chien Yang 
Date:  2014-08-18 15:31 -0700
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ffedbb480817

Fix to RT-38351: [Gtk] Remove "Failed in XOpenDisplay" warning message
A trivial post commit fix, tagged kcr as reviewer.

! modules/graphics/src/main/native-prism-es2/x11/X11GLFactory.c



Re: Text rendering on Windows

2014-08-18 Thread Kevin Rushforth

Can you file a JIRA and send screen-shots to Felipe?

-- Kevin


John C. Turnbull wrote:

Richard, I totally agree on the subjective nature of "font appreciation" but 
that's not really what I am highlighting here. What I am seeing is a difference between 
the quality of font rendering between JFX and native apps on the same machine with the 
same font etc. and the JFX rendering is definitely less sharp/black. Some may prefer that 
(not me) but the issue is that there *is* a difference.

Cheers,

-jct

On 18 Aug 2014, at 10:36 pm, Richard Bair  wrote:

  

I won't be able to get access to a Windows machine for another week or so but 
when I do I will gladly send you some screenshots.  However, are you saying 
that this is the first time anyone has reported such a finding? There's no 
existing JIRA for this specific issue? I ask because even though people tell me 
I am super fussy with fonts and see things others just can't see, I have 
observed the stated discrepancy on *every* Windows machine I have tried with 
JFX 8 (about 4 quite different machines) so I would be very surprised if no one 
else notices a difference.
  

It is really common for two font fussy people to disagree on which font 
rendering is “better” :-). We’ve also looked at various applications and it 
seems to be a mixture of different techniques (sometimes even within the same 
app!). For such things, it might be better to expose some kind of settings that 
lets the developer chose which font hinting they want to use or other settings. 
Just something to keep in mind.

The other day I was doing some HTML (blah) and comparing the font rendering 
with another website. My fonts were dark and heavy, their fonts were light and 
stylish. The font was exactly the same. The weight was exactly the same. The 
style, variant, etc were all the same. The difference was 
'-webkit-font-smoothing: antialiased;’. I don’t know if the two of us, given 
the same page and same rendering, would agree on which font looked nicer (maybe 
we would, maybe not, I really don’t know!).

Which makes me think we probably need to expose some toggles so folks can tweak 
the characteristics to their liking.

Richard



Re: Text rendering on Windows

2014-08-18 Thread John C. Turnbull
Richard, I totally agree on the subjective nature of "font appreciation" but 
that's not really what I am highlighting here. What I am seeing is a difference 
between the quality of font rendering between JFX and native apps on the same 
machine with the same font etc. and the JFX rendering is definitely less 
sharp/black. Some may prefer that (not me) but the issue is that there *is* a 
difference.

Cheers,

-jct

On 18 Aug 2014, at 10:36 pm, Richard Bair  wrote:

>> I won't be able to get access to a Windows machine for another week or so 
>> but when I do I will gladly send you some screenshots.  However, are you 
>> saying that this is the first time anyone has reported such a finding? 
>> There's no existing JIRA for this specific issue? I ask because even though 
>> people tell me I am super fussy with fonts and see things others just can't 
>> see, I have observed the stated discrepancy on *every* Windows machine I 
>> have tried with JFX 8 (about 4 quite different machines) so I would be very 
>> surprised if no one else notices a difference.
> 
> It is really common for two font fussy people to disagree on which font 
> rendering is “better” :-). We’ve also looked at various applications and it 
> seems to be a mixture of different techniques (sometimes even within the same 
> app!). For such things, it might be better to expose some kind of settings 
> that lets the developer chose which font hinting they want to use or other 
> settings. Just something to keep in mind.
> 
> The other day I was doing some HTML (blah) and comparing the font rendering 
> with another website. My fonts were dark and heavy, their fonts were light 
> and stylish. The font was exactly the same. The weight was exactly the same. 
> The style, variant, etc were all the same. The difference was 
> '-webkit-font-smoothing: antialiased;’. I don’t know if the two of us, given 
> the same page and same rendering, would agree on which font looked nicer 
> (maybe we would, maybe not, I really don’t know!).
> 
> Which makes me think we probably need to expose some toggles so folks can 
> tweak the characteristics to their liking.
> 
> Richard


Re: Text rendering on Windows

2014-08-18 Thread John C. Turnbull
That's great to hear Kevin!

> On 18 Aug 2014, at 10:39 pm, Kevin Rushforth  
> wrote:
> 
> 
>> As for LCD on Canvas, I am very pleased that it is being addressed and even 
>> though I want it right now, JFX 9 fits fairly well with my timeline. 
>> Hopefully there will be preview releases to test in the not too distant 
>> future...
> 
> Btw, as I mentioned in another thread we are looking to pull LCD-on-Canvas 
> into an 8-update release (possibly 8u40).
> 
> -- Kevin
> 
> 
> 
> John C. Turnbull wrote:
>> Hi Felipe,
>> 
>> Thanks for your prompt and informative response.
>> 
>> I won't be able to get access to a Windows machine for another week or so 
>> but when I do I will gladly send you some screenshots.  However, are you 
>> saying that this is the first time anyone has reported such a finding? 
>> There's no existing JIRA for this specific issue? I ask because even though 
>> people tell me I am super fussy with fonts and see things others just can't 
>> see, I have observed the stated discrepancy on *every* Windows machine I 
>> have tried with JFX 8 (about 4 quite different machines) so I would be very 
>> surprised if no one else notices a difference.
>> 
>> Thanks for the J1 suggestion but sadly I will not be able to attend this 
>> year.
>> 
>> As for LCD on Canvas, I am very pleased that it is being addressed and even 
>> though I want it right now, JFX 9 fits fairly well with my timeline. 
>> Hopefully there will be preview releases to test in the not too distant 
>> future...
>> 
>> Cheers,
>> 
>> -jct
>> 
>>  
>>> On 18 Aug 2014, at 9:00 pm, Felipe Heidrich  
>>> wrote:
>>> 
>>> Hi John,
>>> 
>>> 1)
>>> There are many different ways to configure DirectWrite, but without more 
>>> details I can not tell what that is for your case.
>>> Maybe the first thing to try is to go to DWGlyph#createAnalysis() and 
>>> changed the rendering mode from DWRITE_RENDERING_MODE_NATURAL to 
>>> DWRITE_RENDERING_MODE_GDI_CLASSIC or DWRITE_RENDERING_MODE_GDI_NATURAL. 
>>> That said, there are many other knobs to try and combine.
>>> 
>>> You can also file a jira with images of your javaFX application and a 
>>> native app using the very same font and size, same foreground, and same 
>>> background. That should enable me to try it on my machine too.
>>> 
>>> In case you are coming to JavaOne this year, you could bring your laptop 
>>> and application, I have a BOF on text rendering scheduled. We could hack 
>>> some code together and maybe find a solution.
>>> 
>>> 2)
>>> LCD text rendering on Canvas is assigned to Jim, see 
>>> https://javafx-jira.kenai.com/browse/RT-23822
>>> The fix version recored on jira is 9, it would be nice if we could get it 
>>> before that but I don’t know if it is possible, Jim ?
>>> 
>>> Thank you,
>>> Felipe
>>> 
>>> 
>>> 
>>>
 On Aug 18, 2014, at 1:28 AM, John C. Turnbull  
 wrote:
 
 Hi Felipe,
 
 I just finished watching your excellent presentation at SVJUGFX on text 
 rendering with JavaFX and have a couple of multi part questions:
 
 1) I noted that DirectWrite is now used to rasterise fonts on Windows 
 instead of T2K or GDI and I for one am pleased about this. However, no 
 matter what I do I just can't get JavaFX text to be rendered as crisply or 
 as "black" as I see in native Windows apps that also use DirectWrite. The 
 result is that my app undesirably "stands out" from a native app.
 
 What could be the cause of this? I saw that DirectWrite provides several 
 options for rendering text and that currently only the default one is 
 being applied so could it have something to do with this?
 
 Is work being done to reduce the differential between JavaFX text 
 rendering quality and that of native Windows apps?
 
 2) I appreciated the explanation relating to LCD text in Canvas and the 
 issue with the Canvas initially bring a transparent surface making later 
 blending with an actual background problematic leading to greyscale 
 support only.
 
 Given that many of us see this as a very serious impediment to developing 
 complex controls that use Canvas, is there a focus within the JFX team on 
 finding a way of supporting LCD text in Canvas and if so, which JFX 
 version is likely to first include this support?
 
 Thanks again for a great talk and for all the hard work you have put into 
 improving text rendering in JavaFX :-)
 
 -jct
  


Re: Text rendering on Windows

2014-08-18 Thread Kevin Rushforth



As for LCD on Canvas, I am very pleased that it is being addressed and even 
though I want it right now, JFX 9 fits fairly well with my timeline. Hopefully 
there will be preview releases to test in the not too distant future...
  


Btw, as I mentioned in another thread we are looking to pull 
LCD-on-Canvas into an 8-update release (possibly 8u40).


-- Kevin



John C. Turnbull wrote:

Hi Felipe,

Thanks for your prompt and informative response.

I won't be able to get access to a Windows machine for another week or so but 
when I do I will gladly send you some screenshots.  However, are you saying 
that this is the first time anyone has reported such a finding? There's no 
existing JIRA for this specific issue? I ask because even though people tell me 
I am super fussy with fonts and see things others just can't see, I have 
observed the stated discrepancy on *every* Windows machine I have tried with 
JFX 8 (about 4 quite different machines) so I would be very surprised if no one 
else notices a difference.

Thanks for the J1 suggestion but sadly I will not be able to attend this year.

As for LCD on Canvas, I am very pleased that it is being addressed and even 
though I want it right now, JFX 9 fits fairly well with my timeline. Hopefully 
there will be preview releases to test in the not too distant future...

Cheers,

-jct

  

On 18 Aug 2014, at 9:00 pm, Felipe Heidrich  wrote:

Hi John,

1)
There are many different ways to configure DirectWrite, but without more 
details I can not tell what that is for your case.
Maybe the first thing to try is to go to DWGlyph#createAnalysis() and changed 
the rendering mode from DWRITE_RENDERING_MODE_NATURAL to 
DWRITE_RENDERING_MODE_GDI_CLASSIC or DWRITE_RENDERING_MODE_GDI_NATURAL. That 
said, there are many other knobs to try and combine.

You can also file a jira with images of your javaFX application and a native 
app using the very same font and size, same foreground, and same background. 
That should enable me to try it on my machine too.

In case you are coming to JavaOne this year, you could bring your laptop and 
application, I have a BOF on text rendering scheduled. We could hack some code 
together and maybe find a solution.

2)
LCD text rendering on Canvas is assigned to Jim, see 
https://javafx-jira.kenai.com/browse/RT-23822
The fix version recored on jira is 9, it would be nice if we could get it 
before that but I don’t know if it is possible, Jim ?

Thank you,
Felipe





On Aug 18, 2014, at 1:28 AM, John C. Turnbull  wrote:

Hi Felipe,

I just finished watching your excellent presentation at SVJUGFX on text 
rendering with JavaFX and have a couple of multi part questions:

1) I noted that DirectWrite is now used to rasterise fonts on Windows instead of T2K or GDI and I 
for one am pleased about this. However, no matter what I do I just can't get JavaFX text to be 
rendered as crisply or as "black" as I see in native Windows apps that also use 
DirectWrite. The result is that my app undesirably "stands out" from a native app.

What could be the cause of this? I saw that DirectWrite provides several 
options for rendering text and that currently only the default one is being 
applied so could it have something to do with this?

Is work being done to reduce the differential between JavaFX text rendering 
quality and that of native Windows apps?

2) I appreciated the explanation relating to LCD text in Canvas and the issue 
with the Canvas initially bring a transparent surface making later blending 
with an actual background problematic leading to greyscale support only.

Given that many of us see this as a very serious impediment to developing 
complex controls that use Canvas, is there a focus within the JFX team on 
finding a way of supporting LCD text in Canvas and if so, which JFX version is 
likely to first include this support?

Thanks again for a great talk and for all the hard work you have put into 
improving text rendering in JavaFX :-)

-jct
  


Re: Text rendering on Windows

2014-08-18 Thread Richard Bair
> I won't be able to get access to a Windows machine for another week or so but 
> when I do I will gladly send you some screenshots.  However, are you saying 
> that this is the first time anyone has reported such a finding? There's no 
> existing JIRA for this specific issue? I ask because even though people tell 
> me I am super fussy with fonts and see things others just can't see, I have 
> observed the stated discrepancy on *every* Windows machine I have tried with 
> JFX 8 (about 4 quite different machines) so I would be very surprised if no 
> one else notices a difference.

It is really common for two font fussy people to disagree on which font 
rendering is “better” :-). We’ve also looked at various applications and it 
seems to be a mixture of different techniques (sometimes even within the same 
app!). For such things, it might be better to expose some kind of settings that 
lets the developer chose which font hinting they want to use or other settings. 
Just something to keep in mind.

The other day I was doing some HTML (blah) and comparing the font rendering 
with another website. My fonts were dark and heavy, their fonts were light and 
stylish. The font was exactly the same. The weight was exactly the same. The 
style, variant, etc were all the same. The difference was 
'-webkit-font-smoothing: antialiased;’. I don’t know if the two of us, given 
the same page and same rendering, would agree on which font looked nicer (maybe 
we would, maybe not, I really don’t know!).

Which makes me think we probably need to expose some toggles so folks can tweak 
the characteristics to their liking.

Richard

hg: openjfx/8u/rt: 55 new changesets

2014-08-18 Thread kevin . rushforth
Changeset: de9dbcbc9885
Author:yjoan
Date:  2014-08-11 13:28 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/de9dbcbc9885

[SCENEBUILDER] Metadata: ScrollPane property minViewPortWidth reads before 
minViewPortHeight in the Inspector

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/metadata/Metadata.java

Changeset: 44b6e89d00ba
Author:kcr
Date:  2014-08-11 14:23 -0700
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/44b6e89d00ba

Automated merge with ssh://hg.openjdk.java.net/openjfx/8u-dev/rt


Changeset: 7ec4725320d0
Author:Martin Sladecek 
Date:  2014-08-12 09:55 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/7ec4725320d0

RT-25980 Add Window setUserData and user data to other non-Node classes
Reviewed by: kcr, snorthov
Contributed by: tom.schi...@bestsolution.at

! modules/controls/src/main/java/javafx/scene/control/ToggleGroup.java
! modules/controls/src/test/java/javafx/scene/control/ToggleGroupTest.java
! modules/graphics/src/main/java/javafx/scene/Scene.java
! modules/graphics/src/main/java/javafx/stage/Window.java
! modules/graphics/src/test/java/javafx/scene/SceneTest.java
! modules/graphics/src/test/java/javafx/stage/WindowTest.java

Changeset: 42903ea10084
Author:Martin Sladecek 
Date:  2014-08-12 10:00 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/42903ea10084

RT-33696 RTL orientation, submenu overlaps its parent menu.
Reviewed by: snorthov, kcr

! modules/controls/src/main/java/javafx/scene/control/PopupControl.java

Changeset: a7f7ec1bc33f
Author:Martin Sladecek 
Date:  2014-08-12 10:04 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/a7f7ec1bc33f

RT-37798 [Charts] Series: NPE when adding data items after deletion of data
Reviewed by: jgiles

! modules/controls/src/main/java/javafx/scene/chart/XYChart.java
! modules/controls/src/test/java/javafx/scene/chart/XYChartDataTest.java

Changeset: 14063a5dd1e1
Author:Anthony Petrov 
Date:  2014-08-12 14:36 +0400
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/14063a5dd1e1

RT-37149: [SwingNode, DND] : drag-and-drop does not work
Summary: Implement DnD for SwingNode
Reviewed-by: ant

+ modules/swing/src/main/java/javafx/embed/swing/CachingTransferable.java
! modules/swing/src/main/java/javafx/embed/swing/DataFlavorUtils.java
+ modules/swing/src/main/java/javafx/embed/swing/FXDnD.java
! modules/swing/src/main/java/javafx/embed/swing/SwingDnD.java
! modules/swing/src/main/java/javafx/embed/swing/SwingDragSource.java
! modules/swing/src/main/java/javafx/embed/swing/SwingFXUtils.java
! modules/swing/src/main/java/javafx/embed/swing/SwingNode.java

Changeset: 2326aecdf8b0
Author:Martin Sladecek 
Date:  2014-08-12 12:39 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/2326aecdf8b0

RT-38238 unmodifiableObservableMap.entrySet() provides entries in wrong order

! 
modules/base/src/main/java/com/sun/javafx/collections/UnmodifiableObservableMap.java
! modules/base/src/test/java/javafx/collections/FXCollectionsTest.java

Changeset: e5dccbae218a
Author:David Grieve
Date:  2014-08-12 08:03 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/e5dccbae218a

RT-38138: -fx-spacing used wrong in .menubar in modena.css
Reviewed by: kcr

! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/MenuBarSkin.java

Changeset: 7c4cb2f851ab
Author:yjoan
Date:  2014-08-12 15:43 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/7c4cb2f851ab

[SCENEBUILDER] Fix for DTL-6746: Text Fill of Label change color the "#" 
hexadecimal color interpreted as event build method ...

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java

Changeset: 340aba2d2506
Author:Eric Le Ponner 
Date:  2014-08-12 18:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/340aba2d2506

[SCENEBUILDER] Added FXOMObject.lookupFirstReference() method (to be used for 
DTL-6774).

! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java
! 
apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java

Changeset: c0f091376dbf
Author:Felipe Heidrich 
Date:  2014-08-12 13:46 -0700
URL:   http://hg.openjdk.java.net/openjfx/8u/rt/rev/c0f091376dbf

RT-37959: [Accessibility] Review a11y enums
Remove PAGES and TABS
Use ITEM_COUNT and ITEM_AT_INDEX for ListView, Pagination, and TabPane.

! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ListViewSkin.java
! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/PaginationSkin.java
! 
modules/controls/src/main/java/com/sun/javafx/scene/control/skin/TabPaneSkin.java
! modules/controls

8u-dev unlocked following this week's sanity testing

2014-08-18 Thread Kevin Rushforth




Re: Text rendering on Windows

2014-08-18 Thread John C. Turnbull
Hi Felipe,

Thanks for your prompt and informative response.

I won't be able to get access to a Windows machine for another week or so but 
when I do I will gladly send you some screenshots.  However, are you saying 
that this is the first time anyone has reported such a finding? There's no 
existing JIRA for this specific issue? I ask because even though people tell me 
I am super fussy with fonts and see things others just can't see, I have 
observed the stated discrepancy on *every* Windows machine I have tried with 
JFX 8 (about 4 quite different machines) so I would be very surprised if no one 
else notices a difference.

Thanks for the J1 suggestion but sadly I will not be able to attend this year.

As for LCD on Canvas, I am very pleased that it is being addressed and even 
though I want it right now, JFX 9 fits fairly well with my timeline. Hopefully 
there will be preview releases to test in the not too distant future...

Cheers,

-jct

> On 18 Aug 2014, at 9:00 pm, Felipe Heidrich  
> wrote:
> 
> Hi John,
> 
> 1)
> There are many different ways to configure DirectWrite, but without more 
> details I can not tell what that is for your case.
> Maybe the first thing to try is to go to DWGlyph#createAnalysis() and changed 
> the rendering mode from DWRITE_RENDERING_MODE_NATURAL to 
> DWRITE_RENDERING_MODE_GDI_CLASSIC or DWRITE_RENDERING_MODE_GDI_NATURAL. That 
> said, there are many other knobs to try and combine.
> 
> You can also file a jira with images of your javaFX application and a native 
> app using the very same font and size, same foreground, and same background. 
> That should enable me to try it on my machine too.
> 
> In case you are coming to JavaOne this year, you could bring your laptop and 
> application, I have a BOF on text rendering scheduled. We could hack some 
> code together and maybe find a solution.
> 
> 2)
> LCD text rendering on Canvas is assigned to Jim, see 
> https://javafx-jira.kenai.com/browse/RT-23822
> The fix version recored on jira is 9, it would be nice if we could get it 
> before that but I don’t know if it is possible, Jim ?
> 
> Thank you,
> Felipe
> 
> 
> 
>> On Aug 18, 2014, at 1:28 AM, John C. Turnbull  wrote:
>> 
>> Hi Felipe,
>> 
>> I just finished watching your excellent presentation at SVJUGFX on text 
>> rendering with JavaFX and have a couple of multi part questions:
>> 
>> 1) I noted that DirectWrite is now used to rasterise fonts on Windows 
>> instead of T2K or GDI and I for one am pleased about this. However, no 
>> matter what I do I just can't get JavaFX text to be rendered as crisply or 
>> as "black" as I see in native Windows apps that also use DirectWrite. The 
>> result is that my app undesirably "stands out" from a native app.
>> 
>> What could be the cause of this? I saw that DirectWrite provides several 
>> options for rendering text and that currently only the default one is being 
>> applied so could it have something to do with this?
>> 
>> Is work being done to reduce the differential between JavaFX text rendering 
>> quality and that of native Windows apps?
>> 
>> 2) I appreciated the explanation relating to LCD text in Canvas and the 
>> issue with the Canvas initially bring a transparent surface making later 
>> blending with an actual background problematic leading to greyscale support 
>> only.
>> 
>> Given that many of us see this as a very serious impediment to developing 
>> complex controls that use Canvas, is there a focus within the JFX team on 
>> finding a way of supporting LCD text in Canvas and if so, which JFX version 
>> is likely to first include this support?
>> 
>> Thanks again for a great talk and for all the hard work you have put into 
>> improving text rendering in JavaFX :-)
>> 
>> -jct
> 


Re: Text rendering on Windows

2014-08-18 Thread Felipe Heidrich
Hi John,

1)
There are many different ways to configure DirectWrite, but without more 
details I can not tell what that is for your case.
Maybe the first thing to try is to go to DWGlyph#createAnalysis() and changed 
the rendering mode from DWRITE_RENDERING_MODE_NATURAL to 
DWRITE_RENDERING_MODE_GDI_CLASSIC or DWRITE_RENDERING_MODE_GDI_NATURAL. That 
said, there are many other knobs to try and combine.

You can also file a jira with images of your javaFX application and a native 
app using the very same font and size, same foreground, and same background. 
That should enable me to try it on my machine too.

In case you are coming to JavaOne this year, you could bring your laptop and 
application, I have a BOF on text rendering scheduled. We could hack some code 
together and maybe find a solution.

2)
LCD text rendering on Canvas is assigned to Jim, see 
https://javafx-jira.kenai.com/browse/RT-23822
The fix version recored on jira is 9, it would be nice if we could get it 
before that but I don’t know if it is possible, Jim ?

Thank you,
Felipe



> On Aug 18, 2014, at 1:28 AM, John C. Turnbull  wrote:
> 
> Hi Felipe,
> 
> I just finished watching your excellent presentation at SVJUGFX on text 
> rendering with JavaFX and have a couple of multi part questions:
> 
> 1) I noted that DirectWrite is now used to rasterise fonts on Windows instead 
> of T2K or GDI and I for one am pleased about this. However, no matter what I 
> do I just can't get JavaFX text to be rendered as crisply or as "black" as I 
> see in native Windows apps that also use DirectWrite. The result is that my 
> app undesirably "stands out" from a native app.
> 
> What could be the cause of this? I saw that DirectWrite provides several 
> options for rendering text and that currently only the default one is being 
> applied so could it have something to do with this?
> 
> Is work being done to reduce the differential between JavaFX text rendering 
> quality and that of native Windows apps?
> 
> 2) I appreciated the explanation relating to LCD text in Canvas and the issue 
> with the Canvas initially bring a transparent surface making later blending 
> with an actual background problematic leading to greyscale support only.
> 
> Given that many of us see this as a very serious impediment to developing 
> complex controls that use Canvas, is there a focus within the JFX team on 
> finding a way of supporting LCD text in Canvas and if so, which JFX version 
> is likely to first include this support?
> 
> Thanks again for a great talk and for all the hard work you have put into 
> improving text rendering in JavaFX :-)
> 
> -jct
> 
> 



hg: openjfx/8u-dev/rt: RT-38345: [CSS] Warning messages from CSS on touch devices

2014-08-18 Thread david . grieve
Changeset: d7373a5e9cd9
Author:David Grieve
Date:  2014-08-18 12:30 -0400
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d7373a5e9cd9

RT-38345: [CSS] Warning messages from CSS on touch devices
Reviewed by: kevin, lisa

! modules/graphics/src/main/java/com/sun/javafx/css/parser/CSSParser.java



Re: hg: openjfx/8u-dev/rt: RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order

2014-08-18 Thread Kevin Rushforth

Hi Martin,

This just missed the 1am Pacific cutoff  (it was 3 minutes late), and as 
such, is not part of the build we are sanity testing this morning. 
Hopefully we will not have any critical issues and can just ignore this 
push for this week...


-- Kevin


martin.slade...@oracle.com wrote:

Changeset: 14219b05f178
Author:Martin Sladecek 
Date:  2014-08-18 10:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/14219b05f178

RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order
Reviewed by: snothov, kcr

! modules/controls/src/main/java/javafx/scene/chart/LineChart.java

  


Re: JavaFX 8 and TextFields

2014-08-18 Thread Jeff Martin
I wonder if this is related to my rendering bug from last week, which also 
resulted in unexpected horizontal lines (boundary lines actually) when 
rendering on top of a background with an effect (assuming the textfield is 
possibly rendering something on a background with an inner shadow effect).

http://reportmill.com/examples/Renderbug/Renderbug.jpg
https://javafx-jira.kenai.com/browse/RT-38315

Mine may have been more pronounced because of the animation.

jeff


On Aug 18, 2014, at 9:29 AM, Stephen F Northover  
wrote:

> This seems to be the bug: https://javafx-jira.kenai.com/browse/RT-36987
> 
> It's quite a mystery.  It's likely a shader problem but that's just a guess.
> 
> Steve
> 
> On 2014-08-18, 10:21 AM, Eric Le Ponner wrote:
>> Dirk, Anothony,
>> 
>> I’ve never observed this visual artifact on Mac OS 10.9 (.4)
>> no matter it’s SB 2.0 (i.e. b20) or latest SB (with latest FX8dev code).
>> 
>> Strange…
>> 
>> Could it be related to the graphics pipeline ?
>> What model of Mac are you using Dirk ?
>> 
>> Eric
>> 
>> 
>> 
>> Le 18 août 2014 à 15:34, Anthony Petrov  a écrit :
>> 
>>> Hi Dirk,
>>> 
>>> This looks like a bug. Could you please verify if the latest 8u20 ea build 
>>> works for you? You can download it at:
>>> 
>>> http://jdk8.java.net/download.html
>>> 
>>> 
>>> If it still fails, please file a new bug at
>>> 
>>> https://javafx-jira.kenai.com/secure/CreateIssue!default.jspa
>>> 
>>> --
>>> best regards,
>>> Anthony
>>> 
>>> On 8/18/2014 5:28 PM, Dirk Dittert wrote:
 Hi,
 
 I'm wondering about the design of TextFields in JavaFX 8. Why are they
 having a horizontal line through the input area? I find that this looks
 rather peculiar...
 
 I posted some screenshots here:
 http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/
 
 One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
 my applications (running on 1.8.0_11) on OS X.
 
 Thanks,
 Dirk
 
> 



Re: JavaFX 8 and TextFields

2014-08-18 Thread Stephen F Northover

This seems to be the bug: https://javafx-jira.kenai.com/browse/RT-36987

It's quite a mystery.  It's likely a shader problem but that's just a guess.

Steve

On 2014-08-18, 10:21 AM, Eric Le Ponner wrote:

Dirk, Anothony,

I’ve never observed this visual artifact on Mac OS 10.9 (.4)
no matter it’s SB 2.0 (i.e. b20) or latest SB (with latest FX8dev code).

Strange…

Could it be related to the graphics pipeline ?
What model of Mac are you using Dirk ?

Eric



Le 18 août 2014 à 15:34, Anthony Petrov  a écrit :


Hi Dirk,

This looks like a bug. Could you please verify if the latest 8u20 ea build 
works for you? You can download it at:

http://jdk8.java.net/download.html


If it still fails, please file a new bug at

https://javafx-jira.kenai.com/secure/CreateIssue!default.jspa

--
best regards,
Anthony

On 8/18/2014 5:28 PM, Dirk Dittert wrote:

Hi,

I'm wondering about the design of TextFields in JavaFX 8. Why are they
having a horizontal line through the input area? I find that this looks
rather peculiar...

I posted some screenshots here:
http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/

One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
my applications (running on 1.8.0_11) on OS X.

Thanks,
Dirk





Re: JavaFX 8 and TextFields

2014-08-18 Thread Eric Le Ponner
Dirk, Anothony,

I’ve never observed this visual artifact on Mac OS 10.9 (.4)
no matter it’s SB 2.0 (i.e. b20) or latest SB (with latest FX8dev code).

Strange…

Could it be related to the graphics pipeline ?
What model of Mac are you using Dirk ?

Eric



Le 18 août 2014 à 15:34, Anthony Petrov  a écrit :

> Hi Dirk,
> 
> This looks like a bug. Could you please verify if the latest 8u20 ea build 
> works for you? You can download it at:
> 
> http://jdk8.java.net/download.html
> 
> 
> If it still fails, please file a new bug at
> 
> https://javafx-jira.kenai.com/secure/CreateIssue!default.jspa
> 
> --
> best regards,
> Anthony
> 
> On 8/18/2014 5:28 PM, Dirk Dittert wrote:
>> Hi,
>> 
>> I'm wondering about the design of TextFields in JavaFX 8. Why are they
>> having a horizontal line through the input area? I find that this looks
>> rather peculiar...
>> 
>> I posted some screenshots here:
>> http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/
>> 
>> One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
>> my applications (running on 1.8.0_11) on OS X.
>> 
>> Thanks,
>> Dirk
>> 



Re: JavaFX 8 and TextFields

2014-08-18 Thread Anthony Petrov

Hi Dirk,

This looks like a bug. Could you please verify if the latest 8u20 ea 
build works for you? You can download it at:


http://jdk8.java.net/download.html


If it still fails, please file a new bug at

https://javafx-jira.kenai.com/secure/CreateIssue!default.jspa

--
best regards,
Anthony

On 8/18/2014 5:28 PM, Dirk Dittert wrote:

Hi,

I'm wondering about the design of TextFields in JavaFX 8. Why are they
having a horizontal line through the input area? I find that this looks
rather peculiar...

I posted some screenshots here:
http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/

One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
my applications (running on 1.8.0_11) on OS X.

Thanks,
Dirk



JavaFX 8 and TextFields

2014-08-18 Thread Dirk Dittert
Hi,

I'm wondering about the design of TextFields in JavaFX 8. Why are they
having a horizontal line through the input area? I find that this looks
rather peculiar...

I posted some screenshots here:
http://d.dittert.org/E4D7EB53-D198-47AC-9230-53E9A23F6767/

One is from SceneBuilder 2.0-b20 on OS X 10.9. The other one is from one of
my applications (running on 1.8.0_11) on OS X.

Thanks,
Dirk


hg: openjfx/8u-dev/rt: [TOYS] Hello : HelloTextFieldWithTextFormatter

2014-08-18 Thread martin . sladecek
Changeset: 0fdd457a9e04
Author:Martin Sladecek 
Date:  2014-08-18 14:25 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0fdd457a9e04

[TOYS] Hello : HelloTextFieldWithTextFormatter

+ apps/toys/Hello/src/main/java/hello/HelloTextFieldWithTextFormatter.java



Text rendering on Windows

2014-08-18 Thread John C. Turnbull
Hi Felipe,

I just finished watching your excellent presentation at SVJUGFX on text 
rendering with JavaFX and have a couple of multi part questions:

1) I noted that DirectWrite is now used to rasterise fonts on Windows instead 
of T2K or GDI and I for one am pleased about this. However, no matter what I do 
I just can't get JavaFX text to be rendered as crisply or as "black" as I see 
in native Windows apps that also use DirectWrite. The result is that my app 
undesirably "stands out" from a native app.

What could be the cause of this? I saw that DirectWrite provides several 
options for rendering text and that currently only the default one is being 
applied so could it have something to do with this?

Is work being done to reduce the differential between JavaFX text rendering 
quality and that of native Windows apps?

2) I appreciated the explanation relating to LCD text in Canvas and the issue 
with the Canvas initially bring a transparent surface making later blending 
with an actual background problematic leading to greyscale support only.

Given that many of us see this as a very serious impediment to developing 
complex controls that use Canvas, is there a focus within the JFX team on 
finding a way of supporting LCD text in Canvas and if so, which JFX version is 
likely to first include this support?

Thanks again for a great talk and for all the hard work you have put into 
improving text rendering in JavaFX :-)

-jct




hg: openjfx/8u-dev/rt: RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order

2014-08-18 Thread martin . sladecek
Changeset: 14219b05f178
Author:Martin Sladecek 
Date:  2014-08-18 10:03 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/14219b05f178

RT-38221 [LineChart] Javafx 8 Line Chart does not plot data in order
Reviewed by: snothov, kcr

! modules/controls/src/main/java/javafx/scene/chart/LineChart.java