https://bugs.openjdk.java.net/browse/JDK-8216377
https://github.com/javafxports/openjdk-jfx/pull/342
Florian Kirmaier
ll/357
Florian Kirmaier
Hello,
Please review this fix for "Poor printing quality"
Ticket: https://github.com/javafxports/openjdk-jfx/issues/379
Pull Request: https://github.com/javafxports/openjdk-jfx/pull/577
Florian Kirmaier
Hello,
Please review this fix for "Multiple press event when JFXPanel gains focus.
Ticket: https://bugs.openjdk.java.net/browse/JDK-8087914
Pull Request: https://github.com/javafxports/openjdk-jfx/pull/591
Florian Kirmaier
from JPro <https://www.jpro.one>
The pull request has been updated with additional changes.
Added commits:
- 5cd96a56: JDK-8200224
Changes:
- all: https://git.openjdk.java.net/jfx/pull/25/files
- new: https://git.openjdk.java.net/jfx/pull/25/files/85c87628..5cd96a56
Webrevs:
- full:
On Wed, 6 Nov 2019 08:30:47 GMT, Kevin Rushforth wrote:
> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier
> wrote:
>
>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
>>
>> A side effect of JDK-8200224 is, that the first click on a JFXPanel i
On Wed, 6 Nov 2019 08:30:47 GMT, Kevin Rushforth wrote:
> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier
> wrote:
>
>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
>>
>> A side effect of JDK-8200224 is, that the first click on a JFXPanel i
The pull request has been updated with additional changes.
Added commits:
- 85c87628: JDK-8200224
Changes:
- all: https://git.openjdk.java.net/jfx/pull/25/files
- new: https://git.openjdk.java.net/jfx/pull/25/files/314e423c..85c87628
Webrevs:
- full:
Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
A side effect of JDK-8200224 is, that the first click on a JFXPanel is always a
double click.
The cause for JDK-8200224 is the fix for JDK-8087914 (Clicking on Menu in
JFXPanel ignored if another swing component has focus).
This
On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote:
> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote:
>
>> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier
>> wrote:
>>
>>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
>
On Tue, 29 Oct 2019 15:59:58 GMT, Kevin Rushforth wrote:
> On Tue, 29 Oct 2019 15:48:46 GMT, Florian Kirmaier
> wrote:
>
>> On Tue, 29 Oct 2019 14:47:19 GMT, Kevin Rushforth wrote:
>>
>>> On Tue, 29 Oct 2019 14:45:46 GMT, Kevin Rushforth wrote:
>>>
On Wed, 13 Nov 2019 21:53:13 GMT, Kevin Rushforth wrote:
> On Tue, 12 Nov 2019 10:23:16 GMT, Florian Kirmaier
> wrote:
>
>> The pull request has been updated with additional changes.
>>
>>
>>
>> Added commits:
>> - 5cd96a56:
The pull request has been updated with a complete new set of changes (possibly
due to a rebase).
Commits:
- 44774dfb: JDK-8200224
- d1309fb6: JDK-8200224
- 53a66b8f: JDK-8200224
- 0be3cb5b: JDK-8200224
- 03b59288: Merge branch 'master' of https://github.com/openjdk/jfx
On Tue, 26 Nov 2019 09:24:01 GMT, Kevin Rushforth wrote:
> On Tue, 26 Nov 2019 09:23:58 GMT, Florian Kirmaier
> wrote:
>
>> The pull request has been updated with a complete new set of changes
>> (possibly due to a rebase).
>>
>>
>>
On Tue, 26 Nov 2019 09:24:01 GMT, Kevin Rushforth wrote:
> On Tue, 29 Oct 2019 11:27:35 GMT, Florian Kirmaier
> wrote:
>
>> Original PR: https://github.com/javafxports/openjdk-jfx/pull/591
>>
>> A side effect of JDK-8200224 is, that the first click on a JFXPanel i
The pull request has been updated with additional changes.
Added commits:
- 24385eb8: JDK-8200224
- e0829ad3: JDK-8200224
- c190384f: JDK-8200224
- 17b458b1: JDK-8200224
Changes:
- all: https://git.openjdk.java.net/jfx/pull/25/files
- new:
On Wed, 27 Nov 2019 15:13:33 GMT, Kevin Rushforth wrote:
> On Wed, 27 Nov 2019 05:31:27 GMT, Prasanta Sadhukhan
> wrote:
>
>> On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier
>> wrote:
>>
>>> The pull request has
The pull request has been updated with additional changes.
Added commits:
- fa465c55: JDK-8200224
Changes:
- all: https://git.openjdk.java.net/jfx/pull/25/files
- new: https://git.openjdk.java.net/jfx/pull/25/files/24385eb8..fa465c55
Webrevs:
- full:
On Thu, 19 Dec 2019 13:47:14 GMT, Jeanette Winzenburg
wrote:
>> no way, afaik - there had been debates when the api was added somewhere in
>> jbs, don't recall exactly where
>
> here's where it was added: https://bugs.openjdk.java.net/browse/JDK-8151617
I don't see an API in the discussion,
> Hi everyone,
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
>
> The unit-test for the fix is a bit more complicated.
>
> I added a library JMemoryBuddy
On Thu, 19 Dec 2019 14:01:08 GMT, Jeanette Winzenburg
wrote:
>> Yes, that doesn't make a lot of sense. It's probably an artifact because I
>> expected a different API do unregister the listener. I'm gonna change it
>> back!
>
> just thinking aloud: actually, it's rather whacky that the
On Thu, 19 Dec 2019 15:33:09 GMT, Jeanette Winzenburg
wrote:
>> Florian, basically it's a single class isn't it? If so, it might be
>> acceptable to add that class to the test.xx.infrastructure package (don't
>> know if doing so would require a jbs issue)
>
> for now, you could have a look
On Thu, 19 Dec 2019 13:23:25 GMT, Jeanette Winzenburg
wrote:
>> Hi everyone,
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>>
>> The fix itself is quite straight forward.
>> It basically just removed the listener which causes the leak.
>>
>> The unit-test for the fix is a
On Thu, 19 Dec 2019 13:28:07 GMT, Jeanette Winzenburg
wrote:
>> Hi everyone,
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>>
>> The fix itself is quite straight forward.
>> It basically just removed the listener which causes the leak.
>>
>> The unit-test for the fix is a
On Thu, 19 Dec 2019 15:12:01 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> I haven't looked at the fix itself, but there are two things that _must_ be
> fixed before this PR can be considered:
> 1. You need to remove the additional 3rd-party
On Thu, 19 Dec 2019 19:59:07 GMT, David Grieve wrote:
>> Yes, exactly.
>>
>> @FlorianKirmaier Proposing to add test class to the test infrastructure
>> would be a reasonable alternative to pulling it in as a third-party
>> dependency. I recommend separating it out into its own enhancement,
On Thu, 19 Dec 2019 22:22:55 GMT, Florian Kirmaier
wrote:
>> I would urge caution about incorporating JMemoryBuddy without seeking out
>> advice from GC experts. I have my doubts that it will work reliably given
>> its reliance on System.gc(). (Opinion is my own,
could solve it differently.
Florian Kirmaier
Hi everyone,
ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
The fix itself is quite straight forward.
It basically just removed the listener which causes the leak.
The unit-test for the fix is a bit more complicated.
I added a library JMemoryBuddy
> Hi everyone,
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
>
> The unit-test for the fix is a bit more complicated.
>
> I added a library JMemoryBuddy
On Tue, 4 Feb 2020 23:19:17 GMT, Kevin Rushforth wrote:
>> A little bit late ...
>> I have now removed unit-test and it's dependency.
>> I will add a ticket about adding them again.
>
> Rather than removing the test, I was suggesting that you create a test for
> memory leaks using the same ad
On Mon, 2 Mar 2020 10:59:12 GMT, Jeanette Winzenburg
wrote:
>> I've now readded the unit-test. It based on the "InitialNodesMemoryLeakTest".
>>
>> Command to execute: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true
>> :systemTests:test --tests
>>
> Hi everyone,
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259
>
> The fix itself is quite straight forward.
> It basically just removed the listener which causes the leak.
>
> The unit-test for the fix is a bit more complicated.
>
> I added a library JMemoryBuddy
On Mon, 6 Jan 2020 23:05:13 GMT, Kevin Rushforth wrote:
>> I agree. Static analysis tools are quite limited in this regard, and are in
>> now way a substitute for regression testing.
>>
>> So the question is how best to test fixes for memory leaks at runtime. Our
>> current approach can be
On Thu, 19 Dec 2019 15:09:02 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> build.gradle line 2514:
>
>> 2513: compile project(':graphics')
>> 2514: testCompile "de.sandec:JMemoryBuddy:0.1.3"
>> 2515: }
>
> This is a new
On Thu, 19 Dec 2019 15:10:32 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Parent.java line 1929:
>
>> 1928: */
>> 1929: public List test_getRemoved() {
>> 1930: return removed;
tests.
> It makes testing for memory-leaks readably and reliable.
> It would also be possible to just copy the code of the library into the
> JavaFX-codebase.
> It only contains a single class.
>
> I also had to make a method public, to write the test. I'm open to ideas, how
&
On Wed, 11 Mar 2020 12:38:48 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8200224
>> cleaned up code based on code review
>
> tests/system/src
tests.
> It makes testing for memory-leaks readably and reliable.
> It would also be possible to just copy the code of the library into the
> JavaFX-codebase.
> It only contains a single class.
>
> I also had to make a method public, to write the test. I'm open to ideas, how
&
On Thu, 5 Mar 2020 22:11:26 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
> tests/sy
On Thu, 5 Mar 2020 22:19:45 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
> The
On Thu, 5 Mar 2020 22:15:07 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8236259
>> readded unit-test without any dependency
>
> tests/sy
tests.
> It makes testing for memory-leaks readably and reliable.
> It would also be possible to just copy the code of the library into the
> JavaFX-codebase.
> It only contains a single class.
>
> I also had to make a method public, to write the test. I'm open to ideas, how
&
Hi everyone,
I can't see any tags in the GitHub project for the various releases of
JavaFX.
I would like to know which commit is the base for various releases.
Specifically, I'm interested in the version 14 and 15-ea3.
Is there a place where I can look it up?
Thanks,
Florian Kirmaier
+OpenJFX
Greetings Florian Kirmaier
On Tue, 7 Apr 2020 09:44:34 GMT, Ambarish Rapte wrote:
>> Closed focused Stages are not collected with Monocle
>>
>> This commit adds a unit-test and a fix for collecting focused closed stages.
>>
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
>
>
On Tue, 7 Apr 2020 09:51:18 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> Some code cleanups
>
> tests/system/src/test/java/test/java
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with one additiona
Closed focused Stages are not collected with Monocle
This commit adds a unit-test and a fix for collecting focused closed stages.
ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
-
Commit messages:
- fixing accidentally commited test
- cleanup
- JDK-8241840
Changes:
Hi everyone,
Here is my PR for the memory-leak I've reported some minutes ago.
PR: https://github.com/openjdk/jfx/pull/153
ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Greetings
Florian Kirmaier
On Mon, 27 Apr 2020 15:09:17 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
&
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with one additiona
On Fri, 17 Apr 2020 12:06:05 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> Some code cleanups
>
> modules/javafx.graphics/sr
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with one additiona
On Fri, 17 Apr 2020 12:50:50 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> Some code cleanups
>
> tests/system/src/test/java/test/java
On Fri, 17 Apr 2020 12:58:00 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> Some code cleanups
>
> Changes requested by arapte
On Thu, 16 Apr 2020 18:56:21 GMT, Ambarish Rapte wrote:
>> This version doesn't work for me.
>> With this change, I get the following error:
>> test.javafx.stage.FocusedWindowTest > testLeak FAILED
>> junit.framework.AssertionFailedError: Exceeded timeout limit of 1
>> msec
>>
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with one additiona
On Fri, 1 May 2020 15:05:26 GMT, Jesper Skov
wrote:
>> @FlorianKirmaier
>> Please integrate this PR by issuing `/integrate` command in a new comment.
>> After that one of us can sponsor it.
>
> @FlorianKirmaier did you want to persue a common shared in-tree GC testing
> facility?
>
>
Hi everyone,
as discussed in my older PR, I want to add some utility to test for memory
leaks.
Check out my PR for more details: https://github.com/openjdk/jfx/pull/204
Greetings
Florian Kirmaier
It's based on the discussion of my previous PR:
https://github.com/openjdk/jfx/pull/71
I Added test utility class copied from JMemoryBuddy and used it to simplify 4
of the existing unit tests.
It's a direct copy of my project
[JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy) without any
itself is not stable but
> the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Added some javadoc to the testutility
Some methods/fields are now private
On Tue, 5 May 2020 10:57:23 GMT, Florian Kirmaier wrote:
>> I would suggest making everything configurable in the original library which
>> will be suggested here to be changed.
>> I will now add the possibility to make the creation of the heapDump
>> configurable, an
On Mon, 4 May 2020 14:24:48 GMT, Kevin Rushforth wrote:
>> It's based on the discussion of my previous PR:
>> https://github.com/openjdk/jfx/pull/71
>>
>> I Added test utility class copied from JMemoryBuddy and used it to simplify
>> 4 of the existing unit tests.
>>
>> It's a direct copy of
On Mon, 4 May 2020 13:47:58 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Updated JMemoeryBuddy
>> Added Copyright header
>&g
On Tue, 5 May 2020 10:38:56 GMT, Florian Kirmaier wrote:
>> I'll put this on my queue to review and test it. I left some high-level
>> comments below.
>
> I would suggest making everything configurable in the original library which
> will be suggested here to be chan
itself is not stable but
> the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Updated JMemoeryBuddy
Added Copyright header
disabled default heapdump
itself is not stable but
> the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Improved the JavaDoc for JMemoryBuddy
-
Changes:
- all: https://git.openjdk.jav
On Wed, 6 May 2020 23:20:42 GMT, Kevin Rushforth wrote:
>> Where/How should I add the documentation? Ideally, I would reference the
>> documentation of the project itself.
>
> A javadoc comment right before the class declaration is fine. It can be short.
Done
-
PR:
On Thu, 7 May 2020 16:58:52 GMT, Jesper Skov
wrote:
>> I've now added also some JavaDoc to the public methods.
>
> What I tried asking from my work account is: what is the purpose of
> createGarbage?
The createGarbage method stimulates the GC. All unit tests are green without
it, but
On Thu, 23 Jul 2020 17:44:14 GMT, Kevin Rushforth wrote:
>> Any news about this PR?
>
> Now that `jfx15` is pretty much done, we'll put this back on the queue to
> review.
Any news? I will probably soon have some PR which would like to use it for the
tests.
-
PR:
On Thu, 8 Oct 2020 07:47:33 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixed unit-test
>
> modules/javafx.base/src/test/java/test/u
On Thu, 8 Oct 2020 07:57:17 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixing some wrong imports
>
> I have reviewed only in pers
On Thu, 8 Oct 2020 07:50:02 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Fixed unit-test
>
> modules/javafx.base/src/test/java/tes
On Mon, 19 Oct 2020 18:26:43 GMT, Ambarish Rapte wrote:
>> Marked as reviewed by kcr (Lead).
>
> Reverting #153 seems right, I don't have any specific comments. Please go
> ahead and merge the change.
@johanvos @jperedadnr
A unit-test would be great, otherwise, it would be very hard to fix the
On Thu, 13 Aug 2020 12:37:11 GMT, Florian Kirmaier
wrote:
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
This pull reque
On Fri, 25 Sep 2020 07:07:07 GMT, Ambarish Rapte wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Improved the JavaDoc for JMemoryBuddy
>
> Tests fail t
itself is not stable but
> the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Fixing some wrong imports
-
Changes:
- all: https://git.openjdk.jav
itself is not stable but
> the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Fixed unit-test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/204/file
On Thu, 1 Oct 2020 17:29:34 GMT, Kevin Rushforth wrote:
>> Thanks, we'll review it now.
>>
>> Btw, we don't plan to hook up Travis, but instead will be looking at GitHub
>> actions now that the `jdk` project is using
>> them successfully.
>
> It looks like you are missing an import statement
On Mon, 26 Oct 2020 22:49:41 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Added some more whitespaces based on review
>
> modules
On Sat, 24 Oct 2020 18:57:27 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8244297
>> Updated JMemoryBuddy based on codereview.
>
> Just a
lf
> is not stable but the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
Added some more whitespaces based on review
-
Changes:
- all: https://git.openjdk
On Tue, 27 Oct 2020 20:40:23 GMT, Kevin Rushforth wrote:
>> I've added runFinalization followed with another System.gc (otherwise it
>> wouldn't make any difference)
>> I'm quite sure it's avoiding an error in the library, but I don't have a
>> unit-test for it yet.
>>
>> It's a tradeoff
lf
> is not stable but the tests with JMemoryBuddy are basically always correct.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8244297
more improvements based on code-review
-
Changes:
- all: https://git.openjdk.java.n
.
I've created a ticket for it:
https://bugs.openjdk.java.net/browse/JDK-8251472
Any opinions on the topic?
Greetings
Florian Kirmaier
> Closed focused Stages are not collected with Monocle
>
> This commit adds a unit-test and a fix for collecting focused closed stages.
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840
Florian Kirmaier has updated the pull request incrementally with three
additiona
Hi everyone,
Can someone look into my small fix for mac minimize?
https://github.com/openjdk/jfx/pull/280
Greetings Florian Kirmaier
ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
This small change fixing the minimize for mac.
Changes are property registered.
Calling setIconize(true) no longer resets to false.
-
Commit messages:
- JDK-8251241
Changes: https://git.openjdk.java.net/jfx/pull/280/files
On Thu, 13 Aug 2020 12:47:32 GMT, Kevin Rushforth wrote:
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>>
>> This small change fixing the minimize for mac.
>> Changes are property registered.
>> Calling setIconize(true) no longer resets to false.
>
>> JDK-8251241: macOS: iconify
On Thu, 13 Aug 2020 16:35:51 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
> mod
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additiona
On Thu, 13 Aug 2020 16:37:44 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8251241
>> Added missing spaces to match the coding style.
>
>
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241
>
> This small change fixing the minimize for mac.
> Changes are property registered.
> Calling setIconize(true) no longer resets to false.
Florian Kirmaier has updated the pull request incrementally with one additiona
On Fri, 7 Aug 2020 20:39:56 GMT, Kevin Rushforth wrote:
>> As mentioned - I don't have a good setup to test this code on Windows.
>>
>> But I've checked where focusedWindow/getFocusedWindow is used, and I can
>> verify your assumption. I've searched through
>> the whole project and the
On Thu, 13 Aug 2020 19:21:56 GMT, Kevin Rushforth wrote:
>> You may have seen my comment in JBS: This PR also fixes
>> [JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I
>> discovered while testing
>> [JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This
On Fri, 7 Aug 2020 21:38:27 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> Fixing exception when clicking on JFXPanel when no Scene is set.
>
> quick test: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests: test
> --tests *javafx.embed.swing.JFXPan* --info`
>
> It's a regression from my previous PR: https://github.com/openjdk/jfx/pull/25
On Thu, 11 Jun 2020 23:37:40 GMT, Kevin Rushforth wrote:
>> The fix looks correct to me (I haven't tested it yet). I left a minor
>> comment inline.
>
> The fix and test both look good. Approved pending the minor format change (no
> need for a second reviewer).
Great, I've added the requested
On Thu, 11 Jun 2020 00:32:34 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8247163:
>> Added space based on code review
>
> modules/javafx.sw
1 - 100 of 294 matches
Mail list logo
