Re: RFR: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568 [v2]

2021-05-17 Thread Kevin Rushforth
On Mon, 17 May 2021 19:35:09 GMT, Ambarish Rapte wrote: >> Issue: >> When css file is added to a `Scene.getStylesheets()` of a Scene which has >> few controls in addition to a Label then css style of a different control >> gets applied to Label after Stage is hidden and shown. This is a

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte wrote: > The test fails intermittently on github build. But I do not observe this > issue locally on my Ubuntu20.04 VM. > I am suspecting that the reason of failure is that the test are not cleaned > up correctly. The changes in this PR cleans

Re: RFR: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568

2021-05-17 Thread Kevin Rushforth
On Mon, 17 May 2021 08:30:26 GMT, Ambarish Rapte wrote: > Issue: > When css file is added to a `Scene.getStylesheets()` of a Scene which has few > controls in addition to a Label then css style of a different control gets > applied to Label after Stage is hidden and shown. This is a regression

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Mon, 17 May 2021 07:16:06 GMT, Ambarish Rapte wrote: > should we also include `root.getChildren().clear()` and `stage.hide()` calls ? I see no need for `root.getChildren().clear()`. I think all graphics unit tests that call `stage.show()` should call `stage.hide()` in a cleanup method, but

Integrated: 8267121: Illegal access to private "size" field of ArrayList from build.gradle

2021-05-17 Thread Kevin Rushforth
On Sat, 15 May 2021 12:42:56 GMT, Kevin Rushforth wrote: > A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug > in `build.gradle` in the `fetchExternalTools()` method. It checks the size of > an `ArrayList` in two places, but rather than calling the `size(

Re: RFR: 8266643: Intermittent failure of HonorDeveloperSettingsTest unit test

2021-05-17 Thread Kevin Rushforth
On Wed, 12 May 2021 11:53:16 GMT, Ambarish Rapte wrote: > The test fails intermittently on github build. But I do not observe this > issue locally on my Ubuntu20.04 VM. > I am suspecting that the reason of failure is that the test are not cleaned > up correctly. The changes in this PR cleans

RFR: 8267121: Illegal access to private "size" field of ArrayList from build.gradle

2021-05-15 Thread Kevin Rushforth
A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug in `build.gradle` in the `fetchExternalTools()` method. It checks the size of an `ArrayList` in two places, but rather than calling the `size()` method it omits the `()` which means it is accessing the private `size`

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-15 Thread Kevin Rushforth
On Fri, 14 May 2021 23:33:44 GMT, Scott Palmer wrote: > Isn't that just the settings for running the gradle wrapper - i.e.  it is not > setting the heap used by the gradle daemon process that will actually run the > build script? Ah yes, you are right. I just verified this with a test build.

Re: RFR: 8266860: [macos] Incorrect duration reported for HLS live streams

2021-05-15 Thread Kevin Rushforth
On Tue, 11 May 2021 23:43:36 GMT, Alexander Matveev wrote: > For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number > double value) and our code expects -1.0. Based on doc we should be using > CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using >

Re: RFR: 8266860: [macos] Incorrect duration reported for HLS live streams

2021-05-14 Thread Kevin Rushforth
On Tue, 11 May 2021 23:43:36 GMT, Alexander Matveev wrote: > For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number > double value) and our code expects -1.0. Based on doc we should be using > CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using >

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-14 Thread Kevin Rushforth
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-05-14 Thread Kevin Rushforth
On Fri, 14 May 2021 22:30:16 GMT, Michael Strauß wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >>

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]

2021-05-14 Thread Kevin Rushforth
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-05-14 Thread Kevin Rushforth
On Sat, 3 Apr 2021 15:20:41 GMT, Michael Strauß wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. >

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]

2021-05-14 Thread Kevin Rushforth
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Re: RFR: 8267160: Monocle mouse never get ENTERED state

2021-05-14 Thread Kevin Rushforth
On Fri, 14 May 2021 14:37:04 GMT, Johan Vos wrote: > allow to pass a fallback window in case the existing one is null (or can't be > computed). > > Fix for JDK-8267160 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/502

Re: RFR: 8267160: Monocle mouse never get ENTERED state

2021-05-14 Thread Kevin Rushforth
On Fri, 14 May 2021 15:55:48 GMT, Johan Vos wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MouseState.java >> line 94: >> >>> 92: */ >>> 93: MonocleWindow getWindow(boolean recalculateCache, MonocleWindow >>> fallback) { >>> 94: if (recalculateCache)

Re: RFR: 8267160: Monocle mouse never get ENTERED state

2021-05-14 Thread Kevin Rushforth
On Fri, 14 May 2021 14:37:04 GMT, Johan Vos wrote: > allow to pass a fallback window in case the existing one is null (or can't be > computed). > > Fix for JDK-8267160 I'm not sure I understand the fix. Questions inline.

Re: CFV: New OpenJFX Reviewer: Jeanette Winzenburg

2021-05-14 Thread Kevin Rushforth
Vote: YES -- Kevin On 5/14/2021 8:23 AM, Kevin Rushforth wrote: I hereby nominate Jeanette Winzenburg [1] to OpenJFX Reviewer.

Re: CFV: New OpenJFX Reviewer: Arun Joseph

2021-05-14 Thread Kevin Rushforth
Vote: YES -- Kevin On 5/14/2021 8:22 AM, Kevin Rushforth wrote: I hereby nominate Arun Joseph [1] to OpenJFX Reviewer.

CFV: New OpenJFX Reviewer: Jeanette Winzenburg

2021-05-14 Thread Kevin Rushforth
I hereby nominate Jeanette Winzenburg [1] to OpenJFX Reviewer. Jeanette is an OpenJFX community member, who has contributed 33 commits [2][3] to OpenJFX. Jeanette consistently participates in code reviews of various OpenJFX pull requests, specifically in the area of UI Controls. Votes are

CFV: New OpenJFX Reviewer: Arun Joseph

2021-05-14 Thread Kevin Rushforth
I hereby nominate Arun Joseph [1] to OpenJFX Reviewer. Arun is a member of JavaFX team at Oracle, who has contributed 41 commits [2][3][4] to OpenJFX. Arun often participates in code reviews of various OpenJFX pull requests. Votes are due by May 28, 2021 at 16:00 UTC. Only current OpenJFX

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces

2021-05-13 Thread Kevin Rushforth
On Thu, 13 May 2021 00:07:15 GMT, Michael Strauß wrote: > This PR fixes an issue when building OpenJFX on Windows and command-line > arguments contain paths with spaces. > > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to > quotes being interpreted twice. This can

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-13 Thread Kevin Rushforth
; > > The following changes were done for > [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760) to update to > gradle 7.0.1: > > 1. Ran `bash ./gradlew wrapper --gradle-version=7.0.1` > 2. Updated the gradle version in `build.properties` to `7.0.1` > 3. Update

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-13 Thread Kevin Rushforth
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth wrote: > This PR fixes the gradle deprecation warnings described in > [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates > the JavaFX build to use gradle 7.0.1 as described in > [JDK-82

Re: [External] : Re: Convenience factories for Border and Background

2021-05-13 Thread Kevin Rushforth
No, I don't like this option at all. This would just duplicate a lot of API methods that would end up delegating to Color. And it would be much worse to duplicate the color constants. This just doesn't seem like a clean API approach. -- Kevin On 5/13/2021 8:41 AM, Michael Strauß wrote:

Re: RFR: 8266516: One label typo in the properties for bi-directional text

2021-05-13 Thread Kevin Rushforth
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote: > A typo in one of the labels of Bidi text has been corrected. This is located > in Samples > Controls > Text > Bidi Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/500

Re: RFR: 8266516: One label typo in the properties for bi-directional text

2021-05-13 Thread Kevin Rushforth
On Thu, 13 May 2021 09:21:10 GMT, Manukumar V S wrote: > A typo in one of the labels of Bidi text has been corrected. This is located > in Samples > Controls > Text > Bidi @manukumarvs since you have an entry in the [OpenJDK Census](https://openjdk.java.net/census#mvs), you can instead file a

Re: RFR: 8264138: Replace uses of Class.newInstance [v3]

2021-05-13 Thread Kevin Rushforth
On Thu, 13 May 2021 10:57:17 GMT, Ajit Ghaisas wrote: >> This PR replaces Class.newInstance() deprecated method with >> Contructor.newinstance(). > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix review comments Marked

Re: RFR: 8264138: Replace uses of Class.newInstance [v2]

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 15:20:28 GMT, Ajit Ghaisas wrote: >> This PR replaces Class.newInstance() deprecated method with >> Contructor.newinstance(). > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix apps and unit tests I

Re: RFR: 8266968: Ignore test.com.sun.webkit.LocalStorageAccessTest

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 13:18:25 GMT, Arun Joseph wrote: > The system test test.com.sun.webkit.LocalStorageAccessTest fails on Windows > as mentioned in > [JDK-8265661](https://bugs.openjdk.java.net/browse/JDK-8265661). We should > skip this test until it is fixed. Marked as reviewed by kcr

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 17:30:20 GMT, Crazyjavahacking wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >>

RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
This PR fixes the gradle deprecation warnings described in [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates the JavaFX build to use gradle 7.0.1 as described in [JDK-8263760](https://bugs.openjdk.java.net/browse/JDK-8263760). The minimum version of gradle is set to

Re: RFR: 8263760: Update gradle to version 7.0.1

2021-05-12 Thread Kevin Rushforth
On Wed, 12 May 2021 17:02:27 GMT, Crazyjavahacking wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >>

Integrated: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-11 Thread Kevin Rushforth
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI builds).

Re: RFR: 8266919: Gradle verification fails on windows x86

2021-05-11 Thread Kevin Rushforth
On Tue, 11 May 2021 14:30:08 GMT, Joeri Sykora wrote: > This pull request fixes gradle verification failures when building JavaFX > with a Windows 32-bit JDK. Marked as reviewed by kcr (Lead). That's up to you. If you think it would help, go ahead. - PR:

Re: Build error with gradle (command line)

2021-05-11 Thread Kevin Rushforth
oo-distant-past so that the current checksums don't match those previously cached pom files. -- Kevin On 5/11/2021 4:36 AM, Kevin Rushforth wrote: We've had a couple other reports about this. The solutions that you can try (should only be needed one time) are: 1. gradle --refresh-dependenc

Re: Build error with gradle (command line)

2021-05-11 Thread Kevin Rushforth
We've had a couple other reports about this. The solutions that you can try (should only be needed one time) are: 1. gradle --refresh-dependencies ... 2. Remove the gradle cache before building:     cd $USERPROFILE/.gradle     rm -rf caches native     gradle ... If this doesn't work, I will

[jfx11u] Integrated: 8264928: Update to Xcode 12.4

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:47:44 GMT, Kevin Rushforth wrote: > Almost clean backport to jfx11u (clean except for surrounding context in > `build.properties`). Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushfo

[jfx11u] Integrated: 8262276: Debug build of WebKit fails

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:44:46 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits

[jfx11u] Integrated: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:44:16 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits

[jfx11u] Integrated: 8264990: WebEngine crashes with segfault when not loaded through system classloader

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:43:36 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits

[jfx11u] Integrated: 8259356: MediaPlayer's seek freezes video

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:42:42 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits

[jfx11u] Integrated: 8259555: Webkit crashes on Apple Silicon

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:42:09 GMT, Kevin Rushforth wrote: > Clean backport to jfx11u. Tested on all three platforms, along with my other > in-progress backports, all of which are aggregated in my > [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits

[jfx11u] Integrated: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-05-10 Thread Kevin Rushforth
On Sat, 8 May 2021 15:41:06 GMT, Kevin Rushforth wrote: > This is a mostly-clean backport to jfx11u. The only merge conflicts I had to > fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the > static library support is not present in 11 (this is the exact sam

Re: [jfx11u] RFR: 8204568: Relative CSS-Attributes don't work all time

2021-05-08 Thread Kevin Rushforth
On Fri, 7 May 2021 11:10:41 GMT, Ambarish Rapte wrote: > Backport had a minor merge conflict of copyright year in the file > `Labeled.java`. > Rest of the changes are clean backport Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/6

[jfx11u] RFR: 8264928: Update to Xcode 12.4

2021-05-08 Thread Kevin Rushforth
Almost clean backport to jfx11u (clean except for surrounding context in `build.properties`). Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my

[jfx11u] RFR: 8264990: WebEngine crashes with segfault when not loaded through system classloader

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8264990:

[jfx11u] RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8263788:

[jfx11u] RFR: 8259356: MediaPlayer's seek freezes video

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8259356:

[jfx11u] RFR: 8259555: Webkit crashes on Apple Silicon

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8259555:

[jfx11u] RFR: 8262276: Debug build of WebKit fails

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8262276: Debug

[jfx11u] RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-05-08 Thread Kevin Rushforth
This is a mostly-clean backport to jfx11u. The only merge conflicts I had to fix were in `D3DPipeline.cc` to ignore two hunks from the patch, since the static library support is not present in 11 (this is the exact same thing I had to do for the FX 8u backport). Tested on all three platforms,

RFR: 8264219: tools/scripts/build.ps1 is out of date and no longer works

2021-05-08 Thread Kevin Rushforth
As noted in PR #212 the unused `tools/scripts/build.ps1` script no longer works. This script was added in support of the Appveyor builds in the old `javafxports/openjdk-jfx` sandbox repo, which haven't been used in nearly two years. In its current state, it is more harmful to leave it in, as it

Re: [jfx11u] RFR: 8240539: Upgrade gradle to version 6.3

2021-05-07 Thread Kevin Rushforth
On Fri, 7 May 2021 14:35:48 GMT, Ambarish Rapte wrote: > jfx11u uses gradle 5.3 for build, it needs to be upgraded to gradle 6.3 same > as jfx mainline. > This PR backports three fixes: > > 1. [JDK-8240539](https://bugs.openjdk.java.net/browse/JDK-8240539): Upgrade > gradle to version 6.3 >

Re: RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-07 Thread Kevin Rushforth
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI buil

RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-07 Thread Kevin Rushforth
As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip bundle for javadoc offline processing. This missing entry is causing a build failure on my system (which will soon propagate to our CI builds). - Commit messages: - 8266757: Add entry for

Re: RFR: JDK-8266396: Add VSCMD_DEBUG for solving WINSDK_DIR build error

2021-05-07 Thread Kevin Rushforth
On Thu, 6 May 2021 20:39:11 GMT, John Neffenger wrote: > The Windows build calls a series of batch files to get the Visual Studio > paths and environment variables. The batch files are a black box: any > messages they print are discarded. If anything goes wrong, the only signs are > a vague

Integrated: 8262396: Update Mesa 3-D Headers to version 21.0.3

2021-05-06 Thread Kevin Rushforth
On Wed, 5 May 2021 13:45:39 GMT, Kevin Rushforth wrote: > Update OpenGL headers to latest versions from Mesa project. I ran a sanity > test on all three platforms. I also checked the diffs against the Java2D > patch in openjdk/jdk#3854 and they match, excluding the Java2D-specific

[jfx11u] Integrated: 8263169: [macos] JavaFX windows open as tabs when system preference for documents is set

2021-05-06 Thread Kevin Rushforth
On Wed, 5 May 2021 21:01:26 GMT, Kevin Rushforth wrote: > Clean backport of macOS tabbed windows fix. Verified on Mac (the fix is > macOS-specific). This pull request has now been integrated. Changeset: 2808769f Author: Kevin Rushforth URL: https://git.openjdk.java.net/

Re: RFR: 8264157: Items of non-editable ComboBox cannot be selected using up/down keys

2021-05-06 Thread Kevin Rushforth
On Tue, 4 May 2021 12:29:54 GMT, Ambarish Rapte wrote: > This issue [JDK-8264157](https://bugs.openjdk.java.net/browse/JDK-8264157) is > a regression of > [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788), which > removed two KeyMappings from `ComboBoxListViewBehavior`. That

Re: RFR: 8265277: SkinBase::registerChangeListener​ missing '@since 9' javadoc tag

2021-05-06 Thread Kevin Rushforth
On Thu, 6 May 2021 10:22:13 GMT, Ajit Ghaisas wrote: > Please review a very simple fix that adds a missing javadoc tag. Looks good. Unrelated to your change, I see the following failure in the GitHub Actions test run on Linux: 2021-05-06T10:27:19.6546656Z

[jfx11u] RFR: 8263169: [macos] JavaFX windows open as tabs when system preference for documents is set

2021-05-05 Thread Kevin Rushforth
Clean backport of macOS tabbed windows fix. Verified on Mac (the fix is macOS-specific). - Commit messages: - 8263169: [macos] JavaFX windows open as tabs when system preference for documents is set Changes: https://git.openjdk.java.net/jfx11u/pull/5/files Webrev:

[jfx11u] Integrated: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

2021-05-05 Thread Kevin Rushforth
On Wed, 5 May 2021 16:12:36 GMT, Kevin Rushforth wrote: > This is the backport of a small enhancement to add a query for CAPS_LOCK and > NUM_LOCK to jfx11u. > > The jfx mainline patch applied cleanly except for one conflict in an import > statement which had to be manually r

[jfx11u] Integrated: 8260245: Update ICU4C to version 68.2

2021-05-05 Thread Kevin Rushforth
On Wed, 5 May 2021 12:00:25 GMT, Kevin Rushforth wrote: > Backport ICU update from jfx mainline to jfx11u. The backport was clean > except for a minor diff in the surrounding context in `build.gradle`. I ran a > sanity test on Windows (I'll test on other two platforms before in

Re: [jfx11u] RFR: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

2021-05-05 Thread Kevin Rushforth
On Wed, 5 May 2021 16:12:36 GMT, Kevin Rushforth wrote: > This is the backport of a small enhancement to add a query for CAPS_LOCK and > NUM_LOCK to jfx11u. > > The jfx mainline patch applied cleanly except for one conflict in an import > statement which had to be manually r

[jfx11u] RFR: 8259680: Need API to query states of CAPS LOCK and NUM LOCK keys

2021-05-05 Thread Kevin Rushforth
This is the backport of a small enhancement to add a query for CAPS_LOCK and NUM_LOCK to jfx11u. The jfx mainline patch applied cleanly except for one conflict in an import statement which had to be manually resolved. I also needed to subsequently modify the `@since` tag in the new API method

[jfx11u] Integrated: 8262366: Update glib to version 2.66.7

2021-05-05 Thread Kevin Rushforth
On Wed, 5 May 2021 11:57:06 GMT, Kevin Rushforth wrote: > Backport glib / gstreamer update from jfx mainline to jfx11u. The backport > applied cleanly, and I ran a sanity test on Windows (I'll test on other two > platforms before integrating). This pull request has now been i

RFR: 8262396: Update Mesa 3-D Headers to version 21.0.3

2021-05-05 Thread Kevin Rushforth
Update OpenGL headers to latest versions from Mesa project. I ran a sanity test on all three platforms. I also checked the diffs against the Java2D patch in openjdk/jdk#3854 and they match, excluding the Java2D-specific ifdefs. - Commit messages: - 8262396: Update Mesa 3-D Headers

[jfx11u] RFR: 8260245: Update ICU4C to version 68.2

2021-05-05 Thread Kevin Rushforth
Backport ICU update from jfx mainline to jfx11u. The backport was clean except for a minor diff in the surrounding context in `build.gradle`. I ran a sanity test on Windows (I'll test on other two platforms before integrating). - Commit messages: - 8260245: Update ICU4C to version

[jfx11u] RFR: 8262366: Update glib to version 2.66.7

2021-05-05 Thread Kevin Rushforth
Backport glib / gstreamer update from jfx mainline to jfx11u. The backport applied cleanly, and I ran a sanity test on Windows (I'll test on other two platforms before integrating). - Commit messages: - 8262366: Update glib to version 2.66.7 Changes:

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-04 Thread Kevin Rushforth
On Tue, 4 May 2021 13:51:01 GMT, Ambarish Rapte wrote: > I was suggesting to close JDK-8189228 because the three issues that are > currently listed in JDK-8189228 are not reproducible with or without this PR. > We can file a new bug for the NPE that I noticed with TreeView. Good idea. Can you

Re: Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread Kevin Rushforth
Hi, We've discussed adding image reading and writing functionality in the past. Something on the order of Java2D's Image I/O. Doing it right would be a large project, and would be more than just adding a couple methods to JavaFX Image. Unless and until we do that, using the SwingFXUtils to

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-05-03 Thread Kevin Rushforth
On Tue, 27 Apr 2021 19:18:59 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Integrated: 8265399: Update to Visual Studio 2019 version 16.9.3

2021-04-30 Thread Kevin Rushforth
On Tue, 27 Apr 2021 21:33:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2019 version 16.9.3 on > Windows, in order to match JDK 17 -- see > [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). > > I ran a full build and test,

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH [v2]

2021-04-30 Thread Kevin Rushforth
On Fri, 30 Apr 2021 00:10:30 GMT, John Neffenger wrote: >> This is a continuation of the [pull request][1] started by @bmwiedemann in >> January 2020. After this change is integrated, I can follow up immediately >> with additional pull requests that get us much closer to providing fully >>

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-30 Thread Kevin Rushforth
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 23:52:30 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-04-30 Thread Kevin Rushforth
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as t

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-30 Thread Kevin Rushforth
On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a

Re: RFR: 8264998: Empty Jars shouldn't have Automatic-Module-Name

2021-04-30 Thread Kevin Rushforth
On Fri, 30 Apr 2021 08:42:14 GMT, Abhinay Agarwal wrote: > 8264998: Empty Jars shouldn't have Automatic-Module-Name Looks good. Pending review from either @johanvos or @tiainen - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/484

Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-29 Thread Kevin Rushforth
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-29 Thread Kevin Rushforth
On Sat, 17 Apr 2021 23:17:04 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-29 Thread Kevin Rushforth
R #481 out for review to update the Linux gcc compiler. I > intend to integrate that one first, at which time I will need to merge > `master` into this branch to resolve a trivial merge conflict (the changes > are on adjacent lines). Kevin Rushforth has updated the pull request with a n

Re: RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Kevin Rushforth
On Thu, 29 Apr 2021 12:59:01 GMT, Johan Vos wrote: > the entry says "gcc10.3.0-OL6.4+1.0" but I tested using the gcc10.3.0 on > Ubuntu (18.04) Yeah, the "OL6.4" part is just the name of the devkit (generated for the JDK builds), since that was their baseline. You can see it in the JDK 17

Integrated: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Kevin Rushforth
On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. This

Re: [jfx11u] RFR: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Kevin Rushforth
On Thu, 29 Apr 2021 07:05:07 GMT, Johan Vos wrote: > Increase security release number for JavaFX 11 to 11.0.12 > Fix for JDK-8265703 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/1

Re: JavaFX 11 updates moving to GitHub on Wed, Apr 28

2021-04-28 Thread Kevin Rushforth
This transition is now complete. The jfx11u repo on GitHub is now active, and the openjfx/11-dev/rt Mercurial repo is now read-only. -- Kevin On 4/21/2021 3:15 PM, Kevin Rushforth wrote: The JavaFX 11 updates repo is moving from HG to GIT on Wednesday, April 28, and will be hosted on GitHub

Re: JavaFX 16 requires Visual C++ 2019 Redistributable on Windows?

2021-04-28 Thread Kevin Rushforth
Yes, JavaFX 16 uses VS 2019, but those libraries should be distributed as part of the JavaFX 16 bundle. It's possible we have a bug in NaativeLibLoader where they are not getting loaded. -- Kevin On 4/28/2021 6:46 AM, thevenet.f...@free.fr wrote: Hi, I am facing an issue where, after

RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2021-04-27 Thread Kevin Rushforth
This patch updates the compiler to Visual Studio 2019 version 16.9.3 on Windows, in order to match JDK 17 -- see [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). I ran a full build and test, including media and WebKit. NOTE: I also have PR #481 out for review to update the

RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-27 Thread Kevin Rushforth
This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). I ran a full build and test, including media and WebKit. - Commit messages: - 8265400: Update to gcc 10.3 on Linux Changes:

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-27 Thread Kevin Rushforth
On Sat, 17 Apr 2021 23:17:04 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v4]

2021-04-27 Thread Kevin Rushforth
On Sun, 25 Apr 2021 21:40:00 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-27 Thread Kevin Rushforth
On Tue, 27 Apr 2021 12:24:54 GMT, Johan Vos wrote: > We do more experimental things in Monocle, but I think we simply need to get > this issue right. Yes, this is the better approach. If we proceed with this PR, we should make sure that what it does is valid and tested on all platforms. We

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-27 Thread Kevin Rushforth
On Sat, 17 Apr 2021 23:21:27 GMT, John Neffenger wrote: >> John Neffenger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add dependencies for internal builds at Oracle > > Thanks, Kevin. I added your list to the file and ran just the

Re: RFR: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2021-04-27 Thread Kevin Rushforth
On Fri, 19 Feb 2021 17:50:01 GMT, Alexander Scherbatiy wrote: > May be it has sense to add a drag event handler (which disarms the > corresponding button) to ButtonBehavior only if javafx.platform is set to > monocle to localize the fix only for Monocle? Or add a separate property and > set

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-27 Thread Kevin Rushforth
On Tue, 27 Apr 2021 02:09:54 GMT, Alexander Matveev wrote: >> Remote Desktop will change default audio device when connecting or >> disconnecting to it's own audio device. Also, when remote desktop is >> disconnect, then remote desktop default audio device is removed and system >> default

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v4]

2021-04-27 Thread Kevin Rushforth
On Sun, 11 Apr 2021 15:44:39 GMT, Florian Kirmaier wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263402 >> Minor cleanup based on codereview > > It shouldn't be platform-specific, > but maybe there are

  1   2   3   4   5   6   7   8   9   10   >