Re: Corrections for Javadoc

I missed seeing this comment so did not add it to JDK-8180070. Sorry about that. I filed a new bug for this one...currently it is assigned to 9, in case there is still time to get it fixed. https://bugs.openjdk.java.net/browse/JDK-8181169 -- Kevin Nir Lisker wrote: Looks like the above

Re: Corrections for Javadoc

Looks like the above didn't make it in time. Can it be fixed in the next batch? On Tue, May 23, 2017 at 9:26 PM, Nir Lisker wrote: > Hopefully this makes it in time: > > javafx.scene.control.TreeView has wrong javadoc for the > queryAccessibleAttribute method. The source code

Re: Corrections for Javadoc

Hopefully this makes it in time: javafx.scene.control.TreeView has wrong javadoc for the queryAccessibleAttribute method. The source code uses javadoc blocks as titles, but they should probably be regular comment blocks. One of those blocks has been read as the doc for the method because that

Re: Corrections for Javadoc

Yes, I saw that the due date on the report is the 24th. I don't know if it's worth anyone's time, but there are simple scripts that catch all sorts of spelling and grammar mistakes. Pretty sure it won't be that hard to integrate one.

Re: Corrections for Javadoc

Thanks. I'm a little surprised that doclint doesn't catch this one since it seems like it would be considered a malformed tag. As a note on timing, I plan to send out the webrev for this late this afternoon and push the changes on Thursday morning. -- Kevin Nir Lisker wrote: Another typo:

Re: Corrections for Javadoc

Another typo: In javafx.scene.Scene, all onDragDone methods and the property use "@{code Scene}" instead of "{@code Scene}". On Wed, May 10, 2017 at 7:25 PM, Kevin Rushforth wrote: > I just filed a new issue to catch any last minute typos: > >

Re: Corrections for Javadoc

I added it to the list. Thanks. -- Kevin Nir Lisker wrote: Another thing: javafx.scene.canvas.GraphicsContext should have a link to Canvas, either in the first sentence or as a @see, or both. On Fri, May 12, 2017 at 12:02 AM, Kevin Rushforth

Re: Corrections for Javadoc

Another thing: javafx.scene.canvas.GraphicsContext should have a link to Canvas, either in the first sentence or as a @see, or both. On Fri, May 12, 2017 at 12:02 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > Added. This is a questionable use of @see anyway. > > Thanks. > > --

Re: Corrections for Javadoc

Added. This is a questionable use of @see anyway. Thanks. -- Kevin Nir Lisker wrote: Add this to the list as well please: javafx.scene.image.Image's constructors: - Image(String url) - Image(String url, boolean backgroundLoading) - Image(String url, double requestedWidth, double

Re: Corrections for Javadoc

Add this to the list as well please: javafx.scene.image.Image's constructors: - Image(String url) - Image(String url, boolean backgroundLoading) - Image(String url, double requestedWidth, double requestedHeight, boolean preserveRatio, boolean smooth) all have a @see annotation pointing to a

Re: Corrections for Javadoc

I just filed a new issue to catch any last minute typos: https://bugs.openjdk.java.net/browse/JDK-8180070 I'll add your note to this new JBS bug. Thank you. -- Kevin Nir Lisker wrote: I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the

Corrections for Javadoc

I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". -