JavaFX 25 is in Rampdown Phase Two (RDP2)

2025-08-07 Thread Kevin Rushforth
To: JavaFX Developers As a reminder, JavaFX 25 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bug fixes, and test or doc fixes of any priority, can be fixed during RDP2. Explicit approval is needed for all bug fixes and enhancements (except for doc and test fixes) to go in to the jfx25 branch

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:36:49 GMT, Ziad El Midaoui wrote: >> Also, this will skip the test on all platforms. That might be a reasonable >> thing to do, but if that's what you propose, then please change the title >> (in JBS and the PR) to drop the "on Linux" part. > > The test is skipped on Mac b

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest on Linux

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 16:25:29 GMT, Andy Goryachev wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java > line 108: > >> 106: // On platforms other than Mac the menu bar should pro

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 15:34:52 GMT, Andy Goryachev wrote: > > How widespread are the cases of unused Java fields/methods/classes that are > > used in the native code? > > Probably a few cases. The main benefit is maintainability in the long run. WebKit is the main place where we do this. By conve

Re: RFR: 8360886: Cmd + plus shortcut does not work reliably [v2]

2025-08-07 Thread Kevin Rushforth
On Mon, 14 Jul 2025 18:26:34 GMT, Martin Fox wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reverted manual tests, added system test, changed check for fake >> performKeyEquivalent event. > > Heads up, I just submi

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 31 Jul 2025 15:05:20 GMT, Martin Fox wrote: >> This PR fixes numerous bugs in the handling of setMaximized() on macOS and >> also cleans up some issues seen when the user changes the maximized state >> manually. >> >> - After setMaximized(false) a notifyResize event was never sent so t

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 05:01:51 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-06 Thread Kevin Rushforth
On Wed, 6 Aug 2025 19:03:54 GMT, Martin Fox wrote: >> There is `Util::waitForIdle(scene, pulseCount)`. >> >> The real question is how to account for the platform-dependent transitions >> (which may take some time) reliably. Waiting for a set amount of time might >> work, but we have to pick a

Re: RFR: 8356982: Update WebKit to 622.1

2025-08-06 Thread Kevin Rushforth
On Wed, 6 Aug 2025 17:51:44 GMT, Hima Bindu Meda wrote: > This PR updates Webkit to v622.1. Verified sanity and build on Mac, Linux and > windows platforms. No issue seen. Reviewers: @kevinrushforth @jaybhaskar @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1865#issuecomm

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-06 Thread Kevin Rushforth
On Wed, 30 Jul 2025 21:39:37 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Cleaned up diff against master. Tighted up system test (tested on Windows >> and Linux) > > tests/system/src/test/java

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-06 Thread Kevin Rushforth
On Thu, 31 Jul 2025 15:05:20 GMT, Martin Fox wrote: >> This PR fixes numerous bugs in the handling of setMaximized() on macOS and >> also cleans up some issues seen when the user changes the maximized state >> manually. >> >> - After setMaximized(false) a notifyResize event was never sent so t

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v21]

2025-08-05 Thread Kevin Rushforth
On Tue, 5 Aug 2025 18:07:04 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v17]

2025-08-05 Thread Kevin Rushforth
On Tue, 5 Aug 2025 12:00:47 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLTexture.java line >> 149: >> >>> 147: for (int colIndex = 0; colIndex < rowStride; >>> colIndex += 3) { >>> 148: index = rowIndex + c

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v20]

2025-08-05 Thread Kevin Rushforth
On Tue, 5 Aug 2025 14:18:01 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8364687: Enable headless with -Dglass.platform=headless

2025-08-05 Thread Kevin Rushforth
On Tue, 5 Aug 2025 07:45:34 GMT, Clément de Tastes wrote: > Basically allow -Dglass.platform=headless to enable headless, not only > -Dglass.platform=Headless. > This makes it consistent with other options (macosx, windows, linux, gtk and > ios) as well was less error-prone for enabling it. Re

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v17]

2025-08-04 Thread Kevin Rushforth
On Mon, 4 Aug 2025 10:46:37 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v17]

2025-08-04 Thread Kevin Rushforth
On Mon, 4 Aug 2025 10:46:37 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 17:25:56 GMT, Andy Goryachev wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> kcr: review: crash regression fix > > modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLFBOTextureData.java

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 21:44:43 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> kcr: review: crash regression fix > > modules/javafx.graphics/src/main/java/com/sun/

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 17:09:58 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v15]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 17:09:58 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8359599: Calling refresh() for all virtualized controls recreates all cells instead of refreshing the cells

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 18:54:53 GMT, John Hendrikx wrote: > So although I agree that recreating is not needed as cell functionality is > defined by their `update` methods, I do think this then requires a CSR. I agree. - PR Comment: https://git.openjdk.org/jfx/pull/1830#issuecomment-31

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 15:52:35 GMT, Andy Goryachev wrote: >> Normally, this would be the right thing to do. However, it looks like >> switching the order has introduced several crashes. I discovered this today >> while testing the latest version of this PR. I bisected it and found out >> that thi

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-08-01 Thread Kevin Rushforth
On Fri, 18 Jul 2025 17:54:41 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/mtl/MTLResourceFactory.java >> line 396: >> >>> 394: public void dispose() { >>> 395: super.dispose(); >>> 396: context.dispose(); >> >> Q: should we call super.di

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v14]

2025-08-01 Thread Kevin Rushforth
On Fri, 1 Aug 2025 03:02:50 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v11]

2025-07-31 Thread Kevin Rushforth
On Wed, 30 Jul 2025 19:10:57 GMT, Andy Goryachev wrote: >> I just looked at which .java files are not on the classpath and pulled those >> source folders in: >> > src="https://github.com/user-attachments/assets/a81ef455-cc97-4b75-be96-cbd3de5bb266"; >> /> > > This issue is still unresolved: `Co

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size

2025-07-31 Thread Kevin Rushforth
On Wed, 30 Jul 2025 15:03:37 GMT, Kevin Rushforth wrote: > @beldenfox It might be better to close > [JDK-8179980](https://bugs.openjdk.org/browse/JDK-8179980) as a duplicate of > this bug (JDK-8355990) rather than add it as a separate issue, since it is a > natural step whe

Re: [jfx25] RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-31 Thread Kevin Rushforth
On Thu, 31 Jul 2025 19:27:51 GMT, Andy Goryachev wrote: > A clean backport of #1856 . > > This is a very localized fix for the issue described in > https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing > snapped and non-snapped values. The issue seems to happen only with >

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale [v4]

2025-07-31 Thread Kevin Rushforth
On Thu, 31 Jul 2025 16:02:05 GMT, Andy Goryachev wrote: >> This is a very localized fix for the issue described in >> https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing >> snapped and non-snapped values. The issue seems to happen only with >> fractional scale, that is,

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size

2025-07-30 Thread Kevin Rushforth
On Tue, 29 Jul 2025 14:45:36 GMT, Martin Fox wrote: > This PR fixes numerous bugs in the handling of setMaximized() on macOS and > also cleans up some issues seen when the user changes the maximized state > manually. > > - After setMaximized(false) a notifyResize event was never sent so the wi

Re: RFR: 8361648: Update Glib to 2.84.3

2025-07-29 Thread Kevin Rushforth
On Tue, 29 Jul 2025 21:02:20 GMT, Alexander Matveev wrote: > - GLib updated to 2.84.3. > - Tested on all platforms. > - No other changes are done. Reviewers: @arapte @tiainen - PR Comment: https://git.openjdk.org/jfx/pull/1862#issuecomment-3134231362

Re: [jfx25] RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Kevin Rushforth
On Tue, 29 Jul 2025 20:45:04 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar. OK for jfx25 - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1861#pullrequestreview-3069203061

Re: RFR: 8364088: ToolBarSkin: NPE in select()

2025-07-29 Thread Kevin Rushforth
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote: > Fixed an NPE in the ToolBar, looks like a corner case. How likely is this bug to occur? It's a safe enough fix that I don't object to backporting it if you think it's worth doing. As for the syntax, yes, you have it right.

Re: JDK24 WARNING: Please consider reporting this to the maintainers of class com.sun.marlin.OffHeapArray

2025-07-29 Thread Kevin Rushforth
Redirecting this to openjfx-dev which is a more relevant mailing list. -- Kevin On 7/29/2025 6:50 AM, Kevin Rushforth wrote: Thanks for the report. This has been fixed in JavaFX 25 by JDK-8334137 [1]. Thanks. -- Kevin [1] https://bugs.openjdk.org/browse/JDK-8334137 On 7/29/2025 6:06 AM

[jfx25u] Integrated: Merge jfx:jfx25

2025-07-29 Thread Kevin Rushforth
Clean merge of `jfx:jfx25` into `jfx25u:master`. - Commit messages: - Merge remote-tracking branch 'jfx/jfx25' into merge-jfx-jfx25-to-master-2025-07-29 - 8304008: Update README.md and CONTRIBUTING.md for jfx update repos - 8362896: Change JavaFX release version to 25.0.1 in jfx25

[jfx25u] Integrated: Merge jfx:jfx25

2025-07-29 Thread Kevin Rushforth
On Tue, 29 Jul 2025 12:42:41 GMT, Kevin Rushforth wrote: > Clean merge of `jfx:jfx25` into `jfx25u:master`. This pull request has now been integrated. Changeset: dd83b798 Author: Kevin Rushforth URL: https://git.openjdk.org/jfx25u/commit/dd83b798293680712eb28b42a6af44d105774

Re: RFR: 8364203: Ignore native mac tests on headless [v2]

2025-07-29 Thread Kevin Rushforth
On Tue, 29 Jul 2025 07:12:52 GMT, Johan Vos wrote: >> Add PlatformUtil.isHeadless() method. >> Use that in tests to conditionally skip tests. >> >> Fix JDK-8364203 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Exclude setup

Re: WARNING: A restricted method in java.lang.System has been called

2025-07-29 Thread Kevin Rushforth
This isn't a bug, but is the expected behavior of libraries or applications that use JNI or FFM native calls after JEP 472 [1]. Applications must now specify `--enable-native-access=`  as indicated in the JavaFX 24 release notes [2]. See JDK-8347744 [3] for more information. Failure to do so w

Re: RFR: 8351357: Add canary system test checking if Stage receives focus on show [v8]

2025-07-29 Thread Kevin Rushforth
On Tue, 29 Jul 2025 11:53:14 GMT, Lukasz Kostyra wrote: >> Originally this issue was supposed to resolve problems with some system >> tests (`MenuDoubleShortcutTest`, `TextAreaBehaviorTest` and others) failing >> on my Windows machine. In the process of figuring this out I found out the >> pro

Re: RFR: 8341286: TreeView: visual artifacts when setting new root with null value

2025-07-28 Thread Kevin Rushforth
On Mon, 30 Jun 2025 21:49:22 GMT, Ziad El Midaoui wrote: > Fix for phantom disclosure nodes appearing when root is null @Ziad-Mid Can you add an evaluation to this PR (you can add it to the Description)? This may indeed be the right fix, but a good evaluation should explain the problem and wh

Re: RFR: 8364203: ignore native mac tests on headless

2025-07-28 Thread Kevin Rushforth
On Mon, 28 Jul 2025 20:41:46 GMT, Johan Vos wrote: > Add PlatformUtil.isHeadless() method. > Use that in tests to conditionally skip tests. > > Fix JDK-8364203 This looks reasonable with one comment inline. Also, as noted by Skara, I recommend to capitalize the first letter of the title (both

Re: RFR: 8351357: Add canary system test checking if Stage receives focus on show [v7]

2025-07-28 Thread Kevin Rushforth
On Thu, 17 Jul 2025 09:18:42 GMT, Lukasz Kostyra wrote: >> Originally this issue was supposed to resolve problems with some system >> tests (`MenuDoubleShortcutTest`, `TextAreaBehaviorTest` and others) failing >> on my Windows machine. In the process of figuring this out I found out the >> pro

Re: RFR: 8324941: POC for Headless platform for JavaFX [v14]

2025-07-28 Thread Kevin Rushforth
On Mon, 28 Jul 2025 15:13:07 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8364049: ToolBar shows overflow menu with fractional scale

2025-07-28 Thread Kevin Rushforth
On Fri, 25 Jul 2025 17:13:30 GMT, Andy Goryachev wrote: > This is a very localized fix for the issue described in > https://bugs.openjdk.org/browse/JDK-8364049 which resulted from comparing > snapped and non-snapped values. The issue seems to happen only with > fractional scale, that is, on W

Re: RFR: 8324941: POC for Headless platform for JavaFX [v13]

2025-07-28 Thread Kevin Rushforth
On Mon, 28 Jul 2025 11:38:26 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8358092: Create accessibility protocol implementation that covers various type of menu items

2025-07-26 Thread Kevin Rushforth
On Fri, 25 Jul 2025 23:32:04 GMT, Alexander Zuev wrote: > Initial implementation. Note that second level menu navigation with the > non-system menus does not work but it was not working with the current > implementation so i am raising a new bug for tracking that but that can not > be a showst

Re: [jfx25] RFR: 8359601: Fix window button states of an extended stage

2025-07-26 Thread Kevin Rushforth
On Fri, 25 Jul 2025 13:10:03 GMT, Michael Strauß wrote: > 8359601: Fix window button states of an extended stage As noted in the mainline PR, this is a good fix to backport to jfx25. The backport is clean. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx

Re: RFR: 8324941: POC for Headless platform for JavaFX [v11]

2025-07-25 Thread Kevin Rushforth
On Tue, 22 Jul 2025 07:09:58 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-25 Thread Kevin Rushforth
On Mon, 7 Jul 2025 09:15:47 GMT, Johan Vos wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessRobot.java >> line 231: >> >>> 229: if (windows.isEmpty()) return null; >>> 230: if (windows.size() == 1) return (HeadlessWindow)windows.get(0); >>> 231:

Re: RFR: 8324941: POC for Headless platform for JavaFX [v11]

2025-07-25 Thread Kevin Rushforth
On Tue, 22 Jul 2025 07:09:58 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-07-25 Thread Kevin Rushforth
On Fri, 18 Jul 2025 19:26:10 GMT, Andy Goryachev wrote: > > Do you refer to the Node.snapshot()? > > In my case, it was Scene::snapshot(), but basically the question is where the > screen size has any effect? Robot? > > It does not seem to impact Scene::snapshot. The screen size is not releva

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-25 Thread Kevin Rushforth
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure out what we would >> expect

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-24 Thread Kevin Rushforth
On Thu, 24 Jul 2025 21:59:35 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 1165: >> >>> 1163: { >>> 1164: GlassWindow *window = getGlassWindow(env, jPtr); >>> 1165: [window _setResizable:jResizable]; >> >> I presume you re

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-24 Thread Kevin Rushforth
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure out what we would >> expect

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-24 Thread Kevin Rushforth
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure out what we would >> expect

Re: RFR: 8351357: Add canary system test checking if Stage receives focus on show [v7]

2025-07-24 Thread Kevin Rushforth
On Wed, 23 Jul 2025 19:40:20 GMT, Martin Fox wrote: >> Lukasz Kostyra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust error message for window-on-top check > > tests/system/src/test/java/test/robot/javafx/stage/StageFocusTest.java

Re: [jfx25] RFR: 8363813: Missing null check in GlassScreen

2025-07-23 Thread Kevin Rushforth
On Wed, 23 Jul 2025 23:45:12 GMT, Ambarish Rapte wrote: > Clean backport of adding simple null checks in glass screen fix to the > `jfx25` stabilization branch. Looks good to go into jfx25. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1854#pullr

Re: [jfx25] RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-23 Thread Kevin Rushforth
he commit being backported was authored by John Hendrikx on 23 Jul 2025 and > was reviewed by Andy Goryachev, Michael Strauß and Kevin Rushforth. OK to backport to jfx25. One reviewer is sufficient. - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1852

Re: Is there an easier way to "fix" a control instead of building everything (i.e., java, native, etc.)?

2025-07-23 Thread Kevin Rushforth
[redirecting to openjfx-dev] You will need to build all of JavaFX using gradle. You might be running into an issue with the version of Xcode you are using. You will need macOS 14 or 15 with a recent version of Xcode. We use Xcode 15.4 for our production builds. Can you list the version of ma

Re: RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-23 Thread Kevin Rushforth
On Tue, 22 Jul 2025 00:05:35 GMT, John Hendrikx wrote: > This PR fixes a regression introduced in #1723 > > It reverts the changes made in the BorderPaneTest with new comments > explaining why the values are what they are. It only fixes the regression > that was introduced, but it can be said

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-07-22 Thread Kevin Rushforth
On Tue, 22 Jul 2025 19:05:12 GMT, Cormac Redmond wrote: > I think this fix should make the 25 release if possible, as it would be > unfortunate to preview the new feature with distracting bugs included. The > fix is also quite well-tested at this point. > > @kevinrushforth @andy-goryachev-orac

Re: RFR: 8363813: Missing null check in GlassScreen

2025-07-22 Thread Kevin Rushforth
On Tue, 22 Jul 2025 17:28:22 GMT, Ambarish Rapte wrote: > The JNI method NewObjectArray may return null, so a null check should be > added as a precaution in methods that creates an array of Screens. LGTM Reviewers: @kevinrushforth @johanvos Johan: can you take a look at the/ios/ changes? -

jfx25u open for JavaFX 25.0.1 backports

2025-07-22 Thread Kevin Rushforth
All, The jfx25u repo [1] is now open for JavaFX 25.0.1 backports (the October 2025 CPU release), with approval from one of the project leads. The general criteria is that we want to backport fixes for regressions introduced in JavaFX 25, third-party library updates, and a limited number of ot

Re: RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-22 Thread Kevin Rushforth
On Tue, 22 Jul 2025 00:08:26 GMT, John Hendrikx wrote: > @kevinrushforth since the regression was introduced in the version we're > about to release, we may want to consider this for immediate backport to > avoid shipping it in the final version. Agreed. This is a good candidate to backport to

Re: RFR: 8362873: Regression in BorderPane after JDK-8350149

2025-07-22 Thread Kevin Rushforth
On Tue, 22 Jul 2025 12:54:52 GMT, Kevin Rushforth wrote: >> @Glavo this should fix the regression >> >> @kevinrushforth since the regression was introduced in the version we're >> about to release, we may want to consider this for immediate backport to >

[jfx25u] Integrated: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2025-07-22 Thread Kevin Rushforth
On Mon, 21 Jul 2025 21:00:57 GMT, Kevin Rushforth wrote: > This is a copy of the jfx24u README and CONTRIBUTING docs, changing 24 to 25. This pull request has now been integrated. Changeset: 8e835833 Author: Kevin Rushforth URL: https://git.openjdk.org/jfx25u/com

[jfx25u] RFR: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2025-07-21 Thread Kevin Rushforth
This is a copy of the jfx24u README and CONTRIBUTING docs, changing 24 to 25. - Commit messages: - 8304008: Update README.md and CONTRIBUTING.md for jfx update repos Changes: https://git.openjdk.org/jfx25u/pull/2/files Webrev: https://webrevs.openjdk.org/?repo=jfx25u&pr=2&range=00

Re: [jfx25u] RFR: 8304008: Update README.md and CONTRIBUTING.md for jfx update repos

2025-07-21 Thread Kevin Rushforth
On Mon, 21 Jul 2025 21:00:57 GMT, Kevin Rushforth wrote: > This is a copy of the jfx24u README and CONTRIBUTING docs, changing 24 to 25. Reviewer: @johanvos - PR Comment: https://git.openjdk.org/jfx25u/pull/2#issuecomment-3098912739

[jfx25u] Integrated: 8362896: Change JavaFX release version to 25.0.1 in jfx25u

2025-07-21 Thread Kevin Rushforth
On Mon, 21 Jul 2025 16:46:36 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 25.0.1 release. This pull request has now been integrated. Changeset: bfceb6a7 Author: Kevin Rushforth URL: https://git.openjdk.org/jfx25u/commit/bfceb6a72b52ad2e2a637389d72e8b43021d0

Re: [jfx25u] RFR: 8362896: Change JavaFX release version to 25.0.1 in jfx25u

2025-07-21 Thread Kevin Rushforth
On Mon, 21 Jul 2025 16:46:36 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 25.0.1 release. @johanvos Can you do the maintainer approval when you get a chance? - PR Comment: https://git.openjdk.org/jfx25u/pull/1#issuecomment-3097719978

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v4]

2025-07-21 Thread Kevin Rushforth
On Fri, 28 Feb 2025 21:30:31 GMT, John Hendrikx wrote: >> Fixes the case where `VBox` will ignore the (horizontal) bias of a child >> when its fill width property is set to `false`. This manifests itself with >> labels that have their wrap text property set to `true`, and the container >> is

[jfx25u] RFR: 8362896: Change JavaFX release version to 25.0.1 in jfx25u

2025-07-21 Thread Kevin Rushforth
Updates for the beginning of the 25.0.1 release. - Commit messages: - 8362896: Change JavaFX release version to 25.0.1 in jfx25u Changes: https://git.openjdk.org/jfx25u/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=jfx25u&pr=1&range=00 Issue: https://bugs.openjdk.org/br

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-18 Thread Kevin Rushforth
On Fri, 18 Jul 2025 17:54:46 GMT, Ambarish Rapte wrote: >> Good catch. I think this should throw a `RuntimeException` of some sort. > > We throw an InternalError from MTLResourceFactory.createStockShader() if > shader creation fails. For matching changed here to use InternalError. If not > Ok,

JavaFX 25 is in Rampdown Phase One (RDP1)

2025-07-17 Thread Kevin Rushforth
JavaFX 25 is now in Rampdown Phase One (RDP1) [1]. We have forked a new jfx25 branch [2] for stabilizing the JavaFX 25 release. Here is the short summary of what this means: - The master branch of the jfx repo is available for integrating bug fixes or enhancements for jfx26. Almost all fixes w

Integrated: 8362079: Change JavaFX release version to 26

2025-07-17 Thread Kevin Rushforth
On Mon, 14 Jul 2025 14:18:07 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 26. I will integrate this to master as > part of forking the jfx25 stabilization branch, which is scheduled for > Thursday, July 17, 2025 at 16:00 UTC. This pull request has now been i

Re: RFR: 8362079: Change JavaFX release version to 26

2025-07-17 Thread Kevin Rushforth
On Mon, 14 Jul 2025 14:18:07 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 26. I will integrate this to master as > part of forking the jfx25 stabilization branch, which is scheduled for > Thursday, July 17, 2025 at 16:00 UTC. I was off by an hour and en

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v8]

2025-07-17 Thread Kevin Rushforth
On Wed, 16 Jul 2025 14:59:07 GMT, Andy Goryachev wrote: > you might want to sync up with the latest master. Agreed, although you might wait until after the jfx25 fork at this point. > modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java > line 53: > >> 51: // a value

Re: RFR: 8355774: RichTextArea: provide mechanism for CSS styling of highlights [v3]

2025-07-16 Thread Kevin Rushforth
On Thu, 3 Jul 2025 19:30:13 GMT, Andy Goryachev wrote: >> Adding missing APIs related to styling the highlights with CSS: >> >> ![Screenshot 2025-05-07 at 15 08 >> 53](https://github.com/user-attachments/assets/e37062b4-9804-40a7-872d-830fe0f584c1) >> >> >> >> Adds methods to the `RichParagr

FINAL REMINDER: JavaFX 25 RDP1 starts tomorrow [was: Proposed schedule for JavaFX 25]

2025-07-16 Thread Kevin Rushforth
JavaFX 25 RDP1 starts tomorrow, July 17th. I will fork the 'jfx25' branch at 16:00 UTC. -- Kevin On 7/7/2025 11:57 AM, Kevin Rushforth wrote: As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 25 starts on Thursday, July 17, 2025 at 16:00 UTC (09:00 US/Pacific time), ten days

Re: RFR: 8351357: Add canary system test checking if Stage receives focus on show [v6]

2025-07-16 Thread Kevin Rushforth
On Fri, 4 Jul 2025 06:59:24 GMT, Lukasz Kostyra wrote: >> Originally this issue was supposed to resolve problems with some system >> tests (`MenuDoubleShortcutTest`, `TextAreaBehaviorTest` and others) failing >> on my Windows machine. In the process of figuring this out I found out the >> prob

Re: RFR: 8141391: Manual JFXPanel DnD test doesn't work [v3]

2025-07-16 Thread Kevin Rushforth
On Wed, 16 Jul 2025 03:31:24 GMT, Prasanta Sadhukhan wrote: >>> Maybe also update the description in this PR and the ticket? >> >> I added a note to the JBS Description. >> >> @prsadhuk Can you update the PR description when you fix the title? > >> > Maybe also update the description in this P

Re: RFR: 8314482: TextFlow: TabStopPolicy [v10]

2025-07-15 Thread Kevin Rushforth
On Tue, 15 Jul 2025 17:32:31 GMT, Andy Goryachev wrote: >> # Tab Stop Policy >> >> Andy Goryachev >> >> >> >> >> ## Summary >> >> Introduce a `tabStopPolicy` property in the `TextFlow` class which, when >> set, overrides the existing `tabSize` >> value and provides consistent way of settin

Re: RFR: 8141391: DnD doesn't work for JFXPanel [v3]

2025-07-15 Thread Kevin Rushforth
On Tue, 15 Jul 2025 17:41:18 GMT, Andy Goryachev wrote: > Maybe also update the description in this PR and the ticket? I added a note to the JBS Description. @prsadhuk Can you update the PR description when you fix the title? - PR Comment: https://git.openjdk.org/jfx/pull/1843#iss

Re: RFR: 8141391: DnD doesn't work for JFXPanel [v3]

2025-07-15 Thread Kevin Rushforth
On Tue, 15 Jul 2025 03:38:20 GMT, Prasanta Sadhukhan wrote: >> Issue is when `JFXPanel `is used to embed some JavaFX components and when we >> drag something from swing or an external application and try to drop on a >> JavaFX component inside the JFXPanel, it doesn't accept the drop showing

[jfx24u] Integrated: 8361887: Create release notes for JavaFX 24.0.2

2025-07-15 Thread Kevin Rushforth
On Thu, 10 Jul 2025 15:27:39 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47734 > > The original filter, with the backpo

Re: [jfx24u] RFR: Merge 82638ae10dad52ac9eee4201d7eee74a09277993 [v2]

2025-07-15 Thread Kevin Rushforth
> Clean merge of July CPU content into `jfx24u:master`. Note that this is a > no-op merge, since the only content is some identity merge commits (so there > are no changes to the contents of the repo). Kevin Rushforth has updated the pull request with a new target base due to a m

[jfx24u] Integrated: Merge 82638ae10dad52ac9eee4201d7eee74a09277993

2025-07-15 Thread Kevin Rushforth
On Tue, 15 Jul 2025 13:44:45 GMT, Kevin Rushforth wrote: > Clean merge of July CPU content into `jfx24u:master`. Note that this is a > no-op merge, since the only content is some identity merge commits (so there > are no changes to the contents of the repo). This pull request has

Re: [jfx24u] RFR: 8361887: Create release notes for JavaFX 24.0.2 [v2]

2025-07-15 Thread Kevin Rushforth
r=47733 > > As usual, I excluded test bugs, cleanup bugs, etc. > > NOTE: Once the CPU release ships on 2025-07-15, I will add any security bugs > and ask for a re-review. Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision

[jfx24u] RFR: Merge 82638ae10dad52ac9eee4201d7eee74a09277993

2025-07-15 Thread Kevin Rushforth
Clean merge of July CPU content into `jfx24u:master`. Note that this is a no-op merge, since the only content is some identity merge commits (so there are no changes to the contents of the repo). - Commit messages: - Merge - Merge - Merge - Merge - Merge - Merge - Merge - 83

Re: RFR: 8324941: POC for Headless platform for JavaFX [v9]

2025-07-14 Thread Kevin Rushforth
On Mon, 7 Jul 2025 17:56:06 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: RFR: 8314482: TextFlow: TabStopPolicy [v9]

2025-07-14 Thread Kevin Rushforth
On Fri, 11 Jul 2025 22:42:23 GMT, Andy Goryachev wrote: >> # Tab Stop Policy >> >> Andy Goryachev >> >> >> >> >> ## Summary >> >> Introduce a `tabStopPolicy` property in the `TextFlow` class which, when >> set, overrides the existing `tabSize` >> value and provides consistent way of settin

Re: RFR: 8141391: DnD doesn't work for JFXPanel [v2]

2025-07-14 Thread Kevin Rushforth
On Fri, 11 Jul 2025 23:23:22 GMT, Martin Fox wrote: >> What code path does it take when pasting from an FX component? Maybe we can >> look how it differs and try to redirect to that path, so the content gets >> pasted correctly. > > Am I missing something? I can't find any evidence that a Java

Re: RFR: 8141391: DnD doesn't work for JFXPanel [v2]

2025-07-14 Thread Kevin Rushforth
On Sun, 13 Jul 2025 08:52:31 GMT, Prasanta Sadhukhan wrote: >> Issue is when `JFXPanel `is used to embed some JavaFX components and when we >> drag something from swing or an external application and try to drop on a >> JavaFX component inside the JFXPanel, it doesn't accept the drop showing

RFR: 8362079: Change JavaFX release version to 26

2025-07-14 Thread Kevin Rushforth
Bump the version number of JavaFX to 26. I will integrate this to master as part of forking the jfx25 stabilization branch, which is scheduled for Thursday, July 17, 2025 at 16:00 UTC. - Commit messages: - 8362079: Change JavaFX release version to 26 Changes: https://git.openjdk.o

Integrated: 8361713: JavaFX API docs overview is missing an intro section

2025-07-14 Thread Kevin Rushforth
On Fri, 11 Jul 2025 00:17:38 GMT, Kevin Rushforth wrote: > This PR adds an introductory section to the JavaFX API docs similar to that > of the JDK docs. > > Compare the [JavaFX 24 API > docs](https://download.java.net/java/GA/javafx24/docs/api/index.html) with > the [

Re: [jfx24u] RFR: 8361887: Create release notes for JavaFX 24.0.2

2025-07-14 Thread Kevin Rushforth
On Thu, 10 Jul 2025 15:27:39 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.2. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47734 > > The original filter, with the backpo

Re: RFR: 8362095: HeaderButtonMetrics should not be used across toolkit boundary

2025-07-14 Thread Kevin Rushforth
On Sun, 13 Jul 2025 21:34:42 GMT, Michael Strauß wrote: > The record `com.sun.glass.ui.HeaderButtonMetrics` is used by Glass, but also > in the FX layer (in `Stage` and `HeaderBar`). This is architectually unsound, > as the FX layer should not directly reference the Glass implementation. > > T

Re: RFR: 8141391: DnD doesn't work for JFXPanel

2025-07-11 Thread Kevin Rushforth
On Fri, 11 Jul 2025 15:29:10 GMT, Andy Goryachev wrote: >> Issue is when `JFXPanel `is used to embed some JavaFX components and when we >> drag something from swing or an external application and try to drop on a >> JavaFX component inside the JFXPanel, it doesn't accept the drop showing >> "b

  1   2   3   4   5   6   7   8   9   10   >