On Fri, 3 Feb 2023 14:09:08 GMT, Kevin Rushforth wrote:
>> sorry to hold up the review - I'll speak to Naoto Sato tomorrow (2/3/23 @
>> 11:00) regarding the requirements for translation hints, and either approve
>> or let you know what they expect us to do.
>
> OK. Presuming that the comment Al
On Fri, 3 Feb 2023 08:08:35 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last
On Fri, 3 Feb 2023 00:37:56 GMT, Andy Goryachev wrote:
>>> Still, I would recommend adding a comment (since now is the time when we
>>> know all the context, and in the future we might forget or lose the
>>> context), may be something like
>>
>> Good idea, let me do it for both strings with pa
On Fri, 3 Feb 2023 08:08:35 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last
On Thu, 2 Feb 2023 23:46:27 GMT, Kevin Rushforth wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed debug output.
>
> modules/javafx.controls/src/main/java/javafx/scene/chart/XYChart.java line
> 1271:
>
>>
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removed getSeries() method
-
Changes
On Thu, 2 Feb 2023 21:14:14 GMT, Alexander Zuev wrote:
>> Still, I would recommend adding a comment (since now is the time when we
>> know all the context, and in the future we might forget or lose the
>> context), may be something like
>>
>>
>> # {seriesName} {xAxisName} is {currentX} {yAxis
On Thu, 2 Feb 2023 21:23:14 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last
On Thu, 2 Feb 2023 17:26:32 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last
On Thu, 2 Feb 2023 00:22:53 GMT, Kevin Rushforth wrote:
> Can you enable GitHub actions for your repo? If you click on the "Checks" tab
> you 'll see a message from Skara with a pointer as to how to do that (the
> short answer is you go to "Actions" for your personal fork and click the big
> g
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Trigger test jobs
-
Changes:
- all
On Thu, 2 Feb 2023 18:14:08 GMT, Andy Goryachev wrote:
> Still, I would recommend adding a comment (since now is the time when we know
> all the context, and in the future we might forget or lose the context), may
> be something like
Good idea, let me do it for both strings with parameters
--
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Added commentary explaining fields ised in paramet
On Thu, 2 Feb 2023 18:09:23 GMT, Andy Goryachev wrote:
>>> one way to do it is to describe the expected result in the comment
>>> immediately preceding the string.
>>> ...
>>>
>>> Also, for testing purposes, we could consider pseudolocalization
>>
>> These are good suggestions that should be c
On Thu, 2 Feb 2023 18:06:51 GMT, Kevin Rushforth wrote:
>> Sorry for accidentally editing your comment. I think I restored it correctly.
>
>> one way to do it is to describe the expected result in the comment
>> immediately preceding the string.
>> ...
>>
>> Also, for testing purposes, we could
On Thu, 2 Feb 2023 17:41:28 GMT, Andy Goryachev wrote:
>>> Do we provide a hint to the translators on how these strings need to be
>>> translated, like giving an example of rendered text?
>>
>> And that is why i did not do any "Google translate" translation in this PR -
>> i will raise a new b
On Thu, 2 Feb 2023 18:05:10 GMT, Kevin Rushforth wrote:
>> one way to do it is to describe the expected result in the comment
>> immediately preceding the string. For example:
>>
>>
>> # "the current execution is complete"
>> Class.runText=The run is run.
>>
>> Also, for testing purposes, we
On Thu, 2 Feb 2023 17:28:22 GMT, Alexander Zuev wrote:
>> modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/resources/controls.properties
>> line 149:
>>
>>> 147:
>>> 148: ### Charts ###
>>> 149: XYChart.series.accessibleText={0} {1} is {2} {3} is {4}
>>
>> Do we pr
On Thu, 2 Feb 2023 17:00:04 GMT, Andy Goryachev wrote:
> Do we provide a hint to the translators on how these strings need to be
> translated, like giving an example of rendered text?
And that is why i did not do any "Google translate" translation in this PR - i
will raise a new bug to transla
On Thu, 2 Feb 2023 00:46:31 GMT, Kevin Rushforth wrote:
> Since you added new i18n resource strings have you verified that it works for
> other locales to ensure no regression?
I did - tested with Japanese VoiceOver on Mac, it correctly constructs the
string.
> You'll need to remove this debu
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removed debug output.
-
Changes:
-
On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/resources/controls.properties
On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
My initial testing (on Windows) looks good. I have a general question in
addition to the one inline comme
On Tue, 31 Jan 2023 19:51:51 GMT, Alexander Zuev wrote:
> > Can you provide an evaluation of the bug and a description of the fix?
>
> Done.
Thanks.
Can you enable GitHub actions for your repo? If you click on the "Checks" tab
you 'll see a message from Skara with a pointer as to how to do th
On Tue, 31 Jan 2023 18:48:41 GMT, Kevin Rushforth wrote:
> Can you provide an evaluation of the bug and a description of the fix?
Done.
-
PR: https://git.openjdk.org/jfx/pull/1016
On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Can you provide an evaluation of the bug and a description of the fix?
-
PR: https://git.ope
26 matches
Mail list logo
