One of the big challenges in running JavaFX with OpenJDK builds is that
developers need to build OpenJDK locally themselves and include the
JavaFX bits produced by a locally-built OpenJFX build.
In an earlier email with the subject "javafx might not be present" [1],
I mentioned our intention
Voting for Rajath Kamath [1] to OpenJFX Committer [2] is now closed.
Yes: 6
Veto: 1
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this nomination
has failed.
I didn't have a chance to respond to the Veto before the voting period
ended, but will reply shortly.
-- Kevin
Hi Ankit,
In response to your veto, I took the opportunity to look at the the list
of changes, and believe that my earlier nomination of Rajath to OpenJFX
Project Committer was justified, if perhaps barely so.
While there is no objective criteria by which one can say a particular
changeset
Hi Phil,
All my webrev does is to replace the way of obtaining name of JDK font
directory – and as rightly pointed by you below (first two lines of your last
reply) – it is what is needed to get rid of dependency on sun.font.lookup.
I have tested it by running an OpenJDK build that
Iv'e given the pipeline some thought. I'm purposely ignoring current role
names (Author, Contributor...). My suggestions:
Potential contributor wants to contribute...
1. Formal process
a. If the issue is not in the JBS, they submit it via bugreport.
b. They send an email on the mailing list
This seems a good start in formalizing the process. It will need a
little tweaking in a couple of areas.
Regarding JBS access, even though I want to relax the requirement to
become an Author (get a JBS account), it will likely end up somewhere
between "an intention to contribute" and "two
That is the difficult point indeed.
But why would a PR to OpenJFX be rejected after it was approved in the
github mirror? I would assume the main reason for this is because the PR
did not what it was supposed to do. In that case, it makes sense to remove
the commits from the github mirror as well.
We now have a Github mirror, and good github projects require clear
guidelines.
Eugene created the following proposal for guidelines, based on standard
guidelines from other projects, but including the link to JBS:
https://github.com/johanvos/openjfxorg/blob/master/CONTRIBUTING.md
Comments
This looks fine to me. Please add this info to JBS when you get a
chance, and also link the new bug to this bug.
The fix looks fine to me, although I was puzzled by the following:
-return
-System.getProperty("java.home","") + File.separator +
-"lib" +
Dear Kevin,
I will get back to you on this shortly with substantial claims.
--Ankit
On 28 Feb 2018 2:23 a.m., "Kevin Rushforth"
wrote:
> Hi Ankit,
>
> In response to your veto, I took the opportunity to look at the the list
> of changes, and believe that my
>
> Johan's thinking was to allow Committers to approve the PR on GitHub --
> meaning they could be merged on GitHub before an actual Review has
> happened. Are you proposing to change that?
What if the PR is rejected at review? We'll end up with conflicts between
the repos. And supposed someone
Nir Lisker wrote:
Johan's thinking was to allow Committers to approve the PR on
GitHub -- meaning they could be merged on GitHub before an actual
Review has happened. Are you proposing to change that?
What if the PR is rejected at review? We'll end up with conflicts
between the
On 2018-02-27T13:21:56 -0800
Kevin Rushforth wrote:
>
> In an earlier email with the subject "javafx might not be present" [1],
> I mentioned our intention to make it easier for OpenJFX to be built,
> tested, and run with OpenJDK builds that don't already contain
13 matches
Mail list logo