Re: Not really a nice comment but a real issue?

2021-03-23 Thread John Neffenger
On 3/22/21 3:27 PM, Philip Race wrote: I am informed that, for no reason given, the corporate IT folks will not allow attachment upload. Thank you for looking into it, Phil. It's good at least to have a definitive answer. I brought this up on the mailing list three years ago, too: Re: More

Re: RFR: 8263322: Calling Application.launch on FX thread should throw IllegalStateException, but causes deadlock [v9]

2021-03-23 Thread Ambarish Rapte
On Sun, 21 Mar 2021 22:30:11 GMT, Florian Kirmaier wrote: >> Fixing deadlock when calling Application.launch in the FXThread after >> Platform.startup > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8263322 >

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene

2021-03-23 Thread Ambarish Rapte
On Mon, 22 Mar 2021 14:35:58 GMT, Florian Kirmaier wrote: > I think it's also quite important to support fast removing/adding subtrees. Yes, Adding listener seems over kill here. Lets go with `WeakReference` approach. I will take a look at the test update. - PR:

Re: Not really a nice comment but a real issue?

2021-03-23 Thread Johan Vos
Hi John, all, Clearly, there are advantages and disadvantages to the Oracle Web form. It's not a black/white situation. We need to find a solution that combines the advantages of being accessible as well as not creating false expectations. I really like the JBS system, it is very powerful and

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 09:49:42 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263402 >> Rewrote the style memoryleak test > >

Re: Dialog contentText does not wrap correctly always

2021-03-23 Thread Daniel Peintner
Hello, Sorry for bothering you with my first email providing an example that used a helper class for showing the dialog. I looked further and please find below or in [1] a Short, Self Contained, Correct (Compilable), Example. The issue appears for cases when setting "glass.win.uiScale" to "1.5".

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

2021-03-23 Thread Ambarish Rapte
On Mon, 22 Mar 2021 14:30:58 GMT, Florian Kirmaier wrote: >> Fixing a memory leak. >> A node hard references its old parent after CSS layout and getting removed. >> This shouldn't be the case, this is very counterintuitive. >> >> The fix uses a WeakReference in CSSStyleHelper for

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-23 Thread Jeanette Winzenburg
On Mon, 22 Feb 2021 20:29:29 GMT, Kevin Rushforth wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed missing/incorrect @since tags in new api doc > > Not yet reviewed. All of the new API methods need to

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v3]

2021-03-23 Thread Ambarish Rapte
> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on > `MenuItem.acceleratorProperty()`. This listener is not removed when the > MenuItem is removed from scenegraph. > Adding and removing a MenuItem

Re: RFR: 8264010: Add Gradle dependency verification

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 05:32:04 GMT, John Neffenger wrote: > This pull request adds dependency verification to the Gradle builds of JavaFX > on Linux, macOS, and Windows. It is the third of three changes that close the > gaps in the JavaFX build security: > > * [JDK-8262236][1]: Configure Gradle

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport

2021-03-23 Thread Ambarish Rapte
On Sat, 20 Mar 2021 13:11:55 GMT, Kevin Rushforth wrote: > The new unit test fails on all platforms, as you can see from the GitHub > actions log: The test failed because, change listeners added by other tests get accumulated in the `changeListenerMap`. These listeners can get GCed only if

Re: Not really a nice comment but a real issue?

2021-03-23 Thread John Neffenger
On 3/23/21 12:34 AM, Johan Vos wrote: * bug-report system: I'm all in to find a more accessible way, keeping into account that would require work being done by the community (hence, us) for converting issues into high-quality JBS issues. I have two GitHub Issue Templates that gather the same

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 11:41:23 GMT, Jeanette Winzenburg wrote: >> Not yet reviewed. All of the new API methods need to have an `@since 17` >> javadoc tag. > > wondering about the sequence of next steps: should I create the csr before or > after (partial) review of this? Doing before feels like

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-23 Thread Arun Joseph
On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote: >> This is a fix for a long-standing bug where the D3D pipeline will stop >> rendering when a Windows remote desktop session is disconnected and then >> reconnected. >> >> A preliminary Draft PR #315 by @Schmidor was a good first step

Re: [External] : Re: OpenJFX custom build - Java application crash (semi-related to 8262276)

2021-03-23 Thread Arun Joseph
The thread dump doesn’t have enough details to locate where the problem occurs. Using a debug build with assertions disabled (as mentioned in the previous mail) may help in generating a thread dump for getting some more information. — Arun Joseph On 18-Mar-2021, at 3:39 PM, Primož Kokol

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-23 Thread Ambarish Rapte
On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote: >> This is a fix for a long-standing bug where the D3D pipeline will stop >> rendering when a Windows remote desktop session is disconnected and then >> reconnected. >> >> A preliminary Draft PR #315 by @Schmidor was a good first step

RFR: 8264061: LocalDateTimeStringConverterTest fails in Canada

2021-03-23 Thread John Neffenger
As the comment in the test case mentions, "Tests require that default locale is en_US." The default locale is required by the objects created in the static method `implementations`, marked with the JUnit annotation `@Parameterized.Parameters`. So the static method `initDefaultLocale`, marked

Integrated: 8264061: LocalDateTimeStringConverterTest fails in Canada

2021-03-23 Thread John Neffenger
On Tue, 23 Mar 2021 18:24:40 GMT, John Neffenger wrote: > As the comment in the test case mentions, "Tests require that default locale > is en_US." The default locale is required by the objects created in the > static method `implementations`, marked with the JUnit annotation >

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 17:36:28 GMT, Arun Joseph wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments to fix typo in comment > > Fix looks good. Tested WebView by reconnecting via remote

Re: RFR: 8264061: LocalDateTimeStringConverterTest fails in Canada

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 18:24:40 GMT, John Neffenger wrote: > As the comment in the test case mentions, "Tests require that default locale > is en_US." The default locale is required by the objects created in the > static method `implementations`, marked with the JUnit annotation >

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-23 Thread Oliver Schmidtmer
On Tue, 23 Mar 2021 19:17:20 GMT, Kevin Rushforth wrote: >> Fix looks good. Tested WebView by reconnecting via remote desktop. > > @Schmidor did you have any further comments or feedback? > > Btw, I realized that you don't have a role in the openjfx project, so you > can't formally review it.

RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64)

2021-03-23 Thread Alexander Scherbatiy
This is a proposal for cross compiling JavaFX base modules (excluding media and webkit) for Windows AArch64 (ARM64). Main changes: - prismES2 native compilation is moved under IS_INCLUDE_ES2 condition - HOST_ARCH and TARGET_ARCH are retrieved from ext.OS_ARCH and ext.TARGET_ARCH using

Integrated: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop

2021-03-23 Thread Kevin Rushforth
On Wed, 17 Mar 2021 18:17:48 GMT, Kevin Rushforth wrote: > This is a fix for a long-standing bug where the D3D pipeline will stop > rendering when a Windows remote desktop session is disconnected and then > reconnected. > > A preliminary Draft PR #315 by @Schmidor was a good first step in

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-23 Thread Kevin Rushforth
On Tue, 23 Mar 2021 20:06:15 GMT, Oliver Schmidtmer wrote: >> @Schmidor did you have any further comments or feedback? >> >> Btw, I realized that you don't have a role in the openjfx project, so you >> can't formally review it. As such, I'll change the requirements back to 2 >> reviewers.

RFR: JDK-8258381 : [macos] Exception when input emoji using Chinese input method

2021-03-23 Thread Hsiafan
The convertNSStringToJString function convert NSString to Java String using NewStringUTF,NewStringUTF accept modified-UTF8 encoded str。This fix using UTF-16 encoding for converting. - Commit messages: - fix input UTF-16 surrogate-pairs in macOS Changes: