[API Review] RT-15314

2013-05-29 Thread David Hill
n for many of the users of this functionality, because in a "kiosk" style application you can control the launching anyway. -- David Hill Java Embedded Development "In the business world, the rearview mirror is always clearer than the windshield." -- Warren Buffett (1930 - )

Update on the FullScreen ESC API proposal.

2013-06-11 Thread David Hill
n we'll use that instead. Or we could add API to Application later which would be applicable to all Stages. But for now I would start with just the API on Stage and see how far that takes us. David Hill Java Embedded Development One of the keys to happiness is a bad memory. -- Rita Mae Brown

Re: CFV: New OpenJFX Committer: Petr Pchelko

2013-07-09 Thread David Hill
, see [2]. Thanks, Artem [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development It is better to keep your mouth closed and let people think you are a fool than to open it and remove all doubt. -- Mark Twain

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread David Hill
this mailing list. For Lazy Consensus voting instructions, see [2]. Thanks, Richard [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development "For every ailment under the sun There is a remedy, or there is none; I

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread David Hill
, Richard [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development "For every ailment under the sun There is a remedy, or there is none; If there be one, try to find it; If there be none, never mind it." -- Mother Goose

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread David Hill
://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development "A specification that will not fit on one page of 8.5x11 inch paper cannot be understood." -- Mark Ardis

Re: CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-09 Thread David Hill
must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Thanks, Richard [1] http://openjdk.java.net/census#openjfx [2] http://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development "A specification that will no

Re: JDK 8 for ARM Early Access Releases (with JavaFX)

2013-07-10 Thread David Hill
is appreciated. -- David Hill Java Embedded Development "Be obscure clearly." -- E. B. White

Re: JDK 8 for ARM Early Access Releases (with JavaFX)

2013-07-10 Thread David Hill
progress change to support fonts properly in OpenJFX is in place. We hope to finish documenting how to perform an OpenJFX PI build really soon now, as it is really, really close. We will announce when it is ready. -- David Hill Java Embedded Development "Nobody will ever win the Battl

Building your own OpenJFX for Linux ARM/Raspberry PI

2013-07-10 Thread David Hill
x ARM soft float ABI (like the the Beagle XM) * a more streamlined porting interface to enable adding other platforms -- David Hill Java Embedded Development "Paradise is exactly like where you are right now... only much, much better." -- Laurie Anderson, Language Is A Virus

Re: Building your own OpenJFX for Linux ARM/Raspberry PI

2013-07-10 Thread David Hill
On 7/10/13 Jul 10, 5:02 PM, Richard Bair wrote: Hi David, maybe you should cross post this over on the raspberry PI forums? Daniel posted this there: http://www.raspberrypi.org/phpBB3/viewtopic.php?f=81&t=49497 Dave On Jul 10, 2013, at 1:46 PM, David Hill wrote: You should now be

Re: A different way to handle pulse timing

2013-07-26 Thread David Hill
ely room for improvement. So, that is my view of the elephant <https://en.wikipedia.org/wiki/Blind_men_and_an_elephant>, and I am sure that others will have a different take :-) -- David Hill Java Embedded Development Education: that which reveals to the wise, and conceals from the stupid, the vast limits of their knowledge. -- Mark Twain

Re: A different way to handle pulse timing

2013-08-05 Thread David Hill
nough rendering that you can usually fit into a vsync period. I would be seriously concerned over user event starvation. It would not take much of a busy set of animations to mean we spin painting a SG that has not completely caught up with the bindings/and or ignoring the incoming input events. --

Re: A different way to handle pulse timing

2013-08-05 Thread David Hill
to fit within a single vsync period is impractical. Without access to true sync, a timer would serve the same purpose. Having both a timer and sync is where things get silly. Cheers, Scott On 2013-08-05, at 9:47 AM, David Hill wrote: On 8/1/13 Aug 1, 3:52 PM, Richard Bair wrote: as far as I can

Re: A different way to handle pulse timing

2013-08-05 Thread David Hill
s - that means we do a lot of work to put computes on a different thread (ie rendering). Richard -- David Hill Java Embedded Development Ich weiß nicht. -- an unknown German philosopher

Re: A different way to handle pulse timing

2013-08-05 Thread David Hill
On 8/5/13 Aug 5, 1:40 PM, Scott Palmer wrote: On 2013-08-05, at 12:49 PM, David Hill wrote: On 8/5/13 Aug 5, 12:27 PM, Scott Palmer wrote: The idea of user event starvation has been mentioned before and has me a little confused… Why aren't things handled as a simple queue, wi

CFV: New OpenJFX Committer:Daniel Blaukopf

2013-08-06 Thread David Hill
I hereby nominate Daniel Blaukopf to OpenJFX Committer. Daniel is a member of the Embedded Device team, which means he works across various aspects of the platform. He is also the architect for the "embedded device" space. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/

CFV: New OpenJFX Committer: Seeon Birger

2013-08-06 Thread David Hill
I hereby nominate Seeon Birger to OpenJFX Committer. Seeon is a member of the Embedded Device team, which means he works across various aspects of the platform, but in particular, Lens and Virtual Keyboard. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/8/master/rt/log?r

Re: A different way to handle pulse timing

2013-08-06 Thread David Hill
non input events) never leave java this way. Dave Scott -- David Hill Java Embedded Development "Sometimes the questions are complicated and the answers are simple." -- Dr. Seuss (1904 - 1991)

Re: CFV: New OpenJFX Committer: Chien Yang

2013-08-15 Thread David Hill
#lazy-consensus -- David Hill Java Embedded Development "Perl - The only language that looks the same before and after RSA encryption." -- Keith Bostic

Re: CFV: New OpenJFX Committer: Mick Fleming

2013-08-15 Thread David Hill
://openjdk.java.net/bylaws#lazy-consensus -- David Hill Java Embedded Development "Play: Work that you enjoy doing for nothing." -- Evan Esar (1899 - 1995), Esar's Comic Dictionary

Result: New OpenJFX Committer: Seeon Birger

2013-08-26 Thread David Hill
Voting for Seeon Birger to OpenJFX Committer [1] is now closed. Yes: 3 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dave [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-July/008677.html -- David Hill

Result: New OpenJFX Committer: Daniel Blaukopf

2013-08-26 Thread David Hill
Voting for Daniel Blaukopf to OpenJFX Committer [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dave [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-July/008677.html -- David Hill

Porting BOF at JavaOne

2013-09-11 Thread David Hill
luminaries from the JFX team present. I am planning on bringing some slides that generally talk about low level porting (primarily to Linux like platforms). Like any good BOF, I hope people will bring questions about their favorite platform. Hope to see you there, Dave -- David Hill Java

RE: CFV: New OpenJFX Committer: Joseph Andresen

2013-09-25 Thread David Hill
Vote: yes -Original Message- From: Artem Ananiev [artem.anan...@oracle.com] Received: Wednesday, 25 Sep 2013, 8:37am To: OpenJFX [openjfx-dev@openjdk.java.net] Subject: CFV: New OpenJFX Committer: Joseph Andresen I hereby nominate Joe Andresen to OpenJFX Committer. Joe is a member of J

RE: CFV: New OpenJFX Committer: Lisa Selle

2013-09-25 Thread David Hill
Vote: yes -Original Message- From: Artem Ananiev [artem.anan...@oracle.com] Received: Wednesday, 25 Sep 2013, 8:36am To: OpenJFX [openjfx-dev@openjdk.java.net] CC: Lisa Selle [lisa.se...@oracle.com] Subject: Re: CFV: New OpenJFX Committer: Lisa Selle Re-sending with the right subject (w

CFV: New OpenJFX Committer: Assaf Yavani

2013-10-30 Thread David Hill
I hereby nominate Assaf Yavnai to OpenJFX Committer. Assaf is a member of JavaFX Embedded team at Oracle. Most of Assaf's changes are in Glass/Lens support code: hg log -u "Assaf Yavani" An incomplete list of Assaf's commits and reviews is also available by the following link: http://hg.o

CFV: New OpenJFX Committer: Assaf Yavani

2013-11-05 Thread David Hill
I hereby nominate Rafi Tayar to OpenJFX Committer. Rafi is a member of JavaFX Embedded team at Oracle. Rafi's changes are in Glass/Lens support code: hg log -M -u "Rafi Tayar" An incomplete list of Rafi's commits and reviews is also available by the following link: http://hg.openjdk.java.

Fwd: CFV: New OpenJFX Committer: Rafi Tayar

2013-11-05 Thread David Hill
[ resending it with a corrected subject line. The dangers of reusing a form] I hereby nominate Rafi Tayar to OpenJFX Committer. Rafi is a member of JavaFX Embedded team at Oracle. Rafi's changes are in Glass/Lens support code: hg log -M -u "Rafi Tayar" An incomplete list of Rafi's comm

review - import change in FXMLLoader

2013-11-13 Thread David Hill
: com.sun.javafx.fxml.ParseTraceElement and the wildcard import should/does get the right one (after all we compile...) The above webrev corrects this oddity, while correcting FXMLLoader so that it conforms to our coding standards by not using package wildcard imports. -- David Hill Java

Result: New OpenJFX Committer: Assaf Yavani

2013-11-14 Thread David Hill
Voting for Assaf Yavani to OpenJFX Committer [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dave [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-July/008677.html -- David Hill

Result: New OpenJFX Committer: Rafi Tayar

2013-11-19 Thread David Hill
Voting for Rafi Tayar to OpenJFX Committer [1] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-July/008677.html -- David Hill Java

Changing the default gradle build results.

2013-12-02 Thread David Hill
itional 3 minutes. There seems a number of ways to solve this issue - adding additional targets, while retaining the overall end result. The challenge seems to be defining what those intermediate targets should be, and what should be the definition of 'sdk' and what is the default g

please review RT-31668

2013-12-05 Thread David Hill
https://javafx-jira.kenai.com/browse/RT-31668 Kevin, Alexander, please review: http://cr.openjdk.java.net/~ddhill/RT-31668/ <http://cr.openjdk.java.net/%7Eddhill/RT-31668/> -- David Hill Java Embedded Development Education: that which reveals to the wise, and conceals from the stupi

webrev for moving a few toys to public toys

2013-12-06 Thread David Hill
the nb source path, and a few javadoc fixes. -- David Hill Java Embedded Development "Any fool can make a rule, and any fool will mind it." -- Henry David Thoreau (1817 - 1862)

Fwd: CFV: New OpenJFX Committer: Vadim Pakhnushev

2013-12-11 Thread David Hill
I hereby nominate Vadim Pakhnushev to OpenJFX Committer. Vadim is a member of JavaFX Embedded team at Oracle. Vadim's changes are in Glass Windows/D3d: hg log -M -u "vadim" An incomplete list of Vadim's commits and reviews is also available by the following link: http://hg.openjdk.java.ne

Additions to apps/toys

2013-12-17 Thread David Hill
tests. In particular - try HelloSanity. Have fun with them :-) -- David Hill Java Embedded Development "For every complex problem there is a simple solution, and it's wrong." -- H. L. Mencken

Result: New OpenJFX Committer: Vadim Pakhnushev

2013-12-26 Thread David Hill
Voting for Vadim Pakhnushev to OpenJFX Committer [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Dave [1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2013-July/008677.html -- David Hill

Re: JavaFX on headless Jenkins

2014-01-06 Thread David Hill
com.sun.javafx.application.LauncherImpl$1.run(LauncherImpl.java:158) at java.lang.Thread.run(Thread.java:744) -- David Hill Java Embedded Development "On a clear disk, you can seek forever."

Re: JavaFX on headless Jenkins

2014-01-07 Thread David Hill
It would appear that I have not touched this since the gradle switchout :-( Dave Tom On 2014-1-6 17:36, David Hill wrote: On 1/4/14, Jan 4, 3:57 PM, Tom Eugelink wrote: I'm trying to run JavaFX UI tests using TestFX on a headless Jenkins server (Ubuntu / Debian). I've gotten to

Failure to find any font (probably on Embedded)

2014-02-12 Thread David Hill
ntConfigManager is: if (anyFont == null) { if (debugFonts) { System.err.println("Fontconfig returned no fonts at all."); } fontConfigFailed = true; return; -- David Hill Java Embedded Development "A common

Heads up... changing the rt/build/*sdk/ directory

2014-02-14 Thread David Hill
obably want to perform a clean build. And then try out the apps, in the new easier to use format. Note: for now, you will still need to specify the JDK for ant/nb, like this: ant -Dplatforms.JDK_1.8.home=$JAVA_HOME -- David Hill Java Embedded Development "On a clear disk, you can seek forever."

Re: Heads up... changing the rt/build/*sdk/ directory

2014-02-17 Thread David Hill
nd we use the JFX_CORE_ONLY property to avoid trying to build some of the examples. Our nightly build does quite a bit (but not all) of the apps tree for both 'host' and cross. I am looking forward to hooking up most of the rest. I think there are a couple that we will not ever

Review for RT-35535 - better provide for embedded font fallback

2014-02-18 Thread David Hill
: -Dprism.fontsdir=/opt/fonts -Dprism.debugfonts=true And my documenting fonts (at least on Linux) page on the Wiki: https://wiki.openjdk.java.net/display/OpenJFX/Font+Setup -- David Hill Java Embedded Development "Basic research is what I am doing when I don't know what I am doing.&q

Embedded ARM interest "poll"

2014-02-20 Thread David Hill
ard float distro with sufficiently integrated graphics drivers to try it on. I have a pending request to support the A20-OLinuXino, and actually have one so I might be able to start work soon. If "Embedded" ARM is interesting to you, could you reply OFF LIST - just to me with the p

Re: review request for RT-35353

2014-02-26 Thread David Hill
bcmLibraryHandle = ls.dlopen("libbcm_host.so", LinuxSystem.RTLD_LAZY); check for null ? other than that, did not see anything. +1 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world."

Review for font fallback change RT-35978

2014-03-05 Thread David Hill
desired information with greater simplicity and accuracy than the previous mechanism. I also would appreciate an associated Wiki rework for this topic: https://wiki.openjdk.java.net/display/OpenJFX/Font+Setup -- David Hill Java Embedded Development "If you want to catch something, running aft

Moved samples 3DViewer and Modena from experiments to samples

2014-03-07 Thread David Hill
A heads up. I just moved samples 3DViewer and Modena from experiments to samples. If you are going to work on these samples, you may want to sync up soon to avoid later fun. Dave -- David Hill Java Embedded Development "We trained hard, but it seemed that every time we were beginni

Re: [8u20] review request: https://javafx-jira.kenai.com/browse/RT-36163

2014-03-11 Thread David Hill
On 3/11/14, Mar 11, 6:21 PM, Kevin Rushforth wrote: David, Please review the (simple) build fix for: JIRA: https://javafx-jira.kenai.com/browse/RT-36163 Webrev: http://cr.openjdk.java.net/~kcr/RT-36163/ -- Kevin +1 -- David Hill Java Embedded Development Education: that which reveals

review: enable debugging info in linux shared libs

2016-02-25 Thread David Hill
Hi Kevin, There is a simple diff in the bug. https://bugs.openjdk.java.net/browse/JDK-8150673 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review for enabling systemTest with Jake

2016-03-08 Thread David Hill
Kevin, (finally) https://bugs.openjdk.java.net/browse/JDK-8147399 http://cr.openjdk.java.net/~ddhill/8147399/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review for paper test

2016-03-09 Thread David Hill
Phil, could you review: JobSettingsTest.testPaper fails with small paper sizes Simple fix, make the margins that don't fit 10% of the page dimension https://bugs.openjdk.java.net/browse/JDK-8149756 http://cr.openjdk.java.net/~ddhill/8149756/ -- David Hill Java Embedded Developmen

jake: enabling systemTests

2016-03-11 Thread David Hill
Kevin, if you could review: Enable systemTests in jake https://bugs.openjdk.java.net/browse/JDK-8147399 http://cr.openjdk.java.net/~ddhill/8147399.2/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world.&

Documenting our Junit tests

2016-03-19 Thread David Hill
existing tests, and quickly realize how much detail I had locked up in my brain. So to set that knowledge free, I put it in a wiki :-) Please let me know if you have any comments, questions, corrections. https://wiki.openjdk.java.net/display/OpenJFX/OpenJFX+unit+tests -- David Hill Java Embedded

Re: Move & Copy DnD operation on OS-X and Linux

2016-03-29 Thread David Hill
oad: " + event.getDragboard().getString()); event.consume(); } } -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: remove a cygwin dependancy

2016-03-30 Thread David Hill
Kevin, I have been running with this for a couple of weeks now. remove a cygwin dependancy https://bugs.openjdk.java.net/browse/JDK-8151747 http://cr.openjdk.java.net/~ddhill/8151747/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, bu

review: Conditionally save policy file in Sandbox tests

2016-03-30 Thread David Hill
Kevin, Conditionally save policy file in Sandbox tests https://bugs.openjdk.java.net/browse/JDK-8153086 http://cr.openjdk.java.net/~ddhill/8153086/ a small change, but very helpful when debugging the Sandbox test apps -- David Hill Java Embedded Development "A man's feet should be

Re: review: remove a cygwin dependancy

2016-03-30 Thread David Hill
On 3/30/16, 2:02 PM, Ali Ebrahimi wrote: Hi, line ByteArrayOutputStream out = new ByteArrayOutputStream(); can be removed! Good catch! thanks On Wed, Mar 30, 2016 at 10:04 PM, David Hill mailto:david.h...@oracle.com>> wrote: Kevin, I have been running with this for a cou

review: javafx.swing system test RT30650Test fails in jigsaw mode

2016-03-30 Thread David Hill
" -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: Add a command line toggle for worker.debug

2016-03-30 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8153110 Add a command line toggle for worker.debug There is a diff inline in the bug that works for toggling worker.debug from the gradle command line -- David Hill Java Embedded Development "A man's feet should be planted in his co

Re: review: remove a cygwin dependancy

2016-03-30 Thread David Hill
On 3/30/16, 1:34 PM, David Hill wrote: Kevin, I have been running with this for a couple of weeks now. remove a cygwin dependancy https://bugs.openjdk.java.net/browse/JDK-8151747 http://cr.openjdk.java.net/~ddhill/8151747/ I updated the webrev in place, removing the unneeded

Re: CFV: New OpenJFX Committer: Murali Billa

2016-03-31 Thread David Hill
/rev/ae75f92d5e53 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a -- David Hill Java Embedded Development "A man's feet should be planted in his countr

review: convert addExports to new syntax

2016-03-31 Thread David Hill
Kevin, yet another review for you to look at :-) https://bugs.openjdk.java.net/browse/JDK-8153231 http://cr.openjdk.java.net/~ddhill/8153231/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- G

review: move DragDrop test app to openjfx

2016-04-05 Thread David Hill
move DragDrop test app to openjfx https://bugs.openjdk.java.net/browse/JDK-8153536 http://cr.openjdk.java.net/~ddhill/8153536/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review request: 8153657 fix DragDrop builds with ARM

2016-04-06 Thread David Hill
Kevin, could you review the diff in: https://bugs.openjdk.java.net/browse/JDK-8153657 thanks! -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: Clear potential exception when reporting exceptions from JNI Glass GTK

2016-04-13 Thread David Hill
Kevin, could you review: Clear potential exception when reporting exceptions from JNI Glass GTK A one line diff in: https://bugs.openjdk.java.net/browse/JDK-8154206 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey

review: quiet Prism warnings

2016-04-14 Thread David Hill
Kevin, Chien, would you review this quick fix to quiet some warnings ? Tested on OEL, Ubuntu, Mac Windows. https://bugs.openjdk.java.net/browse/JDK-8154256 http://cr.openjdk.java.net/~ddhill/8154256/ -- David Hill Java Embedded Development "A man's feet should be planted in his co

early draft for 8087516: [JavaFX] Conditional support for GTK 3 on Linux

2016-04-22 Thread David Hill
later. * shaped windows with GTK3 - need to verify the new region methods * debug code that will be used to check that all of the code paths are tested. * move the disableGrab back into the main code logic. -- David Hill Java Embedded Development "A man's feet should be planted in his

Re: early draft for 8087516: [JavaFX] Conditional support for GTK 3 on Linux

2016-04-24 Thread David Hill
with SWT on Gtk3 or Gtk2 and not having to use -Djdk.gtk.version=3 The problem with requiring one to switch by setting the System-Property is that eg if someone want to use FX in the Eclipse IDE he does not control the Java-Launch Process. Tom On 23.04.16 00:50, David Hill wrote: Kevin, Phil,

review:

2016-04-26 Thread David Hill
Morris, would you please review: JDK-8155114: Set both X and Y position for some window managers <https://bugs.openjdk.java.net/browse/JDK-8155114> webrev: http://cr.openjdk.java.net/~ddhill/8155114/ -- David Hill Java Embedded Development "A man's feet should be planted in

review for Linux: unit test failures in ImageTest on some systems

2016-04-26 Thread David Hill
Kevin, Linux: unit test failures in ImageTest on some systems https://bugs.openjdk.java.net/browse/JDK-8089960 http://cr.openjdk.java.net/~ddhill/ 8089960 <https://bugs.openjdk.java.net/browse/JDK-8089960> -- David Hill Java Embedded Development "A man's feet should be plante

Re: [9] Review request: 8154186: JVM crash while using JavaFW WebView and colgroup/cols html feature

2016-04-27 Thread David Hill
t/~ghb/8154186/webrev.00/ Root Cause and solution updated in JBS. Thanks, Guru -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: CFV: New OpenJFX Committer: Guru Hb

2016-04-28 Thread David Hill
/0576d7a6f137 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/d4f8c9496683 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/620f5c6b4383 http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/aa51df7e1d41 -- David Hill Java Embedded Development "A man's feet should be planted in his country, bu

review for minor changes to build.gradle

2016-05-02 Thread David Hill
Kevin, a couple of proposed changes to build.gradle. Diffs are inline in the bugs. Provide for extra jvm arguments for gradle test task https://bugs.openjdk.java.net/browse/JDK-8155831 Allow disabling :web:test https://bugs.openjdk.java.net/browse/JDK-8155832 -- David Hill Java Embedded

review: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-03 Thread David Hill
& 3 for me. http://cr.openjdk.java.net/~ddhill/8087516.2/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review:

2016-05-03 Thread David Hill
Kevin, please review this fix to update our handling of -Xpatch with tests and provide a @xpatch.args for general developement. https://bugs.openjdk.java.net/browse/JDK-8155862 http://cr.openjdk.java.net/~ddhill/8155862 <http://cr.openjdk.java.net/%7Eddhill/8155862> -- David Hil

review v3: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-04 Thread David Hill
e in GlassApplication.cpp -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

JFX - Running with Jigsaw in development

2016-05-05 Thread David Hill
recently built binaries. Get your Jigsaw enabled JDK9 preview here: https://jdk9.java.net/download/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review v4: [JavaFX] Conditional support for GTK 3 on Linux

2016-05-06 Thread David Hill
Minor cleanups version 4: http://cr.openjdk.java.net/~ddhill/8087516.4/ changes from 3: http://cr.openjdk.java.net/~ddhill/8087516.4d/ -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George

Support for GTK 2 & 3 now in JFX

2016-05-09 Thread David Hill
be appreciated, along with a note to me with the OS version. thanks! -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: Support for GTK 2 & 3 now in JFX

2016-05-09 Thread David Hill
156491>, but that has some portability issues and might not make the final product. I am not aware of any reason why there would be an issue - unless there is something with the GTK event loop. Let me know if you give it a try. Dave regards, Erik On Mon, May 9, 2016 at 3:18 PM, David Hill

review: remove use of GetPropertyAction

2016-05-18 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8157280 webrev: http://cr.openjdk.java.net/~ddhill/8157280 <http://cr.openjdk.java.net/%7Eddhill/8157280> -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the w

review: Correct unused import in FXDnD

2016-05-19 Thread David Hill
Kevin, https://bugs.openjdk.java.net/browse/JDK-8157390 webrev: http://cr.openjdk.java.net/~ddhill/8157390 <http://cr.openjdk.java.net/%7Eddhill/8157390> -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should s

review: missing export to fxml in base module

2016-05-20 Thread David Hill
Kevin, a patch inline: https://bugs.openjdk.java.net/browse/JDK-8157473 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: remove old annotations from web

2016-05-20 Thread David Hill
Kevin, another inline diff: https://bugs.openjdk.java.net/browse/JDK-8157477 -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: Openjfx on Wanboard

2016-06-08 Thread David Hill
seem to "just work" :-) Also - never tried the Wandboard. I know it is a varient of the i.MX so likely will just work. Some of the ARM boards are not so easy though. Dave -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes sh

Re: Building OpenJFX for the first time

2016-06-28 Thread David Hill
accomplish this? Thanks very much, John -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Re: [9] Review Request: 8149975: [packager] Programmatically Determine JDK or JRE Modules

2016-07-06 Thread David Hill
nder if they are in place already. Dave -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Review: Clean up module relative paths in build.gradle

2016-07-13 Thread David Hill
Chien, could you review: https://bugs.openjdk.java.net/browse/JDK-8161227 webrev: http://cr.openjdk.java.net/~ddhill/8161227 <http://cr.openjdk.java.net/%7Eddhill/8161227> -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his ey

CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-19 Thread David Hill
I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=a.ankit.srivast...@oracle.com http://hg.openjdk.j

review: Fix more hardcoded paths in gradle build

2016-07-21 Thread David Hill
Kevin, if you could review: https://bugs.openjdk.java.net/browse/JDK-8162114 webrev: http://cr.openjdk.java.net/~ddhill/8162114 <http://cr.openjdk.java.net/%7Eddhill/8162114> -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his ey

review: Rename directories under modules to exactly match the module names

2016-07-27 Thread David Hill
brev: http://cr.openjdk.java.net/~ddhill/8161705 rename script: http://cr.openjdk.java.net/~ddhill/8161705/module_rename -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

Migrating FX patches to/from module paths

2016-08-01 Thread David Hill
is correct! Likely the new_patch will fail to apply cleanly if there is an error, but check the resulting diffs to make sure. * your mileage may vary. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey the world." -- George Santayana (1863 - 1952)

review: Add xpatch argfile creation script

2016-08-01 Thread David Hill
r whatever the build output to another location. The arguments in the file really have to be full paths to enable Java to find them. Script is attached to the JBS. -- David Hill Java Embedded Development "A man's feet should be planted in his country, but his eyes should survey th

review: (JDK-8163010) support macosx with fix_patch scripts

2016-08-02 Thread David Hill
Kevin, I really dislike platform specific code :-) yet another review (JDK-8163010) support macosx with fix_patch scripts <https://bugs.openjdk.java.net/browse/JDK-8163010> attached new versions of the files as it is a pretty big makeover. Diff is in the jbs. -- David Hill Java Em

Result: New OpenJFX Committer:Ankit Srivastava

2016-08-03 Thread David Hill
-- David Hill Java Embedded Development "The most likely way for the world to be destroyed, most experts agree, is by accident. That's where we come in; we're computer professionals. We cause accidents." -- Nathaniel Borenstein (1957 - )

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
a:34) at build_17kvkvc4f9j45htivwn1v303b$_run_closure5.doCall(/tmp/rt-b41445afa464/build.gradle:614) at build_17kvkvc4f9j45htivwn1v303b.run(/tmp/rt-b41445afa464/build.gradle:612) at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultSc

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
d say the culprit is here: 08:38:45.852 [INFO] [org.gradle.api.Project] Applying COMPILE_FLAGS_FILE 'buildSrc/.gradle' I think that COMPILE_TARGETS is "" since it's not a "mac", not a "win" nor a "linux". Vadim -- David Hill Java Embed

review: Build should fail fast with unsupported OS/ARCH

2016-08-04 Thread David Hill
thanks to Jyri's email, I have a simple fix to fail quickly and with a understandable error message. jbs: https://bugs.openjdk.java.net/browse/JDK-8163196 simple diff inside jbs -- David Hill Java Embedded Development "A man's feet should be planted in his country, but

Re: Compiling OpenJFX on OpenBSD

2016-08-04 Thread David Hill
bsd.gradle, fix the compile line issues in that configuration and then build with gradle -PCOMPILE_TARGETS=bsd With the change you have done, we would treat the platform as similar to linux, but with a configuration of bsd. Dave - Jyri -- Turvamies IT Security Services -- David Hill Java Embe

  1   2   3   4   >