Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Paul Fertser
On Mon, Jan 21, 2013 at 12:12:43PM +, John wrote: > > If you can formulate a decent patch, then learning Gerrit will be a > > walk in the park. In this light, the list isn't terribly concerned > > about those patches that we "miss out on" because someone doesn't want > > to spend the time to le

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Ing. Rodrigo Alejandro Melo
Only as example, I recently started to use openocd and I has sent some patches the last month. I use git as standalone on personal projects, but I never has used gerrit before. I has read http://openocd.sourceforge.net/doc/doxygen/html/patchguide.html, however, I has had several problems with t

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Øyvind Harboe
On Mon, Jan 21, 2013 at 1:12 PM, John wrote: > On Mon, Jan 21, 2013 at 12:11:33PM +0100, Øyvind Harboe wrote: >> Just to be clear: if you want to submit a patch to OpenOCD, then you >> do need to learn Gerrit to give your patch the best chances of review >> and approval. > > Of course a project ca

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread John
On Mon, Jan 21, 2013 at 12:11:33PM +0100, Øyvind Harboe wrote: > Just to be clear: if you want to submit a patch to OpenOCD, then you > do need to learn Gerrit to give your patch the best chances of review > and approval. Of course a project can enforce whatever its owners/busy members/etc decide.

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Øyvind Harboe
Just to be clear: if you want to submit a patch to OpenOCD, then you do need to learn Gerrit to give your patch the best chances of review and approval. It's pretty much a fact of life for open source that you need to show that you're willing to put in time if you expect that others are going to s

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread CeDeROM
On Mon, Jan 21, 2013 at 10:41 AM, Øyvind Harboe wrote: > Maybe we should have a FAQ in addition to the HACKING file? > Q: Can I update a patch in Gerrit? > A: Yes. Anyone can and are welcome to update patches with a new and > improved version. See Gerrit docs for details. Hello Øyvind :-) I was w

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Laurent Gauch
Le 21.01.2013 09:18, Peter Stuge a écrit : > Tomek CEDRO wrote: >> I suggest that we put all above information essence into the Handbook :-) > It has nothing to do with OpenOCD. If you want to work on Gerrit docs > that's great - but then I think that makes most sense *in the Gerrit > project*. Wha

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Øyvind Harboe
Maybe we should have a FAQ in addition to the HACKING file? Q: Can I update a patch in Gerrit? A: Yes. Anyone can and are welcome to update patches with a new and improved version. See Gerrit docs for details. On Mon, Jan 21, 2013 at 9:18 AM, Peter Stuge wrote: > Tomek CEDRO wrote: >> I suggest

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Tomek CEDRO
This question is frequently asked and it is about sending patches to OpenOCD so "it has anything to do" and one sentence would be nice to put into the Developers Handbook Hacking section, no? ;-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info 21 sty 2013 09:20, "Peter Stuge" napisał(a): > Tome

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Peter Stuge
Tomek CEDRO wrote: > I suggest that we put all above information essence into the Handbook :-) It has nothing to do with OpenOCD. If you want to work on Gerrit docs that's great - but then I think that makes most sense *in the Gerrit project*. //Peter ---

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Øyvind Harboe
On Mon, Jan 21, 2013 at 9:11 AM, Tomek CEDRO wrote: > I suggest that we put all above information essence into the Handbook :-) You mean HACKING? We want to keep the HACKING short and sweet. There are many superior, but tl;dr, sources of how to use git & Gerrit out there. A short paragraph on t

Re: [OpenOCD-devel] gerrit question

2013-01-21 Thread Tomek CEDRO
I suggest that we put all above information essence into the Handbook :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScr

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Øyvind Harboe
Hi Franck, > If I update the patch, I guess I'll be the new author and Robert > will be erased from the log. So I think I'll choose the second option and > push a separate change. You can safely update any Gerrit patch, without risking destroying anything or the wrath of the mailing list. If some

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Freddie Chopin
W dniu 2013-01-21 07:34, Franck Jullien pisze: > If I update the patch, I guess I'll be the new author and Robert > will be erased from the log. So I think I'll choose the second option and > push a separate change. Well, I think he won't be erased and the author will not change, so it all depend

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Franck Jullien
2013/1/20 Freddie Chopin : > W dniu 2013-01-20 20:01, CeDeROM pisze: >> On Sun, Jan 20, 2013 at 7:49 PM, Franck Jullien >> wrote: >>> I'd like to push a new patch set to an existing patch which is not >>> from me (http://openocd.zylin.com/#/c/467/). >>> I don't know if it's possible. >> >> Hey Fra

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Spencer Oliver
On 20/01/13 14:23, Franck Jullien wrote: > Hi, > > I'd like to add a patch to the existing usb_blaster driver rewrite > here: http://openocd.zylin.com/#/c/467/ > How would you do that ? > > Waiting for your advices. > 1. checkout the original change that you want to append: git fetch http://openoc

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Freddie Chopin
W dniu 2013-01-20 20:01, CeDeROM pisze: > On Sun, Jan 20, 2013 at 7:49 PM, Franck Jullien > wrote: >> I'd like to push a new patch set to an existing patch which is not >> from me (http://openocd.zylin.com/#/c/467/). >> I don't know if it's possible. > > Hey Franck, go to that commit in Gerrit, ma

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread CeDeROM
On Sun, Jan 20, 2013 at 7:49 PM, Franck Jullien wrote: > I'd like to push a new patch set to an existing patch which is not > from me (http://openocd.zylin.com/#/c/467/). > I don't know if it's possible. Hey Franck, go to that commit in Gerrit, make sure you are registered and logged in, see patc

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread Franck Jullien
2013/1/20 William M.A. Traynor : > On Sun, Jan 20, 2013 at 9:23 AM, Franck Jullien > wrote: >> Hi, >> >> I'd like to add a patch to the existing usb_blaster driver rewrite >> here: http://openocd.zylin.com/#/c/467/ >> How would you do that ? > > It's documented in the HACKING document in the sourc

Re: [OpenOCD-devel] gerrit question

2013-01-20 Thread William M.A. Traynor
On Sun, Jan 20, 2013 at 9:23 AM, Franck Jullien wrote: > Hi, > > I'd like to add a patch to the existing usb_blaster driver rewrite > here: http://openocd.zylin.com/#/c/467/ > How would you do that ? It's documented in the HACKING document in the source tree. You can read it directly in the sour