On Tue, Aug 30, 2011 at 6:53 AM, Øyvind Harboe wrote:
If Kernel programming guidelines requires variable names like that,
then I don't want to see it for OpenOCD.
Do not fear :) This is what the Linux Documentation/CodingStyle says:
Encoding the type of a function into the name (so-called
Do not fear :) This is what the Linux Documentation/CodingStyle says:
Encoding the type of a function into the name (so-called Hungarian
notation) is brain damaged - the compiler knows the types anyway and can
check those, and it only confuses the programmer. No wonder MicroSoft
makes buggy
On Tue, Aug 30, 2011 at 5:26 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:
Goal: switch OpenOCD to use the Kernel coding style
Plan:
a) get all outstanding patches merged
b) do wholesale automated(hopefully) code style fix
d) patch w/documentation and scripts to enforce the new coding
On Wed, Aug 31, 2011 at 12:21 AM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 11:26 Tue 30 Aug , Øyvind Harboe wrote:
Goal: switch OpenOCD to use the Kernel coding style
Plan:
a) get all outstanding patches merged
b) do wholesale automated(hopefully) code style fix
On Mon, Aug 29, 2011 at 1:07 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
Hi,
personnally I'd like we use the same coding style as the kernel
in the kernel anre barebox we use checkpatch to check the patch coding
style
I don't mind picking the
On Mon, Aug 29, 2011 at 7:35 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
On Mon, Aug 29, 2011 at 1:07 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
Hi,
personnally I'd like we use the same coding style as the kernel
in the kernel anre barebox we use
On Mon, Aug 29, 2011 at 7:35 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:
I don't mind picking the kernel style, if nothing else because we then can get
scripts to check for the style.
It seems people like Linux kernel coding style. It's widely used and
well documented. So I think it will
Hi,
personnally I'd like we use the same coding style as the kernel
in the kernel anre barebox we use checkpatch to check the patch coding
style
Best Regards,
J.
On 19:40 Sat 27 Aug , Øyvind Harboe wrote:
As a maintainer I'm interested in this subject from the point
On Mon, Aug 29, 2011 at 9:11 AM, Jie Zhang jzhang...@gmail.com wrote:
On Mon, Aug 29, 2011 at 7:35 AM, Øyvind Harboe oyvind.har...@zylin.com
wrote:
I don't mind picking the kernel style, if nothing else because we then can
get
scripts to check for the style.
It seems people like Linux
Le 29/08/2011 12:28, Eric Wetzel a écrit :
For the record, here are the relevant standards:
GNU: http://www.gnu.org/prep/standards/standards.html#Writing-C
Kernighan Ritchie:
http://en.wikipedia.org/wiki/Indent_style#K.26R_style (sorry, didn't
try very hard on this one)
Linux:
I strongly disagree on using anything that resembles KR.
Where I work you could get reprimanded and maybe even fired if you did
use it.
So are you saying that
if (x == y) {
x++;
} else {
x--;
}
is a serious offence where you work? If it is, I'd love to know the
logic behind the
2011/8/29 Michel Catudal michelcatu...@gmail.com:
Since we have bigger monitor than in the 70s and 80s why make the code
unreadable?
The only valid reason for using KR would be
1- You still expect to be stuck with a teletype at times and want to make
sure you can see many lines of code at
Le 29/08/2011 20:03, mike a écrit :
I strongly disagree on using anything that resembles KR.
Where I work you could get reprimanded and maybe even fired if you did
use it.
So are you saying that
if (x == y) {
x++;
} else {
x--;
}
is a serious offence where you work? If it is,
unsigned long ulApp_eOdometer_E2p;
or
U32 ulApp_eOdometer_E2p;
Now there are identifiers from hell.
- Since the invention of IDE's that can present type information, we
don't need to encode type info into the name.
- After the invention of namespaces, the world stopped embedding
scoping into
On 27.08.2011 19:40, Øyvind Harboe wrote:
As a maintainer I'm interested in this subject from the point of view
of how it can be used to *save* time of the maintainers.
E.g. if we had a script committed that checked that a patch sequence
was acceptable, then that report could be amended to the
On Sun, Aug 28, 2011 at 9:29 AM, Michael Schwingen
rincew...@discworld.dascon.de wrote:
On 27.08.2011 19:40, Øyvind Harboe wrote:
As a maintainer I'm interested in this subject from the point of view
of how it can be used to *save* time of the maintainers.
E.g. if we had a script committed
On 28.08.2011 10:04, Øyvind Harboe wrote:
Also, I'd be happy to let someone else define what the correct
coding style is. I don't particularly care as long as the check can
be automated and the style is consistent.
Are there scripts to fix coding style too?
at least indent and the C-Mode in
Hello,
eclipse are also able to format to a desired coding style.
I think we should define an indent rule and use it as base. Personally i use
the Allman-Style.
Openocd mix more then two styles, i have seen Allman, KR and GNU.
Regards,
Mathias
Am 28.08.2011 13:50, schrieb Michael Schwingen:
2011/8/26 Michel Catudal michelcatu...@gmail.com:
Le 25/08/2011 15:18, Jie Zhang a écrit :
Hi,
There are a lot of coding style mismatch in the current OpenOCD code.
I'd like suggest setting a rule that asks fixing all coding style
issues before a patch is merged.
And there are still
As a maintainer I'm interested in this subject from the point of view
of how it can be used to *save* time of the maintainers.
E.g. if we had a script committed that checked that a patch sequence
was acceptable, then that report could be amended to the patch
sequence.
Thus maintainers would not
There is a tool that has been around for a long time that can
address this issue. It's called indent. It has numerous options
that can generate just about any type of coding style.
Jim
___
Openocd-development mailing list
On Sat, Aug 27, 2011 at 1:40 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
As a maintainer I'm interested in this subject from the point of view
of how it can be used to *save* time of the maintainers.
E.g. if we had a script committed that checked that a patch sequence
was acceptable,
On Sat, Aug 27, 2011 at 5:49 PM, j. m. norris u17...@att.net wrote:
There is a tool that has been around for a long time that can
address this issue. It's called indent. It has numerous options
that can generate just about any type of coding style.
I don't know if indent can check in-line
Le 25/08/2011 15:18, Jie Zhang a écrit :
Hi,
There are a lot of coding style mismatch in the current OpenOCD code.
I'd like suggest setting a rule that asks fixing all coding style
issues before a patch is merged.
And there are still something missing on
24 matches
Mail list logo
