Very good work Hung.
Ack with a few comments inlined in the relevant patch mails (separate
replies).
/AndersBj
On 09/18/2015 09:11 AM, Hung Nguyen wrote:
> Summary: imm: Add attribute def flag SA_IMM_ATTR_DEFAULT_REMOVED [#1471]
> Review request for Trac Ticket(s): 1471
> Peer Reviewer(s):
Comments inline.
On 09/18/2015 09:11 AM, Hung Nguyen wrote:
> opensaf.spec.in | 1 +
> osaf/libs/agents/saf/imma/imma_cb.h | 1 +
> osaf/libs/agents/saf/imma/imma_def.h | 2 +-
> osaf/libs/agents/saf/imma/imma_oi_api.c | 3 +
>
Ack from me.
Not tested.
/AndersBj
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 september 2015 08:12
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: corrected
Hi Neelakanta,
'errStrList' is populated in immnd_evt_proc_ccb_obj_create_rsp(), it's not from
the OI.
Why we have to assert the type of incoming message (from OI) here?
Best Regards,
Hung Nguyen - DEK Technologies
Summary: imm: corrected missmatch in the event type for CCB create rsp [#1494]
Review request for Trac Ticket(s): 1494
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es): default(4.7)
Development branch: default
Impacted area Impact y/n
Hi Nhat Pham,
I had look at the final TRACE content of CPND & CPD ,
in some of the TRACE content like sec_id looks incorrect, and in some
cases the node id being printed `node 0x0` my be we required
conditional check,
so attached the CPND traces for your reference. ( file is large so
Ack,
Mathi.
- vu.m.ngu...@dektech.com.au wrote:
> osaf/services/saf/logsv/lgs/lgs_imm.c | 47 ++
> tests/logsv/tet_LogOiOps.c| 141
> ++
> 2 files changed, 170 insertions(+), 18 deletions(-)
>
>
> At start up, `logStreamFileFormat`
Summary: imm: Add attribute def flag SA_IMM_ATTR_STRONG_DEFAULT [#1425]
Review request for Trac Ticket(s): 1425
Peer Reviewer(s): AndersBj, Zoran, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area
osaf/tools/safimm/immcfg/imm_import.cc | 5 -
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immlist/imm_list.c | 6 ++
3 files changed, 19 insertions(+), 1 deletions(-)
Add support for strong default to IMM tools.
diff --git
tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c |6 +
tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 173 +
tests/immsv/management/test_saImmOmCcbInitialize.c |6 +
tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 173 +
osaf/libs/agents/saf/imma/imma_om_api.c | 6 ++
osaf/libs/common/immsv/immpbe_dump.cc | 3 ++-
osaf/libs/saf/include/saImmOm_A_2_16.h | 3 +++
3 files changed, 11 insertions(+), 1 deletions(-)
SA_IMM_ATTR_STRONG_DEFAULT flag is supported in version A.02.16 or higher.
diff --git
osaf/services/saf/immsv/immloadd/imm_loader.cc | 7 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 81 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 8 +-
osaf/services/saf/immsv/schema/SAI-AIS-IMM-XSD-A.02.16.xsd | 1 +
4 files
Hi Zoran,
ACK form me , Not tested.
By the way In which participial case you are getting Zero bytes message
(How do you reproduce ) ?
Can you please share the Application that sends Zero bytes if you have ,
I may required in some other testing.
-AVM
On 9/22/2015 5:57 PM, Zoran Milinkovic
Hi Hung,
yes, immnd_evt_proc_ccb_obj_modify_rsp needs to be corrected .
IMMND_EVT_A2ND_CCB_OBJ_CREATE_RSP is present instead of
IMMND_EVT_A2ND_CCB_OBJ_MODIFY_RSP.
/Neel.
On Tuesday 22 September 2015 12:55 PM, Hung Nguyen wrote:
> Thanks, I got it.
>
> I think immnd_evt_proc_ccb_obj_modify_rsp()
Hi Vu,
Acked and tested
Best Regards,
Giang Do
On 17/09/2015 17:46, Vu Minh Nguyen wrote:
> osaf/services/saf/logsv/lgs/lgs_imm.c | 47 ++
> tests/logsv/tet_LogOiOps.c| 141
> ++
> 2 files changed, 170 insertions(+), 18 deletions(-)
>
Hi Hung,
The IMMND_EVT_A2ND_CCB_OBJ_CREATE_RSP is the message type comes from OI
when error string is not set.
/Neel.
On Tuesday 22 September 2015 12:44 PM, Hung Nguyen wrote:
> Hi Neelakanta,
>
> 'errStrList' is populated in immnd_evt_proc_ccb_obj_create_rsp(), it's
> not from the OI.
> Why
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Tuesday, September 22, 2015 8:12 AM
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: corrected
Thanks, I got it.
I think immnd_evt_proc_ccb_obj_modify_rsp() also needs to be corrected.
It should be IMMND_EVT_A2ND_CCB_OBJ_MODIFY_RSP in stead of
IMMND_EVT_A2ND_CCB_OBJ_MODIFY_RSP_2.
Best Regards,
Hung Nguyen - DEK Technologies
Comments inline.
On 09/18/2015 09:11 AM, Hung Nguyen wrote:
> osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 +-
> osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
> osaf/services/saf/immsv/immnd/ImmModel.cc | 81 +-
>
Hi Hung,
Reviewed and tested the patch.
Ack
The patch 3 need to be re-based to latest staging while pushing.
/Neel.
On Friday 18 September 2015 12:41 PM, Hung Nguyen wrote:
> Summary: imm: Add attribute def flag SA_IMM_ATTR_DEFAULT_REMOVED [#1471]
> Review request for Trac Ticket(s): 1471
>
Hi Vu,
See my comments below:
Thanks
Lennart
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 22 september 2015 04:51
To: Lennart Lund; mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] log: Rt obj
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
Best Regards,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Tuesday, September 22, 2015 6:51PM
To: Neelakanta
Summary: imm: guard osafimmpbed by parent pid instead of parent name [#1496]
Review request for Trac Ticket(s): 1496
Peer Reviewer(s): Neelakanta, Hung, Anders
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area
osaf/services/saf/immsv/immpbed/immpbe.cc | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
The patch change the parent check from parent process name to parent pid.
This patch will allow to start osafimmnd with debugging tools (valgrind, etc.)
when PBE is enabled.
diff
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
When new and old default values are checked in schema upgrade, memory allocated
by copyValueToEdu() is not freed.
The patch releases allocated memory.
diff --git
Summary: imm: fix memory leak in schema upgrade [#1495]
Review request for Trac Ticket(s): 1495
Peer Reviewer(s): Neelakanta, Hung, Anders
Pull request to: Zoran
Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, dfault(4.7)
Development branch: default(4.7)
Hi Zoran,
Reviewed the patch.
Ack.
/Neel.
On Tuesday 22 September 2015 04:29 PM, Zoran Milinkovic wrote:
> Summary: imm: fix memory leak in schema upgrade [#1495]
> Review request for Trac Ticket(s): 1495
> Peer Reviewer(s): Neelakanta, Hung, Anders
> Pull request to: Zoran
> Affected
Hi Hung,
Ack from me.
Reviewed and tested the patch.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, September 18, 2015 9:12 AM
To: Anders Björnerstedt; Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc:
osaf/libs/core/mds/mds_dt_tipc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Unlock mutex when 0 bytes is read from TIPC connection
diff --git a/osaf/libs/core/mds/mds_dt_tipc.c b/osaf/libs/core/mds/mds_dt_tipc.c
--- a/osaf/libs/core/mds/mds_dt_tipc.c
+++
Summary: mds: unlock mutex when 0 bytes is read from TIPC socket [#1497]
Review request for Trac Ticket(s): 1497
Peer Reviewer(s): Mahesh
Pull request to: Zoran
Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, default(4.7)
Development branch: default(4.7)
30 matches
Mail list logo
