[devel] [PATCH 0 of 1] Review Request for plm: let hsm init plmc at system init [#1813]

2016-06-09 Thread Alex Jones
Summary: plm: let hsm init plmc at system init Review request for Trac Ticket(s): 1813 Peer Reviewer(s): Mathi Pull request to: Mathi Affected branch(es): default, 5.0, 4.7 Development branch: Impacted area Impact y/n Docs

[devel] [PATCH 1 of 1] plm: let hsm init plmc at system init [#1813]

2016-06-09 Thread Alex Jones
osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 6 ++ osaf/services/saf/plmsv/plms/plms_amf.c | 10 -- 2 files changed, 14 insertions(+), 2 deletions(-) EE on which active PLMS is running can be shutdown when it receives its own plmc connection. The plmc socket is

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-09 Thread Lennart Lund
Hi Vu Ack. I have run legacy and resilience tests (except suite 11) Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 9 juni 2016 06:41 > To: Lennart Lund ; 'A V Mahesh' > > Cc:

[devel] [PATCH 1 of 2] amfd: Segv in ng_ccb_completed_delete_hdlr [#1766]

2016-06-09 Thread praveen . malviya
osaf/services/saf/amf/amfd/nodegroup.cc | 10 ++ osaf/services/saf/amf/amfd/su.cc| 12 +++- 2 files changed, 21 insertions(+), 1 deletions(-) Note: This patch is work of Hans N and it is for the crash given in the description of ticket #1766. When running SMF tests

[devel] [PATCH 0 of 2] Review Request for amfd: fix amfd crashes related to NG[#1766].

2016-06-09 Thread praveen . malviya
Summary: amfd: fix amfd crashes related to NG[#1766]. Review request for Trac Ticket(s): #1766 Peer Reviewer(s): AMFD devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n Docs

[devel] [PATCH 0 of 1] Review Request for rde: Fix cppcheck warnings [#1870]

2016-06-09 Thread Anders Widell
Summary: rde: Fix cppcheck warnings [#1870] Review request for Trac Ticket(s): 1870 Peer Reviewer(s): Ramesh Pull request to: Affected branch(es): default(5.1) Development branch: default Impacted area Impact y/n Docs

Re: [devel] [PATCH 1 of 1] nid: Add support for multiple tipc bearers to configure_tipc [#1862]

2016-06-09 Thread A V Mahesh
ACK , Tested . -AVM On 6/9/2016 11:24 AM, Hung Nguyen wrote: > Hi Mahesh, > > The script compares ETH_NAME (which is comma delimited) with output from > "tipc-config -b" (which is LF delimited). > That only works when using single bearer. > The script will fail in case of multiple bearers. > >

Re: [devel] [PATCH 1 of 1] AMFD: Update RTA saAmfSUHostedByNode after headless [#1720] V2

2016-06-09 Thread praveen malviya
Ack code review only. Thanks, Praveen On 09-Jun-16 5:11 AM, minh chau wrote: > Hi Praveen, > > saAmfSUHostedByNode should be cold synced after headless. The > avd_process_state_info_queue() is called before active amfd creates > Opensaf-2N assignment for SCs. The standby assignment for

Re: [devel] [PATCH 1 of 1] nid: Add support for multiple tipc bearers to configure_tipc [#1862]

2016-06-09 Thread Anders Widell
Excellent, I think this version of the code is more readable and I get zero warnings from shellcheck. :-) ACK. thanks, Anders Widell On 06/09/2016 06:19 AM, Hung Nguyen wrote: > osaf/services/infrastructure/nid/scripts/configure_tipc.in | 12 > +++- > 1 files changed, 3

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

2016-06-09 Thread Lennart Lund
Hi This means that both ticket #1847 and #1865 must be closed when this is pushed! But I am ok with this, #1865 is for test /Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 9 juni 2016 06:41 > To: Lennart Lund