Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, On 2/22/2017 12:19 PM, Vu Minh Nguyen wrote: > [Vu] I has sent you 02 patches. There is code change in osaflogd code that > fix the coredump you have observed. > The other one is test code that fix the logtest coredump. Ok I will re-test , and update you . -AVM On 2/22/2017 12:19 PM, Vu

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Mahehs, See my reply inline, [Vu]. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, February 22, 2017 1:36 PM > To: Vu Minh Nguyen ; > lennart.l...@ericsson.com; canh.v.tru...@dektech.com.au > Cc:

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, One more point, this is always reproducible , I was running /usr/bin/logtest on active node only . Let us investigate why osaflogd core dumped SC-1:~ # /etc/init.d/opensafd status

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, On 2/22/2017 11:52 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > Have a code fault in uml test, and other one in checkpoint. [AVM] This is Normal Suse 11 VM ( not UML). > I have just updated the code. Please re-apply for #3 and #4 patches. [AVM] is these new patch has function changes or

Re: [devel] [PATCH 1 of 1] dtm: Use .1 file name extension for MDS log backup file [#2241]

ACK not tested -AVM On 2/21/2017 10:49 PM, Anders Widell wrote: > src/dtm/transport/log_writer.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Use a ".1" file name extension for the MDS log backup file. This aligns with > the > naming convention used for log rotation

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, Thanks , While testing /usr/bin/logtest , SC-2 standby osaflogd core dumped and /usr/bin/logtest on SC-1 Active got Segmentation fault , am I missing any other patch ( i am using devel published patch only ) Following patches i am using : 1) #2293 (sent by Anders Widel, but not

Re: [devel] [PATCH 1 of 1] AMFND: Ensure su operational message synchronizes with component failover sequence [#2233]

Hi Minh, Please see response with [Praveen] Thanks Praveen On 22-Feb-17 5:39 AM, minh chau wrote: > Hi Praveen, > > Please find my response with [Minh2] > > Thanks, > Minh > > On 21/02/17 16:45, praveen malviya wrote: >> Hi Minh, >> >> Please find my response inline with [Praveen]. >> >>

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, Sorry I did missed Lennart #2258 (v2) , now it is fine -AVM On 2/22/2017 9:39 AM, A V Mahesh wrote: > Hi Vu, > > I did follow that still i get Hunk #2 FAILED even on today's staging > > > > > >

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, I did follow that still i get Hunk #2 FAILED even on today's staging [root@dhcp-hyd-scp-5fl-10-176-177-96 staging]# patch -p1 <2293 patching file src/base/Makefile.am Hunk #1 succeeded at 33 (offset 1 line).

[devel] [PATCH 0 of 1] Review Request for osaf: fix saflog to handle long log record [#2313]

Summary: osaf: fix saflog to handle long log record [#2313] Review request for Trac Ticket(s): #2313 Peer Reviewer(s): Lennart Lund, Mahesh Valla, Vu M Nguyen Pull request to: Vu M Nguyen Affected branch(es): all Development branch: default Impacted area

[devel] [PATCH 1 of 1] osaf: fix saflog to handle long log record [#2313]

src/osaf/saflog/saflog.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) saflog is a utility function provided for other OpenSAF services to write log records to the system log stream. Before this ticket, saflog limited the log record size to only 255 chars, which made it

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Ack Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, February 16, 2017 1:49 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > mahesh.va...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject:

Re: [devel] [PATCH 1 of 1] AMFND: Ensure su operational message synchronizes with component failover sequence [#2233]

Hi Praveen, Please find my response with [Minh2] Thanks, Minh On 21/02/17 16:45, praveen malviya wrote: > Hi Minh, > > Please find my response inline with [Praveen]. > > Thanks, > Praveen > > On 20-Feb-17 6:58 AM, minh chau wrote: >> Hi Praveen, >> >> Thanks for your V2 patch, I have tested V2

[devel] [PATCH 1 of 1] dtm: Use .1 file name extension for MDS log backup file [#2241]

src/dtm/transport/log_writer.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Use a ".1" file name extension for the MDS log backup file. This aligns with the naming convention used for log rotation of other log files under /var/log, and opens up the possibility for a future

[devel] [PATCH 0 of 1] Review Request for dtm: Use .1 file name extension for MDS log backup file [#2241]

Summary: dtm: Use .1 file name extension for MDS log backup file [#2241] Review request for Trac Ticket(s): 2241 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.2) Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 3] log: add alternative destinations of log records [#2258]

Hi Vu Ack with commants See comments below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 21 februari 2017 10:34 > To: Lennart Lund ; mahesh.va...@oracle.com; > Canh Van Truong

Re: [devel] [PATCH 1 of 1] base: Add a collision-resistant hash function [#2266]

Hi! See replies marked AndersW>. regards, Anders Widell On 02/21/2017 01:31 PM, Zoran Milinkovic wrote: > Hi Anders, > > I have few comments to the patch > > The hash function will not work on big endian systems. > Do we support only little endian systems or OpenSAF code should work on both >

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu See my comment below [Lennart] I will continue reviewing part 1 Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 21 februari 2017 10:34 > To: Lennart Lund ; mahesh.va...@oracle.com; > Canh Van

Re: [devel] [PATCH 1 of 1] base: Add a collision-resistant hash function [#2266]

Hi Anders, I have few comments to the patch The hash function will not work on big endian systems. Do we support only little endian systems or OpenSAF code should work on both endian systems ? Base64 has only encoding function. If something is going to be pushed to base directory, then I think

Re: [devel] [PATCH 1 of 1] amfd: fix default value of saAmfSIPrefActiveAssignments [1190]

Hi All, Please provide your feedback on #1190 (V2), #2252 and #2259. Thanks, Praveen On 20-Feb-17 11:58 AM, praveen malviya wrote: > Hi Gary, > > I think value '0' can be used for saAmfSIPrefActiveAssignments to > indicate AMFD to use default value as saAmfSGNumPrefAssignedSUs. In all >

Re: [devel] [PATCH 2 of 3] log: Add minor version checking in log server [#2146]

Hi Canh Ack with comment see [Lennart] I will not review part 1 (implementation of filter callback) again since I acked that part in the previous review Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 16 februari 2017 07:49

[devel] [PATCH 0 of 1] Review Request for amfd: support si-swap admin op for NplusM model [#2259]

Summary:amfd: support si-swap admin op for NplusM model [#2259] Review request for Trac Ticket(s): #2259 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] amfd: support si-swap admin op for NplusM model [#2259]

src/amf/amfd/sg.cc | 12 +++- src/amf/amfd/sg.h |4 + src/amf/amfd/sg_npm_fsm.cc | 145 - src/amf/amfd/su.cc | 11 +++ src/amf/amfd/su.h |2 + 5 files changed, 144 insertions(+), 30 deletions(-) This

Re: [devel] [PATCH 0 of 1] Review Request for imm: Cleanup orphaned implementers and admowners when headless [#2309]

Hi Hung, got it. Reviewed the patch. Ack. Thanks, Neel. On 2017/02/21 01:01 PM, Hung Nguyen wrote: > Hi Neel, > > The problem is, > in immnd_proc_discard_other_nodes(), it fails to use > immnd_client_node_getnext() to get the client_node associated to the OI that > being discarded. > The

Re: [devel] [PATCH 1 of 1] lgs: Add new multivalue attributes to configuration handler [#2258]

Hi Lennart, Ack with few comments. [Vu] Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, February 20, 2017 10:18 PM > To: mahesh.va...@oracle.com; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net > Subject:

[devel] [PATCH 1 of 1] base: Add a collision-resistant hash function [#2266]

src/base/Makefile.am| 16 +- src/base/hash.cc| 239 src/base/hash.h | 32 + src/base/tests/hash_test.cc | 109 4 files changed, 390 insertions(+), 6 deletions(-) Add a function that

Re: [devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Hi Vu, Is this applies on top of log #2146 - V4 , I see both #tickets has version changes ? in which order i need to apply ( #2146 & #2258 )or (#2258 & #2146). = patching file src/log/Makefile.am Hunk #1 FAILED at 72. Hunk #2

Re: [devel] [PATCH 3 of 3] log: fix checking version in log agent [#2146]

Hi Canh This patch Ack Will continue reviewing patch 2 Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 16 februari 2017 07:49 > To: Lennart Lund ; Vu Minh Nguyen > ;

Re: [devel] [PATCH 1 of 1] imm: Cleanup orphaned implementers and admowners when headless [#2309]

Hi Hung, Reviewed the patch. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 17 februari 2017 09:06 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, I got it, i got confused because of increased version to A.02.03 , I went through version handling given by Lennart I just ACKed it. -AVM On 2/21/2017 3:29 PM, Canh Truong wrote: > Hi Mahesh, > > SaLogFilterSetCallbackT was already declared before . So we don't have to > add more

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Mahesh, SaLogFilterSetCallbackT was already declared before . So we don't have to add more one header file. Regards Canh -Original Message- From: Canh Truong [mailto:canh.v.tru...@dektech.com.au] Sent: Tuesday, February 21, 2017 4:41 PM To: 'A V Mahesh';

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, ACK tested ( including agent upgrade ) -AVM On 2/21/2017 3:11 PM, Canh Truong wrote: > Hi Mahesh, > > The saLogFilterSetCallback is already existing in spec. But it has not > implemented yet. The patch implemented to received filter callback from log > server. So we increase version to

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Mahesh, The saLogFilterSetCallback is already existing in spec. But it has not implemented yet. The patch implemented to received filter callback from log server. So we increase version to A.02.03. You can refer at Lennart's comments in https://sourceforge.net/p/opensaf/tickets/2146/ for

[devel] [PATCH 3 of 3] log: add unit tests to verify interfaces provided by destination handler [#2258]

src/log/Makefile |4 + src/log/Makefile.am| 19 +++ src/log/tests/Makefile | 20 +++ src/log/tests/lgs_dest_test.cc | 209 + 4 files changed, 252 insertions(+), 0 deletions(-) Unit tests to verify major

[devel] [PATCH 1 of 3] log: add alternative destinations of log records [#2258]

src/log/Makefile.am |8 +- src/log/config/logsv_classes.xml |7 +- src/log/logd/lgs_config.cc | 169 - src/log/logd/lgs_config.h|3 +- src/log/logd/lgs_dest.cc | 707 +++ src/log/logd/lgs_dest.h

[devel] [PATCH 0 of 3] Review Request for log: add alternative destinations of log records [#2258] V4

Summary: log: add alternative destinations of log records [#2258] Review request for Trac Ticket(s): #2258 Peer Reviewer(s): Lennart, Canh, Mahesh Pull request to: <> Affected branch(es): Default Development branch: Default Impacted area Impact y/n

[devel] [PATCH 2 of 3] log: add UML test case to verify alternative destination [#2258]

src/log/Makefile.am |4 +- src/log/apitest/tet_LogOiOps.c|8 +- src/log/apitest/tet_cfg_destination.c | 483 ++ 3 files changed, 490 insertions(+), 5 deletions(-) Major changes: 1) Modify Lennart's test cases because enhancing

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, I am sorry saLogFilterSetCallback is existing call back in specification and it seem we increased initialized version jut to support agent version is that right ? -AVM On 2/21/2017 2:51 PM, A V Mahesh wrote: > Hi Canh, > > The general practice of implementing any upcoming

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, The general practice of implementing any upcoming functionality of SAF specification we do define in relevant structures `src//saf/` file for example `src/ckpt/saf/saCkpt_B_02_03.h` in addition to `src/ckpt/saf/saCkpt.h`, so that user will include that new .h file for new

[devel] FW: [PATCH 1 of 3] log: add alternative destinations of log records [#2258]

Hi Vu, Please see some my comments with [Canh] Regards Canh -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday, February 16, 2017 5:30 PM To: lennart.l...@ericsson.com; mahesh.va...@oracle.com; canh.v.tru...@dektech.com.au Cc:

Re: [devel] [PATCH 0 of 3] Review Request for log: implement SaLogFilterSetCallbackT and version handling V4 [#2146]

Hi Canh, I can see that you are passing NULL callbacks as `` for "logtest 1 10" and " logtest 1 11" by seeing -AVM On 2/21/2017 1:02 PM, Canh Truong wrote: > Hi Mahesh, > > The test case " logtest 1 10" and " logtest 1 11" are created for version > handling. In standby node, it has new code