[devel] [PATCH 3/3] base: Use the OpenSAF internal log service for trace [#2165]

Instead of writing trace messages directly to a file, use the OpenSAF internal log service which is implemented in osaftransportd. As a consequence, the trace files will now be rotated automatically when they have exceeded the maximum allowed log file size. --- src/base/logtrace.cc | 280

[devel] [PATCH 1/3] dtm: Support multiple OpenSAF internal log streams [#2165]

Extend the OpenSAF internal log service so that it supports multiple log streams in addition to the MDS log. All log streams are received on the same socket and the stream name is extracted from the MSGID field. Each stream is written to a separate file based on the name of the stream. ---

[devel] [PATCH 2/3] base: Convert logtrace to C++ [#2165]

--- src/base/Makefile.am | 2 +- src/base/logtrace.c | 268 --- src/base/logtrace.cc | 253 src/base/logtrace.h | 88 - 4 files changed, 298 insertions(+), 313 deletions(-)

[devel] [PATCH 0/3] Review Request for base: Use the OpenSAF internal log service for trace [#2165]

Summary: dtm: Support multiple OpenSAF internal log streams [#2165] Review request for Ticket(s): 2165 Peer Reviewer(s): Hans, Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2165 Base revision: 30fdde2868dce841d08e697b39c1bc753346d8a4 Personal repository:

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

Just tried it that was not the case for patch, still got the "*" c0b25cd7a1a94d386d813735c72d22abded8583b base: Atomically create pid file from temporary pid file V2 [#2432] On 10/10/2017 02:39 PM, Zoran Milinkovic wrote: Hi, Reviewed and tested the patch. Ack from me with minor comment.

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

Hi, Reviewed and tested the patch. Ack from me with minor comment. When OpenSAF is started the second time, it exits with "*". It would be good to write some text why OpenSAF didn't succeed to start, as it was a case with Hans's patch earlier. Thanks, Zoran -Original Message- From:

Re: [devel] [PATCH 1/1] smf: Upgrade failed due to CCB aborted by imm sync request [#2584]

Hi Lennart, We need to correct this in few other files/functions in SMF service. How about having a separate ticket to track those change related to timer class object ? Thanks Vijay -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Tuesday, October 10,

Re: [devel] [PATCH 1/1] smf: Upgrade failed due to CCB aborted by imm sync request [#2584]

Hi Vijay, Almost there. I found one more thing about usage of the Timer class that I had missed. See attached diff with my comments. Also another minor comment. Naming the Timer class object " adminOpTimer" is not correct here since it is not used for timing an admin operation. Maybe you

[devel] [PATCH 0/1] Review Request for base: double start failed [#2622]

Summary: base: double start failed [#2622] Review request for Ticket(s): 2622 Peer Reviewer(s): zoran/hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2622 Base revision: 30fdde2868dce841d08e697b39c1bc753346d8a4 Personal

[devel] [PATCH 1/1] base: double start failed [#2622]

Previously named function "check_env" overwrites pid file. Move it to after running pidofproc for amfnd pid. --- src/nid/opensafd.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in index effe87d..d7035f5 100644 ---

[devel] [PATCH 2/2] msg: don't create cache entry during delete operation [#2619]

Fix typo. --- src/msg/common/mqsv_asapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/msg/common/mqsv_asapi.c b/src/msg/common/mqsv_asapi.c index 8b6fb65..1d5d629 100644 --- a/src/msg/common/mqsv_asapi.c +++ b/src/msg/common/mqsv_asapi.c @@ -649,7 +649,7 @@ static

[devel] [PATCH 0/2] Review Request for msg: don't create cache entry for delete operation [#2619]

Summary: msg: don't create cache entry if operation is delete [#2619] Review request for Ticket(s): 2619 Peer Reviewer(s): Srinivas Pull request to: Affected branch(es): develop Development branch: ticket-2619 Base revision: 30fdde2868dce841d08e697b39c1bc753346d8a4 Personal repository:

[devel] [PATCH 1/2] msg: don't create cache entry if operation is delete [#2619]

saMsgMessageSend and Async calls return TRY_AGAIN forever after controller failover. If more than 1 ASAPi_MSG_TRACK_NTFY for deletion is processed by the cache, the first time the cache entry will be deleted. When the second one comes in, before a new queue registration message has been received,

[devel] [PATCH 0/1] Review Request for smf: Upgrade failed due to CCB aborted by imm sync request [#2584]

Summary: smf: Upgrade failed due to CCB aborted by imm sync request [#2584] Review request for Ticket(s): 2584 Peer Reviewer(s): lennart.l...@ericsson.com, rafael.odza...@ericsson.com Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch:

[devel] [PATCH 1/1] smf: Upgrade failed due to CCB aborted by imm sync request [#2584]

The Patch provides the fix where smfCreateRollbackElement return OK to avoid failed/ERR_EXIST situation. Also fixed the logging of messages correctly. * This issue is a by-product of the fix/patch provided at commit 44d113c4fa669065afe78d70bc81c5297d79ec0e. ---

Re: [devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message V2 [#2590]

Hi Anders, thanks, I'll fix the comments before pushing/Regards Hans On 10/10/2017 11:04 AM, Anders Widell wrote: Ack with minor comments inline, marked AndersW> regards, Anders Widell On 10/06/2017 11:10 AM, Hans Nordeback wrote: ---   scripts/opensaf_scale_out  | 14 +-  

Re: [devel] [PATCH 1/1] amf: Allow SI and SI Dependency object to be deleted in same ccb [#2585]

Hi Minh, Ack for the patch as well AMF PR doc update Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, September 28, 2017 6:24 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; praveen.malv...@oracle.com;

Re: [devel] [PATCH 1/1] msg: don't create cache entry if operation is delete [#2619]

Hi Alex, Please find my comments below, preceded with [Srinivas]. Thank you Srinivas -Original Message- From: Alex Jones [mailto:alex.jo...@genband.com] Sent: Friday, October 6, 2017 7:05 PM To: Venkata Mahesh Alla Cc: Alex Jones ;

Re: [devel] [PATCH 1/1] clm: Add user data in CLMSV_CLUSTER_JOIN_REQ message V2 [#2590]

Ack with minor comments inline, marked AndersW> regards, Anders Widell On 10/06/2017 11:10 AM, Hans Nordeback wrote: --- scripts/opensaf_scale_out | 14 +- src/clm/README | 17 src/clm/clmd/clms_cb.h | 2 ++ src/clm/clmd/clms_evt.c| 32

Re: [devel] [PATCH 1/1] log: fix test case logtest 5 2 failed due to logsv is busy [#2600]

Hi Canh Ack with comment. See [Lennart] below > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 9 oktober 2017 13:27 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: