Re: [devel] [PATCH 1 of 1] cpsv: cpd broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP [#1615]

2015-12-01 Thread A V Mahesh
[468:cpsv_evt.c:2201] TR cpnd <<== [3] > CPND_EVT_D2ND_CKPT_INFO(err=1, active=0x2020F, create_rep=false) from CPD > > So, the flow in this case is: > cpnd_evt_proc_ckpt_open() --> CPD_EVT_ND2D_CKPT_CREATE --> > cpd_evt_proc_ckpt_create() > > Best regards, > Nhat Pham > > -Original M

Re: [devel] [PATCH 1 of 1] cpsv: cpd broadcasts CPND_EVT_D2ND_CKPT_RDSET with STOP [#1615]

2015-12-01 Thread A V Mahesh
Hi , We may need to handle else condition of below with `cp_node->is_unlink == true` case in function cpnd_evt_proc_ckpt_open() `if(((cp_node = cpnd_ckpt_node_find_by_name(cb, ckpt_name)) != NULL) && cp_node->is_unlink == false) {` -AVM On 12/1/2015 3:25 PM, A V Mahe

Re: [devel] [PATCH 0 of 1] Review Request for ckpt: cpsv tests improvement [#1481] v3

2015-11-23 Thread A V Mahesh
Hi, ACK from me . It looks patch covered the previous comments are addressed , now we can push this patch ( not tested ) subsequent while usage if we find any small things missing we can fix them as Bug later , so please go a head and push it . -AVM On 11/23/2015 8:44 AM, Nhat Pham

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: The checkpoint name in the replica file name lacks last character [#1539]

2015-10-13 Thread A V Mahesh
ster=myClmCluster,safCkpt=test_cp_1 > root@PL-3:~# ls -l /run/shm/ > total 692 > -rw-r--r-- 1 root root 704008 Oct 13 10:32 > opensaf_CPND_CHECKPOINT_INFO_131855 > -rw-r--r-- 1 root root 4968 Oct 13 10:33 opensaf_safCkpt=test_cp__131855_1 > > Best regards, > Nhat Pham > >

Re: [devel] [PATCH 1 of 1] cpsv: trace log enhancement build 32bit fails [#1524]

2015-10-13 Thread A V Mahesh
ACK. -AVM On 10/7/2015 12:20 PM, Nhat Pham wrote: > osaf/libs/common/cpsv/cpsv_evt.c | 16 > osaf/services/saf/cpsv/cpd/cpd_proc.c | 2 +- > osaf/services/saf/cpsv/cpnd/cpnd_mds.c | 2 +- > 3 files changed, 10 insertions(+), 10 deletions(-) > > > diff --git

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: The checkpoint name in the replica file name lacks last character [#1539]

2015-10-13 Thread A V Mahesh
oot root 4968 Oct 13 15:09 opensaf_safCkpt=test_cp_3_132367_3 > > Best regards, > Nhat Pham > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Tuesday, October 13, 2015 2:49 PM > To: Nhat Pham <nhat.p...@dektech.com.

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: The checkpoint name in the replica file name lacks last character [#1539]

2015-10-13 Thread A V Mahesh
Hi Nhat Pham, Do you mean ls /dev/shm & immfind should be the same ? -AVM On 10/13/2015 10:20 AM, Nhat Pham wrote: > Summary: cpsv: The checkpoint name in the replica file name lacks last > character > Review request for Trac Ticket(s): #1539 > Peer Reviewer(s): mahesh.va...@oracle.com

Re: [devel] [PATCH 0 of 1] Review Request for CKPT: fix crash in cpnd when checkpoint open sync to active times out [#1510]

2015-10-05 Thread A V Mahesh
Hi Alex, On 10/1/2015 10:34 PM, Alex Jones wrote: > When a collocated checkpoint replica is opened, and the active replica > has > large numbers of sections (~200k), can you please share the size of each sections . -AVM On 10/5/2015 9:31 AM, A V Mahesh wrote: > Hi Alex, >

Re: [devel] [PATCH 0 of 1] Review Request for CKPT: fix crash in cpnd when checkpoint open sync to active times out [#1510]

2015-10-05 Thread A V Mahesh
the sections is approximately 2k. > >I don't have a test program that exhibits this. This was captured in our > product. > >I do want to look into why the sync is timing out. I may create another > bug for that depending on what I find. > > Alex > > _____

Re: [devel] [PATCH 0 of 1] Review Request for CKPT: fix crash in cpnd when checkpoint open sync to active times out [#1510]

2015-10-04 Thread A V Mahesh
Hi Alex, If you have ready to use test application can you please attach. -AVM On 10/1/2015 10:34 PM, Alex Jones wrote: > Summary: CKPT: fix crash in cpnd when opening replica times out [#1510] > Review request for Trac Ticket(s): 1510 > Peer Reviewer(s): AVM > Pull request to: AVM > Affected

Re: [devel] [PATCH 1 of 1] ckpd: enhanced trace log and check of user parameters [#1224]

2015-09-28 Thread A V Mahesh
OWN(4)) TR cpnd <<== [1] CPND_EVT_D2ND_CKPT_REP_ADD(dest=0x2010F, active=0x0, restart=false, dest_cnt=0) from CPD TR cpnd ==>> [1] CPD_EVT_ND2D_CKPT_USR_INFO(open_flags=0x7, CLOSE_LAST(3), ckpt_flags=7) to CPD Best regards, Nhat Pham -Original Message- From: A V Ma

Re: [devel] [PATCH 1 of 1] imported patch ckptTraceEnhancement.patch

2015-09-22 Thread A V Mahesh
Hi Nhat Pham, I had look at the final TRACE content of CPND & CPD , in some of the TRACE content like sec_id looks incorrect, and in some cases the node id being printed `node 0x0` my be we required conditional check, so attached the CPND traces for your reference. ( file is large so

Re: [devel] [PATCH 1 of 1] mds: unlock mutex when 0 bytes is read from TIPC socket [#1497]

2015-09-22 Thread A V Mahesh
Hi Zoran, ACK form me , Not tested. By the way In which participial case you are getting Zero bytes message (How do you reproduce ) ? Can you please share the Application that sends Zero bytes if you have , I may required in some other testing. -AVM On 9/22/2015 5:57 PM, Zoran Milinkovic

Re: [devel] [PATCH 1 of 1] opensaf: prevented cluster re-start on misconfigured slot_id [#464/#414]

2015-09-17 Thread A V Mahesh
Hi Anders Widell, On 9/17/2015 4:19 PM, Anders Widell wrote: > Ack from me, with the minor comment that it looks like you have > forgotten to remove the TIPC kernel module in the following part of > the code: > > +if [ $# -eq 1 ] ; then > + Address config and

Re: [devel] [PATCH 1 of 1] mds: fixed memory leak in opensf authenticate code [#1475]

2015-09-11 Thread A V Mahesh
HI Zoran, Thanks for the quick review . In start_mds_down_tmr() the timer was created with tmr_t tmr_id = ncs_tmr_alloc() to make consistent with that I used ncs_tmr_free(). -AVM On 9/11/2015 3:14 PM, Zoran Milinkovic wrote: > Ack from me with a minor comment. > > In OpenSAF code,

Re: [devel] [PATCH 1 of 1] mds: fix memory leak in MDS auth server [#1462]

2015-08-27 Thread A V Mahesh
ACK from me. Comment: Add free() in mds_dt_common.c as well. -AVM On 8/27/2015 9:34 AM, A V Mahesh wrote: Hi Zoran, Dose valgrind report any thing at below code (mds_dt_common.c) as well ? we have (void)mds_process_info_del(info) as well. case MDS_DOWN_TMR

Re: [devel] [PATCH 1 of 1] mds: fix memory leak in MDS auth server [#1462]

2015-08-26 Thread A V Mahesh
Hi Zoran, Dose valgrind report any thing at below code (mds_dt_common.c) as well ? we have (void)mds_process_info_del(info) as well. case MDS_DOWN_TMR: { MDS_PROCESS_INFO *info = mds_process_info_get( tmr_req_info-info.down_event_tmr_info.adest,

Re: [devel] [PATCH 1 of 1] imm:checkpoint only FEVS header for sync messages [#952] v2

2015-07-02 Thread A V Mahesh
Hi Nell, On 7/2/2015 2:54 PM, Anders Björnerstedt wrote: Ack from me. Not tested. I was trying to test with 200K objects , I observed some issues please verify before pushing . 1) bring up SC-1 active with 2000K objects 2) bring up PL-3 3) bring up PL-4 4) try to bring up SC-2 as standby

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: enhance cpnd to shm read/write size to SaOffsetT(SaUint64T) [#1372]

2015-05-14 Thread A V Mahesh
Hi Ramesh, I used your system to publish , so accidentally your name is getting displayed as publisher , please ignore. Provide your review comment by reviewing it. -AVM On 5/14/2015 2:43 PM, ramesh.bet...@oracle.com wrote: Summary:cpsv: enhance cpnd to shm read/write size to

Re: [devel] [PATCH 0 of 1] Review Request for dtm: changed maximum processes allowed per node configurable for tcp transport [#1187]

2015-03-09 Thread A V Mahesh
for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset dea90c5398043d034b36931fb6250c3a1154b044 Author: A V Mahesh mahesh.va...@oracle.com Date: Fri, 06 Mar 2015 17:42:14 +0530 test-mds: tune testsuite 6 of 6 message size

Re: [devel] [PATCH 0 of 1] Review Request for n

2015-03-05 Thread A V Mahesh
): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 0a16c5270acb3050ad8165d3f37788d6390351b0 Author: A V Mahesh mahesh.va...@oracle.com Date: Fri, 06 Mar 2015 09:15:20 +0530 test-mds: tune testsuite 6 of 6 message size below the default heartbeat time

Re: [devel] [PATCH 1 of 1] IMM: Sync-retry reverted back to milliseconds with increase on retries [#1188]

2014-10-24 Thread A V Mahesh
Hi, Ack from Me. -AVM On 10/24/2014 10:15 AM, A V Mahesh wrote: Hi Anders Bj, I changed of 2 second is required to address following issue, as a part of TIPC multicast following issue was observed to address that i did the change: With TIPC multicast enabled, When A node sync

Re: [devel] [PATCH 1 of 1] IMM: Sync-retry reverted back to milliseconds with increase on retries [#1188]

2014-10-23 Thread A V Mahesh
Hi Anders Bj, I changed of 2 second is required to address following issue, as a part of TIPC multicast following issue was observed to address that i did the change: With TIPC multicast enabled, When A node sync is in-progress , the sync message are being send in very high number/frequency

Re: [devel] test

2014-10-19 Thread A V Mahesh
Test passed :) -AVM On 10/20/2014 10:15 AM, Suryanarayana Garlapati wrote: -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email, SMS, voice calls or mobile push

Re: [devel] [PATCH 1 of 1] mds: change tipc_or_tcp variable from string to bool to avoid strcmp [#998]

2014-10-16 Thread A V Mahesh
Hi They are not related we are using ` rc = stat(MDS_MDTM_CONNECT_PATH, sockStat);` to make is_tipc true or false . What Nagu is suggesting is echo message on opensaf start `opensafd: Starting OpenSAF Services (Using TIPC)` -AVM On 10/16/2014 2:41 PM, Suryanarayana Garlapati wrote: as we

Re: [devel] [PATCH 1 of 1] mds: change tipc_or_tcp variable from string to bool to avoid strcmp [#998]

2014-10-16 Thread A V Mahesh
Hi On 10/16/2014 3:09 PM, Suryanarayana Garlapati wrote: On 16-10-2014 14:56, A V Mahesh wrote: Hi They are not related we are using ` rc = stat(MDS_MDTM_CONNECT_PATH, sockStat);` to make is_tipc true or false . [Surya] We should not use this. We should depend on env variable only. [AVM

Re: [devel] [PATCH 1 of 1] dtm: fix NULL ptr dereference [#1152]

2014-10-06 Thread A V Mahesh
Ack , didn't get chance to test ( not able to make one of my system interface IP as NULL) . -AVM On 10/6/2014 12:29 PM, Hans Feldt wrote: osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) osafdtmd segfaulted Reason was a

Re: [devel] [tickets] [opensaf:tickets] #1043 immnd crashes (segfault) while bringing up the SC-1 controller .

2014-09-03 Thread A V Mahesh
Hi Manu , Bt shows MDS apis context but it looks like lib old/new related issue, Can you please check/provide build and setup info. === (gdb) bt #0 0x7f7e7a9f2472 in memcpy () from /lib64/libc.so.6 #1

Re: [devel] [PATCH 3 of 4] mds: update adest details for log readability [#520]

2014-08-18 Thread A V Mahesh
Fixed latest Gcc errors/warning on top of this published patch , any how I will be republish complete patch after my test result with LOG_LEVEL 4 . diff --git a/osaf/libs/core/include/mds_papi.h

Re: [devel] [PATCH 0 of 3] Review Request for mds: use TIPC multicast for MDS broadcast [#851]

2014-08-13 Thread A V Mahesh
libraries y Samples n Tests n Other n Comments (indicate scope for each y above): - changeset c6de7935bc53f5b96ee0cf604e29d2784c6e4fca Author: A V Mahesh mahesh.va

Re: [devel] [PATCH 1 of 1] ckptnd: increase performance when creating and writing large numbers of sections [#770]

2014-08-11 Thread A V Mahesh
Hi Alex, Ack with following query: Because of Map pairing , the sectionInfo will be returned in the order, is that right ? = +CPND_CKPT_SECTION_INFO * +cpnd_ckpt_sec_get_next(const CPND_CKPT_REPLICA_INFO *replicaInfo, +

Re: [devel] [PATCH 1 of 1] ckptnd: increase performance when creating and writing large numbers of sections [#770]

2014-08-11 Thread A V Mahesh
all the sections it will return them in the order in which they are sorted by the less than function. Alex On 08/11/2014 08:10 AM, A V Mahesh wrote: Hi Alex, Ack with following query: Because of Map pairing , the sectionInfo will be returned in the order, is that right

Re: [devel] [PATCH 1 of 1] cpsv: set dtaBuff to NULL and readSize to zero in TrackCallback [#733]

2014-06-11 Thread A V Mahesh
On 6/11/2014 12:07 PM, Hans Feldt wrote: tools/devel/review/00-README It is impossible from just reading the patch to understand what this is about The ticket explains the problem and i thought the fix is simple. But i do agree that more explanation could have been added, i would take care

Re: [devel] [users] Upcoming OpenSAF 4.5 Transport (MDS) PerformanceMeasurements

2014-06-09 Thread A V Mahesh
Hi Ted, Currently it is available in default staging you can do `hg clone http://hg.code.sf.net/p/opensaf/staging` -AVM On 6/10/2014 7:39 AM, Yao Cheng LIANG wrote: Dear A V M, IS that available for download? Thanks. Ted -Original Message- From: A V Mahesh [mailto:mahesh.va

Re: [devel] [opensaf:tickets] #654 MDS improvements

2014-06-02 Thread A V Mahesh
Hi Hans, On 5/20/2014 12:36 AM, Hans Feldt wrote: Next steps: - Set DEST_DROPPABLE=False What are we planning to achieve ? if it is only for Loging , we already have `i_msg_loss_indication` flag which is part of svc_install , if enabled any message is lost a callback of type

Re: [devel] [opensaf:tickets] #654 MDS improvements

2014-06-02 Thread A V Mahesh
wrote: *From:*A V Mahesh [mailto:mahesh.va...@oracle.com] *Sent:* den 2 juni 2014 09:20 *To:* Hans Feldt *Cc:* opensaf-devel@lists.sourceforge.net *Subject:* Re: [opensaf:tickets] #654 MDS improvements Hi Hans, On 5/20/2014 12:36 AM, Hans Feldt wrote: Next steps: - Set

Re: [devel] [PATCH 1 of 3] dtm: upgrade the fragment size to MDS_DIRECT_BUF_MAXSIZE [#654]

2014-05-20 Thread A V Mahesh
Hi, On 5/20/2014 11:47 AM, SuryaNarayana Garlapati wrote: On Tuesday 20 May 2014 12:56 AM, Hans Feldt wrote: - I guess the commit message prefix should be mds: - I miss the use case / benefit of the proposed change in the commit message I don't understand the need for setting a default

Re: [devel] [PATCH 0 of 1] Review Request for cpnd: increase performance when creating large numbers of sections [#770]

2014-05-20 Thread A V Mahesh
HI Alex, I appreciate your contribution in CPSV , thanks for your patch , I will take some time reviewing/testing the complete patch (database a C++ STL map for fast access ) ,for now my initial comment is : On 5/21/2014 2:57 AM, Alex Jones wrote: make MAX_SYNC_TRANSFER_SIZE much smaller: 3M

Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

2014-05-06 Thread A V Mahesh
, then encode full is called. In this case the source and destination can be on the same or different node. On Tuesday 06 May 2014 09:05 AM, A V Mahesh wrote: Hi All, I re-verified the behavior of OpenSAF MDS_ENC_TYPE_FULL/MDS_ENC_TYPE_FLAT messaging and its optimization , following is my

Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

2014-05-05 Thread A V Mahesh
the encoding is handled for the destinations. Thanks, Hans -Original Message- From: SuryaNarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com] Sent: den 1 maj 2014 10:54 To: A V Mahesh Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 3 of 4] mds: use

Re: [devel] [PATCH 3 of 4] mds: use TIPC segmentation/reassembly [#654]

2014-05-01 Thread A V Mahesh
are also raising enhancement ticket for code clean. -AVM On 5/1/2014 10:16 AM, SuryaNarayana Garlapati wrote: On Thursday 01 May 2014 09:56 AM, A V Mahesh wrote: Hi Surya, On 5/1/2014 7:28 AM, Suryanarayana Garlapati wrote: Nack. MDS ARCHWORD is used for deciding the factor whether

Re: [devel] [PATCH 1 of 3] MDS: TIPC performance improvement [#654]

2014-02-04 Thread A V Mahesh
People who ware viewing Mail text format didint received the performance statistics Table , please find it as attachment . -AVM On 2/4/2014 3:59 PM, A V Mahesh wrote: Hi All, This patch adjusted the MDS send fragmentation size from 1400 to 65479. This value is derived from

Re: [devel] [PATCH 1 of 3] MDS: TIPC performance improvement [#654]

2014-02-04 Thread A V Mahesh
? /AndersBj -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 4 februari 2014 12:00 To: praveen malviya Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 3] MDS: TIPC performance improvement [#654] Sorry for that , 1) Standby

Re: [devel] [PATCH 1 of 1] mds: Remove unnecessary syslog message about TIPC importance [#755]

2014-02-02 Thread A V Mahesh
ACK from me. -AVM On 1/30/2014 9:19 PM, Anders Widell wrote: osaf/libs/core/mds/mds_dt_tipc.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) Remove an unnecessary log message regarding the configured TIPC importance, that was introduced in ticket [#589]. The information in

Re: [devel] [PATCH 0 of 3] Review Request for MDS: Performance improvement [#654]

2014-01-29 Thread A V Mahesh
Hi Hans, I thought i had informed you that i'm working on a patch for the ticket. Please see my mail below. Since i didn't hear from you, i thought you are okay with that. But i'm sorry, yes should have checked with you before accepting the ticket. On 1/21/2014 5:47 PM, A V Mahesh wrote: Hi

Re: [devel] [PATCH 0 of 2] Review Request for MDS #654

2014-01-21 Thread A V Mahesh
Hi Hans, Iam currently working on a patch for #654 (considering both TIPC/TCP) that adjusts: - the fragmentation - buffers Iam currently testing it. The logging improvements has to be done, but i shall take it up as a separate ticket. Thanks, AVM. On 1/21/2014 5:30 PM, Hans Feldt wrote: On

Re: [devel] checkpoint problems

2014-01-09 Thread A V Mahesh
performance. Alex On 01/08/2014 08:30 AM, Hans Feldt wrote: sysctl -a | grep rmem set rmem_default to 256K or so /Hans -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: den 8 januari 2014 14:01 To: A V Mahesh; Alex Jones Cc: opensaf-devel

Re: [devel] checkpoint problems

2014-01-08 Thread A V Mahesh
doesn't work at all in this scenario. It never succeeds. I can reproduce the problem with sectionCreationAttributes.expirationTime set to SA_TIME_ONE_DAY. You should be able to reproduce the problem with the code I sent in the last e-mail. Alex On 01/06/2014 10:31 PM, A V Mahesh

Re: [devel] checkpoint problems

2014-01-07 Thread A V Mahesh
can reproduce the problem with sectionCreationAttributes.expirationTime set to SA_TIME_ONE_DAY. You should be able to reproduce the problem with the code I sent in the last e-mail. Alex On 01/06/2014 10:31 PM, A V Mahesh wrote: Hi Alex, CheckpointOpen call failing

Re: [devel] checkpoint problems

2014-01-06 Thread A V Mahesh
, A V Mahesh wrote: Hi Alex, We never tested the 7500 sections , will test and let you know , can you please share your test application , that allow us to respond quick. -AVM On 1/3/2014 8:23 PM, Alex Jones wrote: Hello All, I'm experimenting with the checkpoint service, and some

Re: [devel] checkpoint problems

2014-01-05 Thread A V Mahesh
Hi Alex, We never tested the 7500 sections , will test and let you know , can you please share your test application , that allow us to respond quick. -AVM On 1/3/2014 8:23 PM, Alex Jones wrote: Hello All, I'm experimenting with the checkpoint service, and some things don't

Re: [devel] checkpoint problems

2014-01-05 Thread A V Mahesh
Hi Alex, when did the ckpt opened on the other node ? is it before the sections created on the fist node . -AVM On 1/6/2014 12:32 PM, A V Mahesh wrote: Hi Alex, We never tested the 7500 sections , will test and let you know , can you please share your test application , that allow us

Re: [devel] [PATCH 1 of 1] clm: fill saClmNodeAddress and saClmNodeAddressFamily with ip info [#228]

2014-01-02 Thread A V Mahesh
namesaClmNodeAddress/name valuefe80::a00:27ff:fe28:eb9d/value /attr === On 1/2/2014 10:10 AM, A V Mahesh wrote: Mathi, I didn't go in to patch details ,but not able to Bring-up the cluster with IPV6 , can you please check. Ignore this , it was configuration issue

Re: [devel] [PATCH 1 of 1] clm: fill saClmNodeAddress and saClmNodeAddressFamily with ip info [#228]

2014-01-01 Thread A V Mahesh
Mathi, I didn't go in to patch details ,but not able to Bring-up the cluster with IPV6 , can you please check. /var/log/messages == an 2 10:04:05 SC-2 osafimmnd[13860]: NO NODE STATE- IMM_NODE_FULLY_AVAILABLE 2316 Jan 2 10:04:05

Re: [devel] [PATCH 1 of 1] mds: provide node's IPV4/IPV6 address in MDS NODEUP event [#617]

2013-12-26 Thread A V Mahesh
Ramesh, Thank you very much for the review, please find my responses as [AVM] for you comment. On 12/26/2013 2:23 PM, Ramesh Betham wrote: [Ramesh]: Why addr_family is required to process DOWN msg? In my opinion it may not be required.. am I missing anything here?. [AVM] It is CLM

Re: [devel] [PATCH 0 of 2] Review Request for cpsv #581

2013-12-23 Thread A V Mahesh
ACK from me. -AVM On 12/19/2013 9:26 PM, Hans Feldt wrote: Summary: cpsv #581 Review request for Trac Ticket(s): 581 Peer Reviewer(s): Mahesh Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE Affected branch(es): default Development branch: default

Re: [devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-19 Thread A V Mahesh
Ok I will increment. -AVM On 12/19/2013 1:49 PM, Mathivanan Naickan Palanivelu wrote: Hi Mahesh, I think we should increment the library version because we are introducing new APIs. Thanks, Mathi. -Original Message- From: Venkata Mahesh Alla Sent: Thursday, December 19, 2013

Re: [devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-12 Thread A V Mahesh
Sirisha, Thank you for the review Comments 1,2 3 are the this enhancement related , so I will address while pushing the patch, but comment 4 5 are existing problems , so can you please raise new ticket for those. -AVM On 12/12/2013 2:52 PM, Sirisha Alla wrote: Mahesh, I have not done

Re: [devel] [PATCH 1 of 1] cpsv: standardize arrival callback API(s) with SAF syntax [#561]

2013-12-02 Thread A V Mahesh
Hi, The scope of this patch is primarily to convert the existing functionality to SAF API syntax. i.e The existing functionality supports tracking checkpoint writes per (user- initialized handle) SaCkptHandleT . So, this existing functionality shall be provided by this API saCkptTrack().

Re: [devel] assert in MDS (using TCP)

2013-10-30 Thread A V Mahesh
Hi Hans, Let us have ticket ,for now I will convert assert to return an error. -AVM On 10/29/2013 5:40 PM, Hans Feldt wrote: -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 29 oktober 2013 12:25 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] assert in MDS (using TCP)

2013-10-29 Thread A V Mahesh
, then we could perhaps remove the assert. -AVM Thanks, Hans On 10/15/2013 12:59 PM, A V Mahesh wrote: Hi Hans, Assuming you tried this in an UML environment, can you share the backtrace? B.T.W, i am not able to repordcue the problme even with writes a burst of larger number of records

Re: [devel] [PATCH 1 of 1] mds: change Unix sock file osaf_dtm_intra_server path [#606]

2013-10-24 Thread A V Mahesh
Ramesh, Thanks for the review . 1) `$pkglocalstatedir/osaf_dtm_intra_server` file will be created only TCP case , it is not required for TIPC. 2) Before fixing Ticket #1993 MDS library also use to bind() and MDS library also use to create Unix sock file prefixing with application

Re: [devel] [PATCH 0 of 1] Review Request for mds #589

2013-10-11 Thread A V Mahesh
Hi Ingvar, Some time back in the context of IMM loading large objects bug, we also given a try with immnd with MEDIUM importance , but we failed to observe congestion over come statistics. Can you please share some statistics that you observed with `TIPC_LOW_IMPORTANCE` Vs

Re: [devel] [PATCH 0 of 1] Review Request for mds #589

2013-10-11 Thread A V Mahesh
the application importance if needed, to minimize the risk for loss of packages. That's the motivation for the ticket. Thanks Ingvar -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 11 oktober 2013 08:54 To: Ingvar Bergström Cc: opensaf-devel

Re: [devel] [PATCH 0 of 1] Review Request for mds #589

2013-10-11 Thread A V Mahesh
but can be called early by a service to change it. Can we solve that requirement when it occur or are they conflicting? /Hans -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 11 oktober 2013 10:40 To: Ingvar Bergström Cc: opensaf-devel

Re: [devel] [PATCH 0 of 2] Review Request for opensaf:make MDS/TCP as the default opensaf transport[#232]

2013-10-10 Thread A V Mahesh
-transport-monitor seems to consume a lot of CPU load. There is something wrong with it. Please check your system. Thanks, Hans -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 9 oktober 2013 08:32 To: Hans Feldt Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 0 of 2] Review Request for opensaf:make MDS/TCP as the default opensaf transport[#232]

2013-10-09 Thread A V Mahesh
script has to customized backup and restore of TIPC Network interface name and TIPC net-id from nodeinit.conf to nid.conf as a process of upgrade. changeset 43bd9a5e0cebf5da23f2581b4dc0514d1597 Author:A V Mahesh mahesh.va...@oracle.com Date:Thu, 26 Sep 2013 09:17:15

Re: [devel] [PATCH 1 of 1] dtm: Don't use NULL pointers or uninitialized data in error paths [#526]

2013-07-31 Thread A V Mahesh
Anders Widell, ACK from me and thanks for the patch . -AVM On 7/31/2013 3:57 PM, Anders Widell wrote: osaf/services/infrastructure/dtms/dtm/dtm_node_sockets.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Fixed two bugs where LOG_ER() was called with illegal parameters in

<    1   2   3   4   5   6