osaf/services/saf/logsv/lgs/lgs_amf.cc | 20 +-
osaf/services/saf/logsv/lgs/lgs_config.cc | 72 ++---
osaf/services/saf/logsv/lgs/lgs_evt.cc |3 -
osaf/services/saf/logsv/lgs/lgs_imm.cc | 196 ++--
osaf/services/saf/logsv/lgs/lgs_imm_gcfg.cc |
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset a99c01a8c8db4a8ffa00644f4857365280007129
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Mon, 16 May 2016 13:23:26 +0700
ent log streams, notification,
alarm, and system."
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Wednesday, May 11, 2016 10:19 PM
>To: Vu Minh Nguyen; mathi.naic...@oracle.com
>Cc: opensaf-devel@lists.sourceforge.net
>S
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 87092ae4af46abf5da32b81621ec098ce4ef4a3b
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Mon, 09 May 2016 14:09:59 +0700
osaf/services/saf/logsv/lgs/lgs_imm_gcfg.cc | 110 ---
osaf/services/saf/logsv/lgs/lgs_util.cc | 18
osaf/services/saf/logsv/lgs/lgs_util.h | 46 +++
3 files changed, 130 insertions(+), 44 deletions(-)
LOG has several threads which were using
Hi Mahesh,
It is not related to the ticket #1789. Two following test cases were added
for #1789.
>>1) logtest 2 42
>>2) logtest 2 43
Regards, Vu.
>-Original Message-
>From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>Sent: Wednesday, May 11, 2016 2:48 P
Hi Lennart,
Ack with few comments, start with [Vu].
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Thursday, May 05, 2016 9:56 AM
>To: mathi.naic...@oracle.com; lennart.l...@ericsson.com;
>vu.m.ngu...@dektech.com.au
>
osaf/libs/agents/saf/lga/lga.h | 1 +
osaf/libs/agents/saf/lga/lga_api.c | 12
osaf/libs/agents/saf/lga/lga_mds.c | 10 ++-
osaf/libs/agents/saf/lga/lga_state.c | 87
osaf/libs/agents/saf/lga/lga_state.h | 3 -
osaf/libs/agents/saf/lga/lga_api.c | 18 +
tests/logsv/tet_saLogStreamOpen_2.c | 4 +++
tests/logsv/tet_saLogWriteLogAsync.c | 38
3 files changed, 60 insertions(+), 0 deletions(-)
When accidentally passing an invalid value of
Hi Mathi,
Do you have any comment on the updated patch -
lgsv_missMutexProtection_1705_r3.patch?
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Thursday, April 21, 2016 2:37 PM
>To: Vu Minh Nguyen; mathi.naic...@oracle.com
osaf/libs/agents/saf/lga/lga_api.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
If timestamp (`logTimeStamp`) is not provided log client, log agent
will get the current time when getting the write log record request
and store the address, pointing to time holder variable,
n
Comments (indicate scope for each "y" above):
-
<>
changeset 56be3574320ec9f697aa56b87c878152cc66fbd4
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Fri, 15 Apr 2016 11:12:47 +0700
log: fix incorr
Hi Mathi,
I have based two things:
1) The API calling sequence:
100|0|Invoking saLogInitialize()// (1)
100|0| Return value : <-- SA_AIS_OK
100|0| Handle obtained is 4290772993
100|0|Invoking saLogStreamOpen_2()
100|0|Handle used is 4290772993
100|0| Return value
Hi all,
Friendly reminder for code review.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Friday, April 08, 2016 5:04 PM
>To: 'Lennart Lund'; 'mathi.naic...@oracle.com'
>Cc: 'opensaf-devel@lists.sourceforge.net'
>Sub
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 3aa4fbabf80286293f3e80719c1b9653e86561c9
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Tue
Hi Minh,
No comment from me. Ack.
Regards, Vu.
>-Original Message-
>From: minh chau [mailto:minh.c...@dektech.com.au]
>Sent: Thursday, April 07, 2016 7:28 AM
>To: praveen malviya; Lennart Lund; Vu Minh Nguyen
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: Re: [dev
nal Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Monday, April 04, 2016 3:51 PM
>To: Vu Minh Nguyen
>Cc: mathi.naic...@oracle.com; opensaf-devel@lists.sourceforge.net; Lennart
>Lund
>Subject: RE: [PATCH 1 of 1] log: miss mutex protection for common r
27 PM
>To: Mathivanan Naickan Palanivelu; Vu Minh Nguyen
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: Re: [devel] Build error: implicit declaration of function
>‘WEXITSTATUS’ [-Werror=implicit-function-declaration]
>
>Hi,
>
-
>From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>Sent: Monday, April 04, 2016 4:34 PM
>To: Vu Minh Nguyen
>Cc: opensaf-devel@lists.sourceforge.net; lennart.l...@ericsson.com; 'Anders
>Widell'
>Subject: Re: [devel] Build error: implicit declaration of function
>‘WEXITSTAT
. What is
> happening in the client thread when we are in recovery state 2 that
> can set p_client == NULL? The client thread should not be able to do
> anything with the data involved when recovering client in the
> recovery thread?
>
> Regards
> Lennart
>
>
Hi Lennart,
Please see my comment inline.
Regards, Vu
Quoting Lennart Lund <lennart.l...@ericsson.com>:
> Hi Vu
>
> Ack with comments
>
> See my comments inline [Lennart]:
>
> Thanks
> Lennart
>
>> -Original Message-
>> From: Vu Minh Nguye
Hi Mahesh,
Can you share your build options? I do not see the build error at my side.
When I tried to run gcc with option "-E" instead of "-c" to see if the macro
WEXITSTATUS() is defined
in the scope of tet_saLogStreamOpen_2.c or not, like this:
gcc -DHAVE_CONFIG_H -I. -I../..
Hi all,
Just friendly reminder for code review.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Wednesday, March 23, 2016 2:16 PM
>To: mathi.naic...@oracle.com; lennart.l...@ericsson.com
>Cc: opensaf-devel@lists.sourcefor
Hi Mathi,
Have you had a chance to looking at this? Thanks.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Thursday, March 24, 2016 12:45 PM
>To: 'Mathivanan Naickan Palanivelu'
>Cc: 'lennart.l...@ericsson.com';
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset fa2350913718b31e5d40d5f4d1553617a43b0f01
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Mon, 28 Mar 2016 16:38:32 +0700
e.com]
>Sent: Monday, March 28, 2016 3:44 PM
>To: opensaf-devel@lists.sourceforge.net
>Subject: Re: [devel] RPM build errors: with changeset: 7355:
>
>Hi Vu Minh Nguyen,
>
>One more thing , I did applied `Support up to 4095 nodes [#1613]` patches
>for review/testing on to
Ack.
Regards, Vu.
>-Original Message-
>From: Canh Truong [mailto:canh.v.tru...@dektech.com.au]
>Sent: Thursday, March 17, 2016 10:00 AM
>To: lennart.l...@ericsson.com; anders.wid...@ericsson.com;
>mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au
>Cc:
osaf/libs/agents/saf/lga/lga_state.c | 41 +++
osaf/libs/agents/saf/lga/lga_state.h | 1 +
osaf/libs/agents/saf/lga/lga_util.c | 30 +++--
3 files changed, 50 insertions(+), 22 deletions(-)
There was an race condition between client
n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset b866fd640124fcae26c98e730198e6439401387d
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Wed, 23 Mar 2016 13:08:10 +0700
on?”, my
>> answer is that
>>
>> the information is not only runtime state, but also other things such
>> as current log files,
>>
>> size of current log files and record Ids for last written log record.
>>
>>
>>
>>
>> Regards, Vu.
>&g
PM
To: Vu Minh Nguyen; mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: Review Request for log: update PR document for cloud resilience
[#1687]
Hi Vu
I have written some comments. See the attached document.
Thanks
Lennart
From: Vu Minh Nguyen
Please see my comments inline.
Regards, Vu.
>-Original Message-
>From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
>Sent: Tuesday, March 15, 2016 1:29 PM
>To: Vu Minh Nguyen; Anders Widell; Lennart Lund
>Cc: opensaf-devel@lists.sourceforge.net; Beatriz
Hi Mathi,
See my responses inline, with [Vu].
Regards, Vu.
>-Original Message-
>From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
>Sent: Tuesday, March 15, 2016 1:07 PM
>To: Anders Widell; Vu Minh Nguyen; Lennart Lund
>Cc: opensaf-devel@lists.sourcefor
Hi Mathi,
Have you had time to look at this yet?
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Friday, February 26, 2016 8:49 AM
>To: anders.wid...@ericsson.com; lennart.l...@ericsson.com;
>mathi.naic...@oracle.com
>
Ack for the series.
Regards, Vu.
>-Original Message-
>From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
>Sent: Tuesday, March 01, 2016 2:30 PM
>To: lennart.l...@ericsson.com; praveen.malv...@oracle.com;
>vu.m.ngu...@dektech.com.au; minh.c...@dektech.com.au
>Cc:
he RDN value of the CLM node name it self is max 255 , so their is
>
> no possibility of
> `/etc/opensaf/node_name` exceeding 255 with combining with RDN
> name
> for example :
>
> `safAmfNode=SC-1,safAmfCluster=myAmfCluster`
>
> That is why I derived the name_nam
Hi Lennart,
Thanks for your comment. I will add the info when sending the patch for
pushing.
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Monday, March 07, 2016 7:18 PM
>To: Vu Minh Nguyen; mathi.naic...@oracle.com
>Cc
n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 9e71920fba5261f8c138d874247a1452c6448f1b
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Fri, 04 Mar 2016 10:07:20 +0700
Hi Mahesh,
I am able to reproduce the problem and found the root cause.
I raised the ticket https://sourceforge.net/p/opensaf/tickets/1686
Regards, Vu.
>-Original Message-
>From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>Sent: Tuesday, March 08, 2016 1:01 PM
>To: Vu
osaf/libs/agents/saf/lga/lga_mds.c | 42 -
1 files changed, 36 insertions(+), 6 deletions(-)
The log agent on defaul branch (5.0) was not backward compatible
with the old OpenSAF versions.
This fix does an workaround to make it work.
diff --git
Hi Lennart,
Please see my responses inline, with [Vu].
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Thursday, March 03, 2016 10:38 PM
>To: Vu Minh Nguyen; Anders Widell; mathi.naic...@oracle.com
>Cc: opensaf-devel@lists.
osaf/libs/agents/saf/lga/lga_mds.c | 26 --
1 files changed, 20 insertions(+), 6 deletions(-)
The log agent on defaul branch (5.0) was not backward compatible
with the old OpenSAF versions.
This fix does an workaround to make it work.
diff --git
n
Comments (indicate scope for each "y" above):
-
<>
changeset 3664ee54adf7f3c86eb830862338c873fabe9a8c
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Fri, 04 Mar 2016 10:07:20 +0700
Hi Mahesh,
What is the changeset number of default (5.0.M0-1 ) that you were using?
And can you send me the trace log of osaflogd on standby node?
Thanks.
Regards, Vu.
>-Original Message-
>From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>Sent: Thursday, March 03, 2016 2:53 PM
>To:
n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset a6c0e7e9785c75c6dcf57404027fc92fc572a25f
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Tue, 02 Feb 2016 10:02:37 +070
osaf/services/saf/logsv/README |16 +
osaf/services/saf/logsv/config/Makefile.am | 4 +-
osaf/services/saf/logsv/config/gcfg_classes.xml |18 +
osaf/services/saf/logsv/config/gcfg_objects.xml | 6 +
osaf/services/saf/logsv/lgs/Makefile.am | 6 +-
Hi Minh,
I have few comments below [Vu] and one question.
I see, in some places, NTF APIs not always return TRY_AGAIN if both SCs
down.
I am not sure if I feel correctly or not.
E.g: In `saNtfNotificationSend` API
When the client thread comes to code line `ntfa_mds_msg_sync_send()`,
headless
Ack.
Regards, Vu.
>-Original Message-
>From: Canh Truong [mailto:canh.v.tru...@dektech.com.au]
>Sent: Tuesday, February 23, 2016 10:18 AM
>To: vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com;
>anders.wid...@ericsson.com; mathi.naic...@oracle.com
>Cc:
Sorry. Please take this attach.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Thursday, February 25, 2016 9:23 AM
>To: 'Mathivanan Naickan Palanivelu'; lennart.l...@ericsson.com
>Cc: opensaf-devel@lists.sourceforge.n
Thanks, Mathi.
Here is the fix for comments of patch 1/4 and 2/4.
Regards, Vu.
>-Original Message-
>From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
>Sent: Wednesday, February 24, 2016 5:24 PM
>To: vu.m.ngu...@dektech.com.au
>Cc: lennart.l...@ericsson.com;
nart.l...@ericsson.com]
>Sent: Tuesday, February 23, 2016 8:30 PM
>To: Mathivanan Naickan Palanivelu; Vu Minh Nguyen
>Cc: opensaf-devel@lists.sourceforge.net; Anders Widell; Lennart Lund
>Subject: RE: [PATCH 2 of 4] log: add support for cloud resilience feature
>(agent
>part) [#1179]
>
>H
Hi Mahesh,
I see you are using constant HOST_NAME_MAX for node_name string.
Referring to following page, it states HOST_NAME_MAX value possibly "is
unspecified."
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html
With _POSIX_HOST_NAME_MAX constant, the value is determined. Its
osaf/services/saf/logsv/README-HEADLESS | 230
1 files changed, 230 insertions(+), 0 deletions(-)
The patch makes LOG service be able to handle the case that both SC nodes
are down at the same time.
When one or both nodes go up again the log service must be
tests/logsv/Makefile.am | 1 +
tests/logsv/README | 4 +
tests/logsv/logtest.c | 290 ++-
tests/logsv/logtest.h |57 +
tests/logsv/logtestfr.c | 6 +-
tests/logsv/saflogtest.c|46 +-
tests/logsv/tet_Log_misc.c |24 +-
osaf/libs/agents/saf/lga/Makefile.am |6 +-
osaf/libs/agents/saf/lga/lga.h | 53 +-
osaf/libs/agents/saf/lga/lga_api.c | 858 --
osaf/libs/agents/saf/lga/lga_mds.c | 46 +-
osaf/libs/agents/saf/lga/lga_state.c | 670 +++
Summary: log: add support for cloud resilience feature [#1179]
Review request for Trac Ticket(s): #1179
Peer Reviewer(s): Mathi, Anders W, Lennart
Pull request to: Lennart
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
osaf/services/saf/logsv/lgs/Makefile.am|6 +-
osaf/services/saf/logsv/lgs/lgs.h | 12 +
osaf/services/saf/logsv/lgs/lgs_cb.h | 14 +
osaf/services/saf/logsv/lgs/lgs_evt.cc | 66 ++-
osaf/services/saf/logsv/lgs/lgs_evt.h |5 +
18311]: NO Implementer connected:
> 2 (safLogService) <14, 2010f>
> Feb 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer locally
> disconnected. Marking it as doomed 2 <14, 2010f> (safLogService)
> Feb 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer
> disconnect
_SC-1 osafimmnd[18311]: NO implementer for class
>> > > > 'SaLogStreamConfig' is safLogService => class extent is safe.
>> > > > Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Implementer locally
>> > > > disconnected. Marking it as doomed 1 <2, 2010f&
Hi,
I forgot adding information. To build the #1179 patch successfully, need
#777 pushed.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Thursday, January 28, 2016 11:13 AM
>To: anders.wid...@ericsson.com; lennart.l...@
Hi Lennart,
Thanks for your feedback. I have added PATH_MAX check as you recommended.
Please get the updated code in attached file.
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Monday, January 25, 2016 4:00 PM
>To: Vu
nuary 22, 2016 6:44 PM
>To: Vu Minh Nguyen; Anders Widell; mathi.naic...@oracle.com
>Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund
>Subject: RE: [PATCH 1 of 1] log: Use pathconf() instead of NAME_MAX [#279]
>
>Hi Vu,
>
>Some comments:
>
>General:
>Indentation is
osaf/libs/agents/saf/lga/lga_api.c | 58 -
osaf/libs/common/logsv/include/lgsv_defs.h | 13 -
osaf/libs/common/logsv/include/lgsv_msg.h |4 +-
osaf/services/saf/logsv/lgs/Makefile.am | 14 +-
osaf/services/saf/logsv/lgs/lgs.h | 12 +-
Ack.
Regards, Vu.
>-Original Message-
>From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
>Sent: Monday, December 14, 2015 2:19 PM
>To: vu.m.ngu...@dektech.com.au
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: [PATCH 1 of 1] ntfd: fix syslog warning when queueing
amples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset e59bd481b8c26a827ef023ea1abd7e0201bf2c64
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
osaf/services/saf/logsv/lgs/Makefile.am| 34 ---
osaf/services/saf/logsv/lgs/lgs.h | 10 ++-
osaf/services/saf/logsv/lgs/lgs_amf.c |4 +-
osaf/services/saf/logsv/lgs/lgs_cb.h |8 +
osaf/services/saf/logsv/lgs/lgs_config.c | 113 ++
amples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 982a14649c9d3fd89654f02a9255707b1b4e9ccf
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au&
Hi Lennart,
I have just found two things in imm_impl_set_sequence(). Please see my below
comments [Vu].
> + if ( true == *(bool*)
> lgs_cfg_get(LGS_IMM_LOG_OPENSAFLOGCONFIG_CLASS_EXIST)) {
> + (void)immutil_saImmOiClassImplementerSet(immOiHandle,
> "OpenSafLogConfig");
[Vu] Not
Ack.
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Thursday, December 03, 2015 6:55 PM
>To: mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: [PATCH 1 of 1] lgs: Correcting OI
sn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset e2593a942f66afc716ce50fa26eed393b2272474
Author
Hi Mathi,
Have you had time to look at this?
If you have no feedback by this Thursday, I will ask Lennart to push the
patch.
Thanks.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Wednesday, November 04, 2015 3:32 PM
>To
Hi Mathi,
Have you had time to look at this?
If you have no feedback by this Wed, I will ask Lennart to push the patch
since the change is minor.
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Wednesday, November 04, 201
osaf/services/saf/logsv/lgs/lgs_evt.c | 7
osaf/services/saf/logsv/lgs/lgs_imm.c | 11 +-
osaf/services/saf/logsv/lgs/lgs_util.c | 57 ++
osaf/services/saf/logsv/lgs/lgs_util.h | 1 +
tests/logsv/tet_LogOiOps.c | 40
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 4e1fe66e277894c89282243d9c26e3fe2f4dfade
Author: Vu Minh Nguyen <v
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset a7d00d50a84584f1d0d079e5f689e9edae6d0929
Author: Vu Minh Nguyen <v
tests/logsv/tet_LogOiOps.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
There is an uninitialized character in an static array of characters.
When outputting the string, the character at that position is unknown.
It causes trouble when passing the string to shell if the
: opensaf-devel@lists.sourceforge.net
>Subject: RE: [PATCH 1 of 1] log: fix ownership of log files is not changed
when
>group name is changed [#1550]
>
>Ack
>
>Thanks
>Lennart
>
>> -Original Message-
>> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>> Sent:
Summary: log: fix ownership of log files is not changed when group name is
changed [#1550]
Review request for Trac Ticket(s): #1550
Peer Reviewer(s): mathi.naic...@oracle.com; lennart.l...@ericsson.com;
Pull request to: Lennart
Affected branch(es): 4.7, default
Development branch: <>
rvicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 243747d004feeec109937ae454e3170fcb4d6042
Author: Vu
osaf/services/saf/logsv/lgs/lgs_fmt.c | 8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
Wrong processing for timezone with having negative gmt offset.
diff --git a/osaf/services/saf/logsv/lgs/lgs_fmt.c
b/osaf/services/saf/logsv/lgs/lgs_fmt.c
---
: opensaf-devel@lists.sourceforge.net
>Subject: RE: [PATCH 1 of 1] log: incorrect verification the string length
of
>saLogStreamFileName value [#1493]
>
>Hi Vu,
>
>The patch cannot be applied. Something wrong when merging test code
>
>Thanks
>Lennart
>
>>
: opensaf-devel@lists.sourceforge.net
>Subject: RE: [PATCH 1 of 1] log: fix crashed with
>saLogStreamFixedLogRecordSize=1 [#1466]
>
>Hi Vu,
>
>See my comments inline
>
>Thanks
>Lennart
>
>> -Original Message-
>> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.co
osaf/libs/agents/saf/lga/lga_api.c | 2 +-
osaf/libs/common/logsv/include/lgsv_defs.h | 10 +
osaf/services/saf/logsv/lgs/lgs_imm.c | 22 +++-
tests/logsv/tet_LogOiOps.c | 47 +-
tests/logsv/tet_saLogStreamOpen_2.c| 54
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 591ac302fd705ff417088f550c1e1d911ab6d5a8
Author: Vu
raries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 7218fab526b8b239cc6f9354580102c7dd958056
Author: Vu Minh Nguyen <vu.m.ng
n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 2a27f0574ae7d46cef94ec83acbacdb65f74c3bb
Author: Vu
osaf/services/saf/logsv/lgs/lgs_imm.c | 4 ++--
tests/logsv/tet_LogOiOps.c| 24
2 files changed, 14 insertions(+), 14 deletions(-)
logsv did validate the value incorrectly (>= 127) instead of (> 127).
diff --git a/osaf/services/saf/logsv/lgs/lgs_imm.c
raries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 344f12525e8b06f6b47312f700f5c5d72b2bb03e
Author: Vu Minh Nguyen <vu.m.ng
osaf/services/saf/logsv/lgs/lgs_imm.c | 8 +++
tests/logsv/tet_LogOiOps.c| 39 +++
2 files changed, 47 insertions(+), 0 deletions(-)
logsv did not check if the operation is perfomed on configuration class
or runtime one. Therefore, once the
osaf/services/saf/logsv/lgs/lgs_imm.c | 47 ++
tests/logsv/tet_LogOiOps.c| 141 ++
2 files changed, 170 insertions(+), 18 deletions(-)
At start up, `logStreamFileFormat` attribute in configuration obj has
value.
Means that, built-in file
amples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset e72c79da6f6c6840959fd920a2bccb737e8fdbb4
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Da
osaf/libs/agents/saf/lga/lga_api.c| 10 ++-
osaf/services/saf/logsv/lgs/lgs_evt.c |9 ++
tests/logsv/tet_LogOiOps.c| 23 +++
tests/logsv/tet_saLogStreamOpen_2.c | 103 ++
4 files changed, 144 insertions(+), 1 deletions(-)
Log agent
Ack
Regards,
Vu
>-Original Message-
>From: giang do [mailto:giang.t...@dektech.com.au]
>Sent: Tuesday, September 08, 2015 11:57 AM
>To: mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au;
>lennart.l...@ericsson.com
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: [PATCH 0 of 1]
raries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset f43357e48f6aa49331207b48ac6a16bd496b34e1
Author: Vu Minh Nguyen <vu.m.ngu...@dektec
: opensaf-devel@lists.sourceforge.net
>Subject: RE: [PATCH 1 of 1] log: Log server crash if SC nodes is not of
same
>chkpt version [#1459]
>
>Hi Vu
>
>If possible remove version 3 checking entirely, see my previous mail
>
>Thanks
>Lennart
>
>-Original Message-
>From
eded since the same thing is
done
>in #1459?
>If that's the case #1387 should be closed and information about that #1459
fix
>the problem described in #1387 must be added to the #1459 ticket
>
>Thanks
>Lennart
>
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu.
Ack with minor comments.
1. Page 19, numbering for "Service Dependencies" is off. In previous
version, it was numbered "3.4 Service Dependencies".
Not sure it is your intention or not.
2. In page 19, "Initial configuration can be made by defining a
configuration object off the
Hi,
With this patch, the lowest value for `logMaxLogrecsize` in the validation
is set to `256`.
But in logsv class definition, the default value of `
saLogStreamFixedLogRecordSize` is set to `150`.
I think the lowest value for ` logMaxLogrecsize` should be changed to `150`
instead.
Regards,
Vu
osaf/tools/saflog/saflogger/saf_logger.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Currently, saflogger tool uses its own defined log file format
for application stream, instead of built-in one in log server.
diff --git a/osaf/tools/saflog/saflogger/saf_logger.c
Author: Vu Minh Nguyen vu.m.ngu...@dektech.com.au
Date: Tue, 11 Aug 2015 09:32:29 +0100
log: saflogger should use built-in default log file format in log server
[#1433]
Currently, saflogger tool uses its own defined log file format for
application stream, instead
501 - 600 of 614 matches
Mail list logo
