Hi Hoang,
Reviewed and tested both patches.
There is still a memory leak when some tests fail.
==20325== 752 bytes in 2 blocks are definitely lost in loss record 9 of 10
==20325==at 0x4C2AB80: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==20325==by 0x4E7731D:
Hi Neelakanta,
You are right.
I tested with the old version.
OpenSAF works fine with V2 patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 7 mars 2017 08:09
To: Zoran Milinkovic <zoran.milinko...@ericsson.
eId = 131855, SupervisionTime = 60
Mar 6 15:37:33 PL-3 opensaf_reboot: Rebooting local node; timeout=60
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 mars 2017 12:54
To: Hung Duc Nguyen <hung.d.ngu...@
Hi Neelakanta,
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 6 mars 2017 11:34
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: o
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm: init CLM in seperate thread to avoid deadlock
[#2327] V2
Hi zoran,
comments inline.
On 2017/03/02 06:06 PM, Zora
Hi Hung,
Ack from me.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 1 mars 2017 11:19
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm: Sync latest
rmv_ind(_cb->clm_init_sel_obj, true, true);
}
This is a quick solution without testing.
Please check is this proposal will work.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 2 mars 2017 08:32
To: Hung Duc
Hi Neelakanta,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 27 februari 2017 12:56
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@eri
Hi Hans,
With one hash and one crypto function, I would rather go with our own
implementation. Both of them is not hard to implement.
If there is a need for supporting more algorithms in the future, then I would
consider for using OpenSSL.
As Anders has pointed out, adding OpenSSL means adding
Hi Anders,
I have few comments to the patch
The hash function will not work on big endian systems.
Do we support only little endian systems or OpenSAF code should work on both
endian systems ?
Base64 has only encoding function.
If something is going to be pushed to base directory, then I think
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 17 februari 2017 09:06
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Reviewed and tested the patch.
No more zombie processes.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 13 februari 2017 05:00
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.
src/imm/common/immpbe_dump.cc| 29 +++--
src/imm/immpbed/immpbe_daemon.cc | 2 ++
2 files changed, 21 insertions(+), 10 deletions(-)
A static string variable sPbeFileName is double freed when exit call is called
from 2 threads.
The patch dynamicly allocate the
Other n
Comments (indicate scope for each "y" above):
-
changeset 8b9bf1c0d417990931c702defaf4b2cfabb74af5
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 13 Feb 2017 13:36:49 +0100
imm:
?SNl 14:18 0:01
/usr/lib/opensaf/osafimmpbed --pbe /etc/opensaf/imm.db
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 10 februari 2017 08:26
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: o
src/mds/mds_c_sndrcv.c | 38 +++---
1 files changed, 23 insertions(+), 15 deletions(-)
Improve MDS logging in mds_mcm_time_wait() and split the common MDS log into
timeout and error logs.
In other places after mds_mcm_time_wait() calls, the log messages are
Comments (indicate scope for each "y" above):
-
changeset 73aa6aa93c98f27c776ddd6e36ea073a56590250
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 09 Feb 2017 14:32:58 +0100
mds: improve MDS logging [#2297]
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 6 februari 2017 04:45
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
will see that it's obvious that this reply is
missing in the function.
BR,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 1 februari 2017 04:39
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subje
src/ckpt/ckptnd/cpnd_evt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
If a client node is not found in cpnd_evt_proc_ckpt_open(), the checkpoint node
director will reply with SA_AIS_ERR_BAD_HANDLE.
diff --git a/src/ckpt/ckptnd/cpnd_evt.c b/src/ckpt/ckptnd/cpnd_evt.c
---
libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 3af6cc61bf08fd86a20d1f4ce87e8c41435e17c7
Author: Zoran Milinkovic <zoran.milinko...
Hi Hoang,
Can you share the test code ?
I cannot reproduce steps you have described. I might be missing something.
Thanks,
Zoran
-Original Message-
From: Hoang Vo [mailto:hoang.m...@dektech.com.au]
Sent: den 19 januari 2017 08:08
To: mahesh.va...@oracle.com; Zoran Milinkovic
Hi Anders,
I'll add your comment when I push the patch.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 10 januari 2017 15:38
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
Hi Anders,
No, we can't.
If we are going to remove ncslpg_*, then we need another ticket.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 10 januari 2017 15:10
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; ramesh.bet...@oracle.com
Cc: opensaf
src/base/sysf_tmr.c | 27 ++-
1 files changed, 6 insertions(+), 21 deletions(-)
Timers started before the timer engine thread is started are calculated from
the time a computer starts.
Timers started after the timer engine thread started are calculated from the
time
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 82a6e93d9e4406a2bb0ca05c6b127d74d56ae796
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 24 Jan 2017 10:40:05 +01
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 23 januari 2017 08:54
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Add missing check
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 19 januari 2017 12:20
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 19 januari 2017 11:39
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
for timers.
I will republish the patch next week.
BR,
Zoran
-Original Message-
From: ramesh betham [mailto:ramesh.bet...@oracle.com]
Sent: den 19 januari 2017 12:27
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: Anders Widell <anders.wid...@ericsson.com>;
o
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 19 januari 2017 07:25
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com; Anders Widell <anders.wid...@ericsson.com>
src/imm/immpbed/immpbe_daemon.cc | 34 ++
1 files changed, 18 insertions(+), 16 deletions(-)
Fix memory leak in PBE when admin op for resource display is invoked.
Additional indentation fix is added to the patch.
diff --git a/src/imm/immpbed/immpbe_daemon.cc
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 3e89f5ba272d17a302554ee632cb24cce0bea923
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 12 Jan 2017 14:19:28 +0100
src/ckpt/agent/cpa_proc.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
Allocated memory in cpa_proc_build_data_access_evt() is freed.
diff --git a/src/ckpt/agent/cpa_proc.c b/src/ckpt/agent/cpa_proc.c
--- a/src/ckpt/agent/cpa_proc.c
+++
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset eea7b196b146baa5fdf4e854a2f5ceab805daf95
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 10 Jan 201
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 38b9760aee947d41b2bc8760fa6f0f181f9621e5
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 10 Jan 201
src/ckpt/ckptd/cpd_red.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Fix memory leak in cpd_a2s_ckpt_usr_info() in cpd_red.c
diff --git a/src/ckpt/ckptd/cpd_red.c b/src/ckpt/ckptd/cpd_red.c
--- a/src/ckpt/ckptd/cpd_red.c
+++ b/src/ckpt/ckptd/cpd_red.c
@@ -339,5 +339,8 @@ void
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 5139bc63f580d9b3dcc6e9caeefaf3bbfa4c7292
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 10 Jan 2017 16:21:56 +0100
src/ckpt/agent/cpa_api.c | 26 +++---
src/ckpt/ckptnd/cpnd_evt.c | 12
2 files changed, 19 insertions(+), 19 deletions(-)
Fix string temination issues when SaNameT value is provided to
saCkptCheckpointOpen(), saCkptCheckpointOpenAsync() and
Hi Neelakanta,
Reviewed and tested the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 30 december 2016 08:03
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zora
src/base/sysf_tmr.c | 9 -
1 files changed, 8 insertions(+), 1 deletions(-)
Fix memory leak in ncs_tmr_add_pat_node()
Fix timer state, so that the timer will not execute if ncs_tmr_start() fails
diff --git a/src/base/sysf_tmr.c b/src/base/sysf_tmr.c
--- a/src/base/sysf_tmr.c
+++
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 7782a5f4a72f0a38bf392c72b1eebeb163582318
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 04 J
n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 59aa1f7d9e6012e70470b3467eadb42454b6dcd2
Author: Zoran Milinkovic <zoran.milinko...@erics
src/base/sysf_tmr.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Add missing decrementing reference counter 'gl_tcb.persist' in ncs_tmr_start()
and ncs_tmr_remaining()
diff --git a/src/base/sysf_tmr.c b/src/base/sysf_tmr.c
--- a/src/base/sysf_tmr.c
+++ b/src/base/sysf_tmr.c
@@
src/base/sysf_tmr.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
sysfTmrCreate() will wait for max 1 second for the timer thread to be fully
ready to start timers.
diff --git a/src/base/sysf_tmr.c b/src/base/sysf_tmr.c
--- a/src/base/sysf_tmr.c
+++
n
Other n
Comments (indicate scope for each "y" above):
-
changeset c6fd229c74ecebb3e776e7ff8884f9a001412d0b
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 03 Jan 2017 16:37:06 +0100
b
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 4618b4305c8e88d59dfa146a7abb2ff57d9a6306
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 02 Jan 201
osaf/libs/core/leap/sysf_def.c | 2 +-
osaf/libs/core/leap/sysf_tmr.c | 23 ++-
2 files changed, 19 insertions(+), 6 deletions(-)
Fix sysfTmrCreate and return values.
diff --git a/osaf/libs/core/leap/sysf_def.c b/osaf/libs/core/leap/sysf_def.c
---
Hi Hung,
Reviewed and tested the patch.
Ack from me.
Memory leak fixed in the second review file needs to be fixed in earlier
OpenSAF releases.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 13 december 2016 04:28
To: Zoran
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 20 december 2016 08:37
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [P
Hi,
immOmIsLoader has been recently changed (#8434).
I must be checking of earlier OpenSAF release.
Ignore immOmIsLoader comment.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 20 december 2016 08:55
To: Zoran Milinkovic <zoran.milinko...@ericsson.
Hi Hung,
Ack from me with a minor comment on immOmIsLoader I sent for the first code
review.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 14 december 2016 09:45
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.n
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 14 december 2016 09:45
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Makefile.common| 1 +
osaf/libs/core/cplusplus/base/mutex.cc | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
After executing ./configure, config.h is created in the build directory.
Top build directory is added to the include path, and solves building issue
n
Comments (indicate scope for each "y" above):
-
changeset 706f4519e765d1b0a65b03bf43d0a57287257b8e
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 08 Dec 2016 16:42:57 +0100
build: add top
Hi,
Affected branches should be: opensaf-5.0.x, opensaf-5.1.x, default(5.2)
Development branch: default(5.2)
Thanks,
Zoran
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 8 december 2016 14:34
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel
n
Other n
Comments (indicate scope for each "y" above):
-
<>
changeset 482be4eb534d858a1df19228bd131b83d0e89cd3
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 08 Dec 2016 14:30:43 +0100
osaf/services/saf/immsv/immnd/ImmModel.cc | 4
osaf/services/saf/immsv/immnd/immnd_cb.h | 4
osaf/services/saf/immsv/immnd/immnd_evt.c | 4
3 files changed, 4 insertions(+), 8 deletions(-)
Move IMM error string prefixes to immnd_cb.h header file.
diff --git
Hi Neelakanta,
I missed that detail.
Reviewed and tested the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 7 december 2016 06:41
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc
...@oracle.com]
Sent: den 6 december 2016 12:11
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in
completed callback[#1956] V4
osaf
Hi Neelakanta,
Ack from me when the code is fixed.
Thanks,
Zoran
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 1 december 2016 10:35
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Cc: o
Hi Hung,
Then the code needs to be fixed, and objectName variable can remain in the code.
Otherwise I don't see the purpose of the variable.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 1 december 2016 10:04
To: Zoran Milinkovic <zoran.milinko...@ericsson.
Sent: den 1 december 2016 05:56
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in
completed callback[#1956] V2
Hi Zoran
,
and replace it with SaImmAdminOwnerNameT (or other sting type).
Find other comments inline
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 30 november 2016 06:39
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 25 november 2016 08:35
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [P
Hi Neelakanta,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 november 2016 11:04
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dekte
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 4 november 2016 05:42
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 25 oktober 2016 12:54
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [P
Hi Hung,
Nice work with MBC versions.
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 21 oktober 2016 06:39
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: o
Hi Anders,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 20 oktober 2016 12:53
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>
Cc: o
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 17 oktober 2016 08:00
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [P
Hi Hung,
Reviewed, but not tested.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 18 oktober 2016 08:58
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 12 oktober 2016 05:02
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Reviewed, but not tested.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 11 oktober 2016 05:57
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
Hi Hung,
Reviewed the patch,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Duc Nguyen
Sent: den 6 oktober 2016 10:43
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm
Hi Hung,
A minor comment can be found inline.
Ack when the code is fixed.
No need to send the patch for another review.
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 29 september 2016 11:24
To: Zoran Milinkovic <zoran.milinko...@ericsson.
Hi Neelakanta,
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 26 september 2016 11:20
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Cc: o
Hi Hung,
Reviewed the code.
Ack from me.
BR,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 23 september 2016 09:49
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 22 september 2016 13:19
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if
Hi Hung,
A minor comment inline.
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 20 september 2016 07:38
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [P
osaf/libs/common/clmsv/clmsv_enc_dec.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Set zeros in SaNameT value before SaNameT is populated with incoming SaNameT
string from the network.
This will make node name unique in patricia tree, and the node name search
mismatch will be
n
Comments (indicate scope for each "y" above):
-
changeset 096dd54d77c4c15392a38ff91d5f37e4cbdb8a04
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 20 Sep 2016 10:52:41 +0200
clm: fi
ck from me when the upper sentence is fixed.
No need to send the document for another review.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 16 september 2016 12:28
To: Zoran Milinkovic; Hung Duc Nguyen; opensaf-devel@lists.sourc
Hi Neelakanta,
Nice work.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 13 september 2016 13:06
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Hi Neelakanta,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 13 september 2016 13:47
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Hi Neelakanta,
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 14 september 2016 10:58
To: Zoran Milinkovic; Hung Duc Nguyen; mathi.naic...@oracle.com; Anders Widell
Cc: opensaf-devel@lists.sourceforge.net
Hi Mathi,
notificationBuffer in only OUT parameter, and input parameters should not be
checked.
Ack from me.
Thanks,
Zoran
-Original Message-
From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com]
Sent: den 9 september 2016 11:40
To: Zoran Milinkovic
Cc: opensaf-devel
Hi Mathi,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
Sent: den 9 september 2016 12:23
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Review request for updates to CLM PR FOR 5.1
Hi,
Please
-Original Message-
From: mathi.naic...@oracle.com [mailto:mathi.naic...@oracle.com]
Sent: den 9 september 2016 11:40
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] clm: avoid checking length of sanamet when clm service
is filling data [#2002]
osaf/libs
...@oracle.com; Anders Widell; Zoran Milinkovic; Hung Duc Nguyen;
reddy.neelaka...@oracle.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] Immnd: maximum Ccbs limit 1 has been reached very
quickly
The IMM service uses the "presumed abort" definition of what a missing CCB
re
to test the performance between std::vector and std::map.
Anyway, this improvement can only be done in the next OpenSAF release.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 september 2016 13:25
To: Zoran Milinkovic; Anders Widell; A V Mahesh; Neelakanta Reddy
for minutes because some other application intensively used CCBs and
managed to close 1 handles within a minute.
BR,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 september 2016 12:29
To: Anders Widell; Zoran Milinkovic; A V Mahesh; Neelakanta Reddy;
opensaf-devel
, IMM test or
because of external interference.
Anyway, I ack the patch because it's a very nice solution for improving IMM
test code.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 26 augusti 2016 08:32
To: Zoran Milinkovic
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 26 augusti 2016 12:45
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Remove pthread_exit from
IMM performance.
Or we can revert the ticket and implement it in the next release with better
performance.
I would also like to hear Neelakanta's and Hung's proposals.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 2 september 2016 05:56
To: Z
Hi Neelakanta,
This is definitely a bug.
When CCB is finalized, it's still shown as an active CCB.
If you check number of CCBs with resource display functionality, you will see
that number of CCBs is not decreasing.
BR,
Zoran
-Original Message-
From: Neelakanta Reddy
...@oracle.com]
Sent: den 1 september 2016 07:29
To: opensaf-devel@lists.sourceforge.net
Cc: Zoran Milinkovic
Subject: Immnd: maximum Ccbs limit 1 has been reached very quickly
Hi All,
I was running `immcfg` in a loop to create some object , once it reaches
10001objects creation Immnd is returning
, and will not abort CLM test.
We can create a macro with Hans proposal and use it when system() is called.
Thanks,
Zoran
-Original Message-
From: Hans Nordebäck
Sent: den 31 augusti 2016 13:33
To: Mathivanan Naickan Palanivelu; Venkata Mahesh Alla; Zoran Milinkovic
Cc: opensaf-devel
you mean ?
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 30 augusti 2016 10:40
To: Hans Nordebäck; Zoran Milinkovic
Cc: praveen malviya; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] staging changeset: 7982 with gcc version 4.8.3
Hi Hung,
Reviewed the patch.
Ack.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 29 augusti 2016 12:47
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request
101 - 200 of 678 matches
Mail list logo
