Re: [devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

ACK not tested -AVM On 8/25/2016 10:06 AM, Vo Minh Hoang wrote: > Dear Mahesh, > > Logic of this part is complicated so I modified it wrong. > This time I correct it, not a roll back. > That part is subsequence of if clause above. > > Sincerely, > Hoang > > -Ori

Re: [devel] Review Request for log: update OpenSAF_LOG_PR for long DN [#1898]

ACK -AVM On 8/25/2016 8:08 AM, Vu Minh Nguyen wrote: > > Hi Mahesh, > > Any comments on the PR? > > Regards, Vu > > *From:* Lennart Lund [mailto:lennart.l...@ericsson.com] > *Sent:* Wednesday, August 17, 2016 5:50 PM > *To:* Vu Minh Nguyen ; mahesh.va...@oracle.com >

Re: [devel] [PATCH 1 of 1] imported patch 1967_fix_headless_error_cppcheck.patch

Hi Hoang, Is this rollback of `ckpt: fix cppcheck warning [#1874]` ? === @@ -4766,6 +4758,13 @@ static uint32_t cpnd_transfer_replica(CP total_num++; tmp_sec_info =

Re: [devel] [PATCH 1 of 1] dtm: Fix cppcheck warnings [#1963]

Hi Anders Widell, ACK Reviewed & tested IPv4 & IPv6 -AVM On 8/23/2016 3:34 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_inter_svc.c|5 +- > osaf/services/infrastructure/dtms/dtm/dtm_intra.c| 10 +- >

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

e > can be seen by all nodes. > > To pass the test, the log folder has to be seen by all nodes. > > Regards, Vu > >> -Original Message- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: Tuesday, August 23, 2016 4:04 PM >> To: Vu

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

ETDATA abort err :%s", strerror(errno) ); *abort();* } = -AVM On 8/23/2016 1:08 PM, Hans Nordebäck wrote: > Hi Mahesh, > > Please see response below with [HansN] > /Thanks H

Re: [devel] [PATCH 1 of 1] ckpt: fix cppcheck warning [#1874] v2

ACK -AVM On 8/23/2016 2:11 PM, Hoang Vo wrote: > osaf/services/saf/cpsv/cpd/cpd_db.c | 8 ++--- > osaf/services/saf/cpsv/cpd/cpd_evt.c| 4 +- > osaf/services/saf/cpsv/cpd/cpd_imm.c| 2 +- > osaf/services/saf/cpsv/cpd/cpd_tmr.c| 2 +- >

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Type Value(s) > > logRootDirectory SA_STRING_T > /repl_opensaf/saflog > > > 2) On PL, check if the node can access to shared folder: > /logtest_sc_down_path > > > Regards, Vu > >>

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

ents. > > Please help me push these items if there is no further problem. > > Thank you and best regards, > Hoang > > -----Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Monday, August 22, 2016 1:53 PM > To: Hoang Vo &

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA [#1574] v4

Sincerely, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Monday, August 22, 2016 1:02 PM > To: Hoang Vo <hoang.m...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 6 of 8] cpsv: Apply new mes

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

: > Hi Mahesh, > > Can you check if PL node can access the shared log folder? > > E.g: path on UML test > /repl_opensaf/saflog/logtest_sc_down_path/ > > I guess the problem is caused by PL not able to access the SAF log folder. > > Regards, Vu > >> -Or

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

Hi Vu, I got it running on SC , but it is failing on PL with : "cur_logfile_name_get scandir Fail No such file or directorysaLogRecov_prepare_client1_8streams Internal error. Test failed 2 FAILED (expected EXIT_SUCCESS, got EXIT_FAILURE (1))" -AVM On 8/23/2016 12:06 PM,

Re: [devel] [PATCH 1 of 1] log: fix failed to recover app streams [#1941]

PASSED Before SC down: Prepare 1 cfg (notif) stream; Stop both SC nodes [stdby first]. Press Enter when stopped... ; Start at least one SC node. Press Enter when started... == -AVM On 8/23/2016 12:03 PM, A V

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN Please see response below with [AVM] -AVM On 8/23/2016 11:41 AM, Hans Nordebäck wrote: > Hi Mahesh, > > please see comments below. > > /Thanks HansN > > > On 08/23/2016 07:21 AM, A V Mahesh wrote: >> Hi HansN, >> >> Let us fist discuss the

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, Let us fist discuss the error handling and abort, then we can come back to interpretation of TIPC currently does permit OR does not permit an application to send a multicast message with the "destination droppable" setting disabled. Let us disable TIPC_DEST_DROPPABLE, so that TIPC

Re: [devel] [PATCH 1 of 1] log: fix incorrect usage of saImmRtObjectDelete on cfg app stream [#1330]

Hi Vu, ACK -AVM On 7/20/2016 11:40 AM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_imm.cc| 25 + > osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 1 + > osaf/services/saf/logsv/lgs/lgs_stream.cc | 6 -- >

Re: [devel] [PATCH 1 of 1] ckpt: fix cppcheck warning [#1874]

Hi Hoan, Can you please push -AVM On 6/13/2016 11:58 AM, A V Mahesh wrote: > Hi Hoang Vo, > > ACK , Not tested. > > By the way which GCC/tool given these warnings ? > > -AVM > > On 6/13/2016 9:20 AM, Hoang Vo wrote: >> osaf/services/saf/cpsv/cpd/cpd_db.c |

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

Hi Hoang, ACK, Please Update README Note : tested default functionality , LONG DN functionality not tested in full fledged. -AVM On 8/18/2016 12:48 PM, Hoang Vo wrote: > Summary: CKPT: Support DNs longer than 255 bytes {#1574} > Review request for Trac Ticket(s): 1574 > Peer Reviewer(s):

Re: [devel] [PATCH 7 of 8] ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1

ACK. Not tested. -AVM On 8/18/2016 12:48 PM, Hoang Vo wrote: > tests/cpsv/Makefile.am |1 + > tests/cpsv/test_cpa.c | 180 > +++- > tests/cpsv/test_cpa_util.c | 16 +++- > tests/cpsv/test_cpsv.h |6 + >

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA [#1574] v4

Hi Hoang, ACK for [PATCH 6 of 8] with following minor comment I think CPND should return SA_AIS_ERR_TOO_BIG = 26 instead of SA_AIS_ERR_INVALID_PARAM ( please sync-up with other service return values ). Note : tested default functionality , LONG DN functionality not tested in full fledged

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT [#1574] v3

Hi Hoang, ACK for [PATCH 4 of 8] assuming unrequited comment code will be removed Note : tested default functionality , LONG DN functionality not tested in full fledged -AVM On 8/18/2016 12:48 PM, Hoang Vo wrote: > osaf/libs/common/cpsv/cpsv_evt.c | 439 >

Re: [devel] [PATCH 3 of 8] cpa: Add support for extended SaNameT [#1574] v1

Hi Hoang, ACK for [PATCH 3 of 8] with following minor comment I think API should return SA_AIS_ERR_TOO_BIG = 26 instead of SA_AIS_ERR_INVALID_PARAM ( please sync-up with other service return values ). Note : tested default functionality , LONG DN functionality not tested in full fledged

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

gh very > unlikely. > > I'll update the patch with the logging of the returned message > removed, and only log that a message has been dropped, which > > should be enough for debugging purposes. > > /Thanks HansN > > > > On 08/18/2016 11:27 AM, A V Mahesh wrote: >

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, It seem you missed to see below : On 8/12/2016 9:11 AM, A V Mahesh wrote: > Hi HansN, > > We were having ticket for this raised by Hans Feldt > `https://sourceforge.net/p/opensaf/tickets/634/` > > at that time i have give my analysis base the MDS code at that time

Re: [devel] [PATCH 1 of 1] log: fix ER in syslog if changing saLogStreamFileName and other atrributes[#1887]

Hi, ACK , tested Please re-base before publishing. -AVM On 8/4/2016 9:36 AM, Canh Van Truong wrote: > osaf/services/saf/logsv/lgs/lgs_imm.cc | 52 > +- > 1 files changed, 26 insertions(+), 26 deletions(-) > > > When changing saLogStreamFileName with other

Re: [devel] [PATCH 1 of 1] clm: fix string format for size_t type [#1906]

Hi Zoran, ACK Not tested. -AVM On 8/16/2016 3:01 PM, Zoran Milinkovic wrote: > osaf/services/saf/clmsv/clms/clms_imm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Fix string format for size_t type, so that 32-bit compilers can compile > OpenSAF without errors. > >

Re: [devel] [PATCH 1 of 1] clm: fix decoding for SaNameT type [#1906]

Hi Zoran, ACK tested. -AVM On 8/16/2016 1:31 PM, Zoran Milinkovic wrote: > osaf/libs/common/clmsv/clmsv_enc_dec.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > Add null-terminated string to the end of decoded string for SaNameT type. > > diff --git

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

SER=root ; COMMA = -AVM On 8/12/2016 11:41 AM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your help. > I send the attached patch that fix missing in encode/decode function. > > Thank you and best regards, > Hoang > > -----Original Messag

Re: [devel] [PATCH 1 of 1] cpd: handle BAD_HANDLE from saClmDispatch [#1822]

Hi Hoang, ACK tested with normal configuration . Note : not created error SA_AIS_ERR_BAD_HANDLE. -AVM On 8/16/2016 12:15 PM, Hoang Vo wrote: > osaf/services/saf/cpsv/cpd/cpd_init.c | 67 > ++- > 1 files changed, 66 insertions(+), 1 deletions(-) > > >

Re: [devel] osafclmna[5375]: ER Exiting

I was starting SC-2 as Active -AVM On 8/16/2016 12:07 PM, A V Mahesh wrote: > Hi Zoran Milinkovic, > > It seems some problem with thees patches : > > Opensaf is not comingup with error `SC-2 osafclmna[5375]: ER*SC-2m* > is not a configured node` & ` SC-2 osafc

[devel] osafclmna[5375]: ER Exiting

Hi Zoran Milinkovic, It seems some problem with thees patches : Opensaf is not comingup with error `SC-2 osafclmna[5375]: ER*SC-2m* is not a configured node` & ` SC-2 osafclmna[5375]: ER Exiting` = changeset: 7855:bc669776cf7f

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

ase consider about it. > > Thank you and best regards, > Hoang > > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Friday, August 12, 2016 12:49 PM > To: Hoang Vo <hoang.m...@dektech.com.au> > Cc: opensaf-devel@lists.

Re: [devel] [PATCH 0 of 1] Review Request for log: improve test cases for log service [#1913]

Hi Canh Van Truong, On 8/11/2016 11:50 AM, Canh Van Truong wrote: > 2) Remove abort (safassert) in test case and handle it as test case failed. Still seeing abort (safassert) Suite 2: Log Service

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

Hi Hoang, We don't required any new event like CPND_EVT_D2ND_CKPT_CREATE_2 even though NEW CPND might might be sending event to OLD CPD. In general Opensaf rule is that any newly introduce enhancement/feature functionality can be used once Cluster is completely upgraded to new version.So while

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT v1 [#1574]

Hi Hoang, I completed the testing most of the in service & normal test case are working fine , so I stated reviewing code now can please answer below : 1) This patch introduced multiple new event between Agent to ND which are always local to the node ( in a new version software cpa & cpnd

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

environment could not reproduce this problem. > > Thank you and best regards, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Tuesday, August 9, 2016 4:35 PM > To: Hoang Vo <hoang.m...@dektech.com.au> > Cc: opensaf-devel

Re: [devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

Hi Anders Widell, ACK with assumption, that In Container environments IV6 not being used/issue doesn't observed. -AVM On 8/4/2016 2:22 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 > +++- > 1 files changed, 32 insertions(+), 4

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT v1 [#1574]

file. > > I find only MDS_CLIENT_MSG_FORMAT_VER and I think that I should not update > this each time adding new message. I am sorry if it is wrong. > > Thank you very much for your review. > Best regards, > Hoang > > -----Original Message- > From: A V Mahesh [mai

Re: [devel] [PATCH 4 of 8] cpsv: Add new message to support extended SaNameT v1 [#1574]

Hi Hoang, I am seeing new encode decodes done between D to ND , in this patch ( old cpd to new cpnd & old cpnd to new cpd ) but not able find edu rules , please confirm. Otherwise it will take unnecessary testing effort. If not handled please refer `osaf/libs/common/cpsv/cpsv_edu.c `

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

following your > comment. > I also update readme file that is attached to this email. > Please tell me if you have any further inquiry. > > Thank you and best regards, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Frid

Re: [devel] [PATCH 2 of 4] lgs: director Cluster Membership (CLM) integration [#1638] V4

Hi Lennar, On 8/8/2016 7:06 PM, Lennart Lund wrote: >> +/** >> >+ * Name : lgs_clm_node_map_init >> >+ * Description : This routine is used to initialize the clm_node_map >> >+ * Arguments : lgs_cb - pointer to the lgs Control Block >> >+ * Return Values :

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

Hi Hoang, The new messages between old cpd to new cpd (A to S) was not handled , please refer `osaf/libs/common/cpsv/cpsv_edu.c ` file for MSG_FORMAT_VER handling or any old patches -AVM On 8/9/2016 3:05 PM, A V Mahesh wrote: > Hi Hoang , > > Please hold on pushing. > > On n

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

-1,safSg=2N,safApp=OpenSAF' faulted due to 'avaDown' : Recovery is 'nodeFailfast' -AVM On 8/9/2016 2:09 PM, A V Mahesh wrote: > ACK, > > -AVM > > > On 8/3/2016 4:02 PM, Hoang Vo wrote: >> osaf/libs/common/cpsv/include/cpd_cb.h |2 + >> osaf/libs/common/

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

ACK, -AVM On 8/3/2016 4:02 PM, Hoang Vo wrote: > osaf/libs/common/cpsv/include/cpd_cb.h |2 + > osaf/libs/common/cpsv/include/cpd_proc.h |3 + > osaf/libs/common/cpsv/include/cpd_red.h | 13 ++ > osaf/libs/common/cpsv/include/cpsv_evt.h |8 + >

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

> Hoang > > -----Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, July 27, 2016 4:53 PM > To: Vo Minh Hoang <hoang.m...@dektech.com.au>; 'Nhat Pham' > <nhat.p...@dektech.com.au>; anders.wid...@ericsson.com > Cc: opensaf-deve

Re: [devel] [PATCH 1 of 1] log: client crashed due to not initialize the client_list pointer [#1933]

ACK, -AVM On 8/5/2016 1:16 PM, Vu Minh Nguyen wrote: > osaf/libs/agents/saf/lga/lga_api.c | 3 ++- > osaf/libs/agents/saf/lga/lga_state.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > > Not initilize the global pointer variable `client_list`. It might refer to an >

Re: [devel] [PATCH 1 of 1] log: build saflogger tool failed on 32-bit machine [#1936]

Hi, ACK. -AVM On 8/5/2016 5:04 PM, Vu Minh Nguyen wrote: > osaf/tools/saflog/saflogger/saf_logger.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Fix build saflogger failed on 32-bit machine. > > Using format "%zu" instead of "%lu" for data type size_t. > > diff --git

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V3

Hi Vu, I Incorporated most of your review comments please review `lgs: director Cluster Membership (CLM) integration [#1638] V4`. -AVM On 8/5/2016 10:26 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > I have some comments [Vu]. > > Regards, Vu > >> -Original Message- >> From:

Re: [devel] [PATCH 3 of 3] logtest: change related to Cluster Membership (CLM) integration [#1638] V3

Hi Lennart, Added test suite 14 , please review`logtest: change related to Cluster Membership (CLM) integration [#1638] V4 & tests: added missing saf_error strings [#1638] V4`, also incorporated , the other review comments as well. -AVM On 8/4/2016 6:23 PM, Lennart Lund wrote: > Hi

Re: [devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

Hi Anders Widell, Did you verified IP6 or you want me to test ? -AVM On 8/4/2016 2:22 PM, Anders Widell wrote: > osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 > +++- > 1 files changed, 32 insertions(+), 4 deletions(-) > > > The IPv4 broadcast address is

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

; Peer Reviewer(s): Vu, Lennart,Anders Widell >> Pull request to: <> >> Affected branch(es): default >> Development branch: defult >> >> >> Impacted area Impact y/n >> >> Docs

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I incorporated most of your review comments except creating a LgsClm class in V3 patch please review. -AVM On 8/2/2016 6:30 PM, Lennart Lund wrote: > Hi > > My comments for patch 2 > > I have found some things that should be considered in order to get as clean > code as possible: >

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

hitespace/tab] [1] > > regards, > > Anders Widell > > On 08/02/2016 10:17 AM, mahesh.va...@oracle.com wrote: >> Summary:lgsv: Log Service CLM integration [#1638] V2 >> Review request for Trac Ticket(s): #1638 >> Peer Reviewer(s): Vu, Lennart,Anders Widell >>

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I just incorporated possible comments based on the current code base, This My fist patch for LOG :) , so I just followed how existing functions/variables organized like. I will considered all other inputs while doing complete refracting code to C++ in a separate ticket soon.

Re: [devel] [PATCH 1 of 3] lga: agent Cluster Membership (CLM) integration [#1638] V2

Hi Lennart, Thanks for the comments. One of your major comment is `lga_hdl_rec->is_stale_client` & `cb->clm_node_state` is not protected in lga_mds.c , but if you see the lga_mds_rcv() , lga_lgs_msg_proc() it self is protected , so all the chances in lga_lgs_msg_proc() are protected. I

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

t; >> >> Comments (indicate scope for each "y" above): >> - >> <> >> >> changeset d7c494e940160d474a89dbafbc2cbf058678 >> Author:A V Mahesh <mahesh.va...@oracle.com> >> Da

Re: [devel] [PATCH 1 of 3] lga: agent Cluster Membership (CLM) integration [#1638] V1

Hi Vu, I incorporated most of your comments , please find my response with [AVM] & code change in V2 patch ( lga: agent Cluster Membership (CLM) integration [#1638] V2) -AVM On 7/29/2016 9:20 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > I have few comments, started with [Vu]: > > General:

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V1

Hi Vu, I incorporated most of your comments , please find my response with [AVM] & code changes V2 patch (lgs: director Cluster Membership (CLM) integration [#1638] V2) -AVM On 7/29/2016 9:34 AM, Vu Minh Nguyen wrote: > Hi Mahesh, > > See my comments inline, started with [Vu]. > > Regards,

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V1

n >> Build systemn >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF servicesy >> OpenSAF services n >> Core libraries n >> Samples n

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V1

-- >> Docsn >> Build systemn >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF servicesy >> OpenSAF services n >> Core

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

Hi Hoang, Minor comment -AVM On 7/21/2016 3:04 PM, Hoang Vo wrote: > osaf/libs/agents/saf/cpa/cpa_api.c | 12 +--- > osaf/libs/agents/saf/cpa/cpa_mds.c | 2 +- > osaf/libs/common/cpsv/cpsv_evt.c| 1 + > osaf/services/saf/cpsv/cpd/cpd_evt.c| 10 +++---

Re: [devel] [PATCH 8 of 8] imported patch 1574_cpnd_support_recover_shm_version_0_v3.patch

Hi Hoang, Minor comment -AVM On 7/21/2016 3:04 PM, Hoang Vo wrote: > osaf/libs/common/cpsv/include/cpsv_shm.h | 20 +- > osaf/services/saf/cpsv/cpnd/cpnd_proc.c |1 - > osaf/services/saf/cpsv/cpnd/cpnd_res.c | 821 > +++--- > 3 files changed, 634

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

Hi Hoang, I just started reviewing please share following : I hope this Long DN should support In-service upgrade , if so, please share the test case that you run , it will help me in reviewing and in test uncovered use/test cases. -AVM On 7/21/2016 3:04 PM, Hoang Vo wrote: >

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

on sharemem > should be one. > 9. immlist to check information > > Please tell us if I miss something. > I am sorry for any inconvenient. > > Thank you and best regards. > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Fri

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

Hi Hoan, I tested in-service testing on 4 node setup ( combination of old and new) , with application opened on two payloads, restarting controllers. I am trying to recollect the test case , mean while you can also give a try . -AVM On 7/26/2016 1:58 PM, A V Mahesh wrote: >

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638]

n > > > Comments (indicate scope for each "y" above): > --------- > > changeset 3cea257f1e7fc8570828ece564f9bfa563c0693b > Author: A V Mahesh <mahesh.va...@oracle.com> > Date: Tue, 26 Jul 2016 13:42:29 +0530 > > lga: agent Cluster M

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

? In my opinion sharemem > should be one. > 9. immlist to check information > > Please tell us if I miss something. > I am sorry for any inconvenient. > > Thank you and best regards. > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracl

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

lags SA_UINT32_T 2 (0x2) SaImmAttrImplementerName SA_STRING_T safCheckPointService SaImmAttrClassName SA_STRING_T SaCkptCheckpoint SaImmAttrAdminOwnerNameSA_STRING_T -AVM On 7/13/2016 12:44 PM,

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

Hi Hoang /Nhat Pham, I just started testing , fowling test case is failing , I may report more as soon as I get some Test case 1 : Step 1 : saCkptCheckpointOpen on SC-1 SC-1:# ./node_A 0 saCkptCheckpointOpen returned checkpointHandle 626bf0 1 saCkptCheckpointOpen returned

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

ings to make long DN work . > > If you want to see the verification data, enable the environment ` > LOGTEST_ENABLE_STDOUT`. > > E.g: > # LOGTEST_ENABLE_STDOUT=1 logtest 13 > > Regards, Vu > >> -Original Message- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com

Re: [devel] [PATCH 1 of 1] cpd: To reduce updating time out [#1788]

ACK ,Not tested . Sorry for the delay some how Over looked this patch. -AVM On 5/13/2016 7:41 AM, Nhat Pham wrote: > osaf/libs/common/cpsv/include/cpd_proc.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > Problem: > > Application gets fault code

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

LLL, parent (null) == -AVM On 7/8/2016 10:19 AM, A V Mahesh wrote: > Hi Vu, > > On 7/8/2016 10:11 AM, Vu Minh Nguyen wrote: >> I zipped all the patches in attached fi

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

redundant to re-state such info in every services that > has Long DN support. > > Regards, Vu > >> -Original Message- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: Friday, July 8, 2016 11:42 AM >> To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

check > it to see why you get failed. > > I zipped all the patches in attached file, you can try to apply it in the > meantime. Thanks. > > Regards, Vu > >> -Original Message- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: Friday, Ju

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

Hi Vu, It seems this README doesn't explained , how to enable SA_ENABLE_EXTENDED_NAMES on a node, if some application is creating an app stream ( NOT using saflogger tool ) DN is longer than 255 characters in length. -AVM On 7/4/2016 8:36 AM, Vu Minh Nguyen wrote: >

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

Hi Vu, This patch is not being applied on latest staging , can you tell on which changesset this will cleanly appy ? == patching file osaf/tools/saflog/saflogger/Makefile.am Hunk #1 FAILED at 22. 1 out of 1 hunk

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

On 7/1/2016 9:59 AM, A V Mahesh wrote: > Hi Hoang, > > Thanks for the clarifications. > > Please hold on publishing new version of patch, I am in process of > reviewing[PATCH 2 to 8] , > > so we may have some more comments , so we can have on single > consolidated pa

Re: [devel] [PATCH 8 of 8] imported patch 1574_cpnd_support_recover_shm_version_0_v2.patch

Hi Hoang , cpnd_restore_client_info cpnd_restore_ckpt_info_v0 cpnd_restore_ckpt_info_v1 can you please elaborate this share memory version & and restoring client information from share memory process , Not able to interpret the use case. -AVM On 6/23/2016 4:23 PM, Hoang Vo wrote: >

Re: [devel] [PATCH 7 of 8] ckpt: Add new test cases to verify long DN feature on CPSV v1 [#1574]

Hi Hoang, +bool is_extended_name_enable() { + + char *extended_name_env = getenv("SA_ENABLE_EXTENDED_NAMES"); Please provide usage detailes of SA_ENABLE_EXTENDED_NAMES in README in V2 patch. -AVM On 6/23/2016 4:23 PM, Hoang Vo wrote: > tests/cpsv/Makefile.am |1 + >

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA v1 [#1574]

Hi Hoang, -case CPD_EVT_ND2D_CKPT_UNLINK: +case CPD_EVT_ND2D_CKPT_UNLINK_2: -send_evt.info.cpnd.type = CPND_EVT_D2ND_CKPT_CREATE; +send_evt.info.cpnd.type = CPND_EVT_D2ND_CKPT_CREATE_2; Is this changes tested with in-service upgrade ? case like old ND and new ND , New

Re: [devel] [PATCH 2 of 8] cpnd: Add support for extended SaNameT v1 [#1574]

Hi Hoan, On 6/23/2016 4:23 PM, Hoang Vo wrote: > + buf = m_MMGR_ALLOC_CPND_DEFAULT(CPND_MAX_REPLICA_NAME_LENGTH); > + memset(buf, '\0', CPND_MAX_REPLICA_NAME_LENGTH); > + strncpy(buf, cp_node->ckpt_name, CPND_REP_NAME_MAX_CKPT_NAME_LENGTH); > + > + sprintf(buf + strlen(buf) - 1,

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

on today's staging. I > tested and found that it need to be applied after #1874. I skip sending new > version for updating patch following your comments. > > Thank you and best regards, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.co

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

g/samples/cpsv -AVM > > Thank you and best regards, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, June 29, 2016 10:48 AM > To: Hoang Vo <hoang.m...@dektech.com.au> > Cc: opensaf-devel@lists.sourcef

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574]

Hi Hoang, On 6/23/2016 4:23 PM, Hoang Vo wrote: > Testing Commands: > - > start all SCs and PLs > log in to Sc-1 > run ckpttest > enable long DN setting Can you please how steps to enable long DN setting. it will be more useful to have README about long DN Support similar

Re: [devel] [PATCH 1 of 1] cpnd: To reject creating section which has id length longer than MAX_SEC_ID_LEN [#1667]

p your review work easier. > > Best regards, > Hoang > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Monday, June 20, 2016 10:58 AM > To: Vo Minh Hoang <hoang.m...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1 of 1] log: fix fail to delete appstream post headless when controllers come back [#1877]

ingue runtime app stream or > configurable app stream > when it performs stream closing. That is why we see that syslog when we > perfom `immcfg -d ` . > > Logsv should only call ` saImmOiRtObjectDelete` if the deleted app stream is > runtime. > > Regards, Vu > >>

Re: [devel] [PATCH 1 of 1] log: fix fail to delete appstream post headless when controllers come back [#1877]

Hi Vu, I was trying validate patch , the App stream got deleted as expected after this patch fix , whic was not getting deleted as reported in this ticket (#1877) but getting "WA saImmOiRtObjectDelete returned 12" while deleting why ?

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

y be > same with patch that I sent it before. > > Regards, > Canh. > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Tuesday, June 21, 2016 11:47 AM > To: Canh Truong; vu.m.ngu...@dektech.com.au; lennart.l...@ericsson.com > Cc: opensaf

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

Hi Canh, It will be good to send V2 patch with Lennart comments and adding new test cases. -AVM On 6/21/2016 9:46 AM, A V Mahesh wrote: > Hi Canh, > > Some how we were not able to open your attachment , so my self written > > a multi threaded test case ( attached `thread_LogIniti

Re: [devel] [PATCH 1 of 1] log: fix issue with priority of messages adding to mailbox in the server[1396]

, before pushing - add # before ticket number in commit message #1396 -AVM On 6/14/2016 2:47 PM, Canh Truong wrote: Hi Mahesh, I have created new test case for multiple threads. Please help check new patch in attachment. Thanks, Canh. -Original Message- From: A V Mahesh

Re: [devel] [PATCH 1 of 1] cpnd: To reject creating section which has id length longer than MAX_SEC_ID_LEN [#1667]

me not tested. -AVM On 6/14/2016 2:40 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your information. > It seem I have lack of information when receiving this ticket from Nhat > Pham. > We will consider more about this. > > Sincerely, > Hoang &g

Re: [devel] [PATCH 1 of 1] cpnd: To reject creating section which has id length longer than MAX_SEC_ID_LEN [#1667]

it the build dependencies Best regards, Nhat Pham -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Monday, June 6, 2016 11:24 AM To: Nhat Pham <nhat.p...@dektech.com.au>; anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 2 of

Re: [devel] [PATCH 1 of 1] ckpt: fix cppcheck warning [#1874]

Hi Hoang Vo, ACK , Not tested. By the way which GCC/tool given these warnings ? -AVM On 6/13/2016 9:20 AM, Hoang Vo wrote: > osaf/services/saf/cpsv/cpd/cpd_db.c | 8 ++--- > osaf/services/saf/cpsv/cpd/cpd_evt.c| 4 +- > osaf/services/saf/cpsv/cpd/cpd_imm.c| 2 +- >

Re: [devel] [PATCH 1 of 1] log: fix fail to recovery well-known streams [#1847]

Sent: Thursday, June 9, 2016 6:51 PM >> To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; 'A V Mahesh' >> <mahesh.va...@oracle.com> >> Cc: opensaf-devel@lists.sourceforge.net; Jorge Pacheco Garcia >> <jorge.pacheco.gar...@ericsson.com> >> Subject: RE

Re: [devel] [PATCH 1 of 1] nid: Add support for multiple tipc bearers to configure_tipc [#1862]

ACK , Tested . -AVM On 6/9/2016 11:24 AM, Hung Nguyen wrote: > Hi Mahesh, > > The script compares ETH_NAME (which is comma delimited) with output from > "tipc-config -b" (which is LF delimited). > That only works when using single bearer. > The script will fail in case of multiple bearers. > >

Re: [devel] [PATCH 1 of 1] nid: Add support for multiple tipc bearers to configure_tipc [#1862]

Hi Hung Nguyen, >>Add support for multiple tipc bearers to configure_tipc. This support already exist and we have been configuring & using multiple tipc bearers, it works with == /etc/opensaf/nid.conf # This is valid when

Re: [devel] [PATCH 2 of 2] cpnd: To reject creating section which has id length longer than MAX_SIZE(30) [#1667]

Hi Nhat Pham, Which was forcing us to have MAX_SIZE(30) limit ? -AVM On 6/6/2016 9:19 AM, Nhat Pham wrote: > osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > > diff --git a/osaf/services/saf/cpsv/cpnd/cpnd_evt.c >

Re: [devel] [PATCH 0 of 2] Review Request for cpsv: cpnd restart with coredump when creating a section with id size greater than 30 [#1667]

Hi Nhat Pham, Some how this # 1667 review was not in devel list mails I am finding an IMM ticket with `[devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667]` Can you please resend -AVM On 6/3/2016 5:50 AM, Nhat Pham wrote: > Hi Mahesh, > > Could you please

Re: [devel] [PATCH 1 of 1] cpsv: add message tracing for headless feature [#1852]

ACK NOT tested -AVM On 5/27/2016 8:20 AM, Hoang Vo wrote: > osaf/libs/common/cpsv/cpsv_evt.c | 20 > 1 files changed, 20 insertions(+), 0 deletions(-) > > > This enhancement adds trace log for following messages: > CPD_EVT_ND2D_CKPT_INFO_UPDATE >

Re: [devel] [PATCH 1 of 1] log: fix log file sizes grow rapidly and cannot open [#1851]

; > Regards, Vu. > > >> -Original Message- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: Thursday, May 26, 2016 5:08 PM >> To: Vu Minh Nguyen; opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 1 of 1] log: fix log file sizes

<    1   2   3   4   5   6   >