Hi,
I think it should be safe to do SU failover for all redundancy models.
It is a much easier operation than comp failover. It would simplify
the patches, specially the AMF node director parts in 5/6 patches.
Please explain (with consequences) why it is needed to know the SG
redundancy model in
On 7 June 2013 08:39, praveen.malv...@oracle.com wrote:
osaf/services/saf/avsv/avnd/avnd_clc.c | 130
++-
osaf/services/saf/avsv/avnd/avnd_comp.c |2 +-
osaf/services/saf/avsv/avnd/avnd_su.c |1 +
osaf/services/saf/avsv/avnd/avnd_susm.c | 81
On 06/25/2013 11:50 AM, Mathivanan Naickan Palanivelu wrote:
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
- I'm sure you would have had a reason to do it this way, but I thought
alternatively performing the repair at the AMFND itself(instead of notifying
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 26 juni 2013 11:37
To: Hans Feldt
Cc: Hans Feldt; Mathivanan Naickan Palanivelu; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 5 of 6] amf: support
Summary,
* very confusing that not the complete patch series was sent
* AMF node director shall not care about SG redundancy model.
Terminating all comps of an SU is independent of SG red model. The
choice of what todo after that is upto the director.
* support in Nway-active is very important
*
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 5 juli 2013 06:15
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfnd: set SU DISABLED at TERM-FAILED
[#481]
Hi Hans,
I
Ack with minor comments inline
/Hans
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 5 juli 2013 09:37
To: Hans Feldt; mathi.naic...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 4 of 6
Ack with minor comments inline
/Hans
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 5 juli 2013 09:37
To: Hans Feldt; mathi.naic...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 5 of 6
2013 20:16
To: opensaf-devel@lists.sourceforge.net
Cc: Nagendra Kumar; Hans Feldt; praveen malviya; UABHANO
Subject: Re: [devel] AMF static code analysis regression in 4.2.4 and
4.3.1
I assume the side effect that modifies the variable i_su-list_of_susi
in the loop conditional happens
From: Hans Nordebäck
Sent: Wednesday, 07 August 2013 10:13 AM
To: praveen malviya; Ramesh Babu Betham; Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net; Hans Feldt; Anders Widell; Hans
Nordebäck
Subject: RE: SV: [PATCH 1 of 1] leap
On 7 August 2013 14:14, praveen.malv...@oracle.com wrote:
osaf/services/saf/avsv/avnd/avnd_clc.c | 93
+++--
osaf/services/saf/avsv/avnd/include/avnd_evt.h | 2 -
2 files changed, 40 insertions(+), 55 deletions(-)
At present when clc response event comes
I am OK with patch except for the change mentioned below. But
avnd_evt_clc_resp_evh() can be simplified and made more elegant now when
cmd_type is available. I will send an additional patch that should be
merged with this one.
/Hans
On 08/07/2013 05:03 PM, Hans Feldt wrote:
On 7 August 2013
Additional patch to be merged with this one. avnd_evt_clc_resp_evh() now
consists of a simple switch(cmd_type)
/Hans
On 08/08/2013 11:02 AM, Hans Feldt wrote:
I am OK with patch except for the change mentioned below. But
avnd_evt_clc_resp_evh() can be simplified and made more elegant now
Ack with comments:
- switch/case indentation in avnd_evt_clc_resp_evh is not according to coding
style (was in my patch)
- remove am_exec_cmd/am_cmd_exec_ctxt in AVND_COMP_CLC_INFO (done in my patch)
- see inline comment
Thanks,
Hans
On 08/13/2013 08:13 AM, praveen.malv...@oracle.com wrote:
Ack but see inline for minor comments.
Please merge attached patch for improved logging.
Another annoying thing is that the opensafd script logs that everything was
successfully stopped, another problem...
Thanks,
Hans
On 08/14/2013 03:03 PM, praveen.malv...@oracle.com wrote:
Other n
Comments (indicate scope for each y above):
-
changeset 2b84448f501a28f786b5bdb624833cd230d4ad71
Author: Hans Feldt hans.fe...@ericsson.com
Date: Fri, 16 Aug 2013 15:29:40 +0200
amfd: exit at MDS quiesced event
osaf/services/saf/avsv/avd/avd_role.cc | 9 +
1 files changed, 9 insertions(+), 0 deletions(-)
MDS can force an active vdest into quiesced state (see docs). Reasons for this
happening is unclear. The logic avd_mds_qsd_role_evh() can only handle this
event in context of a controller
:07 AM, Lennart Lund wrote:
Summary: logsv: Fix hanging main thread when file i/o don't return
Review request for Trac Ticket(s): #9
Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt)
Pull request to: NA
Affected branch(es): devel (4.4)
Development branch: IF ANY GIVE THE REPO URL
Ack (not tested)
/Hans
On 08/16/2013 10:04 AM, Hans Nordeback wrote:
python/pyosaf/saClm.py | 104
+---
1 files changed, 88 insertions(+), 16 deletions(-)
Correct python bindings for saClm, see also
http://devel.opensaf.org/ticket/2905.
Ack I guess (not tested), see inline for minor (?) comments.
/Hans
On 08/16/2013 10:12 AM, Hans Nordeback wrote:
python/pyosaf/saCkpt.py | 194
++-
1 files changed, 189 insertions(+), 5 deletions(-)
Correct python bindings for saCkpt, see
osaf/libs/agents/saf/amfa/include/ava.h | 8
osaf/libs/common/amfsv/Makefile.am | 14 +++---
osaf/libs/common/amfsv/avsv_d2nedu.c| 8
osaf/libs/common/amfsv/avsv_d2nmsg.c| 4 ++--
osaf/libs/common/amfsv/avsv_eduutil.c
Comments (indicate scope for each y above):
-
changeset 1abf7f5a01dbf7d2936c2bb55ac711fec55e7f90
Author: Hans Feldt hans.fe...@ericsson.com
Date: Fri, 23 Aug 2013 14:44:51 +0200
rename avsv to amfsv [#533]
In order to align AMF
--
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit
osaf/libs/common/amfsv/Makefile.am| 7 +++
osaf/libs/saf/libSaAmf/Makefile.am| 2 +-
osaf/services/saf/amfsv/amfd/Makefile.am | 2 +-
osaf/services/saf/amfsv/amfnd/Makefile.am | 2 +-
4 files changed, 6 insertions(+), 7 deletions(-)
diff --git
osaf/services/saf/amfsv/config/Makefile.am | 4 ++--
osaf/services/saf/amfsv/config/avsv_classes.xml | 0
osaf/services/saf/amfsv/config/avsv_objects.xml | 0
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/amfsv/config/Makefile.am
oops empty...
I forgot hg commit after hg rm tests/avsv
/Hans
On 08/23/2013 02:58 PM, Hans Feldt wrote:
--
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your
The change seems fine but I think I have found another memory leak.
saImmOmFinalize() should finalize all not yet finalized handles. From IMM A.03
spec (did not have A.02 at hand):
If the saImmOmFinalize() function completes successfully, it releases all
resources acquired when
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 26 augusti 2013 08:51
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 5] Review Request for amfsv #533
I think word service is not used for AMF and SMF. So instead
To: Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] pyosaf: correct python bindings for saImmOi [#548]
python/pyosaf/saImmOi.py | 225
+++---
1 files changed, 172 insertions(+), 53 deletions(-)
Correct
python/pyosaf/saNtf.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/pyosaf/saNtf.py b/python/pyosaf/saNtf.py
--- a/python/pyosaf/saNtf.py
+++ b/python/pyosaf/saNtf.py
@@ -222,7 +222,7 @@ class SaNtfNotificationHeaderT(Structure
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ebee8cc933d2e04eb498a3869b1ac1a9460f5908
Author: Hans Feldt hans.fe...@ericsson.com
Date: Tue, 27 Aug 2013 14:49:12 +0200
pyosaf
Both immomtest and immoitest works great and produce zero valgrind warnings
with the three patches 549, 550 and 552!
Great stuff!
/Hans
On 08/27/2013 01:57 PM, Zoran Milinkovic wrote:
tests/immsv/common/immtest.c| 4
Hi,
I don't understand what you are trying to solve, apparently not #517...
To solve #517 and for other reasons (#395), one possible solution is to use a
helper IMM reader thread. Such thread can
block and wait in TRYAGAIN loops longer than the main thread can. Another
possible solution is
Ack but please remove code commented out
/Hans
-Original Message-
From: Lennart Lund
Sent: den 3 september 2013 10:11
To: madhurika.kopp...@oracle.com; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 4] logtest: Replace hard coded root path with root path
Any suggestion?
/Hans
-Original Message-
From: Suryanarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com]
Sent: den 5 september 2013 11:06
To: praveen malviya
Cc: Hans Feldt; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd: exit at MDS quiesced
osaf/services/saf/amf/amfd/Makefile.am | 1 -
osaf/services/saf/amf/amfd/avd.cc | 59 --
2 files changed, 0 insertions(+), 60 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/Makefile.am
b/osaf/services/saf/amf/amfd/Makefile.am
---
osaf/services/saf/amf/amfd/Makefile.am | 4 ++--
osaf/services/saf/amf/amfd/avd_proc.cc | 0
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/Makefile.am
b/osaf/services/saf/amf/amfd/Makefile.am
--- a/osaf/services/saf/amf/amfd/Makefile.am
+++
osaf/services/saf/amf/amfd/avd.cc | 201 ---
osaf/services/saf/amf/amfd/avd_proc.cc | 209 -
2 files changed, 207 insertions(+), 203 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/avd.cc
osaf/services/saf/amf/amfd/Makefile.am | 1 -
osaf/services/saf/amf/amfd/amfd_main.cc | 24
2 files changed, 0 insertions(+), 25 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/Makefile.am
b/osaf/services/saf/amf/amfd/Makefile.am
---
osaf/services/saf/amf/amfd/amfd_main.cc | 33 --
osaf/services/saf/amf/amfd/avd_proc.cc| 47 --
osaf/services/saf/amf/amfd/include/avd_proc.h | 2 -
3 files changed, 35 insertions(+), 47 deletions(-)
diff --git
osaf/services/saf/amf/amfd/Makefile.am | 8 +-
osaf/services/saf/amf/amfd/app.cc | 11 +--
osaf/services/saf/amf/amfd/apptype.cc | 10 +-
osaf/services/saf/amf/amfd/chkop.cc| 2 +-
osaf/services/saf/amf/amfd/mbcsv_dec.cc|
osaf/services/saf/amf/amfd/include/avd.h |1 -
osaf/services/saf/amf/amfd/main.cc | 233 +-
2 files changed, 101 insertions(+), 133 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/avd.h
b/osaf/services/saf/amf/amfd/include/avd.h
---
it in
m_AVD_APP_SU_IS_INSVC will need more fixes and testing. The same changes were
done in SU unlocking but was missing in SG unlock.
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 09 September 2013 12:18
To: Nagendra Kumar
Cc: hans.nordeb
Ack, builds for me
/Hans
On 09/06/2013 04:53 PM, Zoran Milinkovic wrote:
osaf/tools/safimm/immcfg/Makefile.am | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Add libdl library to Makefile.am for immcfg.
On Ubuntu 13.04 with gcc 4.7.3, it's not possible to link files without
Hi,
I think some help text is missing (even better a man page but that is for
later).
I don't understand how to use this feature.
Could you explain here first and add into the help text of immcfg?
Thanks,
Hans
On 07/18/2013 03:27 PM, Zoran Milinkovic wrote:
Summary: IMMTOOLS: add
Guess you should add a new test case?
Sent from my smart phone
Zoran Milinkovic zoran.milinko...@ericsson.com skrev:
Summary: IMM: fix memory leak in imma_search_node_delete function [#549]
Review request for Trac Ticket(s): 549
Peer Reviewer(s): Neel
Pull request to: Zoran
Affected
in AMF PR.
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 23 September 2013 17:10
To: Nagendra Kumar
Cc: Mathivanan Naickan Palanivelu; Praveen Malviya;
opensaf-devel@lists.sourceforge.net; UABHANO
Subject: Re: [devel] [PATCH 1 of 1] Amf
Ack, tested it and problem no longer appears:
without patch:
$ immcfg -f samples/amf/sa_aware/AppConfig-2N.xml
Failed to call saImmOmAdminOwnerSet on parent:
'safAmfNode=SC-2,safAmfCluster=myAmfCluster' , rc = 12
Segmentation fault (core dumped)
$
with patch:
$ immcfg -f
I don't understand why you are not just checking
saAmfSUMaintenanceCampaign for the SU in question?
The reason for bringing in all this code is not commented/described.
Basically why not just:
if (su_ptr-saAmfSUMaintenanceCampaign.length == 0) {
+
Ack with comments:
- split into two patches, one for amfd and one for amfnd, we should
avoid grouping logically independent changes into the same changeset
- prefix the commit message with amfd: resp amfnd: (no capital
letters or Amf or ...)
Thanks,
Hans
On 23 September 2013 08:38,
Hi,
Some minor comments:
- there is one realloc in clc.c that needs to be reworked
- there are a lot of stupid comments about alloc/free such as: free
the memory or allocate the ..., that could be removed. Not
neccessarily in the same changeset...
I also checked how memory allocation is done for
-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 3 oktober 2013 10:52
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net; hans.nordeb...@ericsson.com
Subject: Re: [devel] [PATCH 1 of 1] Amfd: Allow admin operation on middleware
only when originated from SMF [#477]
Hi Hans
osaf/libs/core/common/daemon.c | 9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
By calling exit() instead of _Exit() registered exit functions are called. This
enabled for example flushing of gcov data.
diff --git a/osaf/libs/core/common/daemon.c
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 0d556db7f63cd3e61fc5231c31c819a1a26da26b
Author: Hans Feldt hans.fe...@ericsson.com
Date: Thu, 03 Oct 2013 13:42:45 +0200
opensaf
Could I please have some feedback on this?
/Hans
On 09/25/2013 04:55 PM, Hans Feldt wrote:
Summary: reduce IMM reads by amfnd
Review request for Trac Ticket(s): 574
Peer Reviewer(s): Praveen, Nags, Hans N
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): all
Ack if you have tested that further admin ops on the SU to make sure it is
manageable.
Thanks,
Hans
On 09/24/2013 12:11 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/sgproc.cc | 9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git
See inline
/Hans
On 10/04/2013 02:58 PM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/proc.h |1 +
osaf/services/saf/amf/amfd/ndfsm.cc |4 +
osaf/services/saf/amf/amfd/ndproc.cc | 105
++
3 files changed, 110
To: mathi.naic...@oracle.com; Hans Feldt; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] logsv: Add support for admin op result strings [#576]
osaf/services/saf/logsv/lgs/lgs_imm.c | 61
--
tests/logsv/saflogtest.c
check your system.
Thanks,
Hans
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 9 oktober 2013 08:32
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 2] Review Request for opensaf:make MDS/TCP
as the default
Yes in this case it is a bit confusing with such a similar name. I think a MDS_
prefix can be used but also move the
stuff to the C-file. This is not part of some API so I think it belongs better
in the C-file.
/Hans
On 10/10/2013 09:22 AM, Bertil Engelholm wrote:
I don't know if we have a
-180 osafamfd[25795]: ER avd_mds_cbk: wrong msg fmt not
valid 5
This is a normal upgrade path and it needs correction.
Thanks
-Nagu
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: 25 September 2013 20:25
To: Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Hm I can see that my carefully placed info log has now been replaced with
error! That is wrong and needs to be removed
Skickat från min Sony Xperia™-smartphone
Mathivanan Naickan Palanivelu mathi.naic...@oracle.com skrev:
Ack,
What could we do to the multiple LOG entries in the below case?
Could you please comment on why it is not possible to do it like this?
The OpenSAF release information just needs to contain information that
controllers needs to be updated before payloads.
This is anyway the best way to do it.
Thanks,
Hans
On 10/15/2013 08:21 AM, Hans Feldt wrote:
Did you
Please change the commit message to something reasonable.
/Hans
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 21 oktober 2013 12:08
To: Carl Johannesson
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] saf/pyosaf:
Ack with comments inline.
I prefer we keep setting the PEND state (calling m_AVND_SU_ASSIGN_PEND_SET) in
one place. Below I have proposed a way to
solve that.
Thanks,
Hans
On 10/15/2013 08:21 AM, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfnd/di.cc | 31
Hi Hans,
Nice work!
I do have some comment that I think needs to be fixed.
amfd:
- main.cc, function rda_cb, memory is allocated with malloc, this is
later returned with delete in avsv_d2d_msg_free() called from
avd_role_change_evh(). I think this malloc should be changed to new
- csiattr.cc,
. And in a separate patch change libs/comon to use
new/delete
Thanks,
Hans
On 23 October 2013 09:51, Hans Nordebäck hans.nordeb...@ericsson.com wrote:
Hi Hans, thanks, see comments below/BR HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
-Original Message-
From: Hans Nordebäck
Sent: den 23 oktober 2013 12:50
To: Hans Feldt
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net; Hans Nordebäck
Subject: Re: [devel] [PATCH 0 of 1] Review Request for amf #94
Hi, I guess libs
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 23 oktober 2013 14:05
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amf: change saAmfResponse to be
synchronous in TerminateCallback context [#570
On 10/23/13 12:32, Hans Feldt wrote:
Hi,
Some more comments from looking at libs/common
- I guess the tmp_common files should be removed?
- d2nedu.c, memory is allocated with malloc in a couple of places. It
is later freed from many locations by calling avsv_dnd_msg_free_TMP
which then uses
Other n
Comments (indicate scope for each y above):
-
changeset 0d26db0b655cda4073db285702cc8b5a5f394de2
Author: Hans Feldt hans.fe...@ericsson.com
Date: Wed, 23 Oct 2013 15:14:54 +0200
base: change ncs_os_lock to use
Hi,
Ack with these minor comments:
- report_ccb_validation_error sounds like a better name than report_oi_error
- in report_oi_error vsnprintf should use sizeof(err_str)
- in report_oi_error add explicit null termination because I am sure
some analysis tools will complain otherwise:
Nack,
cluster_sus_instantiation_status_check is a bad function name and is doing more
things not described by its name.
Keep the functions simple and let them do one thing only...
See inline.
Thanks,
Hans
On 10/23/2013 12:34 PM, nagendr...@oracle.com wrote:
Ack with inline comments. Not tested.
Thanks,
Hans
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 29 oktober 2013 11:16
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com;
mathi.naic...@oracle.com
Cc: opensaf-devel
Hi,
The approach seems fine. Just some minor comments:
* You recently introduced report_ccb_validation_error(), I think this new
function should be named similar. I suggest
report_admin_op_error
* In avd_saImmOiAdminOperationResult() there is a call to saflog() which needs
to be kept in the
n
Comments (indicate scope for each y above):
-
changeset 139100500b3b2110f13394ff06cc519b7f6146b1
Author: Hans Feldt hans.fe...@ericsson.com
Date: Thu, 31 Oct 2013 09:11:25 +0100
amfd: saflog all model changes [#611]
Trivial
osaf/services/saf/amf/amfd/imm.cc | 32 ++--
1 files changed, 18 insertions(+), 14 deletions(-)
Trivial change, move a code block so that it saflog also for base entity types.
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
---
Yes that is a bit strange...
Is this an ack with that change?
Thanks,
Hans
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 31 oktober 2013 14:04
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfd
Hi,
I think it is starting to look OK now. Just some minor comments.
1) The patch should be split into one for amfd and one for amfnd.
2) There is still one problem remaining in amfd according to valgrind
that needs to be fixed:
==2684== Mismatched free() / delete / delete []
==2684==at
Just a question to understand more. Why is a feature like 2PBE touching imma
the IMM client library?
It doesn't make sense to me.
Thanks,
Hans
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 5 november 2013 17:21
To:
osaf/services/saf/avsv/avnd/avnd_susm.c | 41 +++-
1 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/avsv/avnd/avnd_susm.c
b/osaf/services/saf/avsv/avnd/avnd_susm.c
--- a/osaf/services/saf/avsv/avnd/avnd_susm.c
+++
osaf/services/saf/avsv/avnd/avnd_comp.c | 2 +-
osaf/services/saf/avsv/avnd/avnd_susm.c | 44 ++--
2 files changed, 36 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/avsv/avnd/avnd_comp.c
b/osaf/services/saf/avsv/avnd/avnd_comp.c
---
n
Comments (indicate scope for each y above):
-
changeset 512a056943335d5adaa0f505b1c8320b2d4c399a
Author: Hans Feldt hans.fe...@ericsson.com
Date: Thu, 07 Nov 2013 20:52:52 +0100
amf: add support for CSI add in unlocked NPI SU
be refactored into two functions!)
/Hans
On 11/07/2013 09:22 PM, Hans Feldt wrote:
osaf/services/saf/avsv/avnd/avnd_susm.c | 41 +++-
1 files changed, 39 insertions(+), 2 deletions(-)
# HG changeset patch
# Parent 14a6b2a46df025cd5be8d0a62415e18001287784
diff -r
Then I think you should raise a separate ticket and handle it there.
/Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 13 november 2013 10:02
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: SV: RE: SV: RE
[mailto:nagendr...@oracle.com]
Sent: den 13 november 2013 08:44
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: SV: RE: [devel] [PATCH 0 of 2] Review Request for amf #194
I am attaching the patch to avoid any kind of contention. Please check it
once.
Do you like
. Just maybe fixing the above problem will
again touch the same code...
Thanks,
Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 13 november 2013 12:52
To: Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel
Ack,
Now when you have divided into two patches you can remove the for amfd and
for amfnd in the commit message
Thanks,
Hans
-Original Message-
From: Hans Nordebäck
Sent: den 11 november 2013 16:20
To: Hans Feldt; nagendr...@oracle.com; praveen.malv...@oracle.com
Cc: opensaf-devel
Still does not build on Ubuntu:
make[6]: Entering directory
`/home/uabhafe/opensaf-repos/opensaf-staging/osaf/services/saf/immsv/immpbed'
CXXLDosafimmpbed
/usr/bin/ld: osafimmpbed-immpbe_daemon.o: undefined reference to symbol
'pthread_create@@GLIBC_2.2.5'
2013 15:34
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [tickets] [opensaf:tickets] #21 IMM: Allow imm-pbe to be
configured without shared file system
I dont get it.
No other service seems to have any direct reference to lpthread in Makefile.am.
But it does appear im
Yeah I don't get it either, can't find any other Makefile.am with lpthread
I did a clean start - bootstrap, configure make
Gcc 3.8.1 on Ubuntu 13.10
Check with Anders W, he usually knows these things...
/Hans
From: Anders Björnerstedt
Sent: den 14 november 2013 15:34
To: Hans Feldt
Cc: opensaf
Hi,
Looking into changing the amfd - amfnd protocol I am facing some issues. Howto
use MDS versions is really not described or understandable.
Let's say for example that you want to add an parameter (simple int) in an
existing message. How do you go about it?
It seems you have to bump the
:21
To: Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Use correct CLC command to term/clean component
[#104]
osaf/services/saf/amf/amfnd/clc.cc | 64
+
osaf/services/saf/amf/amfnd/compdb.cc
the payload when this happens?
/Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 18 november 2013 07:57
To: Suryanarayana Garlapati; Hans Feldt; Hans Nordebäck; Praveen Malviya;
Mathivanan Naickan Palanivelu
Cc: opensaf-devel
I don't think you have even read what I wrote below...
-Original Message-
From: SuryaNarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com]
Sent: den 18 november 2013 09:41
To: Nagendra Kumar; Hans Feldt; Hans Nordebäck; Praveen Malviya; Mathivanan
Naickan Palanivelu
Cc
[mailto:nagendr...@oracle.com]
Sent: den 18 november 2013 09:34
To: Hans Feldt; Suryanarayana Garlapati; Hans Nordebäck; Praveen Malviya;
Mathivanan Naickan Palanivelu
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfnd: Reboot payload when link between
Controller
-Original Message-
From: SuryaNarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com]
Sent: den 18 november 2013 10:19
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] amfnd: Reboot payload when link between
Controller and Payload
please provide the simplest patch you can come up with and I will test it.
/Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 18 november 2013 13:46
To: Anders Björnerstedt; Bertil Engelholm; Hans Feldt; Hans Nordebäck
Cc: opensaf-devel
can proceed to commit.
Thanks
-Nagu
-Original Message-
From: Nagendra Kumar
Sent: 18 November 2013 15:24
To: Hans Feldt; hans.nordeb...@ericsson.com; Praveen Malviya; Mathivanan
Naickan Palanivelu; Suryanarayana Garlapati
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
]
Sent: den 19 november 2013 09:28
To: Hans Feldt; Hans Nordebäck; Bertil Engelholm
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Use correct CLC command to term/clean component
[#104]
osaf/services/saf/amf/amfnd/clc.cc | 27 +++
1 files
1 - 100 of 575 matches
Mail list logo
