[devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

The message type IMMA_EVT_ND2A_PROC_STALE_CLIENTS was introduced in IMM, but missed mention it in `void imma_proc_free_pointers()`. --- src/imm/agent/imma_proc.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/imm/agent/imma_proc.cc b/src/imm/agent/imma_proc.cc index 886b50c..ec62b98

Re: [devel] [PATCH 0/1] Review Request for log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Lennart, Ack from me. Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, March 12, 2018 7:01 PM > To: Canh Van Truong <canh.v.tru...@dektech.com.au>; Vu Minh Nguyen > <vu.m.ngu...@dektech.com

[devel] [PATCH 0/1] Review Request for imm: coredump during scale-in on large configuration [#2794]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 653915d26ddbbd405ed6579c2f90b9993f4e3b8d Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Mon, 12 Mar 2018 14:10:47 +0700 imm: coredump during scale-in on large configuration [#2

[devel] [PATCH 1/1] imm: coredump during scale-in on large configuration [#2794]

When IMMND restarts (e.g: OUT OF ORDER detection), it may get message from active IMMD which is originated from just-dead IMMND process. In such case, we are in confused situation - messages come from local IMMND, but not me (reply_dest != cb->immnd_mdest_id)! This patch discards such messages,

[devel] [PATCH 0/1] Review Request for imm: improve cascade delete [#2667] V2

uot; above): - Send for review on Zoran's behalf. There is performance degradation in previous patch, this patch is the replacement. revision ad8765987d64f18df9c6eb7002d930c40d032c5e Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Mon, 12 Mar 2018 09:48:31 +07

[devel] [PATCH 1/1] imm: improve cascade delete [#2667]

When an object is deleted, and the object has children, the delete meesage is sent for each deleted object to PBE. Since there are a lot of messages in the cascade delete from IMMND to PBE at once, there is a limitation that the cascade delete should not be done on object that contains more than

Re: [devel] [PATCH 0/1] Review Request for log: IMM OI BAD HANDLE incorrectly propagated to log client [#2799]

Ack. Thanks, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Wednesday, March 7, 2018 10:39 PM > To: canh.v.tru...@dektech.com.au; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund > >

Re: [devel] [PATCH 1/1] dtm: change trace config var name to _PATHNAME [#2792]

Hi Srinivas, Looks good to me. Thanks! Regards, Vu > -Original Message- > From: Srinivas Mangipudy [mailto:srinivas.mangip...@oracle.com] > Sent: Monday, March 5, 2018 5:14 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; > anders.wid...@ericsson.co

Re: [devel] [PATCH 1/1] imm: not allow creating reserved IMM class names [#2771]

ink. Regards, Vu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: Wednesday, March 7, 2018 1:31 PM > To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au>; ravisekhar.ko...@

Re: [devel] [PATCH 2/2] imm: return correct error code when working on more than 10000 objects [#2359]

Hi Srinivas, Ack from my side. Thanks, Vu > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Thursday, March 1, 2018 4:57 PM > To: vu.m.ngu...@dektech.com.au; zoran.milinko...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net; srinivas >

Re: [devel] [PATCH 1/1] log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Lennart, See my response inline, started with [Vu2] Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Wednesday, February 28, 2018 8:20 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; Canh Van Truong > <canh

Re: [devel] [PATCH 1/1] dtm: change trace config var name to _PATHNAME [#2792]

Ack with a minor comment, with [Vu]. Regards, Vu > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Thursday, March 1, 2018 2:31 PM > To: anders.wid...@ericsson.com; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; srinivas >

Re: [devel] [PATCH 1/1] log: Fix cyclic crash when starting standby and OI is not active [#2711]

; From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Wednesday, February 28, 2018 2:10 PM > To: 'Lennart Lund' <lennart.l...@ericsson.com>; > 'canh.v.tru...@dektech.com.au' <canh.v.tru...@dektech.com.au> > Cc: 'opensaf-devel@lists.sourceforge.net' de...@lists.

Re: [devel] [PATCH 1/1] log: Fix cyclic crash when starting standby and OI is not active [#2711]

Hi Lennart, See my comments inline, with [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, February 26, 2018 8:40 PM > To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net;

[devel] [PATCH 0/1] Review Request for log: explicit constructors and use fix arrays of char [#2782]

THE PATCH SERIES HERE *** revision 4d2b4d7a2155abcdc2f2b66d5c69d1fd8b98b7a3 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 8 Feb 2018 17:29:05 +0700 log: explicit constructors and use fix arrays of char [#2782] Make ScopeData::LogClientData and ScopeData::LogStreamInfoD

[devel] [PATCH 1/1] log: explicit constructors and use fix arrays of char [#2782]

Make ScopeData::LogClientData and ScopeData::LogStreamInfoData constructors explicit, and use fix arrray of chars for callers (mainly for debug) instead of constant pointer to __func__. --- src/log/agent/lga_agent.cc | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-)

[devel] [PATCH 1/1] ais: disable slow decorator unit test in default [#2780]

Only run the slow test case if the OSAF_SLOW_UNITTESTS enviroment variable is defined. --- src/ais/tests/try_again_decorator_test.cc | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/ais/tests/try_again_decorator_test.cc

[devel] [PATCH 0/1] Review Request for ais: disable slow decorator unit test in default [#2780]

ERIES HERE *** revision ba437dcb2f615f0f3392dade85822e9d1f6263c0 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Mon, 5 Feb 2018 21:39:41 +0700 ais: disable slow decorator unit test in default [#2780] Only run the slow test case if the OSAF_SLOW_UNITTESTS enviroment var

Re: [devel] [PATCH 1/1] log: fix to reject creating log streams with same file name in same CCB [#2752]

Hi Canh, Ack with a minor comment. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Monday, February 5, 2018 1:27 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > srinivas.mangip...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] log: update saflogtest to limit timeout when handling try again [#2764]

Ack. Thanks, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Monday, January 29, 2018 6:06 AM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > srinivas.mangip...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net; Canh Van

[devel] [PATCH 1/1] imm: immnd coredump during SYNC finalize [#2775]

The call to saImmOiImplementerSet and saImmOiImplementerClear are allowed during sync. Therefore, there is possibility the messages of these calls arrived at veteran nodes after finalizeSync was sent from IMMND coord but before finalizeSync arrived at the veterans (over fevs). In that case, the

[devel] [PATCH 0/1] Review Request for imm: immnd coredump during SYNC finalize [#2775]

ERIES HERE *** revision c5563224ffe6ff4d5c2184eeff5dbed54113498e Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 31 Jan 2018 17:59:17 +0700 imm: immnd coredump during SYNC finalize [#2775] The call to saImmOiImplementerSet and saImmOiImplementerClear are allowed during

[devel] [PATCH 1/1] imm: not allow creating reserved IMM class names [#2771]

PBE will be restarted and will not be able to come up if user requests creating IMM object class with same name of reserved ones. This patch adds code to reject such request with SA_AIS_ERR_INVALID_PARAM. --- src/imm/Makefile.am| 2 + src/imm/agent/imma_om_api.cc

[devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771] V2

THE PATCH SERIES HERE *** revision 8be516e90d971b3fc3e100c8f1f45d251e3a8003 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 30 Jan 2018 21:11:48 +0700 imm: not allow creating reserved IMM class names [#2771] PBE will be restarted and will not be able to come up if user r

[devel] [PATCH 1/1] imm: not allow creating reserved IMM class names [#2771]

PBE will be restarted and will not be able to come up if user requests creating IMM object class with same name of reserved ones. This patch adds code to reject such request with SA_AIS_ERR_INVALID_PARAM. --- src/imm/agent/imma_om_api.cc | 1 -

[devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

THE PATCH SERIES HERE *** revision 0ab2275cc190d7be107a9294e1b8411e07a4f5b9 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 30 Jan 2018 16:19:57 +0700 imm: not allow creating reserved IMM class names [#2771] PBE will be restarted and will not be able to come up if user r

Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

rst...@telia.com; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au>; ravisekhar.ko...@oracle.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [devel] [PATCH 0/1] Review Request for imm: not allow creating > reserved IMM class names [#2771] > > Hi, >

Re: [devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

n > > Other n > > > > > >Comments (indicate scope for each "y" above): > >- > >*** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > > >revision 8e072e9858c105266d7975ad366

[devel] [PATCH 1/1] imm: not allow creating reserved IMM class names [#2771]

PBE will be restarted and will never come up if user requests creating IMM class object class which is reserved by PBE. This patch adds code to reject such request with SA_AIS_ERR_INVALID_PARAM. --- src/imm/agent/imma_om_api.cc | 27 ++- 1 file changed, 26 insertions(+),

[devel] [PATCH 0/1] Review Request for imm: not allow creating reserved IMM class names [#2771]

THE PATCH SERIES HERE *** revision 8e072e9858c105266d7975ad366a579b720dfcae Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 25 Jan 2018 20:40:08 +0700 imm: not allow creating reserved IMM class names [#2771] PBE will be restarted and will never come up if user requests cr

[devel] [PATCH 1/1] imm: correct data size mismatches in pbe code [#2770]

Object ID and Class ID are `unsigned int` data type, but they are not used consistently through the codes. Some places use `int` type. This patch corrects these places. --- src/imm/common/immpbe_dump.cc| 49 src/imm/common/immpbe_dump.h | 6 ++---

[devel] [PATCH 0/1] Review Request for imm: correct data size mismatches in pbe code [#2770]

ERIES HERE *** revision 15efa760826efc46bb4e5ddf633af6089abb3141 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 25 Jan 2018 18:32:59 +0700 imm: correct data size mismatches in pbe code [#2770] Object ID and Class ID are `unsigned int` data type, but they are not used cons

[devel] [PATCH 0/1] Review Request for imm: improve immlist printout for multiple attribute values [#2753]

IN/COMMENT THE PATCH SERIES HERE *** revision 47ee1adea42667899a0da66705d1d650ccfd62c7 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 24 Jan 2018 21:41:40 +0700 imm: improve immlist printout for multiple attribute values [#2753] Have one space separated among attribute values. C

[devel] [PATCH 1/1] imm: improve immlist printout for multiple attribute values [#2753]

Have one space separated among attribute values. --- src/imm/tools/imm_list.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/imm/tools/imm_list.c b/src/imm/tools/imm_list.c index 83c0653..7ccd710 100644 --- a/src/imm/tools/imm_list.c +++

[devel] [PATCH 0/1] Review Request for imm: fix wrong printouts and incorrect behavior of immadm and immcfg [#2751]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision ffa43284ee2ae78d8a92248fd1ed36ac7690fb29 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 24 Jan 2018 20:29:49 +0700 imm: fix wrong printouts and incorrect behavior of immadm/imm

[devel] [PATCH 1/1] imm: fix wrong printouts and incorrect behavior of immadm/immcfg [#2751]

Fix wrong printouts and incorrect behavior of immadm/immcfg. Refer to the ticket #2751 for more info. --- src/imm/tools/imm_admin.c | 4 ++-- src/imm/tools/imm_cfg.c | 7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/imm/tools/imm_admin.c b/src/imm/tools/imm_admin.c

Re: [devel] [PATCH 1/1] log: fix to reject creating log streams with same file name in same CCB [#2752]

Hi Canh, Ack with minor comments inline. And consider to create test cases (e.g: create 2 streams with same targets, create/modify existing stream to same target) to verify the fix. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent:

[devel] [PATCH 0/1] Review Request for imm: immnd asserts at veterans due to mismatched data during sync [#2748]

** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision ee63e0e14af56bc50aa2f7002862ba91bcff0c81 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 9 Jan 2018 20:03:51 +0700 imm: immnd asserts at veterans due to mismatched data during sync [#2748] Don't allow to make any cha

[devel] [PATCH 1/1] imm: fix IMMND assert at veteran nodes during SYNC [#2748]

During sync, if saImmOmAdminOwnerInitialize or saImmOmCcbInitialize message comes to active IMMD just right after IMMD_EVT_ND2D_SYNC_START message and before IMMND_EVT_D2ND_SYNC_START message is arrived at IMMNDs, there is possibily the request(s) is accepted at IMMND coord but is rejected at

[devel] [PATCH 0/1] Review Request for imm: fix IMMND assert at veteran nodes during SYNC [#2748]

IN/COMMENT THE PATCH SERIES HERE *** revision 4322e0a3ae5bf6df70ad3faefae454a9c619b635 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 29 Dec 2017 16:58:09 +0700 imm: fix IMMND assert at veteran nodes during SYNC [#2748] During sync, if saImmOmAdminOwnerInitialize or saImmOmCcbIn

[devel] [PATCH 1/1] imm: fix immnd restarted during SYNC finalize [#2749]

The call to saImmOiImplementerSet and saImmOiImplementerClear are allowed during sync. Therefore, there is possibility the messages of these calls arrived at the sync-client after finalizeSync was sent from IMMND coord but before finalizeSync arrived at sync-client (over fevs). In that case, the

[devel] [PATCH 2/2] clm: add tryagain handle to clmtest [#2634]

Add tryagain to CLM APIs using C++ decorator. --- src/clm/Makefile.am| 29 +- src/clm/apitest/clm_api_with_try_again.h | 145 ++ src/clm/apitest/clmtest.cc | 2 +- src/clm/apitest/clmtest.h | 9

[devel] [PATCH 0/2] Review Request for clm: add tryagain handle to clmtest [#2634]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision e02f36d66fa74481b166372f2d49e390942b8801 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 21 Dec 2017 18:59:49 +0700 clm: add tryagain handle to clmtest [#2634] Add tryagain to CLM APIs usi

Re: [devel] [PATCH 1/1] imm: change log level for failing to send accept message [#2426]

Ack from me. Thanks. Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Wednesday, December 20, 2017 2:56 PM > To: vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Zoran Milinkovic >

[devel] [PATCH 0/1] Review Request for ais: change default retry in decorator [#2743]

ERIES HERE *** revision a5e04c9e467ec0774d4416eea86e45afe7d9e23b Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 20 Dec 2017 19:29:41 +0700 ais: change default retry in decorator [#2743] Change interval time to 100 miliseconds, and timeout to one minute for the default retry cont

[devel] [PATCH 1/1] ais: change default retry in decorator [#2743]

Change interval time to 100 miliseconds, and timeout to one minute for the default retry control. --- src/ais/tests/try_again_decorator_test.cc | 8 +--- src/ais/try_again_decorator.h | 8 2 files changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [devel] [PATCH 1/1] log: Added retry logic for RT object creation call fails due to timeout error [#2711]

Hi Srinivas, I have some comments: 1) Add such retry logic could hang the main thread and may cause unwanted troubles such as health-check timeout, delay processing higher priority events. 2) Possibility of race condition using IMM OI handle b/w main thread and recovery thread. 3) When

[devel] [PATCH 0/1] Review Request for mds: show extra tipc port id when install_tipc invoked [#2732]

THE PATCH SERIES HERE *** revision 1b816354f4905e073038d9fb9b986d54b1d387f2 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 6 Dec 2017 23:02:24 +0700 mds: show extra tipc port id when install_tipc invoked [#2732] Add extra information - tipc port id toghether with service id w

[devel] [PATCH 1/1] mds: show extra tipc port id when install_tipc invoked [#2732]

Add extra information - tipc port id toghether with service id when install tipc invoked. Such information will help find out which OpenSAF services causes tipc trouble such as TIPC_ERR_OVERLOAD. --- src/mds/mds_dt_tipc.c | 36 +++- 1 file changed, 23

[devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/ais/Makefile.am| 5 +- src/ais/try_again_decorator.h | 110 + src/base/Makefile.am | 4 +-

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

nders Widell <anders.wid...@ericsson.com>; Vu Minh Nguyen > <vu.m.ngu...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 1/1] base: create generic try-again handling decorator for > AIS APIs [#2702] > > agree, constexpr should be fine. /Ha

[devel] [PATCH 0/1] Review Request for base: create generic try-again handling decorator for AIS APIs [#2702] V3

IN/COMMENT THE PATCH SERIES HERE *** revision 75a8e1da33382c9d1af17c3b962b8fca3acdf596 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 30 Nov 2017 22:18:33 +0700 base: create generic try-again handling decorator for AIS APIs [#2702] Make generic C++ decorator for handling SA_A

[devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/ais/Makefile.am| 5 +- src/ais/try_again_decorator.h | 111 + src/base/Makefile.am | 4 +-

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

than interval!"); RetryControl ctrl({0, interval_ms * 1000 * 1000}, timeout_ms); return Decorator<T(Args...)> (std::function<T(Args...)>(f), ctrl); Regards, Vu > -----Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >

Re: [devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Hi Anders, Thanks a lot for your very good comments. I have just sent out the updated patch V2. Regards, Vu > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Monday, November 27, 2017 10:45 PM > To: Vu Minh Nguyen <vu.m.ngu...

[devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/base/Makefile.am | 5 +- src/base/tests/try_again_decorator_test.cc | 48 + src/base/try_again_decorator.h | 109 + 3 files

[devel] [PATCH 0/1] Review Request for base: create generic try-again handling decorator for AIS APIs [#2702] V2

IN/COMMENT THE PATCH SERIES HERE *** revision fcbb9500df11055b24ce6216e517185f1375113e Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 28 Nov 2017 20:07:03 +0700 base: create generic try-again handling decorator for AIS APIs [#2702] Make generic C++ decorator for handling SA_A

[devel] [PATCH 0/1] Review Request for base: create generic try-again handling decorator for AIS APIs [#2702]

IN/COMMENT THE PATCH SERIES HERE *** revision d827ba30f2a5615992667023a341e0ecfa8e299d Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 24 Nov 2017 17:24:26 +0700 base: create generic try-again handling decorator for AIS APIs [#2702] Make generic C++ python-like de

[devel] [PATCH 1/1] base: create generic try-again handling decorator for AIS APIs [#2702]

Make generic C++ python-like decorator handling SA_AIS_ERR_TRY_AGAIN return code of AIS APIs. --- src/base/Makefile.am | 5 +- src/base/tests/try_again_decorator_test.cc | 69 +++ src/base/try_again_decorator.h | 131 +

Re: [devel] [PATCH 1/1] log: fix coredump when stop cluster [#2700]

Hi Canh, Ack. Thanks, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, November 23, 2017 11:47 AM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > srinivas.mangip...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] clm: clmprint does not work as expected [#2651]

Hi Zoran, See my responses inline. Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Monday, November 13, 2017 9:35 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> > Cc: opensaf-devel@lists.sourceforg

Re: [devel] [PATCH 1/1] imm: update README with IMM changes in OpenSAF 5.17.11 and rename IMM schema [#2665]

Hi Zoran, Ack from me. Thanks! Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Monday, November 6, 2017 11:33 PM > To: vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Zoran Milinkovic >

Re: [devel] [PATCH 1/1] imm: immxml-merge tool taking long time with huge count of classes, objects [#2663]

Hi Vijay, Ack from me. Thanks. Regards, Vu -Original Message- From: Vijay Roy [mailto:vijay@oracle.com] Sent: Tuesday, October 31, 2017 8:52 PM To: zoran.milinko...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1/1] imm: immxml-merge tool taking long

Re: [devel] [PATCH 1/1] imm: update README with IMM changes in OpenSAF 5.17.11 [#2665]

Hi Zoran, Ack with one below question. In README, it states: "A word of caution about implementer names. Implementer names are to be re-used. They are never garbage collected by the imm service. An implementer-name may have no current live implementer handle attached, but once created, it

Re: [devel] [PATCH 1/1] imm: improve the cascade delete [#2667]

Hi Zoran, Ack with few comments and some questions, tagged [Vu]. Thanks! Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Wednesday, November 1, 2017 9:44 PM > To: vu.m.ngu...@dektech.com.au > Cc:

[devel] [PATCH 1/1] clm: clmprint does not work as expected [#2651]

clmprint should exit with EXIT_FAILURE when querying non-member node. --- src/clm/tools/clm_print.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/clm/tools/clm_print.c b/src/clm/tools/clm_print.c index f44aee2..25b5e35 100644 ---

[devel] [PATCH 0/1] Review Request for clm: clmprint does not work as expected [#2651]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 6326f9b06d7bd639c29af357a0ddff7e8a58d163 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 1 Nov 2017 18:04:06 +0700 clm: clmprint does not work as expected [#2651] clmprint should exit with EXIT_FAILU

Re: [devel] [PATCH 1/1] clm: wrapper CLM APIs with try_again handle inside [#2634]

Hi Hans, Thanks for your comments and proposal. I will think about that and send prototype code when done. Regards, Vu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: Tuesday, October 31, 2017 4:41 PM > To: Vu Minh Nguy

[devel] [PATCH 1/1] log: fix invalid write reported by valgrind [#2657]

The global pointer genLogrecord.logBuffer->logBuf was moved to local data in test case `logtest 2 39`. Therefore, any write to that global pointer results in "invalid write". --- src/log/apitest/logtest.c| 6 ++ src/log/apitest/tet_cfg_destination.c| 4 ++--

[devel] [PATCH 0/1] Review Request for log: fix invalid write reported by valgrind [#2657]

THE PATCH SERIES HERE *** revision e5e923295fcc0ea34a03256d9829c5426a4e Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 26 Oct 2017 15:36:53 +0700 log: fix invalid write reported by valgrind [#2657] The global pointer genLogrecord.logBuffer->logBuf was moved to loca

Re: [devel] [PATCH 1/1] clm: wrapper CLM APIs with try_again handle inside [#2634]

Hi Zoran, This ticket is related to clmtest. Could you help to review this change? Thanks! Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Thursday, October 19, 2017 11:46 AM > To: anders.wid...@ericsson.com;

[devel] [PATCH 0/1] Review Request for clm: fix errors in clmprint tool [#2651] V3

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision e070300a38f0f564c8c8493f112c68c442c6528c Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 25 Oct 2017 10:57:17 +0700 clm: fix errors in clmprint tool [#2651] Fix the problems: 1) clmprint returns 0 fo

[devel] [PATCH 1/1] clm: fix errors in clmprint tool [#2651]

Fix the problems: 1) clmprint returns 0 for the error case. 2) clmprint does not handle invalid inputs. 3) clmprint does not deal with non-member node. --- src/clm/tools/Makefile| 18 + src/clm/tools/clm_print.c | 191 +++--- 2 files changed, 182

Re: [devel] [PATCH 1/1] clm: fix errors in clmprint tool [#2651]

Hi Zoran, Thanks for your quick look and good comments. I just sent the V2. Thanks! Regards, Vu > -Original Message- > From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] > Sent: Tuesday, October 24, 2017 3:23 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektec

[devel] [PATCH 0/1] Review Request for clm: fix errors in clmprint tool [#2651] V2

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 65f50f8228c875c06de151556cb327e9d5e25901 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 24 Oct 2017 15:49:43 +0700 clm: fix errors in clmprint tool [#2651] Fix the problems: 1) clmprint returns

[devel] [PATCH 1/1] clm: fix errors in clmprint tool [#2651]

Fix the problems: 1) clmprint returns 0 for the error case. 2) clmprint does not handle invalid inputs. 3) clmprint does not deal with non-member node. --- src/clm/tools/Makefile| 18 + src/clm/tools/clm_print.c | 186 +++--- 2 files changed, 176

[devel] [PATCH 0/1] Review Request for clm: fix return wrong error code [#2652]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision ce03000bfe56b68b66f5da4f5621c8e58e4b18d9 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 24 Oct 2017 14:44:14 +0700 clm: fix return wrong error code [#2652] saClm

[devel] [PATCH 1/1] clm: fix return wrong error code [#2652]

saClmClusterNodeGet_4() and saClmClusterNodeGetAsync() returns SA_AIS_ERR_UNAVAILABLE(31) when querying non-member node information from a member node. According to AIS, they should return SA_AIS_ERR_NOT_EXIST. SA_AIS_ERR_UNAVAILABLE should be returned when invoking process is not executing on a

[devel] [PATCH 1/1] clm: fix errors in clmprint tool [#2651]

Fix the problems: 1) clmprint returns 0 for the error case. 2) clmprint does not handle invalid inputs. 3) clmprint does not deal with non-member node. --- src/clm/tools/Makefile| 18 + src/clm/tools/clm_print.c | 186 +++--- 2 files changed, 178

[devel] [PATCH 0/1] Review Request for clm: fix errors in clmprint tool [#2651]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision cda2e3dd84e3c23b23dabee515b04a920384e580 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 24 Oct 2017 14:34:34 +0700 clm: fix errors in clmprint tool [#2651] Fix the problems: 1) clmprint returns 0 fo

[devel] [PATCH 0/1] Review Request for log: update target log file location [#2635]

ERIES HERE *** revision b94b8ed150bdb2b626ddb1f225a6849febdffcf6 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 19 Oct 2017 14:16:57 +0700 log: update target log file location [#2635] After introducing the ticket [#2165], writing log to log server will have its own log file name

[devel] [PATCH 1/1] log: update target log file location [#2635]

After introducing the ticket [#2165], writing log to log server will have its own log file name based on msg_id field. This change causes logtest failed.(Previously, log was stored in mds.log) logtest code needs to be updated accordingly . --- src/log/apitest/tet_cfg_destination.c | 8

[devel] [PATCH 0/1] Review Request for clm: wrapper CLM APIs with try_again handle inside [#2634]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 2eaa7c94330b7b682cac07732c9c529e828ab733 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 19 Oct 2017 10:41:40 +0700 clm: wrapper CLM APIs with try_again handle inside [#2634] All c

[devel] [PATCH 1/1] clm: wrapper CLM APIs with try_again handle inside [#2634]

All calls to CLM APIs in clmtest do not handle SA_AIS_ERR_TRY_AGAIN. Running clmtest sometimes get failed because of this miss. Create wrappers which handling try again error code inside. --- src/clm/Makefile.am| 4 +- src/clm/apitest/clm_util.c

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

Hi Srinivas, Ack with a minor comment, tagged [Vu]. Regards, Vu > -Original Message- > From: Srinivas Mangipudy [mailto:srinivas.mangip...@oracle.com] > Sent: Tuesday, October 3, 2017 2:04 PM > To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; > lennart.l...@erics

Re: [devel] [PATCH 1/1] log: fix incorrect handling of version when initializing OpenSAF APIs in log service [#2516]

Hi Canh, Ack with a minor comment, tagged [Vu]. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Monday, October 2, 2017 2:28 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] log: corrected parsing of command logtest with option -e [#2121]

Hi, > 1 file changed, 14 insertions(+), 26 deletions(-) > mode change 100644 => 100755 src/log/apitest/logtest.c Any reason of changing the file permission? Regards, Vu > -Original Message- > From: Srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: Thursday, September 21, 2017

[devel] [PATCH 0/1] Review Request for osaf: create C++ abstractions of AIS C APIs for IMM [#2558]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 8fcc54f908362c8df78a8c91860dbfb42fd73ba0 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 29 Sep 2017 18:16:00 +0700 osaf: create C++ abstractions of AIS C APIs for IMM [#2558] M

Re: [devel] [PATCH 1/1] log: fix to provide relevant info when lgsv is busy in case change root directory [#2600]

Ack. Thanks, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, September 28, 2017 1:53 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong >

Re: [devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

nesday, September 13, 2017 6:56 PM To: 'Lennart Lund' <lennart.l...@ericsson.com>; 'Vu Minh Nguyen' <vu.m.ngu...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580] Hi Lennart, As I

Re: [devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

s, I edited them even some belongs to legacy code. I sent out version 02, please have a look and give your comments. Thanks. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Tuesday, September 12, 2017 10:06 PM > To: Vu Minh Nguyen

[devel] [PATCH 0/1] Review Request for log: fix log server fail to start with old IMM model [#2580] V2

IN/COMMENT THE PATCH SERIES HERE *** revision 284b81d913cc4b9f120d6b38389e9515cb84a59e Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Wed, 13 Sep 2017 10:05:44 +0700 log: fix log server fail to start with old IMM model [#2580] LOG introduced the `saLogRecordDestination` attribute s

[devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

LOG introduced the `saLogRecordDestination` attribute since OpenSAF 5.2 to handle the alternative destinations of log records, ticket [#2258]. During upgrade, if LOG server comes up before IMM model is updated to new one which has saLogRecordDestination in, LOG server will be crashed The solution

[devel] [PATCH 1/1] log: fix log server fail to start with old IMM model [#2580]

LOG introduced the `saLogRecordDestination` attribute since OpenSAF 5.2 to handle the alternative destinations of log records, ticket [#2258]. During upgrade, if LOG server comes up before IMM model is updated to new one which has saLogRecordDestination in, LOG server will be crashed The solution

[devel] [PATCH 0/1] Review Request for log: fix log server fail to start with old IMM model [#2580]

uot; above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision d58b8f1072077347f485e98a9b31fbf56a334bc9 Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Tue, 12 Sep 2017 20:46:00 +0700 log: fix log server fail to start with old IMM model [#2580]

Re: [devel] [PATCH 1/1] log: duplicated code in lga_client and lga_stream [#2567]

Hi, Have you had time to look at this? Thanks! Regards, Vu > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: Friday, September 1, 2017 12:19 PM > To: mahesh.va...@oracle.com; lennart.l...@ericsson.com; > canh.v.tru...@dektech.com.a

[devel] [PATCH 0/1] Review Request for log: duplicated code in lga_client and lga_stream [#2567]

IN/COMMENT THE PATCH SERIES HERE *** revision c79ece5853a201d2664709fab2f0f4a7569b1b5d Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 1 Sep 2017 12:09:34 +0700 log: duplicated code in lga_client and lga_stream [#2567] Introduce `RefCounter` class to remove duplicated c

[devel] [PATCH 1/1] log: duplicated code in lga_client and lga_stream [#2567]

Introduce `RefCounter` class to remove duplicated code in LogClient and LogStreamInfo. Introduce also one new parameter `caller`, the purpose is mainly for debug - know who is the caller to `RefCounter` methods. --- src/log/Makefile.am | 5 +- src/log/agent/lga_agent.cc |

Re: [devel] [PATCH 1/1] log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

Hi Canh, Ack with comments, with [Vu]. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, July 20, 2017 1:31 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] log: fix log supported maximum 2047 characters for long DN [#2525]

Ack with one following minor comment. Consider use C++ google coding rule or Linux Kernel coding rule for naming these functions: encodeSaNameT()/decodeSaNameT() e.g: EncodeSaNameT() or encode_sanamet() And as you do refactor for SaNameT encode/decode, I hope you have run valgrind/upgrade tests.

<    1   2   3   4   5   6   7   >