Re: [devel] [PATCH 1 of 1] amfd: use simple decode/encode for AVD_CL_CB [#1544]

Hi Praveen I did it mainly for consistency. A few of the decode functions require peer version so I thought maybe all of them can have the same signature format? Thanks Gary Quoting praveen malviya : > Ack with minor comment. > > > On 25-Nov-15 12:02 PM, Gary Lee wrote: >&

[devel] [PATCH 1 of 2] amfd: use simple encode/decode for siass [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 +++- osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 77 +++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 + o

[devel] [PATCH 2 of 2] amfd: use simple encode/decode for si_trans [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 ++ osaf/services/saf/amf/amfd/ckpt_edu.cc| 55 --- osaf/services/saf/amf/amfd/ckpt_enc.cc| 63 ++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 0 of 2] Review Request for amfd: use simple encode/decode [#1544]

n Comments (indicate scope for each "y" above): - changeset 3e9c38fb204ebd378e8e83139fab40371d1961f7 Author: Gary Lee Date: Fri, 04 Dec 2015 16:32:44 +1100 amfd: use simple encode/decode for siass [#1544]

Re: [devel] [PATCH 0 of 3] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

Hi Hans ack for the series (review only) > On 2 Dec 2015, at 6:49 PM, Hans Nordeback wrote: > > Summary: AMF: Coverity issues in amfd/amfnd > Review request for Trac Ticket(s): #680 > Peer Reviewer(s): Nagu, Praveen, Gary > Pull request to: > Affected branch(es): default > Development branch: d

[devel] [PATCH 1 of 2] amfd: use simple encode/decode for siass [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 +++- osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 77 +++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 + o

[devel] [PATCH 0 of 2] Review Request for amfd: use simple encode/decode V2 [#1544]

eclaration of avsv_edp_ckpt_msg_siass() - use SA_FALSE in place of static_casts(false) changeset 02e9b85395aaa88e8301cacd707a7b281398f691 Author: Gary Lee Date: Fri, 18 Dec 2015 13:32:59 +1100 amfd: use simple encode/decode for siass [#1544] changeset c99ca646a235e5abfd02199fcbf1f7

[devel] [PATCH 2 of 2] amfd: use simple encode/decode for si_trans [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 ++ osaf/services/saf/amf/amfd/ckpt_edu.cc| 53 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 63 ++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 2 of 2] clm nodeagent: send nodeup again when clms is available after both controllers are down [#1646]

osaf/services/saf/clmsv/nodeagent/main.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/clmsv/nodeagent/main.c b/osaf/services/saf/clmsv/nodeagent/main.c --- a/osaf/services/saf/clmsv/nodeagent/main.c +++ b/osaf/services/saf/clmsv/nodeagent/ma

[devel] [PATCH 1 of 2] clma: send BAD_HANDLE to all clients if both controller nodes are unavailable [#1646]

osaf/libs/agents/saf/clma/clma.h | 2 ++ osaf/libs/agents/saf/clma/clma_api.c | 30 +++--- osaf/libs/agents/saf/clma/clma_mds.c | 27 --- osaf/libs/agents/saf/clma/clma_util.c | 2 ++ 4 files changed, 51 insertions(+), 10 deletions(-)

[devel] [PATCH 0 of 2] Review Request for clm: support simultaneous reboot of both controller nodes [#1646]

Other n Comments (indicate scope for each "y" above): - changeset 44df7b651431e306911e9b327d182e86ce3022fb Author: Gary Lee Date: Thu, 07 Jan 2016 15:27:12 +1100 clma: send BAD_HANDLE to all clients if both

Re: [devel] [PATCH 1 of 1] amfd: Convert struct avd_sirankedsu_t to class [#1543]

Hi Hans Some comments below. Thanks Gary > On 18 Dec 2015, at 8:59 PM, Hans Nordeback > wrote: > > osaf/services/saf/amf/amfd/include/si.h |6 +- > osaf/services/saf/amf/amfd/include/sirankedsu.h | 19 ++- > osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 132 ++

[devel] [PATCH 2 of 4] amfd: use simple decode [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 309 1 files changed, 120 insertions(+), 189 deletions(-) use simple decode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc --- a/osaf/s

[devel] [PATCH 0 of 4] Review Request for amfd: use simple encode and decode [#1544]

n Comments (indicate scope for each "y" above): - changeset 3438fda0d2866d3232f7fbe00507de9539be6357 Author: Gary Lee Date: Fri, 08 Jan 2016 13:56:34 +1100 corelibs: add simple encode and decode routines for SaClmNo

[devel] [PATCH 4 of 4] amfd: remove unused encode and decode routines [#1520]

osaf/services/saf/amf/amfd/ckpt_edu.cc| 215 -- osaf/services/saf/amf/amfd/include/ckpt_edu.h | 12 - 2 files changed, 0 insertions(+), 227 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc --- a/osaf/ser

[devel] [PATCH 1 of 4] corelibs: add simple encode and decode routines for SaClmNodeAddressT [#1544]

osaf/libs/core/include/ncsencdec_pub.h | 3 +++ osaf/libs/core/leap/hj_enc.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h --- a/osaf/libs/core/include/ncsenc

[devel] [PATCH 3 of 4] amfd: use simple encode [#1544]

osaf/services/saf/amf/amfd/ckpt_enc.cc | 232 +--- 1 files changed, 97 insertions(+), 135 deletions(-) use simple encode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_enc.cc b/osaf/services/saf/amf/amfd/ckpt_enc.cc --- a/osaf/se

Re: [devel] [PATCH 2 of 4] amfd: use simple decode [#1544]

Hi Hans Please see reply below. > On 11 Jan 2016, at 8:44 PM, Hans Nordebäck > wrote: > > ack, code review only. One question below/Thanks HansN > >> >> @@ -2769,14 +2715,10 @@ >> static uint32_t dec_comp_cs_type_config(AVD_CL_CB *cb, NCS_MBCSV_CB_DEC >> *dec) >> { >> uint32_t status

[devel] [PATCH 1 of 5] corelibs: add simple encode and decode routines for SaClmNodeAddressT [#1544]

osaf/libs/core/include/ncsencdec_pub.h | 3 +++ osaf/libs/core/leap/hj_enc.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h --- a/osaf/libs/core/include/ncsenc

[devel] [PATCH 4 of 5] amfd: remove unused encode and decode routines [#1520]

osaf/services/saf/amf/amfd/ckpt_edu.cc| 215 -- osaf/services/saf/amf/amfd/include/ckpt_edu.h | 12 - 2 files changed, 0 insertions(+), 227 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc --- a/osaf/ser

[devel] [PATCH 2 of 5] amfd: use simple decode [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 312 1 files changed, 121 insertions(+), 191 deletions(-) use simple decode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc --- a/osaf/s

[devel] [PATCH 0 of 5] Review Request for amfd: use simple encode and decode V2 [#1544]

T() as per Hans's comment 4/5: no change 5/5: added * added unit test case changeset c280a91ea5d2bee125bee59de83226ac341e17d1 Author: Gary Lee Date: Thu, 14 Jan 2016 17:13:30 +1100 corelibs: add simple encode and decode routines for SaClmNodeAddressT [#1

[devel] [PATCH 3 of 5] amfd: use simple encode [#1544]

osaf/services/saf/amf/amfd/ckpt_enc.cc | 236 +--- 1 files changed, 98 insertions(+), 138 deletions(-) use simple encode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_enc.cc b/osaf/services/saf/amf/amfd/ckpt_enc.cc --- a/osaf/se

[devel] [PATCH 5 of 5] amfd: add unit test for node config decode & encode [#1520]

osaf/services/saf/amf/amfd/include/ckpt.h | 4 + osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 71 +++ 2 files changed, 75 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/ckpt.h b/osaf/services/saf/amf/amfd/include/ckpt.h --

Re: [devel] [PATCH 1 of 1] amfd: Remove redundant declarations in util.h and msg.h [#1662]

Hi Hans ack (review only) Thanks Gary > On 15 Jan 2016, at 11:22 PM, Hans Nordeback > wrote: > > osaf/services/saf/amf/amfd/comptype.cc| 1 + > osaf/services/saf/amf/amfd/dmsg.cc| 1 + > osaf/services/saf/amf/amfd/hlt.cc | 1 + > osaf/services/saf/amf/amfd/include/msg.h

[devel] [PATCH 00 of 15] Review Request for amfd: replace internal use of SaNameT with std::string [#1537]

ssages are still encoded as SaNameT for backwards compatibility with existing amfd version * messages between d and nd have not been changed changeset 4390a3d3b078620d9a9cfc05b600992a79ea5a3f Author: Gary Lee Date: Mon, 25 Jan 2016 11:18:17 +1100 amd libs: move avsv_saname_init to a

[devel] [PATCH 07 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/hlt.cc | 14 +++--- osaf/services/saf/amf/amfd/hlttype.cc | 18 -- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/osaf/services/saf/amf/amfd/hlt.cc b/osaf/services/saf/amf/amfd/hlt.cc --- a/osaf/services/saf/amf/amfd/hlt.

[devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

osaf/libs/core/include/ncsencdec_pub.h | 1 + osaf/libs/core/leap/hj_enc.c | 17 + 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h --- a/osaf/libs/core/include/ncsencdec_p

[devel] [PATCH 05 of 15] afmd: change SaNameT to std::string in ckpt related files [#1537]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 134 --- osaf/services/saf/amf/amfd/ckpt_enc.cc | 121 +--- osaf/services/saf/amf/amfd/ckpt_updt.cc | 94 +++--- 3 files changed, 191 insertions(+), 158 deletions(-) diff --git a/os

[devel] [PATCH 15 of 15] amfd: update unit tests to use std::string [#1537]

osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 33 -- 1 files changed, 15 insertions(+), 18 deletions(-) diff --git a/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc b/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc --- a/osaf/services/saf/amf/amfd/tests/te

[devel] [PATCH 09 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/ndfsm.cc| 12 +- osaf/services/saf/amf/amfd/ndproc.cc | 32 +-- osaf/services/saf/amf/amfd/node.cc | 227 +--- osaf/services/saf/amf/amfd/nodegroup.cc| 215 ++ osaf/services/saf/amf/amfd/node

[devel] [PATCH 13 of 15] amfd: change SaNameT to std::string in SU related code [#1537]

osaf/services/saf/amf/amfd/su.cc | 444 ++ osaf/services/saf/amf/amfd/sutcomptype.cc| 25 +- osaf/services/saf/amf/amfd/sutype.cc | 65 ++- osaf/services/saf/amf/amfd/svctype.cc| 44 +- osaf/services/saf/amf/amfd/svctypecstypes.cc |

[devel] [PATCH 01 of 15] amd libs: move avsv_saname_init to amfd [#1537]

osaf/libs/common/amf/include/amf_util.h | 1 - osaf/libs/common/amf/util.c | 17 - 2 files changed, 0 insertions(+), 18 deletions(-) this is only used in amfd diff --git a/osaf/libs/common/amf/include/amf_util.h b/osaf/libs/common/amf/include/amf_util.h --- a/osa

[devel] [PATCH 03 of 15] amfd: added wrapper class for SaNameT [#1537]

osaf/services/saf/amf/amfd/include/db_template.h | 39 +++- 1 files changed, 38 insertions(+), 1 deletions(-) SaNameTWrapper allows easy conversion from std::string to SaNameT required by many API functions diff --git a/osaf/services/saf/amf/amfd/include/db_template.h b/os

[devel] [PATCH 04 of 15] amfd: change SaNameT variables to std::string in include directory [#1537]

osaf/services/saf/amf/amfd/include/app.h | 6 +- osaf/services/saf/amf/amfd/include/apptype.h | 8 +- osaf/services/saf/amf/amfd/include/cb.h| 4 +- osaf/services/saf/amf/amfd/include/ckpt.h | 4 +- osaf/services/saf/amf/amfd/include/cluster.h |

[devel] [PATCH 11 of 15] amfd: change SaNameT to std::string in SI related code [#1537]

osaf/services/saf/amf/amfd/si.cc | 233 ++- osaf/services/saf/amf/amfd/si_dep.cc | 297 +++--- osaf/services/saf/amf/amfd/siass.cc | 107 ++-- 3 files changed, 303 insertions(+), 334 deletions(-) diff --git a/osaf/services/saf/a

[devel] [PATCH 12 of 15] amfd: change SaNameT to std::string in sirankedsu.cc [#1537]

osaf/services/saf/amf/amfd/sirankedsu.cc | 143 -- 1 files changed, 57 insertions(+), 86 deletions(-) diff --git a/osaf/services/saf/amf/amfd/sirankedsu.cc b/osaf/services/saf/amf/amfd/sirankedsu.cc --- a/osaf/services/saf/amf/amfd/sirankedsu.cc +++ b/osaf/services/

[devel] [PATCH 08 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/imm.cc | 281 ++--- 1 files changed, 138 insertions(+), 143 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amfd/imm.cc +++ b/osaf/services/saf/amf/amfd/imm.cc

[devel] [PATCH 14 of 15] amfd: change SaNameT to std::string in util.cc [#1537]

osaf/services/saf/amf/amfd/util.cc | 205 ++-- 1 files changed, 126 insertions(+), 79 deletions(-) diff --git a/osaf/services/saf/amf/amfd/util.cc b/osaf/services/saf/amf/amfd/util.cc --- a/osaf/services/saf/amf/amfd/util.cc +++ b/osaf/services/saf/amf/amfd/util

[devel] [PATCH 06 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/app.cc| 68 osaf/services/saf/amf/amfd/apptype.cc| 61 --- osaf/services/saf/amf/amfd/clm.cc| 14 +- osaf/services/saf/amf/amfd/cluster.cc|2 +- osaf/services/saf/amf/amfd/comp.cc | 169 ++-- osaf/serv

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

Hi Sorry, just realised I should have done this better. > On 25 Jan 2016, at 3:35 PM, Gary Lee wrote: > > osaf/libs/core/include/ncsencdec_pub.h | 1 + > osaf/libs/core/leap/hj_enc.c | 17 + > 2 files changed, 18 insertions(+), 0 deletions(-) >

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

LENGTH length limitation will be removed from the function. Thanks Gary > On 27 Jan 2016, at 6:35 PM, Hans Nordebäck > wrote: > > ack, code review only. See questions below. /Thanks HansN > > On 01/25/2016 05:35 AM, Gary Lee wrote: >> osaf/libs/core/include/ncsencdec_pu

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

äck > wrote: > > Hi Gary, > > I missed that mail, yes it's enough, what about the name of the function? > /Thanks HansN > > On 01/27/2016 08:46 AM, Gary Lee wrote: >> Hi Hans >> >> Good point, I commented on this in a later email, after I sent th

Re: [devel] [PATCH 03 of 15] amfd: added wrapper class for SaNameT [#1537]

Hi Hans Thanks, please see my reply below. > On 27 Jan 2016, at 11:45 PM, Hans Nordebäck > wrote: > > ack, code review only. Minor question below. /Thanks HansN > > On 01/25/2016 05:35 AM, Gary Lee wrote: >> osaf/services/saf/amf/amfd/inc

Re: [devel] [PATCH 0 of 1] Review Request for amfa: Divide amf api functions in a thin C layer and use C++ for implementation [#1673]

Hi Hans I think it would be very, very nice if we got rid of SaNameT in libs/common/osaf, and replaced it with std::string. As you know, the data structures defined here are used by the agent, director and node director. There is a lot of code that copies and frees various messages (both in th

[devel] [PATCH 1 of 1] amfd: ensure su is in su_oper_list before deleting [#1675]

osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) failed SU is not necessarily involved in the SG realignment diff --git a/osaf/services/saf/amf/amfd/sg_nored_fsm.cc b/osaf/services/saf/amf/amfd/sg_nored_fsm.cc --- a/osaf/se

[devel] [PATCH 0 of 1] Review Request for amfd: ensure su is in su_oper_list before deleting [#1675]

n Comments (indicate scope for each "y" above): - changeset 173845fb9b17c3f832918e4a1f93fdf07270fe71 Author: Gary Lee Date: Tue, 02 Feb 2016 17:45:38 +1100 amfd: ensure su is in su_oper_list before delet

Re: [devel] [PATCH 0 of 2] Review Request for clm: support simultaneous reboot of both controller nodes [#1646]

HI Mathi Any comments regarding this series? Can we push it? Thanks Gary > On 19 Jan 2016, at 11:29 PM, Anders Widell wrote: > > Ack for the series (code review only). > > regards, > Anders Widell > > On 01/07/2016 05:38 AM, Gary Lee wrote: >> Summary: clm:

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

Hi Nagu Just wanted to confirm that when you attach gdb to a process, the process is amf_demo, and not amfnd? Thanks Gary > On 13 Feb 2016, at 1:35 AM, Nagendra Kumar wrote: > > TC #27: Same configuration as TC #24: > Add a new Csi in running demo appl: Keep gdb in SU1 comp in > amf_csi_set_

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

at 4:00 PM, Gary Lee wrote: > > Hi Nagu > > Just wanted to confirm that when you attach gdb to a process, the process is > amf_demo, and not amfnd? > > Thanks > Gary > >> On 13 Feb 2016, at 1:35 AM, Nagendra Kumar wrote: >> >> TC #27: Same conf

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

Hi Nagu Please ignore fix.patch Minh previously sent, and replace with this version. Thanks Gary > On 19 Feb 2016, at 8:09 PM, minh chau wrote: > > Hi Nagu, > > Thanks for your testing. > Below is our investigation from TC1 - TC31 which seem to be important, plus > some patches that we're

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

It seems the file wasn't attached properly. Take #2. Quoting Gary Lee : Hi Nagu Please ignore fix.patch Minh previously sent, and replace with this version. Thanks Gary On 19 Feb 2016, at 8:09 PM, minh chau wrote: Hi Nagu, Thanks for your testing. Below is our investigation fro

[devel] [PATCH 1 of 1] amf: Add support for cloud resilience [#1620] V3

osaf/services/saf/amf/README-HEADLESS | 143 ++ 1 files changed, 143 insertions(+), 0 deletions(-) Update README-HEADLESS diff --git a/osaf/services/saf/amf/README-HEADLESS b/osaf/services/saf/amf/README-HEADLESS new file mode 100644 --- /dev/null +++ b/osaf/se

[devel] [PATCH 0 of 1] Review Request for amf: Add support for cloud resilience [#1620] V3

Other n Comments (indicate scope for each "y" above): - changeset 689569bc10f0a1856d04a164897a40feb85fd11d Author: Gary Lee Date: Tue, 23 Feb 2016 11:59:15 +1100 amf: Add support for cloud resilience [#1620] V3

Re: [devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

Hi Mathi I think Minh has previously said "delayed failover" isn't the best description of what patch 6 is doing. Minh has previously described it better as "adjust HA assignment"; moving transient states to states that realign() can work with. The transient states aren't necessarily caused

[devel] [PATCH 0 of 1] Review Request for amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

n Other n Comments (indicate scope for each "y" above): - changeset 6cc1f9edfa377497f670394a1ed7798c1899e723 Author: Gary Lee Date: Mon, 07 Mar 2016 16:29:09 +1100 amfd: handle cases where a checkpoint arrive

[devel] [PATCH 1 of 1] amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 25 - osaf/services/saf/amf/amfd/ckpt_updt.cc | 6 +++--- osaf/services/saf/amf/amfd/su.cc| 8 ++-- 3 files changed, 29 insertions(+), 10 deletions(-) Sometimes a mbc checkpoint may arrive after an object has been

[devel] [PATCH 2 of 2] amfd: fix warning on some g++ versions [#1710]

osaf/services/saf/amf/amfd/sg.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/amf/amfd/sg.cc b/osaf/services/saf/amf/amfd/sg.cc --- a/osaf/services/saf/amf/amfd/sg.cc +++ b/osaf/services/saf/amf/amfd/sg.cc @@ -136,7 +136,7 @@ AVD_SG::AVD_SG(): stati

[devel] [PATCH 1 of 2] amfa: return SA_AIS_ERR_TRY_AGAIN immediately [#1710]

osaf/libs/agents/saf/amfa/ava_api.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/osaf/libs/agents/saf/amfa/ava_api.c b/osaf/libs/agents/saf/amfa/ava_api.c --- a/osaf/libs/agents/saf/amfa/ava_api.c +++ b/osaf/libs/agents/saf/amfa/ava_api.c @@ -1900,8 +1900,10 @@ SaAis

[devel] [PATCH 0 of 2] Review Request for amfa: return SA_AIS_ERR_TRY_AGAIN immediately [#1710]

Other n Comments (indicate scope for each "y" above): - changeset 6f533e849c5e570aacab7009a07eb845cf0237ac Author: Gary Lee Date: Thu, 24 Mar 2016 16:41:07 +1100 amfa: return SA_AIS_ERR_TRY_AGAIN immediately [#

Re: [devel] [PATCH 1 of 1] amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

Hi I will push this tomorrow (1 Apr) if there are no more comments. Thanks Gary On 11/03/2016, 7:19 PM, "Hans Nordebäck" wrote: >ack, code review only/Thanks HansN > >On 03/07/2016 06:31 AM, Gary Lee wrote: >> osaf/services/saf/am

Re: [devel] [PATCH 1 of 1] amfd: ensure su is in su_oper_list before deleting [#1675]

Hi I will push this tomorrow if there are no more comments. Thanks Gary On 11/03/2016, 7:13 PM, "Hans Nordebäck" wrote: >ack, code review only/Thanks HansN > >On 02/02/2016 07:48 AM, Gary Lee wrote: >> osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 19 +++

Re: [devel] [PATCH 1 of 1] amfd: ensure su is in su_oper_list before deleting [#1675]

Sure, will fix before pushing. Thanks! On 31/03/2016, 5:11 PM, "praveen malviya" wrote: >Ack code reivew only. >I think commit message must include Red model name. > >Thanks, >Praveen > > >On 31-Mar-16 9:05 AM, Gary Lee wrote: >> Hi >> >

[devel] [PATCH 0 of 1] Review Request for amf: send extra state information from nd to d after headless state [#1620]

n Tests n Other n Comments (indicate scope for each "y" above): - changeset abedc429029d4a1baaa2cc18b3ee47f6c2ab815a Author: Gary Lee Date: Mon, 04 Apr 2016 14:23:25 +1000 amf: send extra state

[devel] [PATCH 1 of 1] amf: send extra state information from nd to d after headless state [#1620]

osaf/libs/common/amf/d2nedu.c | 11 +-- osaf/libs/common/amf/include/amf_d2nmsg.h | 3 ++ osaf/libs/common/amf/include/amf_si_assign.h | 19 + osaf/services/saf/amf/amfd/csi.cc | 3 ++ osaf/services/saf/amf/amfd/include/mds.h | 7 +

[devel] [PATCH 1 of 1] amf: add README_HEADLESS [#1620]

osaf/services/saf/amf/README_HEADLESS | 150 ++ 1 files changed, 150 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README_HEADLESS b/osaf/services/saf/amf/README_HEADLESS new file mode 100644 --- /dev/null +++ b/osaf/services/saf/amf/README_HE

[devel] [PATCH 0 of 1] Review Request for amf: add README_HEADLESS [#1620]

mments (indicate scope for each "y" above): - Update README_HEADLESS to match the limited functionality provided by #1620 v4 patches 1 to 4 changeset c0bc0ae374ba75fbaf56da883f2b1ee3c906614e Author: Gary Lee Date: Mon, 04 Apr 2016 17:34:07 +1

Re: [devel] [PATCH 1 of 1] amf: add README_HEADLESS [#1620]

K >4. The following lines is incomplete: > +SA_AMF_HA_STATE of a SI may change from "" to <> This is intended. The initial text is blank. Thanks Gary > >Thanks >-Nagu > >> -Original Message- >> From: Gary Lee [mailto:gary@dektech.com.au] >> S

[devel] [PATCH 1 of 1] amf: add README_HEADLESS [#1620]

osaf/services/saf/amf/README_HEADLESS | 150 ++ 1 files changed, 150 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README_HEADLESS b/osaf/services/saf/amf/README_HEADLESS new file mode 100644 --- /dev/null +++ b/osaf/services/saf/amf/README_HE

[devel] [PATCH 0 of 1] Review Request for amf: add README_HEADLESS V2 [#1620]

mments (indicate scope for each "y" above): - Updated after comments from Nagu changeset 0585bce27d7880b0d8103e6a514c4a390fca10df Author: Gary Lee Date: Tue, 05 Apr 2016 07:02:51 +1000 amf: add README_HEADLESS [#1620] C

[devel] CLM PR update for #1646

will need to call saClmInitialize again to obtain a new CLM handle. Thanks Gary On 19/01/2016, 11:29 PM, "Anders Widell" wrote: >Ack for the series (code review only). > >regards, >Anders Widell > >On 01/07/2016 05:38 AM, Gary Lee wrote: >> Summary: clm: s

Re: [devel] CLM PR update for #1646

r >> recovery from a headless state and reception of ERR_BAD_HANDLE, >> each CLM client will need to call saClmInitialize again >> to obtain a new CLM handle. >> >> Thanks >> Gary >> >> >> >> >> On 19/01/2016, 11:29 PM,

[devel] [PATCH 1 of 1] amf: send extra state information from nd to d after headless state [#1723]

osaf/libs/common/amf/d2nedu.c | 11 +-- osaf/libs/common/amf/include/amf_d2nmsg.h | 3 ++ osaf/libs/common/amf/include/amf_si_assign.h | 19 + osaf/services/saf/amf/amfd/csi.cc | 3 ++ osaf/services/saf/amf/amfd/include/mds.h | 7 +

[devel] [PATCH 0 of 1] Review Request for amf: send extra state information from nd to d after headless state [#1723]

Tests n Other n Comments (indicate scope for each "y" above): - changeset 226a473224096ae0a09635bb740b71c6e87bc6a2 Author: Gary Lee Date: Thu, 07 Apr 2016 13:27:29 +1000 amf: send extra state informat

[devel] [PATCH 0 of 1] Review Request for amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

amples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 0b577273443bb6b03b4e50196cd29262c63f86f7 Author: Gary Lee Date: Thu, 07 Apr 2016 13:44:46 +1000

[devel] [PATCH 1 of 1] amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

osaf/services/saf/amf/amfnd/pg.cc | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless, since protection group tracking requires amfd's presence diff --git a/osaf/services/saf/

Re: [devel] CLM PR update for #1646

Hi Mathi Thanks, we can go with your version. Thanks Gary On 7/04/2016, 3:54 PM, "Mathivanan Naickan Palanivelu" wrote: >Comment inline: >Mathi. > >> -Original Message- >> From: Gary Lee [mailto:gary@dektech.com.au] >> Sent: Thursday, Apr

Re: [devel] [PATCH 1 of 1] amfnd: Add missing braces [#1743]

Ack (review only) Thanks Gary > On 9 Apr 2016, at 2:04 AM, Anders Widell wrote: > > osaf/services/saf/amf/amfnd/compdb.cc | 6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > Add missing braces to fix the following compilation error discovered when > using > GCC 6: > > compd

Re: [devel] [PATCH 1 of 1] amfd: respond to IMM for admin op status when SG becomes stable [#1740]

Ack (review only) Thanks Gary On 12/04/2016, 3:18 PM, "praveen.malv...@oracle.com" wrote: > osaf/services/saf/amf/amfd/sgproc.cc | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > >If unlock admin operation on SU1 is timed just after cluster timer expiry, >AMFD will start assig

Re: [devel] [PATCH 1 of 1] amfd: Remove dead-code detected by Coverity [#680]

Hi Hans Ack (review only) Thanks Gary On 11/04/2016, 4:55 PM, "Hans Nordeback" wrote: > osaf/services/saf/amf/amfd/apptype.cc | 6 -- > osaf/services/saf/amf/amfd/csiattr.cc | 8 +--- > osaf/services/saf/amf/amfd/ctcstype.cc| 7 --- > osaf/services/saf/amf/amfd/sg

Re: [devel] CLM PR update for #1646

Hi Mathi I’ve updated the PR doc (please see attachment). Please push it if you’re happy with it. Thanks Gary On 7/04/2016, 4:13 PM, "Gary Lee" wrote: >Hi Mathi > >Thanks, we can go with your version. > >Thanks >Gary > > > > >On 7/04/2016, 3:54 P

Re: [devel] [PATCH 1 of 1] amfnd: remove receive message id counter from threads [#1728]

Hi Nagu I think there might still be race conditions that need to be fixed. Seems to be at least two places where rcv_msg_id is reset to 0 in the main thread, that might interfere with the MDS thread’s use of rcv_msg_id. Thanks Gary On 12/04/2016, 5:12 PM, "Nagendra Kumar" wrote: >Hi Hans

Re: [devel] [PATCH 1 of 1] amfnd: do not invoke health check command when npi comp is TERMINATING [#1759]

Hi Praveen Ack (not tested) On 14/04/2016, 7:37 PM, "praveen.malv...@oracle.com" wrote: > osaf/services/saf/amf/amfnd/chc.cc | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > >In the reported problem Command Based HC was invoked for a NPI component in >termination

Re: [devel] [PATCH 1 of 1] amfnd: remove receive message id counter from threads [#1728]

/* * We are done with use of rev_msg_id count. Now it is time * re-set it since all new messages we are going to get with * the new counter value. */ cb->rcv_msg_id = 0; .. } On 18/04/2016, 8:50 PM, "Gary Lee" wrote: >Hi Nag

Re: [devel] [PATCH 1 of 1] amfnd: remove receive message id counter from threads [#1728]

controllers and payload. > >Thanks >-Nagu > >> -Original Message- >> From: Gary Lee [mailto:gary@dektech.com.au] >> Sent: 20 April 2016 06:16 >> To: Nagendra Kumar; Hans Nordebäck; Praveen Malviya; Minh Hon Chau >> Cc: opensaf-devel@lists.sourceforg

[devel] [PATCH 0 of 1] Review Request for amfnd: reset rcv_msg_id on AVD down [#1728]

Other n Comments (indicate scope for each "y" above): - changeset 120a36b759ef77ec3a0b39f1a00bbcbfffe9eae7 Author: Gary Lee Date: Sat, 23 Apr 2016 22:17:45 +1000 amfnd: reset rcv_msg_id on AVD down [#1728] This patch re

[devel] [PATCH 1 of 1] amfnd: reset rcv_msg_id on AVD down [#1728]

osaf/services/saf/amf/amfnd/di.cc | 1 - osaf/services/saf/amf/amfnd/mds.cc | 1 + 2 files changed, 1 insertions(+), 1 deletions(-) This patch reverts the change in behaviour introduced in changeset 3451e8a8ba90, where rcv_msg_id reset was moved from avnd_evt_mds_avd_dn_evh() to avnd_evt_mds_

[devel] [PATCH 1 of 1] amfnd: reset rcv_msg_id on AVD down [#1728]

osaf/services/saf/amf/amfnd/di.cc | 1 - osaf/services/saf/amf/amfnd/mds.cc | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) This patch reverts the change in behaviour introduced in changeset 3451e8a8ba90, where rcv_msg_id reset was moved from avnd_evt_mds_avd_dn_evh() to avnd_evt_

[devel] [PATCH 0 of 1] Review Request for amfnd: reset rcv_msg_id on AVD down V2 [#1728]

n Comments (indicate scope for each "y" above): - <> changeset 48a81d8043356d133105c69a8780d3a1c04775ab Author: Gary Lee Date: Mon, 25 Apr 2016 15:39:35 +1000 amfnd: reset rcv_msg_id on AVD down [#1728] T

[devel] [PATCH 1 of 1] clms: change log level from error to notice when clms_client_delete fails [#1701]

osaf/services/saf/clmsv/clms/clms_mbcsv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) An active clmd may send a checkpoint update to the standby clmd before cold sync is complete. If a client_id deletion checkpoint is received by the standby, before the client_id is synced to the

[devel] [PATCH 0 of 1] Review Request for clmd: change log level from error to notice when clms_client_delete fails [#1701]

n Tests n Other n Comments (indicate scope for each "y" above): - <> changeset 0649dcaf2ad7816b61e51d2e9f2be69bc8874e0a Author: Gary Lee Date: Tue, 03 May 2016 13:59:13 +1000 clms: change l

Re: [devel] [PATCH 1 of 1] amfd: Segv in ng_ccb_completed_delete_hdlr [#1766]

Hi Hans ack (review only) On 30/04/16 00:28, Hans Nordebäck wrote: > Gentle reminder for review!/Thanks Hans > > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: den 15 april 2016 10:26 > To: praveen.malv...@oracle.com; nagendr..

[devel] [PATCH 1 of 1] amfd: reinit with CLM on SA_AIS_ERR_BAD_HANDLE [#1812]

osaf/services/saf/amf/amfd/main.cc | 37 ++--- 1 files changed, 30 insertions(+), 7 deletions(-) amfd needs to reinit with CLM if saClmDispatch() returns SA_AIS_ERR_BAD_HANDLE diff --git a/osaf/services/saf/amf/amfd/main.cc b/osaf/services/saf/amf/amfd/main.cc

[devel] [PATCH 0 of 1] Review Request for amfd: reinit with CLM on SA_AIS_ERR_BAD_HANDLE [#1812]

Other n Comments (indicate scope for each "y" above): - changeset 9311ad9655d7f4d97b0011cb2b18c1c18975ef9b Author: Gary Lee Date: Fri, 06 May 2016 16:38:31 +1000 amfd: reinit with CLM on SA_AIS_ERR_BAD_HANDLE [#181

Re: [devel] [PATCH 1 of 1] amfd: reinit with CLM on SA_AIS_ERR_BAD_HANDLE [#1812]

97? > >Thanks, >Praveen > >On 06-May-16 12:16 PM, Gary Lee wrote: >> osaf/services/saf/amf/amfd/main.cc | 37 >++--- >> 1 files changed, 30 insertions(+), 7 deletions(-) >> >> >> amfd needs to reinit with CLM if

[devel] [PATCH 1 of 1] amf: support 75 node deployments [#1815]

osaf/libs/common/amf/include/amf_defs.h | 2 +- osaf/services/saf/amf/amfd/role.cc | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) On a 75 node deployment, avd_imm_config_get() can take up to 3 minutes to complete. The default heartbeat period of 60s between amfnd and

[devel] [PATCH 0 of 1] Review Request for amf: support 75 node deployments [#1815]

n Comments (indicate scope for each "y" above): - changeset 5599d81c5a6fd779b9bca741ae51ea7628064d14 Author: Gary Lee Date: Mon, 09 May 2016 16:57:16 +1000 amf: support 75 node deployments [#1815] On a 75 node deployment, av

Re: [devel] [PATCH 1 of 1] amf: support 75 node deployments [#1815]

raveen > >On 09-May-16 12:46 PM, Gary Lee wrote: >> osaf/libs/common/amf/include/amf_defs.h | 2 +- >> osaf/services/saf/amf/amfd/role.cc | 10 +- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> >> On a 75 node deployment, avd_i

Re: [devel] [PATCH 1 of 1] amf: support 75 node deployments [#1815]

I'll try to trim down the logs and attach ... From clm traces, clmd didn't receive any errors sending the callbacks. But the MDS callback in amfd was not triggered and there are no errors in MDS.log or syslog. --

Re: [devel] [PATCH 1 of 1] amfd: reinit with CLM on SA_AIS_ERR_BAD_HANDLE [#1812]

Hi I will push this on Friday if there are no objections? Thanks Gary On 6/05/2016, 4:46 PM, "Gary Lee" wrote: > osaf/services/saf/amf/amfd/main.cc | 37 ++--- > 1 files changed, 30 insertions(+), 7 deletions(-) > > >amfd ne

  1   2   3   4   5   6   7   8   9   10   >