Re: [devel] [PATCH 1/1] smf: improve ccb handler rules for recovery [#3071]

Hi Thang, I assume this is the fix we have already discussed with no changes. If that's the case Ack. Thanks Lennart -Original Message- From: thang.d.nguyen Sent: den 26 augusti 2019 12:10 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen

Re: [devel] [PATCH 1/1] smf: allow to commit merged camp after a manual cluster reboot [#3063]

: den 23 augusti 2019 13:04 To: Lennart Lund ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net; Khanh Hoang Dang Subject: [PATCH 1/1] smf: allow to commit merged camp after a manual cluster reboot [#3063] Return OK to immSteps if step is already completed in order to continue executing after

Re: [devel] [PATCH 0/1] Review Request for smf: retry if ccb is aborted at init proc [#3061] V2

Hi Thang, I'm back from vacation. I will do a review. Thanks Lennart -Original Message- From: thang.d.nguyen Sent: den 12 augusti 2019 10:44 To: Lennart Lund ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen Subject: [PATCH 0/1] Review Request for smf: retry

Re: [devel] [PATCH 1/1] log: Update the try again for admin operation [#3056]

Hi Canh, Ack. Not tested Thanks Lennart Från: Canh Van Truong Skickat: den 1 juli 2019 12:23 Till: Lennart Lund; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 1/1] log: Update the try again for admin operation [#3056

Re: [devel] Review request log: document for ticket #3022 and #3046

need that when committing and pushing to the OpenSAF document repository. Thanks Lennart From: Canh Van Truong Sent: den 17 juni 2019 13:07 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Review request log: document for ticket #3022 and #3046 Update

Re: [devel] [PATCH 1/1] log: Delete the older file without closing current log file via admin operation [#3046]

Hi Canh, Ack with minor comments. See [Lennart] below. Note: It is very important to also update the "OpenSAF_LOGSv_PR.odt" document with the new admin operation Thanks Lennart Från: Canh Van Truong Skickat: den 14 juni 2019 14:20 Till: Lennart Lun

Re: [devel] [PATCH 1/1] log: Delete the older file without closing current log file via admin operation [#3046]

. For local functions (static) this documentation shall be placed with the source code. However, this is not to be seen as a remark for this review so you don't have to take any actions to fix this. Thanks Lennart From: Canh Van Truong Sent: den 14 juni 2019 06:56 To: Lennart Lund ; Vu Minh

Re: [devel] [PATCH 1/1] log: Delete the older file without closing current log file via admin operation [#3046]

Hi Canh I think you can send the new version for review Thanks Lennart From: Canh Van Truong Sent: den 14 juni 2019 13:31 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: Delete the older file without closing current log file via admin

Re: [devel] [PATCH 1/1] log: Delete the older file without closing current log file via admin operation [#3046]

ser (calling report_om_error()) Thanks Lennart Från: Canh Van Truong Skickat: den 13 juni 2019 13:57 Till: Lennart Lund; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 1/1] log: Delete the older file without closing current log f

Re: [devel] [PATCH 1/1] log: fix to remove the cfg file when log file rotation [#3045]

ber of log files and the new option for requesting a rotation. Thanks Lennart Från: Canh Van Truong Skickat: den 30 maj 2019 10:10 Till: Lennart Lund; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 1/1] log: fix to remove th

Re: [devel] [PATCH 1/1] mds: use new TIPC getsockopt to log receive queue utilization [#3038]

Hi Hans Ack. Not tested Thanks Lennart Från: Hans Nordebäck Skickat: den 20 maj 2019 14:27 Till: Anders Widell; Lennart Lund; Gary Lee Kopia: opensaf-devel@lists.sourceforge.net; Hans Nordebäck Ämne: [PATCH 1/1] mds: use new TIPC getsockopt to log receive queue

Re: [devel] [PATCH 1/1] imm: fix coredump on immnd during upgrade [#3030]

ickat: den 17 april 2019 11:29 Till: Hans Nordebäck; Lennart Lund; Gary Lee Kopia: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen Ämne: [PATCH 1/1] imm: fix coredump on immnd during upgrade [#3030] The assertion about the existence of the new added attribute `saImmFileSystemStatus` s

Re: [devel] [PATCH 1/1] log: Log enhance to rotate log file via admin operation [#3022]

Hi Canh, Ack with comments. See [Lennart] Thanks Lennart Från: Canh Van Truong Skickat: den 16 april 2019 10:26 Till: Lennart Lund; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 1/1] log: Log enhance to rotate log file

Re: [devel] [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018]

nart From: Canh Van Truong Sent: den 26 mars 2019 10:17 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018] Thanks Lennart, Please my comments. Regards Canh From: Lennart L

Re: [devel] [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018]

r places where an "out of synch" restart is done. Regards Lennart From: Canh Van Truong Sent: den 25 mars 2019 04:50 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: logd crash due to well known stream has numOpeners =

Re: [devel] [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018]

(well known streams are also configuration streams). Regards Lennart From: Vu Minh Nguyen Sent: den 22 mars 2019 09:30 To: Canh Van Truong ; Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018]

Re: [devel] [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018]

Hi Canh, Ack Thanks Lennart -Original Message- From: Canh Van Truong Sent: den 14 mars 2019 12:49 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong Subject: [PATCH 1/1] log: logd crash due to well known stream has numOpeners = 0 [#3018

Re: [devel] [PATCH 1/1] log: Fix the last value of logRecordDestinationConfiguration is not deleted [#3014]

Hi Canh, Ack. Thanks Lennart Från: Canh Van Truong Skickat: den 1 mars 2019 11:35 Till: Lennart Lund; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 1/1] log: Fix the last value of logRecordDestinationConfiguration

Re: [devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]

Hi Thang Ack. Thanks Lennart -Original Message- From: thang.d.nguyen Sent: den 25 februari 2019 07:25 To: Lennart Lund ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen Subject: [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync

Re: [devel] [PATCH 1/1] log: fix coredump at log agent application [#3002]

Hi Vu, Ack. Not tested If I understand correct this fix solves a problem with shutting down the log service but what is the problem if the described race condition happen? Thanks Lennart Från: Vu Minh Nguyen Skickat: den 24 januari 2019 11:14 Till: Lennart

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

Hi Canh, Ack Thanks Lennart From: Canh Van Truong Sent: den 23 januari 2019 07:13 To: Lennart Lund ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Thanks Lennart I have updated your comments

Re: [devel] [PATCH 5/5] logd: fix crash in logd [#2999]

To: Lennart Lund ; Hans Nordebäck ; Anders Widell ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 5/5] logd: fix crash in logd [#2999] Hi Lennart, The reason I removed it in some cases is because the warning was removed simply by using "%u" instead

Re: [devel] [PATCH 1/5] all: fix warnings from gcc 8.2.1 [#2999]

Hi Alex, Ack Thanks Lennart Från: Jones, Alex Skickat: den 17 januari 2019 20:27 Till: Hans Nordebäck; Lennart Lund; Anders Widell; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Jones, Alex Ämne: [PATCH 1/5] all: fix warnings from gcc 8.2.1

Re: [devel] [PATCH 5/5] logd: fix crash in logd [#2999]

cases it will just be a message that is truncated? Thanks Lennart Från: Jones, Alex Skickat: den 17 januari 2019 20:27 Till: Hans Nordebäck; Lennart Lund; Anders Widell; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Jones, Alex Ämne: [PATCH 5/5] logd

Re: [devel] [PATCH 2/5] smfd: fix uninitialized variable warning [#2999]

Hi ALex, Ack Thanks Lennart Från: Jones, Alex Skickat: den 17 januari 2019 20:27 Till: Hans Nordebäck; Lennart Lund; Anders Widell; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Jones, Alex Ämne: [PATCH 2/5] smfd: fix uninitialized variable

Re: [devel] [PATCH 3/5] log: fix truncation warning [#2999]

Hi Alex, Ack Thanks Lennart Från: Jones, Alex Skickat: den 17 januari 2019 20:27 Till: Hans Nordebäck; Lennart Lund; Anders Widell; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Jones, Alex Ämne: [PATCH 3/5] log: fix truncation warning [#2999

Re: [devel] [PATCH 5/5] logd: fix crash in logd [#2999]

if the fix affects the code in a significant way. Thanks Lennart Från: Jones, Alex Skickat: den 17 januari 2019 20:27 Till: Hans Nordebäck; Lennart Lund; Anders Widell; Vu Minh Nguyen Kopia: opensaf-devel@lists.sourceforge.net; Jones, Alex Ämne: [PATCH 5/5] logd: fix

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

Truong Sent: den 18 januari 2019 08:43 To: Minh Hon Chau ; Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi aMinh I have updated your comments. Please help check and push the document

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

Hi Canh, I should have Acked the document in my previous answer. Just fix any minor things and push. Thanks Lennart From: Canh Van Truong Sent: den 11 januari 2019 12:01 To: Lennart Lund ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: RE: Review request ntf: update document

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

Hi Canh, I have one minor comment in the attached document. Also, it may be better if the table has three columns "Environment Variable, Default value and Comment" Thanks Lennart From: Canh Van Truong Sent: den 11 januari 2019 10:18 To: Lennart Lund ; Minh Hon Chau Cc: ope

Re: [devel] [PATCH 0/1] Review Request for smf: return false instead of empty string [#2993]

Hi Ack Thanks Lennart -Original Message- From: thang.d.nguyen Sent: den 9 januari 2019 06:26 To: Lennart Lund ; Canh Van Truong Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen Subject: [PATCH 0/1] Review Request for smf: return false instead of empty string [#2993

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

ient to timeout. If the buffer is full and the log service answers TRY AGAIN NTF will return TRY AGAIN when Notification send is called." Thanks Lennart From: Canh Van Truong Sent: den 10 januari 2019 12:52 To: Minh Hon Chau ; Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Review

Re: [devel] [PATCH 1/1] imm: allow empty-value attribute with default-tag persisted [#2985]

ues larger than that max are invalid) and if the value is invalid it could be replaced by a default value. Thanks Lennart -Original Message- From: Vu Minh Nguyen Sent: den 10 januari 2019 03:56 To: Hans Nordebäck ; Lennart Lund ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net S

Re: [devel] [PATCH 2/2] ntf: Update TRY_AGAIN error in ntfsend tool [#2961]

Hi Canh, Ack, see minor comment below [Lennart] Thanks Lennart Från: Canh Van Truong Skickat: den 9 januari 2019 10:22 Till: Lennart Lund; Minh Hon Chau Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 2/2] ntf: Update TRY_AGAIN

Re: [devel] [PATCH 1/2] ntf: Limit the logger buffer [#2961]

Hi Canh Ack for "ntf: Limit the logger buffer" commit with some comments. See [Lennart] below Thanks Lennart Från: Canh Van Truong Skickat: den 9 januari 2019 10:22 Till: Lennart Lund; Minh Hon Chau Kopia: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1/1] ntf: Fix to NTFD doesn't send the response if MDS_DEST of client is disconnected [#2973]

Hi Canh, I have some comments. Please see [Lennart] the attached .diff file that can be applied on top of the review branch Thanks Lennart Från: Canh Van Truong Skickat: den 5 december 2018 07:06:38 Till: Lennart Lund; Minh Hon Chau Kopia: opensaf-devel

Re: [devel] [PATCH 1/3] imm: add new test cases of API saImmOmSelectionObjectGet() of apitest [#2951]

Hi Mohan, The comments I gave for the log service test cases about how to document them and why, usage descriptive names etc. is applicable for IMM and all other services as well. Remember that test cases has to be documented regarding What's tested, if needed how and what the criteria for is

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

2018 05:13 To: Lennart Lund ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong Subject: [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973] When the sending notification request come to NTFD , they are put in the mbx to wait for being

Re: [devel] [PATCH 1/1] ntf: Increase the priority when sending MDS_DOWN to NTFD maind thread [#2973]

Hi Canh, Ack, with comments see [Lennart] below. I have not tested I cannot say if this is a good solution or not. Thanks Lennart -Original Message- From: Canh Van Truong Sent: den 27 november 2018 14:17 To: Lennart Lund ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net; Canh

Re: [devel] [PATCH 1/1] log: add new test cases in log apitest v3 [#2915]

Hi Mohan, Ack Thanks Lennart -Original Message- From: Mohan Kanakam Sent: den 21 november 2018 11:12 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam Subject: [PATCH 1/1] log: add new test cases in log apitest v3 [#2915] --- src/log/apitest

Re: [devel] [PATCH 0/7] Review Request for log: add new test cases in apitest [#2915]

one commit containing all the new test cases instead of 7 commits. When this is fixed you can send a new review request and I will do some testing. Thanks Lennart -Original Message- From: Mohan Kanakam Sent: den 16 november 2018 09:47 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel

Re: [devel] [PATCH 1/7] log: add new test case of API saLogInitialize() of apitest [#2915]

isites" before the actual test. Thanks Lennart -Original Message- From: Mohan Kanakam Sent: den 9 november 2018 07:58 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam Subject: [PATCH 1/7] log: add new test case of API saLogInitialize() of

Re: [devel] [PATCH 1/1] imm: fix introduceMsg resent in every 0.1 second [#2959]

To: Hans Nordebäck ; Lennart Lund ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen Subject: [PATCH 1/1] imm: fix introduceMsg resent in every 0.1 second [#2959] It is expected that resending introduceMsg should happen every 05 seconds if the previous send has not yet received

Re: [devel] [PATCH 1/1] imm: fix coredump generated during roaming test [#2943]

Hi Vu, Ack. Note1: Not tested. Note2: This function is doing too much and its dependencies is very hard to understand so I cannot confirm that this will solve the problem or add any new problems within the time I can use  on this review. Thanks Lennart On tis, 2018-10-23 at 11:31 +0700, Vu

Re: [devel] [PATCH 1/1] imm: fix osafimmnd coredump genereted during sanity test [#2947]

Hi Vu Ack Thanks Lennart -Original Message- From: Vu Minh Nguyen Sent: den 29 oktober 2018 10:15 To: Hans Nordebäck ; Lennart Lund ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen Subject: [PATCH 1/1] imm: fix osafimmnd coredump genereted during sanity test

Re: [devel] [PATCH 1/1] imm: cluster is rebooted after split-brain recovery [#2934]

Hi Vu, Ack Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 16 oktober 2018 09:09 > To: Hans Nordebäck ; Lennart Lund > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 1/1] imm: cluster is re

Re: [devel] [PATCH 1/1] imm: cluster is rebooted after split-brain recovery [#2934]

Hi Vu, I haven't tested this and I cannot see by reading the if it does work but I have a few remarks for improvement of mostly readability. See [Lennart] below. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 12 oktober 2018 08:35 > To: Hans Nordebä

Re: [devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

to push Thanks Lennart > -Original Message- > From: thuan.tran > Sent: den 28 september 2018 10:45 > To: Lennart Lund ; Gary Lee > > Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran > > Subject: [PATCH 1/1] smf: campaign is executing forever unti

Re: [devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

Hi Thuan Ack with comments. See below [Lennart] Still not tested Thanks Lennart > -Original Message- > From: thuan.tran > Sent: den 28 september 2018 06:00 > To: Lennart Lund ; Gary Lee > > Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran > > Subject: [

Re: [devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

in src/base/ Thanks Lennart > -Original Message- > From: Thuan TRAN > Sent: den 27 september 2018 15:24 > To: Lennart Lund > Cc: Gary Lee ; opensaf- > de...@lists.sourceforge.net > Subject: Re: [PATCH 1/1] smf: campaign is executing forever until cluster > reset

Re: [devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

; Thanks Lennart > -Original Message- > From: thuan.tran > Sent: den 25 september 2018 09:04 > To: Lennart Lund ; Gary Lee > > Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran > > Subject: [PATCH 1/1] smf: campaign is executing forever until cluster reset &g

Re: [devel] [PATCH 1/1] smf: improve CcbApplyCallback() to avoid NULL access [#2927]

Hi, I see that this is already pushed. The fix seems correct. Thanks Lennart > -Original Message- > From: thuan.tran > Sent: den 17 september 2018 13:39 > To: Lennart Lund ; Gary Lee > > Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran > > Subject:

Re: [devel] [PATCH 1/1] smf: correct LOG_NO to TRACE [#2849]

Hi Krishna, Ack Thanks Lennart > -Original Message- > From: Krishna Pawar > Sent: den 14 september 2018 09:59 > To: Lennart Lund ; Rafael Odzakow > > Cc: opensaf-devel@lists.sourceforge.net; Krishna Pawar > > Subject: [PATCH 1/1] smf: correct LOG_NO to TRACE

Re: [devel] [PATCH 1/1] log: add new test case of API saLogInitialize() of apitest [#2915]

Hi Ack Thanks Lennart > -Original Message- > From: Ratnamala Tallari > Sent: den 28 augusti 2018 14:19 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Ratnamala Tallari > > Subject: [PATCH 1/1] log: add new test cas

Re: [devel] [PATCH 1/1] log: fix timeout when deleting configuration stream [#2903]

Hi Canh, Ack Thanks Lennart > -Original Message- > From: Canh Van Truong > Sent: den 24 augusti 2018 10:57 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong > > Subject: [PATCH 1/1] log: fix timeout when delet

Re: [devel] [PATCH 0/2] Review Request for mdstest: correct timing issues in mdstest V3 [#2798]

string in the test_suite_add() and test_case_add() is enough for knowing test progress. Thanks Lennart > -Original Message- > From: Hoa Le > Sent: den 23 augusti 2018 04:26 > To: Lennart Lund ; Minh Hon Chau > ; Hans Nordebäck > > Cc: opensaf-devel@lists.sourceforge.n

Re: [devel] [PATCH 1/1] log: add new test case of API saLogInitialize() of apitest [#2915]

Hi, Ack. See my comments below tagged [Lennart] Thanks Lennart > -Original Message- > From: ratnamala > Sent: den 21 augusti 2018 15:46 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; ratnamala > > Subject: [PATCH 1/1] log:

Re: [devel] [PATCH 1/1] mbc: fix mbcsv loop forever while it is being dispatch ALL [#2899]

Hi Canh, Ack. See my minor misspell comment below Thanks Lennart > -Original Message- > From: Canh Van Truong > Sent: den 20 augusti 2018 10:48 > To: Minh Hon Chau ; Gary Lee > ; Hans Nordebäck > ; Lennart Lund > > Cc: opensaf-devel@lists.sourceforge.net; Canh

Re: [devel] [PATCH 1/1] ntf: Update timeout for initializing log client [#2878]

in some cases. I suggest that this is fixed, at least for functions that are affected by other fixes. I have written a comment about that for one affected function in the commented code Thanks Lennart > -Original Message- > From: Lennart Lund > Sent: den 6 augusti 2018 10:44 >

Re: [devel] [PATCH 1/1] log: fix logtest 4 58 fail [#2909]

it is hard to understand what's tested, new incorrect dependencies for example fixes in wrong places such as making "generic" functions coupled to some specific task etc. Thanks Lennart > -Original Message- > From: Canh Van Truong > Sent: den 10 augusti 2018 09:34 > T

Re: [devel] [PATCH 1/1] log: fix log agent never remove log-client in list if server return BAD_HANDLE [#2910]

Hi Canh, Ack Thanks Lennart > -Original Message- > From: Canh Van Truong > Sent: den 9 augusti 2018 11:08 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 1/1] log: fix log agent never remove log-client in li

Re: [devel] [PATCH 1/1] log: fix log agent never remove log-client in list if server return BAD_HANDLE [#2910]

this event handler should return BAD HANDLE if no valid client and no recovery is ongoing. I think this should be investigated Regards Lennart > -Original Message- > From: Canh Van Truong > Sent: den 6 augusti 2018 10:37 > To: Lennart Lund ; Vu Minh Nguyen > >

Re: [devel] [PATCH 1/1] ntf: Update timeout for initializing log client [#2878]

that both standby and active NTF may be log service clients. Standby does not log anything. Regards Lennart > -Original Message- > From: Lennart Lund > Sent: den 3 augusti 2018 14:19 > To: Minh Hon Chau ; Canh Van Truong > ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sou

Re: [devel] [PATCH 1/1] ntf: Update timeout for initializing log client [#2878]

Hi Canh I happened to see this It is always correct to have a timed try again loop. If initializing the log service time out in the AMF callback may not a big issue. If this happen NTF will get a BAD_HANDLE reply when trying to write a log record. If this happen, just initialize the log

Re: [devel] [PATCH 1/1] smf: fix memory leak reported by clang [#2904]

Hi Vu Ack Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 3 augusti 2018 04:37 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 1/1] smf: fix memory leak reported by clang [#2904] >

Re: [devel] [PATCH 0/1] Review Request for imm: attrDefaultValue is set to NULL if no default value is given [#2901]

Hi Vu Ack Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 30 juli 2018 10:47 > To: Hans Nordebäck ; Lennart Lund > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 0/1] Review Request for imm:

Re: [devel] [PATCH 0/1] Review Request for log: fix logtest 6 42 fail [#2903]

Hi Canh, I forgot to attach some comments I made in the code Thanks Lennart From: Lennart Lund Sent: den 2 augusti 2018 14:32 To: Canh Van Truong ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Lennart Lund Subject: RE: [PATCH 0/1] Review Request for log: fix logtest 6 42 fail

Re: [devel] [PATCH 0/1] Review Request for log: fix logtest 6 42 fail [#2903]

seconds which is the recommended timeout time for initializing an in this case OM handle (also for OI handle). Note that changing the file renaming timeout may be considered NBC! Thanks Lennart > -Original Message- > From: Canh Van Truong > Sent: den 1 augusti 2018 05:15 > To:

Re: [devel] [PATCH 0/1] Review Request for imm: attrDefaultValue is set to NULL if no default value is given [#2901]

age- > From: Vu Minh Nguyen > Sent: den 30 juli 2018 10:47 > To: Hans Nordebäck ; Lennart Lund > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 0/1] Review Request for imm: attrDefaultValue is set to > NULL if no de

Re: [devel] [PATCH 0/1] Review Request for smf: fix numberic attribute types not accept boolean values [#2902]

nd it was implemented in the IMM service! That would be ridiculous. See also my comments below. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 31 juli 2018 03:53 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 0/1

Re: [devel] [PATCH 0/1] Review Request for smf: fix numberic attribute types not accept boolean values [#2902]

uot; or "false" then in method AddAttributeValue() the conversion to "1" or "0" can be done. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 30 juli 2018 10:38 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net; Vu

Re: [devel] [PATCH 1/1] imm: syslog recent fevs evts when immnd down [#2898]

in the C code for collecting data and doing the logging. I have also added a new comment in the code. See new attached diff file Thanks Lennart > -Original Message- > From: Danh Vo > Sent: den 30 juli 2018 13:54 > To: Lennart Lund ; Hans Nordebäck > ; Gary Lee ; > Vu

Re: [devel] [PATCH 0/1] Review Request for imm: failed to load and import objects having system attributes in [#2897] V2

nal Message- > From: Vu Minh Nguyen > Sent: den 25 juli 2018 12:11 > To: Hans Nordebäck ; Lennart Lund > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 0/1] Review Request for imm: failed to load and import > objects having syst

Re: [devel] [PATCH 1/1] imm: syslog recent fevs evts when immnd down [#2898]

gt; To: Hans Nordebäck ; Lennart Lund > ; Gary Lee ; Vu > Minh Nguyen > Cc: opensaf-devel@lists.sourceforge.net; Danh Cong Vo > > Subject: [PATCH 1/1] imm: syslog recent fevs evts when immnd down > [#2898] > > An enhancement for IMM to print out 5 last FEVS events into sys

Re: [devel] [PATCH 0/1] Review Request for imm: do not purge sync request on client having critical CCB [#2889]

CRITICAL also means that the CCB is in a critical state and abort is not allowed IMM_CCB_CRITICAL = 9, // Unilateral abort no longer allowed (except by PBE). /Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 6 juli 2018 08:19 > To: Hans Nordebäck ; Lennar

Re: [devel] [PATCH 0/1] Review Request for osaf: update for saflog in case saLogWriteLogAsync with BAD_HANDLE [#2886]

is actually done and there is no information if logging fail. I suggest adding this information. /Lennart > -Original Message- > From: Canh Van Truong > Sent: den 2 juli 2018 12:24 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Canh Van T

Re: [devel] [PATCH 1/1] log: fix saLogFilterSetCallbackT_03 fails [#2875]

Ack /Lennart > -Original Message- > From: Canh Van Truong > Sent: den 14 juni 2018 08:14 > To: Lennart Lund ; Vu Minh Nguyen > > Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong > > Subject: [PATCH 1/1] log: fix saLogFilterSetCallbackT_03 fails [#2875

Re: [devel] [PATCH 1/1] smf: Fix failed rollback of DELETE/MODIFY CCB with originally empty attributes [#2877]

Hi Nguyen, Ack Thanks Lennart > -Original Message- > From: Nguyen Luu > Sent: den 21 juni 2018 15:07 > To: Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net; Nguyen Tran Khoi Luu > > Subject: [PATCH 1/1] smf: Fix failed rollback of DELETE/MODIFY CCB wi

Re: [devel] [PATCH 1/1] imm: fix failure to import file containing existing long dn object [#2874]

Hi Vu, Ack. Have not tested. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 19 juni 2018 10:50 > To: Lennart Lund ; Hans Nordebäck > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH 1/1] imm: fi

Re: [devel] [PATCH 1/1] imm: fix failure to import file containing existing long dn object [#2874]

ed patch (can be applied on your review branch) Thanks Lennart > -Original Message- > From: Vu Minh Nguyen > Sent: den 19 juni 2018 10:50 > To: Lennart Lund ; Hans Nordebäck > ; Gary Lee > Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen > > Subject: [PATCH

Re: [devel] [PATCH 1/1] imm: fix failure to import file containing existing long dn object [#2874]

Hi Vu, Please see my answers [Lennart] Thanks Lennartt > -Original Message- > From: Vu Minh Nguyen > Sent: den 19 juni 2018 07:20 > To: Lennart Lund ; Gary Lee > ; Hans Nordebäck > > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [devel] [PATCH 1/1] im

Re: [devel] [PATCH 1/1] imm: fix failure to import file containing existing long dn object [#2874]

Hi Vu, Your solution will probably work but is a bit problematic. The actual problem is that state is an in-parameter and in this case state->objectName is changed by the createImmObject() function and this change is without any meaning in the place where createImmObject() is called.

Re: [devel] [PATCH 0/1] Review Request for ntf: restart ntfimcnd if operation invoker name is missing [#2859]

Hi, Ack with comments. See attached diff file Thanks Lennart > -Original Message- > From: Hoa Le > Sent: den 4 juni 2018 07:07 > To: Minh Hon Chau ; Lennart Lund > > Cc: opensaf-devel@lists.sourceforge.net; Hoa Le > Subject: [PATCH 0/1] Review Request for

Re: [devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

in SMF is that doImmOperation() is also contains rollback handling (creation of additional data stores that has to be deleted). Thanks Lennart From: Nguyen Luu Sent: den 7 juni 2018 07:19 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] smf: Validation error

Re: [devel] [PATCH 1/1] log: fix restore ref counter for deleted stream [#2870]

n 6 juni 2018 10:27 > To: Canh Van Truong ; Lennart Lund > > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 1/1] log: fix restore ref counter for deleted stream > [#2870] > > Hi Canh, > > I forgot that patch. Just reviewed it. Thanks. > > Anyway, I will pus

[devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

SMF imm operation lists may contain duplicate create operations. Fix, rollback data shall not be stored for duplicate operations and duplicate operations shall not be added to the CCB. Fix, crash in SmfUtil::doImmoperation if the CCB fails --- opensaf.spec.in | 3

[devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

--- Second review. Fixed review comments revision 8eb84b8681e74de405fca1840c7aa482b99cf518 Author: Lennart Lund Date: Tue, 5 Jun 2018 08:50:35 +0200 smf: Validation error for rollback CCB and a related core dump [#2858] SMF imm operation lists may contain duplicate create operations. Fix, rol

Re: [devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

Hi Nguyen, Yes, I will use this information and check this. Maybe some sort of internal length check is needed in order to prevent this kind of assert. Thanks Lennart From: Nguyen Luu Sent: den 1 juni 2018 09:55 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0/1

Re: [devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

that has anything to do with this. Can you please help look into this. The only information I have got is the backtrace in this mail-thread. I will continue looking for possible problems based on the backtrace. Thanks Lennart From: Nguyen Luu Sent: den 1 juni 2018 05:39 To: Lennart Lund Cc

Re: [devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

Hi Nguyen, Attached is a diff with your comments still in there and my answers tagged [Lennart]. I have also kept your uncommented fixes. If you ack this I will use the patch with review comments removed. Thanks Lennart From: Nguyen Luu Sent: den 31 maj 2018 11:10 To: Lennart Lund Cc

Re: [devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

is not in the IMM model. The test of course fail but no coredump. The fail happen in a controlled and predictable way. What kind of system are you using? Thanks Lennart From: Nguyen Luu Sent: den 31 maj 2018 11:10 To: Lennart Lund Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0/1] Review

[devel] [PATCH 0/1] Review Request for smf: Validation error for rollback CCB and a related core dump [#2858]

descriptor is not added. The ccb decriptor AddCreate() method will also return false if a create descriptor is not added. See ../imm_modify_config/immccb.h revision cf93518e220de4e0b9053d46850d926ef0293f33 Author: Lennart Lund Date: Tue, 29 May 2018 15:47:05 +0200 smf: Validation error for ro

[devel] [PATCH 1/1] smf: Validation error for rollback CCB and a related core dump [#2858]

SMF imm operation lists may contain duplicate create operations. Fix, rollback data shall not be stored for duplicate operations and duplicate operations shall not be added to the CCB. Fix, crash in SmfUtil::doImmoperation if the CCB fails --- opensaf.spec.in | 3

Re: [devel] [PATCH 1/1] smf: Add capability to redo CCBs that fail [#1398]

have removed the original patch from the mail thread to reduce the message size) Thanks, Nguyen On 5/14/2018 8:13 PM, Lennart Lund wrote: Hi Nguyen, Attached patch contains all fixes. Can be applied on the review request. I will not send out a new review request unless Hans will find something t

Re: [devel] [PATCH 1/1] ntf: Don't use old style SaNameT with 255 chars DN in ntfimcnd [#2850]

Ack Thanks Lennart > -Original Message- > From: Hoa Le [mailto:hoa...@dektech.com.au] > Sent: den 14 maj 2018 11:17 > To: Minh Hon Chau <minh.c...@dektech.com.au>; Lennart Lund > <lennart.l...@ericsson.com>; srinivas.mangip...@oracle.com > Cc: opensaf-devel

Re: [devel] [PATCH 0/1] Review Request for smfd: Remove duplicate DU, AU on SU or comp level in one-step upgrade V3 [#2227]

Ack Thanks Lennart > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] > Sent: den 13 maj 2018 07:01 > To: Lennart Lund <lennart.l...@ericsson.com> > Cc: opensaf-devel@lists.sourceforge.net; Nguyen Tran Khoi Luu > <nguyen.tk@dektec

Re: [devel] [PATCH 0/1] Review Request for imm: fix PBE terminated when adding data with duplicated values [#2422]

nal Message- > From: Danh Vo [mailto:danh.c...@dektech.com.au] > Sent: den 8 maj 2018 11:35 > To: ravisekhar.ko...@oracle.com; Hans Nordebäck > <hans.nordeb...@ericsson.com>; Zoran Milinkovic > <zoran.milinko...@ericsson.com>; Anders Widell > <anders.wid...@er

Re: [devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

hard to find intermittent problem. My conclusion: Keep the wait for termination logic and go for the simpler solution described above Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 9 maj 2018 10:30 > To: Lennar

Re: [devel] [PATCH 0/1] Review Request for smfd: Remove duplicate DU, AU on SU or comp level in one-step upgrade V2 [#2227]

Hi Nguyen See my comments [Lennart] in the attached diff file. Can be applied on your review repository. Thanks Lennart > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] > Sent: den 8 maj 2018 04:19 > To: Lennart Lund <lennart.l...@ericsson.

[devel] [PATCH 0/1] Review Request for smf: Add capability to redo CCBs that fail [#1398]

g/immccb.h revision c033a5cc90dd22e302b385d2eb7925190114d2c1 Author: Lennart Lund <lennart.l...@ericsson.com> Date: Mon, 7 May 2018 15:55:51 +0200 smf: Add capability to redo CCBs that fail [#1398] Refactoring "main" CCB handling. Is mainly affecting SmfImmOperation and doImmOpera

  1   2   3   4   5   6   7   >