n
Samples y
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 842d06c3a6787789b018221ed5ee43ee02f48e0d
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
The $piddir variable (containing path to amf_demo comp's pid file)
is missed to be defined in amf_demo_script.
This could lead to the amf_demo process not getting truely killed
in some cases when cleanup is called (e.g when invoking
saAmfComponentErrorReport()), leaving the process unmanaged by
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 92f39d85213eea901334dcdf3c6b3ac7669810d1
Author: Nguyen Luu <nguyen.tk@d
Valid environment variable should have the format 'var=value'.
AMF currently does not validate this format during CREATE CCBs
for comptype and comp objects (MODIFY allowed for comp after #2255)
related to saAmfxxxCmdEnv attribute.
Besides, the existing validation in avnd_comp_clc_cmd_execute()
is
-
revision a8676a873a86f9836e2a1a55e27c8f1acee0535f
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 2 Aug 2017 13:48:13 +0700
amfa: Fix saAmfComponentErrorClear_4 to return ERR_NOT_EXIST for non-exist comp
[#2540]
When called with a non-existing component name, saAmfComponentErrorClear
-
revision 5c481c9e0fb45afe6cb9c7ae838191ff68b64b48
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 2 Aug 2017 10:11:02 +0700
amfa: Fix saAmfPmStart_3 and saAmfResponse_4 to correctly return BAD_HANDLE
[#2539]
When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfR
12:51 PM, Nguyen Luu wrote:
When called with a non-existing component name,
saAmfComponentErrorClear_4
should return SA_AIS_ERR_NOT_EXIST instead of SA_AIS_ERR_BAD_OPERATION
as previously done.
---
src/amf/amfnd/err.cc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
When called with a non-existing component name, saAmfComponentErrorClear_4
should return SA_AIS_ERR_NOT_EXIST instead of SA_AIS_ERR_BAD_OPERATION
as previously done.
---
src/amf/amfnd/err.cc | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
-
revision 7d907166c175fef1ca5e1ddbb258a8b5d915a364
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 16 Aug 2017 14:48:56 +0700
amfa: Fix saAmfComponentErrorClear_4 to return ERR_NOT_EXIST for non-exist comp
[#2540]
When called with a non-existing component name, saAmfComponentErrorClear
7da04c1a07
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 11 Aug 2017 14:51:31 +0700
amfa: Fix api internal check to avoid fatal mutex unlock [#2548]
Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (ComponentRegister, Quiescin
Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (ComponentRegister, QuiescingComplete)
would crash the invoking process if that env variable was missed
to be set for some reason, as the agent lib tries, during cleanup,
to unlock a mutex which it
-
revision 2df1d81a8b76eebf0f7fe8df25bc942e00c4aa7f
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 11 Aug 2017 15:23:24 +0700
amfa: Fix saAmfComponentErrorClear_4 to return ERR_NOT_EXIST for non-exist comp
[#2540]
When called with a non-existing component name, saAmfComponentErrorClear
When called with a non-existing component name, saAmfComponentErrorClear_4
should return SA_AIS_ERR_NOT_EXIST instead of SA_AIS_ERR_BAD_OPERATION
as previously done.
---
src/amf/amfnd/err.cc | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/amf/amfnd/err.cc
Hi,
I'd like to push this patch tomorrow if there are no more comments.
Thanks,
Nguyen
On 8/7/2017 2:00 PM, Nguyen Luu wrote:
Thanks, Hans and Anders, for your review.
About the code refactoring, should we do it in a separate ticket for
all AMF API's that use such constant and format
Valid environment variable should have the format 'var=value'.
AMF currently does not validate this format during CREATE CCBs
for comptype and comp objects (MODIFY allowed for comp after #2255)
related to saAmfxxxCmdEnv attribute.
Besides, the existing validation in avnd_comp_clc_cmd_execute()
is
-
revision 94ced33d5ee94030122a5431a3a131ed705736a6
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 28 Apr 2017 17:03:05 +0700
amf: validate env variable format set in comptype/comp objects [#2409]
Valid environment variable should have the format 'var=value'.
AMF currently does not validate this format du
?
And PRIx64 from instead of %llx?
/Regards HansN
On 08/02/2017 06:01 AM, Nguyen Luu wrote:
When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfResponse_4 should return SA_AIS_ERR_BAD_HANDLE
instead of SA_AIS_ERR_VERSION as previously done.
---
src/amf/agent
Hi,
Tested OK with legacy test. This change is similar to that in #2539
which was already pushed.
Thanks,
Nguyen
On 7/28/2017 4:41 PM, Nagendra Kumar wrote:
---
src/amf/agent/amf_agent.cc | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/amf/agent/amf_agent.cc
Suite 35 of ntftest requires long-dns support be enabled in the system.
If ntftest is run without any argument or specific test suite, suite 35
should be skipped if long-dns support is not enabled in the system.
---
src/ntf/apitest/test_ntf_imcn.c | 70 ++---
-
revision 46f41bc31bc2c25346916a816144ec7370da7373
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 19 May 2017 15:47:20 +0700
ntf: ntftest to check longDnsAllowed to run or skip suite 35 [#2463]
Suite 35 of ntftest requires long-dns support be enabled in the system.
If ntftest is run without any argu
-
revision 300b97ff3e52f29f9696a8b7e799af0880eb3b58
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 6 Oct 2017 13:49:30 +0700
pyosaf: Fix various pylint and PEP8 issues of pyosaf utils [#2603]
Complete diffstat:
--
python/pyosaf/utils/__init__.py | 48 +-
python/
Hi,
My comments:
Why not just simply reusing the decorate() function as below, instead of
inventing a new initialize_decorate() function only for zzzInitialize()
API? And why making 'version' a global variable when it is only used by
initialize()?
/
//@decorate//
//def
uot;y" above):
-
revision 02c0cbb22ae82801ada8e206d09427516a0a848b
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Thu, 19 Oct 2017 13:23:57 +0700
pyosaf: Fix various pylint and PEP8 issues of pyosaf utils [#2603]
- Fix most pylint a
---
python/pylintrc | 380
1 file changed, 380 insertions(+)
create mode 100644 python/pylintrc
diff --git a/python/pylintrc b/python/pylintrc
new file mode 100644
index 000..c1021a1
--- /dev/null
+++ b/python/pylintrc
@@ -0,0 +1,380
uot; above):
-
revision 51ec9f79721a03210f2a693eb37cd2e0698fd2a5
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Thu, 19 Oct 2017 14:46:58 +0700
pyosaf: Create a common pylint config file for pyosaf [#2636]
Added Files:
-
revision 78efa1ad3c85e245a3e262c84662a3f0354f4436
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 18 Oct 2017 11:56:06 +0700
pyosaf: Fix various pylint and PEP8 issues of pyosaf utils [#2603]
Complete diffstat:
--
python/pyosaf/utils/__init__.py | 84 +-
Hi Hans,
I have one comment inline marked with [Nguyen].
Thanks,
Nguyen
On 10/23/2017 7:40 PM, Hans Nordeback wrote:
---
Makefile.am | 9 +-
python/pylintrc | 381
2 files changed, 389 insertions(+), 1 deletion(-)
create
- Restore the previous printout format in the immxml tools, which
happened to be changed by ticket #2664 for better readability, in order
to maintain backward-compatibility for any user scripts/tools that have
been depending their check on the former printout.
- Some other minor updates
-
revision 17e0c8f44cb70a9763ef8b5b825f20b84d76627b
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 5 Dec 2017 13:52:39 +0700
imm: Restore printout format in immxml tools to maintain backward compatibility
[#2728]
- Restore the previous printout format in the immxml tools,
-
revision 17e0c8f44cb70a9763ef8b5b825f20b84d76627b
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 5 Dec 2017 13:52:39 +0700
imm: Restore printout format in immxml tools to maintain backward compatibility
[#2728]
- Restore the previous printout format in the immxml tools,
- Restore the previous printout format in the immxml tools, which
happened to be changed by ticket #2664 for better readability, in order
to maintain backward-compatibility for any user scripts/tools that have
been depending their check on the former printout.
- Some other minor updates
print_info_stderr("Note! Merge ignored %d objects "
- "(parsed: %d stored: %d)", diff_objects,
+ "(parsed:%d stored:%d)", diff_objects,
self.objects_parsed, len(self.objectList)
Thanks
- Refactor the ntfsend and ntfsubscribe python samples to make use of
the new pyosaf utils implementation of enhancement ticket #2602.
- Add a new ntfread sample to demonstrate usage of the new NtfReader
utils.
---
python/samples/ntfread | 411
python/samples/ntfsend
-
revision d56df110afd51411cb4fa75f6655ccca171e9f89
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 20 Dec 2017 15:23:32 +0700
pyosaf: Refactor NTF samples to make use of new pyosaf utils [#2707]
- Refactor the ntfsend and ntfsubscribe python samples to make use of
the new pyosaf util
-
revision fcec6c823a95bd8cf397edbe80600f3a129f6a87
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 20 Dec 2017 15:18:40 +0700
pyosaf: Fix some issues in NTF utils [#2682]
agent.py:
- Update some default values for notificationSend.
- Correct NtfAgent.finalize() to handle BAD_HANDLE error code.
producer.
agent.py:
- Update some default values for notificationSend.
- Correct NtfAgent.finalize() to handle BAD_HANDLE error code.
producer.py:
- Fix type conversion when assigning value of type SaNtfValueT.
- Keep the notification info for reuse after sending notification.
- Update the
agent.py:
- Update some default values for notificationSend.
- Correct NtfAgent.finalize() to handle BAD_HANDLE error code.
producer.py:
- Fix type conversion when assigning value of type SaNtfValueT.
- Keep the notification info for reuse after sending notification.
- Update the
Hi Hans,
Ack from me. Tested OK with both pylint-1.6.5 and pylint-1.7.4.
I just have one minor suggestion for the README. Please find it inline,
marked with [Nguyen].
Thanks,
Nguyen
On 11/17/2017 6:50 PM, Hans Nordeback wrote:
The output format can now be given, e.g.:
make pylint
Fix pylint and pep8 issues for the following Python files:
./tools/devel/dot/trace2dot
./tools/devel/review/patch-tokenize.py
./src/imm/tools/immxml-merge
./src/imm/tools/immxml-validate
./src/imm/tools/baseimm.py
---
src/imm/tools/baseimm.py | 376 ---
2: updated with pylint and pep8 corrections for the change added by
ticket #2663 ***
revision aad75ae26682701562f01b090ad7fdbe999a0746
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Mon, 20 Nov 2017 17:51:19 +0700
tools: Fix pylint and pep8 issues for tools written in Python [#2
Improved implementation of NTF pyosaf utils
The following comments shall be removed when the patch is pushed.
- This is the 2nd patch in the series of patches to improve the
implementation of the pyosaf utils of OpenSAF services.
- This patch is based on and uses the code change of the
-
revision 13615cadcdb4f433f00cb9504878312db68c41ad
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Wed, 25 Oct 2017 17:48:42 +0700
pyosaf: High level python interfaces for NTF [#2602]
Improved implementation of NTF pyosaf utils
The following comments shall be removed when the
Fix pylint and pep8 issues for the following Python files:
./tools/devel/dot/trace2dot
./tools/devel/review/patch-tokenize.py
./src/imm/tools/immxml-merge
./src/imm/tools/immxml-validate
./src/imm/tools/baseimm.py
---
src/imm/tools/baseimm.py | 376 ---
-
revision bcbf709cdd7a35ce0dfa7e2278092d2924740255
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 31 Oct 2017 17:14:49 +0700
tools: Fix pylint and pep8 issues for tools written in Python [#2664]
Fix pylint and pep8 issues for the following Python files:
./tools/devel/dot/trace2dot
-
revision dae399f6d30c7cac041282d8d3c5510838fdc3cd
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 8 May 2018 08:57:12 +0700
smfd: Remove duplicate DU/AU on SU/comp level in one-step upgrade [#2227]
This fix extends the previous one of #2209 which was on node level.
In particular, it is
This fix extends the previous one of #2209 which was on node level.
In particular, it is to eliminate any duplicate DU/AU on SU or component
level when merging forAddRemove and forModify/rolling procedures into a
single-step procedure for one-step upgrade execution mode.
---
Lennart
-Original Message-
From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au]
Sent: den 8 maj 2018 04:19
To: Lennart Lund <lennart.l...@ericsson.com>; syam.tall...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Nguyen Tran Khoi Luu
<nguyen.tk@dektech.com.au>
Subje
This fix extends, and also improves the previous one of #2209 which was
done for node level DU/AU. In particular, it eliminates any duplicate AU/DU
on SU and component level when merging forAddRemove and forModify/Rolling
procedures into a single-step procedure for one-step upgrade execution mode.
168ea43f78
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Sun, 13 May 2018 11:37:53 +0700
smfd: Remove duplicate DU/AU on SU/comp level in one-step upgrade [#2227]
This fix extends, and also improves the previous one of #2209 which was
done for node level DU/AU. In particular, i
ons according to
Google style guide so there may be a mix in some classes. However this file is
fixed.
SmfUtils.cc:
lldtest_delete is test code that should have been removed. Fixed
Thanks
Lennart
-Original Message-
From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au]
Sent: den 10 m
to be deleted).
Thanks
Lennart
*From:*Nguyen Luu
*Sent:* den 7 juni 2018 07:19
*To:* Lennart Lund
*Cc:* opensaf-devel@lists.sourceforge.net
*Subject:* Re: [PATCH 1/1] smf: Validation error for rollback CCB and
a related core dump [#2858]
Hi Lennart,
Ack from me for this new patch. Code
Hi Lennart,
I've reviewed and tested your patch.
- For the code review, please check comments in the attached diff file.
- For the testing, a core dump occurred when executing *test_ccbhdl*
(always reproducible). Test printouts, core dump backtrace, and syslog
as shown below. Looks like some
,
Attached is a diff with your comments still in there and my answers
tagged [Lennart].
I have also kept your uncommented fixes.
If you ack this I will use the patch with review comments removed.
Thanks
Lennart
*From:*Nguyen Luu
*Sent:* den 31 maj 2018 11:10
*To:* Lennart Lund
*Cc:* opensaf-devel
way.
What kind of system are you using?
Thanks
Lennart
*From:*Nguyen Luu
*Sent:* den 31 maj 2018 11:10
*To:* Lennart Lund
*Cc:* opensaf-devel@lists.sourceforge.net
*Subject:* Re: [PATCH 0/1] Review Request for smf: Validation error
for rollback CCB and a related core dump [#2858]
Hi Lenn
Hi Lennart,
Ack from me for this new patch. Code review only, no re-test.
Just a minor comment below for you to consider.
Since we will now not add the CreateDescriptor for an object to the CCB
if it already exists (CheckObjectExist::IsExisting() ==
CheckObjectExist::ReturnCode::kOk), do we
Hi Lennart,
Looks like you have by mistake commented on the wrong mail thread.
Thanks for the comments and suggestion anyway. I will consider them and
work on a new fix.
Thanks,
Nguyen
On 6/19/2018 9:30 PM, Lennart Lund wrote:
Hi Nguyen
The main issue that I saw is that you have added
-
revision 99484e9ba2fce28b997cfd6a0af571c99c876804
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Thu, 3 May 2018 09:47:12 +0700
smfd: Remove duplicate DU/AU on SU/comp level in one-step upgrade [#2227]
This fix extends the previous one of #2209 which was on node level.
In particular, it is
This fix extends the previous one of #2209 which was on node level.
In particular, it is to eliminate any duplicate DU/AU on SU or component
level when merging forAddRemove and forModify/rolling procedures into a
single-step procedure for one-step upgrade execution mode.
The fix also corrects
Improve the implementation of NTF pyosaf utils.
The following comments shall be removed when the patch is pushed.
- This is the 2nd patch in the series of patches to improve the
implementation of the pyosaf utils for OpenSAF services.
- This patch is based on and uses the code change of the
-
revision ba8ecebcd399440496f0baf5bf95e0dcdc9b64fd
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 27 Oct 2017 16:01:03 +0700
pyosaf: High level python interfaces for NTF [#2602]
Improve the implementation of NTF pyosaf utils.
The following comments shall be removed when the
-
revision e582f51adac286b9492fcc358468cbc0c7fdf2cb
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 27 Oct 2017 20:52:50 +0700
pyosaf: High level python interfaces for NTF [#2602]
Improve the implementation of NTF pyosaf utils
Added Files:
python/pyosaf/utils/ntf/agent.p
Improve the implementation of NTF pyosaf utils
---
python/pyosaf/saNtf.py| 4 +-
python/pyosaf/utils/ntf/__init__.py | 855 ++-
python/pyosaf/utils/ntf/agent.py | 500 ++
python/pyosaf/utils/ntf/producer.py | 711
Improve the implementation of NTF pyosaf utils
---
python/Makefile.am| 6 +-
python/pyosaf/saNtf.py| 4 +-
python/pyosaf/utils/ntf/__init__.py | 855 ++-
python/pyosaf/utils/ntf/agent.py | 500 ++
-
revision 6b05b92f072e0f247b52c656600ceaba0a852d86
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Fri, 27 Oct 2017 21:53:04 +0700
pyosaf: High level python interfaces for NTF [#2602]
Improve the implementation of NTF pyosaf utils
Added Files:
python/pyosaf/utils/ntf/agent.p
Hi Gary,
Thank you for your comments. Please see my corresponding answers below,
marked with [Nguyen].
Thanks,
Nguyen
On 2/7/2018 11:30 AM, Gary Lee wrote:
Hi Nguyen
Some comments below marked with [GL].
Thanks
Gary
On 6/2/18, 6:35 pm, "Nguyen Luu" <nguyen.tk@dektech.
Valid environment variable should have the format 'var=value'.
This validation shall now be done by AMF during CCB operations
on SaAmfCompType (CREATE) and SaAmfComp (CREATE/MODIFY) objects
regarding the saAmfxxxCmdEnv attribute.
---
src/amf/amfd/comp.cc | 59
-
revision de870ceadd4d59cacbacfad3cfed29b6e5fec615
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 13 Feb 2018 10:51:49 +0700
amf: Validate env variable format set in comptype/comp objects [#2409]
Valid environment variable should have the format 'var=value'.
This validation shall now be done b
uot; above):
-
revision bf0660bdc4010f77086dabb6ea2c5b0a77ca4070
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 6 Feb 2018 09:44:41 +0700
amf: validate env variable format set in comptype/comp objects [#2409]
Valid environment variable should have the f
Valid environment variable should have the format 'var=value'.
AMF currently does not validate this format during CREATE CCBs
for comptype and comp objects (MODIFY allowed for comp after #2255)
related to saAmfxxxCmdEnv attribute.
Besides, the existing validation in avnd_comp_clc_cmd_execute()
is
uot; above):
-
revision bf0660bdc4010f77086dabb6ea2c5b0a77ca4070
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 6 Feb 2018 09:44:41 +0700
amf: validate env variable format set in comptype/comp objects [#2409]
Valid environment variable should have the f
Valid environment variable should have the format 'var=value'.
AMF currently does not validate this format during CREATE CCBs
for comptype and comp objects (MODIFY allowed for comp after #2255)
related to saAmfxxxCmdEnv attribute.
Besides, the existing validation in avnd_comp_clc_cmd_execute()
is
Currently, if an upgrade DELETE or MODIFY CCB contains empty-value
attributes, SMF will create rollback data for those attributes with
the hard-coded "<_empty_>" string value. However, this hard-coded
string will actually make the later rollback fail, especially for
numeric-type attributes, when
uot; above):
-
revision 3d1d6e45cd49fabddcdab00ad998af7583090a20
Author: Nguyen Luu
Date: Thu, 21 Jun 2018 19:46:55 +0700
smf: Fix failed rollback of DELETE/MODIFY CCB with originally empty attributes
[#2877]
Currently, if an upgrade DELETE or MODIFY CCB contains empty-value
attri
Hi Thuan,
Ack from me.
Just a suggestion for more correct comment (in case there's only one
handle matching the callback label):
/* Descrease the cbk count */ => /* Remove the agent hdl from the cbk_list */
Thanks,
Nguyen
On 7/13/2018 10:52 AM, thuan.tran wrote:
Sometimes, callback agent
is critical problem since agent will miss a callback.
Also avoid smfnd is keeping waiting for agent response for that callback.
Please correct if I was wrong.
Best Regards,
Thuan (UFO – Unique FBI Opensaf)
CoreMW Maintenance, DEK VietNam
-Original Message-
From: Nguyen Luu
Sent: Wednesday
Hi,
One comment from me for the patch: With the new flow, the matched hdl
should be removed from the cbk_list if posting the message to the client
mailbox fails.
A general comment: The original issue happened because of a race
condition in which the smfa_cb was used in different threads
of SMFD, it crash mean SMFD crash (node reboot?), is there
any rollback trigger after that?
If it cannot, then I should handle posting fail as your comment.
Best Regards,
Thuan
-Original Message-
From: Nguyen Luu
Sent: Thursday, July 5, 2018 8:00 PM
To: Tran Thuan ; lennart.l
Thuan (UFO – Unique FBI Opensaf)
CoreMW Maintenance, DEK VietNam
-Original Message-----
From: Nguyen Luu
Sent: Friday, July 6, 2018 5:34 PM
To: Tran Thuan ; lennart.l...@ericsson.com; 'Gary Lee'
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1] smf: Increase cbk count b
Hi Thuan,
I also agree with Gary about removing assert(). Other changes look fine.
Thanks,
Nguyen
On 7/11/2018 12:52 PM, Gary Lee wrote:
Hi Thuan
Looks OK to me, but I would remove the assert. We shouldn't do that in library
code.
Thanks
Gary
On 10/7/18, 6:52 pm, "thuan.tran" wrote:
, Nguyen Luu wrote:
Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (ComponentRegister, QuiescingComplete)
would crash the invoking process if that env variable was missed
to be set for some reason, as the agent lib tries, during cleanup,
to unlock
Hi Lennart, Vijay,
Please help me review this patch whenever possible for you.
Thanks,
Nguyen
On 3/28/2018 3:07 PM, Nguyen Luu wrote:
Current handling of SMFND DOWN event does not take into account failed
SMFND UP event, which could eventually result in an inexact view of the
actual number
,
Ack with comments. See below [Lennart]
Thanks
Lennart
-Original Message-
From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au]
Sent: den 28 mars 2018 10:08
To: Lennart Lund <lennart.l...@ericsson.com>; vijay@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Nguyen T
Hi,
I intend to push this patch by the end of today if there are no more
comments.
Thanks,
Nguyen
On 4/6/2018 10:54 AM, Nguyen Luu wrote:
Hi Lennart,
Thank you for your comment.
You suggested that the changed files be reformatted following Google
Coding Style (i.e space-indented
Current handling of SMFND DOWN event does not take into account failed
SMFND UP event, which could eventually result in an inexact view of the
actual number of SMFND nodes in the cluster if, for example, a node
happened to be DOWN and UP twice, and the first UP event somehow failed.
---
Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (ComponentRegister, QuiescingComplete)
would crash the invoking process if that env variable was missed
to be set for some reason, as the agent lib tries, during cleanup,
to unlock a mutex which it
-
revision cbe183d7927cd53d6928611b91f5fcda5d939eee
Author: Nguyen Luu <nguyen.tk@dektech.com.au>
Date: Tue, 6 Mar 2018 13:14:52 +0700
amfa: Fix api internal check to avoid fatal mutex unlock [#2548]
Current check for the required setting of the SA_AMF_COMPONENT_NAME
env variable in some amf api's (C
Hi Hans,
Please help me review this patch whenever possible for you. It has been
on review for months.
Thanks,
Nguyen
On 12/20/2017 3:31 PM, Nguyen Luu wrote:
- Refactor the ntfsend and ntfsubscribe python samples to make use of
the new pyosaf utils implementation of enhancement ticket
uot; above):
-
revision 6a3ea7621b35c4562571f8dd6156ad03c1cd8a2e
Author: Nguyen Luu
Date: Wed, 20 Jun 2018 17:30:42 +0700
smf: Fix failed rollback of DELETE/MODIFY CCB with originally empty attributes
[#2877]
Currently, if an upgrade DELETE or MODIFY CCB contains empty-value
attri
Currently, if an upgrade DELETE or MODIFY CCB contains empty-value
attributes, SMF will create rollback data for those attributes with
the hard-coded "<_empty_>" string value. However, this hard-coded
string will actually make the later rollback fail, especially for
numeric-type attributes, when
89 matches
Mail list logo
