Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Alon Bar-Lev
Thanks. I did not commit this. :) On 4/25/08, Peter Stuge <[EMAIL PROTECTED]> wrote: > Alon, > > > On Thu, Apr 24, 2008 at 07:43:59PM +0300, Alon Bar-Lev wrote: > > +++ src/include/winconfig.h.in(working copy) > > @@ -67,11 +67,17 @@ > > #endif > > > > #ifndef S_IRUSR > > +#ifdef

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Peter Stuge
Alon, On Thu, Apr 24, 2008 at 07:43:59PM +0300, Alon Bar-Lev wrote: > +++ src/include/winconfig.h.in(working copy) > @@ -67,11 +67,17 @@ > #endif > > #ifndef S_IRUSR > +#ifdef S_IREAD > #define S_IRUSR S_IREAD > +#else > +#define S_IRUSR _S_IREAD > #endif > > #ifndef S_IWUSR > +#

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Alon Bar-Lev
On 4/25/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > Alon Bar-Lev: > > > Do you sure you not require O_BINARY in rutoken-tool? > > > O_BINARY is non-standard flag, but for generality... It is standard on Windows :) You cannot read/write DER or any binary without this. Alon ___

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Do you sure you not require O_BINARY in rutoken-tool? O_BINARY is non-standard flag, but for generality... opensc-0.11.4.trunk-r3491-fix_msvc_o_binary.diff.gz Description: application/gzip ___ opensc-devel mailing list opensc-devel@lis

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Alon Bar-Lev
On 4/25/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > Alon Bar-Lev: > > > So what caused the need to apply this in the first place? > > > I have not looked through change in winconfig.h.in and used > http://www.opensc-project.org/opensc/browser/trunk/src/tools/pkcs11-tool.c?rev=3489#

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: > So what caused the need to apply this in the first place? I have not looked through change in winconfig.h.in and used http://www.opensc-project.org/opensc/browser/trunk/src/tools/pkcs11-tool.c?rev=3489#L961 as a basis. > Is there an issue to fix? This is an attempt to solve a poss

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Alon Bar-Lev
On 4/25/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > > This is not required. > > > Right, current trunk is already true. So what caused the need to apply this in the first place? Is there an issue to fix? Should I apply the winconfig.h.in fixup? Alon. _

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-25 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: > Committed at rev 3490. Thanks! > This is not required. Right, current trunk is already true. > Anyway it looks like it is required only for MSVC. Yes, it's for MSVC only. ___ opensc-devel mailing list [email protected]

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-24 Thread Alon Bar-Lev
On Thursday 24 April 2008, Aktiv Co. Aleksey Samsonov wrote: > Patch for trunk revision 3489 is in attachment. > Committed at rev 3490. The opensc-tool open was not committed. As per: http://msdn2.microsoft.com/en-us/library/w7sa2b22(VS.71).aspx This is not required. Maybe you mean the follo

[opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-24 Thread Aktiv Co. Aleksey Samsonov
Patch for trunk revision 3489 is in attachment. opensc-0.11.4.trunk-r3489-fix_msvc_build.diff.gz Description: application/gzip ___ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-dev

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-18 Thread Alon Bar-Lev
Committed at rev#3478. On 4/18/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > Alon Bar-Lev: > > > Much better!!! > > Can you please rebase and send all your modifications as single patch? > > > > Patch for trunk revision 3477 is in attachment. > >

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-18 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Much better!!! Can you please rebase and send all your modifications as single patch? Patch for trunk revision 3477 is in attachment. opensc-0.11.4.trunk-r3477-0.11.4.trunk-r3477_rutoken-0.3.3.diff.gz Description: application/gzip ___

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-17 Thread Alon Bar-Lev
Much better!!! Can you please rebase and send all your modifications as single patch? Thanks! On 4/17/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > > Alon Bar-Lev: > > > > > > Patch opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff > (for > > > > opensc-0.11.4.trunk-r3476-0.11.4.trunk

[opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-17 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Patch opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff (for opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff) is draft. This patch solves the problem with exported functions. (Instead of pkcs15-prkey-rutoken.c it'll be rutoken-prkey.h). If this solution is better than

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-16 Thread Alon Bar-Lev
On 4/16/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > Alon Bar-Lev: > > Please also explain why the pkcs15-prkey-rutoken.c is needed, there is > > not prkey specific file for any other card. > > This file is necessary to avoid redoubling of code. I don't understand why the emulat

[opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-16 Thread Aktiv Co. Aleksey Samsonov
On Fri, Apr 11, 2008 at 11:40 AM, Aktiv Co. Aleksey Samsonov wrote: We are going to release tested patch for the current version of your code in a couple of days. It fixes a number of bugs in Rutoken code and changes card-rutoken.c file to meet OpenSC coding standards. Patch for trunk revision

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-11 Thread Alon Bar-Lev
On 4/11/08, Ludovic Rousseau <[EMAIL PROTECTED]> wrote: > > We are going to release tested patch for the current version of your code > > in a couple of days. It fixes a number of bugs in Rutoken code and changes > > card-rutoken.c file to meet OpenSC coding standards. Great! Please also expl

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-11 Thread Ludovic Rousseau
Hello, I add the opensc-devel list in Cc: On Fri, Apr 11, 2008 at 11:40 AM, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote: > We have to maintain "our" version which we ship to our clients with higher > priority, but we surely interested in applying the fixes we have in "our" > version of

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-08 Thread Andrew V. Stepanov
Hello! Thank you for notice about current problems with supporting ruToken in opensc/openct. I take a position to support ruToken devices in AltLinux distro. http://git.altlinux.org/people/stanv/packages/openct_current.git http://git.altlinux.org/people/stanv/packages/opensc_current.git are reposi

Re: [opensc-devel] OpenSC svn build on Windows with rutoken

2008-04-07 Thread Alon Bar-Lev
On Tuesday 08 April 2008, Douglas E. Engert wrote: > Attached changes to: > > (1) use the exports for opensc-pkcs11.dll, onepin-opensc-pkcs11.dll, > and pkcs11-spy.dll > > (2) don't link common.lib with scconf.lib, to avoid duplicate messages > later. > > (3) add piv-tool to op

Re: [opensc-devel] OpenSC svn build on Windows with rutoken

2008-04-07 Thread Douglas E. Engert
Attached changes to: (1) use the exports for opensc-pkcs11.dll, onepin-opensc-pkcs11.dll, and pkcs11-spy.dll (2) don't link common.lib with scconf.lib, to avoid duplicate messages later. (3) add piv-tool to openssl_programs. These all work with your changes below. Alon Bar-Lev w

Re: [opensc-devel] OpenSC svn build on Windows with rutoken

2008-04-07 Thread Douglas E. Engert
Alon Bar-Lev wrote: > On 4/7/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> Attached are the latest mode to OpenSC svn 3462 to use the Makefile.mak >> files to build on Windows. > > Looks much better! > >> Index: src/include/winconfig.h >> ===

Re: [opensc-devel] OpenSC svn build on Windows with rutoken

2008-04-07 Thread Alon Bar-Lev
On 4/7/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > > Attached are the latest mode to OpenSC svn 3462 to use the Makefile.mak > files to build on Windows. Looks much better! > Index: src/include/winconfig.h > === > --- src/

[opensc-devel] OpenSC svn build on Windows with rutoken

2008-04-07 Thread Douglas E. Engert
Attached are the latest mode to OpenSC svn 3462 to use the Makefile.mak files to build on Windows. I got rutoken to compile, and took out the #ifdef's I had in last week. The rutoken programmer declared some variables in the middle of a block rather then having all the declare statements at the

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-05 Thread Ludovic Rousseau
Hello Andrew and al., You submitted patches to add support of the rutoken in OpenSC and OpenCT in [1]. We have problems maintaining your code and you do not participate in the discussion on the opensc-devel mailing list. I included your code in the official OpenSC and maybe it was a mistake (I h

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Alon Bar-Lev
On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > > CSP11 will not be provided as it is not maintained and it is low quality. > > If you care about Windows, please help us and (I guess your users) find a > better > > working solution we can provide. > > > > We were testing with IdAlly, and

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Alon Bar-Lev
On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > > > #include > > > +#define WIN32_LEAN_AND_MEAN > > > > > > > This should go into Makefiles and not in include file, as it should > > effect the whole > > compilation process in Windows. > > > > It does, as as the winconfig.h is the conf

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Douglas E. Engert
Alon Bar-Lev wrote: > On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> With your changes today to svn for internal-winscard.h, and reader-pcsc.c >> and the attached change to src/include/winconfig.h all the tools work. >> >> WIN32_LEAN_AND_MEAN, and #include work with reader-pcsc.c

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Alon Bar-Lev
On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > With your changes today to svn for internal-winscard.h, and reader-pcsc.c > and the attached change to src/include/winconfig.h all the tools work. > > WIN32_LEAN_AND_MEAN, and #include work with reader-pcsc.c Great! Please keep small ca

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Douglas E. Engert
With your changes today to svn for internal-winscard.h, and reader-pcsc.c and the attached change to src/include/winconfig.h all the tools work. WIN32_LEAN_AND_MEAN, and #include work with reader-pcsc.c If you can generate versions.rc and the winconfig.h files during automake, that would be g

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Douglas E. Engert
Peter Stuge wrote: > On Fri, Apr 04, 2008 at 07:47:36PM +0300, Alon Bar-Lev wrote: >>> The complexity issue works both ways. By doing cross compiling >>> you have now introduced additional packages to build it, using >>> derived header files. >> I don't understand. > > I think he means that in

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Peter Stuge
On Fri, Apr 04, 2008 at 07:43:09PM +0200, Peter Stuge wrote: > On Windows this means using MinGW. Just to be extra clear; MinGW (Minimalist GNU for Windows) at http://mingw.org/ http://prdownloads.sf.net/mingw/MinGW-5.1.3.exe?download and optionally also: http://prdownloads.sf.net/mingw/MSYS-1

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Peter Stuge
On Fri, Apr 04, 2008 at 07:47:36PM +0300, Alon Bar-Lev wrote: > > The complexity issue works both ways. By doing cross compiling > > you have now introduced additional packages to build it, using > > derived header files. > > I don't understand. I think he means that in the current state which

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Douglas E. Engert
Alon Bar-Lev wrote: > PLEASE don't use HTML mail. > > On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> I will for now, at least until you can get the cross compile working, >> and can produce a SCB with installer, that will run on XP and Vista, >> for use by CSPs for login, IE and p

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Alon Bar-Lev
PLEASE don't use HTML mail. On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > I will for now, at least until you can get the cross compile working, > and can produce a SCB with installer, that will run on XP and Vista, > for use by CSPs for login, IE and pkcs11 for other browsers and ma

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-04 Thread Douglas E. Engert
Alon Bar-Lev wrote: > On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> This is the first of two messages, dealing with building OpenSC on Windows >> using the win32/Makefile.mak files as has been done in the past. As I had >> stated before, I would like to see OpenSC built on Windows

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-04 Thread Douglas E. Engert
Alon Bar-Lev wrote: > On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: >> Both rutoken and WinCrypt.h define: _RSAPUBKEY, RSAPUBKEY, _PUBLICKEYSTRUC, >> PUBLICKEYSTRUC and BLOBHEADER. It looks like the structures where copied >> from >> the winCrypt.h and BYTE replaced with u8, WORD re

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-04 Thread Douglas E. Engert
Peter Stuge wrote: > On Thu, Apr 03, 2008 at 05:02:24PM -0500, Douglas E. Engert wrote: >> The first problem deals with the rutoken modules which define many >> duplicate names. It appears some code was copied from the Windows >> header file: WinCrypt.h > > .. > >> Both rutoken and WinCrypt.h d

Re: [opensc-devel] OpenSC svn build on Windows

2008-04-03 Thread Alon Bar-Lev
On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > > This is the first of two messages, dealing with building OpenSC on Windows > using the win32/Makefile.mak files as has been done in the past. As I had > stated before, I would like to see OpenSC built on Windows using the > Windows > c

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-03 Thread Alon Bar-Lev
On 4/4/08, Douglas E. Engert <[EMAIL PROTECTED]> wrote: > Both rutoken and WinCrypt.h define: _RSAPUBKEY, RSAPUBKEY, _PUBLICKEYSTRUC, > PUBLICKEYSTRUC and BLOBHEADER. It looks like the structures where copied from > the winCrypt.h and BYTE replaced with u8, WORD replaced with uint16_t, and > DW

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-03 Thread Peter Stuge
On Thu, Apr 03, 2008 at 05:02:24PM -0500, Douglas E. Engert wrote: > The first problem deals with the rutoken modules which define many > duplicate names. It appears some code was copied from the Windows > header file: WinCrypt.h .. > Both rutoken and WinCrypt.h define: _RSAPUBKEY, RSAPUBKEY, > _

[opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-03 Thread Douglas E. Engert
There were too many problems with the rutoken modules so I left them out of the Windows build. The first problem deals with the rutoken modules which define many duplicate names. It appears some code was copied from the Windows header file: C:\Program Files\Microsoft Visual Studio 8\VC\PlatformSD

[opensc-devel] OpenSC svn build on Windows

2008-04-03 Thread Douglas E. Engert
This is the first of two messages, dealing with building OpenSC on Windows using the win32/Makefile.mak files as has been done in the past. As I had stated before, I would like to see OpenSC built on Windows using the Windows compiler header files and dlls. I understand some would like to convert