Re: [Openvpn-devel] [PATCH 5/5] auth-gen-token: Authenticate generated auth-tokens when client re-authenticates

2016-10-19 Thread David Sommerseth
On 19/10/16 22:12, Steffan Karger wrote: > Hi, > > This feature looks very useful, and the code seems to work well. Aside > from some nitpicking, I do have some questions on the bigger picture: Thanks a lot! > On 13-10-16 21:59, David Sommerseth wrote: >> On a server with --auth-gen-token enabl

[Openvpn-devel] [PATCH applied] Re: Remove verbose msg() from send_push_reply()

2016-10-19 Thread Gert Doering
ACK. Not Lev to blaim, I put that debug there - back in the "how do I get ifconfig-ipv6 into that buffer?" times :-) - but it definitely makes sense to kick it. Your patch has been applied to the master branch - it would make sense to remove that in release/2.3 as well, but the surrounding code i

[Openvpn-devel] [PATCH applied] Re: Fix use-after-free bug in prepare_push_reply()

2016-10-19 Thread Gert Doering
Your patch has been applied to the master branch. commit 83fdae3e9c482a3d3ceca484d96e1241359a0450 Author: Steffan Karger Date: Wed Oct 19 21:24:20 2016 +0200 Fix use-after-free bug in prepare_push_reply() Signed-off-by: Steffan Karger Acked-by: Gert Doering Message-Id: <1

[Openvpn-devel] [PATCH applied] Re: Fix use-after-free bug in prepare_push_reply()

2016-10-19 Thread Gert Doering
Uh... re-sending. Too late. *ACK* - patch totally matches explanation, and both make sense. Your patch has been applied to the master branch. commit 83fdae3e9c482a3d3ceca484d96e1241359a0450 Author: Steffan Karger Date: Wed Oct 19 21:24:20 2016 +0200 Fix use-after-free bug in prepare_pus

Re: [Openvpn-devel] [PATCH 5/5] auth-gen-token: Authenticate generated auth-tokens when client re-authenticates

2016-10-19 Thread Steffan Karger
Hi, This feature looks very useful, and the code seems to work well. Aside from some nitpicking, I do have some questions on the bigger picture: On 13-10-16 21:59, David Sommerseth wrote: > On a server with --auth-gen-token enabled, the server will have created > a random token and pushed it to

[Openvpn-devel] [PATCH] Fix use-after-free bug in prepare_push_reply()

2016-10-19 Thread Steffan Karger
This was introduced by commit dfd3513e, which changes the push_cipher memory allocation from the options gc to a temporary gc. For the ciphername in the options structure, which has to be available longer, change this back to using the options gc. Apologies for not spotting this during patch revi

[Openvpn-devel] [PATCH] Remove verbose msg() from send_push_reply()

2016-10-19 Thread Steffan Karger
Probably committed by lev by accident, and then overlooked by me during review. Signed-off-by: Steffan Karger --- src/openvpn/push.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/openvpn/push.c b/src/openvpn/push.c index ff374c8..54726e7 100644 --- a/src/openvpn/push.c +++ b/src/openv

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Samuli Seppänen
Il 19/10/2016 19:27, Selva Nair ha scritto: > > On Wed, Oct 19, 2016 at 11:46 AM, Samuli Seppänen > wrote: > > The "%USERPROFILE%\Appdata" folder seems to be for "files generated > by applications" as SviMik said: > >

[Openvpn-devel] Fwd: Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Selva Nair
On Wed, Oct 19, 2016 at 11:46 AM, Samuli Seppänen wrote: > The "%USERPROFILE%\Appdata" folder seems to be for "files generated by > applications" as SviMik said: > > >

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread SviMik
> Maybe add an 'open config folder' button/link to openvpn-gui? Sounds like a good idea in any case! Why it hasn't been done, like, 10 years ago? :D I spent sooo much time opening the C:\Program Files\OpenVPN\config ! But my vote is still for %USERPROFILE%. -- SviMik

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread debbie10t
On 19/10/16 14:04, Samuli Seppänen wrote: > Hi, > > Three directory alternatives have been proposed: > > %USERPROFILE%\OpenVPN\config (current approach) > %APPDATA%\OpenVPN\config > %USERPROFILE%\.openvpn\config > I find the whole idea of "Hiding things from users" to be an unnecessary and poin

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Selva Nair
On Wed, Oct 19, 2016 at 11:17 AM, Steffan Karger wrote: > On 19 October 2016 at 17:14, Samuli Seppänen wrote: > > SviMik had a very good point against using %APPDATA%: it is a hidden > > folder. At least on Windows 7 it seems to be hidden at the filesystem > > level, because no tools seem to see

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Samuli Seppänen
Il 19/10/2016 18:17, Steffan Karger ha scritto: > On 19 October 2016 at 17:14, Samuli Seppänen wrote: >> SviMik had a very good point against using %APPDATA%: it is a hidden >> folder. At least on Windows 7 it seems to be hidden at the filesystem >> level, because no tools seem to see it. However,

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread SviMik
> Three directory alternatives have been proposed: > > %USERPROFILE%\OpenVPN\config (current approach) > %APPDATA%\OpenVPN\config > %USERPROFILE%\.openvpn\config > I vote for %USERPROFILE%, as it is more intuitive. %APPDATA% seems to be a folder for a files generated solely by software, and no

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Selva Nair
Hi, Samuli Seppänen wrote: > >> Looks like there is a general consensus on this. If so, I will post a >> patch later today to use %APPDATA% >> >> Selva >> > > SviMik had a very good point against using %APPDATA%: it is a hidden > folder. At least on Windows 7 it seems to be hidden at the filesys

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Samuli Seppänen
Il 19/10/2016 18:08, Selva Nair ha scritto: > Hi, > > Am 19.10.16 um 15:04 schrieb Samuli Seppänen: > > > Hi, > > > > While preparing OpenVPN 2.4-alpha1 release the discussion about > > user-specific OpenVPN configuration files came up again. To give some > > background, OpenVPN

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Steffan Karger
On 19 October 2016 at 17:14, Samuli Seppänen wrote: > SviMik had a very good point against using %APPDATA%: it is a hidden > folder. At least on Windows 7 it seems to be hidden at the filesystem > level, because no tools seem to see it. However, doing a > >cd $HOME\Appdata > > in Powershell wi

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Selva Nair
Hi, Am 19.10.16 um 15:04 schrieb Samuli Seppänen: > > Hi, > > > > While preparing OpenVPN 2.4-alpha1 release the discussion about > > user-specific OpenVPN configuration files came up again. To give some > > background, OpenVPN-GUI can now delegate privileged operations (e.g. > > route adding) to

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Arne Schwabe
Am 19.10.16 um 15:04 schrieb Samuli Seppänen: > Hi, > > While preparing OpenVPN 2.4-alpha1 release the discussion about > user-specific OpenVPN configuration files came up again. To give some > background, OpenVPN-GUI can now delegate privileged operations (e.g. > route adding) to the OpenVPN

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread David Sommerseth
On 19/10/16 15:04, Samuli Seppänen wrote: > Hi, > > While preparing OpenVPN 2.4-alpha1 release the discussion about > user-specific OpenVPN configuration files came up again. To give some > background, OpenVPN-GUI can now delegate privileged operations (e.g. > route adding) to the OpenVPN Inter

Re: [Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Gert Doering
Hi, On Wed, Oct 19, 2016 at 04:04:30PM +0300, Samuli Seppänen wrote: > *NIX guys would love %USERPROFILE%\.openvpn\config, and it kind of makes > sense for a cross-platform app, but Windows guys would probably be at loss. Now *this* does not make sense on Windows - and since this is about windo

[Openvpn-devel] Proper location for user-specific OpenVPN configuration files used by OpenVPN-GUI?

2016-10-19 Thread Samuli Seppänen
Hi, While preparing OpenVPN 2.4-alpha1 release the discussion about user-specific OpenVPN configuration files came up again. To give some background, OpenVPN-GUI can now delegate privileged operations (e.g. route adding) to the OpenVPN Interactive Service. This means that normal users are now

Re: [Openvpn-devel] [PATCH 0/3] implement crl-persist logic

2016-10-19 Thread Antonio Quartulli
On Wed, Oct 19, 2016 at 02:22:28PM +0800, Antonio Quartulli wrote: > Hello OpenVPN community, > not sure if this is any helpful, but I have also prepared a branch with these changes on github at https://github.com/ordex/openvpn/tree/crl-persist Maybe somebody prefers a comfy webbrowser when revi