[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-03 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, stipa, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#6). The following approvals got

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-03 Thread d12fk (Code Review)
Attention is currently required from: cron2, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters ..

[Openvpn-devel] [M] Change in openvpn[master]: cmake: symlink whole build dir not just .json file

2024-01-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/501?usp=email to review the following change. Change subject: cmake: symlink whole build dir not just .json

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#5). Change subject: Windows: enforce

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-10 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#4). Change subject: Windows: enforce 'block-local' with

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#3). Change subject: Windows: enforce 'block-local' with

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-09 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-08 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=email to review the following change. Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-19 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#4). The following approvals got outdated and were

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
d12fk has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/484?usp=email ) Change subject: cmake: build native binaries with debug info .. Abandoned -- To view, visit

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/484?usp=email ) Change subject: cmake: build native binaries with debug info ..

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: create and link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to look at the new patch set (#2). Change subject: cmake: create and link

[Openvpn-devel] [XS] Change in openvpn[master]: create and (sym)link compile_commands.json file

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/483?usp=email to review the following change. Change subject: create and (sym)link compile_commands.json file

[Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email to review the following change. Change subject: cmake: build native binaries with debug info

[Openvpn-devel] [S] Change in openvpn[master]: tun.c: don't attempt to delete DNS and WINS servers if they're not set

2023-12-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/482?usp=email ) Change subject: tun.c: don't attempt to delete DNS and WINS servers if they're not set

[Openvpn-devel] [M] Change in openvpn[master]: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patch...

2023-09-25 Thread d12fk (Code Review)
Attention is currently required from: cron2, flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/361?usp=email ) Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-22 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt ..

[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6

[Openvpn-devel] [M] Change in openvpn[release/2.6]: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to relea...

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/311?usp=email ) Change subject: vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/312?usp=email ) Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Mock openvpn_exece on win32 also for test_tls_crypt

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/313?usp=email ) Change subject: Mock openvpn_exece on win32 also for test_tls_crypt

[Openvpn-devel] [XS] Change in openvpn[release/2.6]: buffer: use memcpy in buf_catrunc

2023-09-18 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/314?usp=email ) Change subject: buffer: use memcpy in buf_catrunc .. Patch Set 1:

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has removed a vote from this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional ..

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional ..

[Openvpn-devel] [M] Change in openvpn[master]: dns option: make server id/priority optional

2023-09-12 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/40?usp=email ) Change subject: dns option: make server id/priority optional .. Patch Set 5: