[Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite

2024-06-05 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/643?usp=email ) Change subject: Add t_server_null test suite .. Patch Set 2:

[Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite

2024-06-05 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/643?usp=email ) Change subject: Add t_server_null test suite .. Patch Set 2:

[Openvpn-devel] [S] Change in openvpn[master]: LZO: do not use lzoutils.h macros

2024-06-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/642?usp=email to review the following change. Change subject: LZO: do not use lzoutils.h macros

[Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd

2024-06-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=email to review the following change. Change subject: test_user_pass: Fix building with --enable-systemd

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-06-04 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config ..

[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: Check fatal errors for empty username/password

2024-05-17 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email to look at the new patch set (#11). Change subject: test_user_pass: Check fatal errors for empty username/password

[Openvpn-devel] [M] Change in openvpn[master]: tun: use is_tun_p2p more consistently

2024-05-13 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/380?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-05-13 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email to look at the new patch set (#4). Change subject: configure: Try to detect LZO with pkg-config

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-05-13 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 8:

[Openvpn-devel] [XS] Change in openvpn[master]: Support OpenBSD with cmake

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/585?usp=email ) Change subject: Support OpenBSD with cmake .. Patch Set 1:

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config ..

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email to look at the new patch set (#3). Change subject: configure: Try to detect LZO with pkg-config

[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 6:

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-05-08 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 6:

[Openvpn-devel] [XS] Change in openvpn[master]: Only run coverity scan in OpenVPN/OpenVPN repository

2024-05-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/583?usp=email ) Change subject: Only run coverity scan in OpenVPN/OpenVPN repository ..

[Openvpn-devel] [XS] Change in openvpn[master]: Repeat the unknown command in errors from management interface

2024-05-06 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/584?usp=email ) Change subject: Repeat the unknown command in errors from management interface

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-05-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-05-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions

[Openvpn-devel] [L] Change in openvpn[master]: Remove openvpn_snprintf and similar functions

2024-05-03 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email ) Change subject: Remove openvpn_snprintf and similar functions

[Openvpn-devel] [S] Change in openvpn[master]: Replace macos11 with macos14 in github runners

2024-05-02 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/582?usp=email ) Change subject: Replace macos11 with macos14 in github runners .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/560?usp=email ) Change subject: Remove custom TLS 1.0 PRF implementation only used by LibreSSL/wolfSSL

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 5:

[Openvpn-devel] [XS] Change in openvpn[master]: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/581?usp=email ) Change subject: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email ) Change subject: Implement support for larger packet counter sizes ..

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 1: (1

[Openvpn-devel] [L] Change in openvpn[master]: Remove OpenSSL 1.0.2 support

2024-04-30 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/559?usp=email ) Change subject: Remove OpenSSL 1.0.2 support .. Patch Set 1:

[Openvpn-devel] [S] Change in openvpn[master]: Only schedule_exit() once

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email ) Change subject: Only schedule_exit() once .. Patch Set 2:

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config first

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/556?usp=email ) Change subject: configure: Try to detect LZO with pkg-config first ..

[Openvpn-devel] [S] Change in openvpn[master]: Address schedule_exit() review comments

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/557?usp=email ) Change subject: Address schedule_exit() review comments ..

[Openvpn-devel] [S] Change in openvpn[master]: Address schedule_exit() review comments

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/557?usp=email ) Change subject: Address schedule_exit() review comments ..

[Openvpn-devel] [S] Change in openvpn[master]: Address schedule_exit() review comments

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/557?usp=email ) Change subject: Address schedule_exit() review comments ..

[Openvpn-devel] [M] Change in openvpn[master]: configure: update old copy of pkg.m4

2024-04-24 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/558?usp=email to look at the new patch set (#2). Change subject: configure: update old copy of pkg.m4

[Openvpn-devel] [M] Change in openvpn[master]: configure: delete old copy of pkg.m4

2024-04-23 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/558?usp=email to review the following change. Change subject: configure: delete old copy of pkg.m4

[Openvpn-devel] [S] Change in openvpn[master]: configure: Try to detect LZO with pkg-config first

2024-04-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/556?usp=email to review the following change. Change subject: configure: Try to detect LZO with pkg-config first

[Openvpn-devel] [XS] Change in openvpn[master]: Only schedule_exit() once

2024-04-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, reynir. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email ) Change subject: Only schedule_exit() once .. Patch Set 1: (2

[Openvpn-devel] [M] Change in openvpn[master]: Use topology default of "subnet" only for server mode

2024-04-17 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/554?usp=email to review the following change. Change subject: Use topology default of "subnet" only for server mode

[Openvpn-devel] [M] Change in openvpn[master]: tun: use is_tun_p2p more consistently

2024-04-17 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/380?usp=email to look at the new patch set (#3). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.

[Openvpn-devel] [XS] Change in openvpn[master]: Fix "binary or" vs "boolean or" related to server_bridge_proxy_dhcp

2024-04-10 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/553?usp=email to review the following change. Change subject: Fix "binary or" vs "boolean or" related to server_bridge_proxy_dhcp

[Openvpn-devel] [S] Change in openvpn[master]: misc.c: remove unused code

2024-03-28 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/550?usp=email ) Change subject: misc.c: remove unused code .. Patch Set 1:

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/548?usp=email ) Change subject: crypto_backend: fix type of enc parameter ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email to look at the new patch set (#3). Change subject: crypto_backend: fix type of enc parameter

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email ) Change subject: Implement support for larger packet counter sizes ..

[Openvpn-devel] [S] Change in openvpn[master]: crypto_backend: fix type of enc parameter

2024-03-27 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by

[Openvpn-devel] [S] Change in openvpn[master]: Fix snprintf/swnprintf related compiler warnings

2024-03-26 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/549?usp=email ) Change subject: Fix snprintf/swnprintf related compiler warnings ..

[Openvpn-devel] [XS] Change in openvpn[master]: mbedtls: avoid warning with GCC 13+

2024-03-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/548?usp=email to review the following change. Change subject: mbedtls: avoid warning with GCC 13+

[Openvpn-devel] [XS] Change in openvpn[master]: Add bracket in fingerprint message and do not warn about missing veri...

2024-03-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/546?usp=email ) Change subject: Add bracket in fingerprint message and do not warn about missing verification

[Openvpn-devel] [XS] Change in openvpn[master]: Use snprintf instead of sprintf for get_ssl_library_version

2024-03-25 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/545?usp=email ) Change subject: Use snprintf instead of sprintf for get_ssl_library_version

[Openvpn-devel] [XS] Change in openvpn[master]: Add bracket in fingerprint message and do not warn about missing veri...

2024-03-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/546?usp=email ) Change subject: Add bracket in fingerprint message and do not warn about missing verification

[Openvpn-devel] [XS] Change in openvpn[master]: Use snprintf instead of sprintf for get_ssl_library_version

2024-03-22 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/545?usp=email ) Change subject: Use snprintf instead of sprintf for get_ssl_library_version

[Openvpn-devel] [M] Change in openvpn[master]: Allow the TLS session to send out TLS alerts

2024-03-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/449?usp=email ) Change subject: Allow the TLS session to send out TLS alerts .. Patch

[Openvpn-devel] [L] Change in openvpn[master]: Implement support for larger packet counter sizes

2024-03-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/507?usp=email ) Change subject: Implement support for larger packet counter sizes ..

[Openvpn-devel] [S] Change in openvpn[master]: GHA: general update March 2024

2024-03-18 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/544?usp=email ) Change subject: GHA: general update March 2024 .. Patch Set 1: (1

[Openvpn-devel] [S] Change in openvpn[master]: GHA: general update March 2024

2024-03-15 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/544?usp=email to review the following change. Change subject: GHA: general update March 2024

[Openvpn-devel] [S] Change in openvpn[master]: Disable DCO if proxy is set via management

2024-03-15 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/543?usp=email ) Change subject: Disable DCO if proxy is set via management ..

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-03-13 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-03-13 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table

[Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/533?usp=email ) Change subject: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-12 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

2024-03-11 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/533?usp=email ) Change subject: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin

[Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-03-11 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-03-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email ) Change subject: t_client.sh: Allow to skip tests .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-03-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email ) Change subject: t_client.sh: Allow to skip tests .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-03-06 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, flichtenheld, ordex, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email to look at the new patch set (#5). The following approvals got outdated and were

[Openvpn-devel] [XS] Change in openvpn[master]: Fix typo --data-cipher-fallback

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/534?usp=email to review the following change. Change subject: Fix typo --data-cipher-fallback

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. Hello ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to look at the new patch set (#2). Change subject: samples: Update sample configurations

[Openvpn-devel] [S] Change in openvpn[master]: gerrit-send-mail: add missing Signed-off-by

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/530?usp=email to review the following change. Change subject: gerrit-send-mail: add missing Signed-off-by

[Openvpn-devel] [M] Change in openvpn[master]: samples: Update sample configurations

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/532?usp=email to review the following change. Change subject: samples: Update sample configurations

[Openvpn-devel] [M] Change in openvpn[master]: samples: Remove tls-*.conf

2024-03-04 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/531?usp=email to review the following change. Change subject: samples: Remove tls-*.conf

[Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always

2024-02-28 Thread flichtenheld (Code Review)
Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=email to look at the new patch set (#10). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email to look at the new patch set (#4). Change subject: t_client.sh: Allow to skip tests

[Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver

2024-02-28 Thread flichtenheld (Code Review)
Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/478?usp=email to look at the new patch set (#9). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now. Change subject: tests: fork default automake

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-28 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email ) Change subject: t_client.sh: Allow to skip tests .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: tests: fork default automake test-driver

2024-02-28 Thread flichtenheld (Code Review)
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/478?usp=email ) Change subject: tests: fork default automake test-driver .. Patch Set 8: (1 comment) Patchset: PS8: Some additional

[Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching

2024-02-27 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching

[Openvpn-devel] [XS] Change in openvpn[master]: Test change

2024-02-21 Thread flichtenheld (Code Review)
flichtenheld has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/401?usp=email ) Change subject: Test change .. Abandoned test -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/401?usp=email To

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-21 Thread flichtenheld (Code Review)
Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email ) Change subject: t_client.sh: Allow to skip tests .. Patch Set 2:

[Openvpn-devel] [M] Change in openvpn[master]: Minor fix to process_ip_header

2024-02-20 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/525?usp=email ) Change subject: Minor fix to process_ip_header ..

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-02-20 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table

[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-02-20 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email ) Change subject: Persist-key: enable persist-key option by default

[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove incorrect routes on exit

2024-02-20 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/522?usp=email ) Change subject: Route: remove incorrect routes on exit ..

[Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email ) Change subject: Route: add support for user defined routing table

[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove incorrect routes on exit

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/528?usp=email ) Change subject: Route: remove incorrect routes on exit ..

[Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: Fix bug preventing proxy credentials caching.

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: Fix bug preventing proxy credentials caching.

[Openvpn-devel] [XS] Change in openvpn[master]: Route: remove uncorrect routes on exit.

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/522?usp=email ) Change subject: Route: remove uncorrect routes on exit. ..

[Openvpn-devel] [S] Change in openvpn[master]: documentation: make section levels consistent

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/527?usp=email to review the following change. Change subject: documentation: make section levels consistent

[Openvpn-devel] [XS] Change in openvpn[master]: check_compression_settings_valid: Do not test for LZ4 in LZO check

2024-02-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/526?usp=email to review the following change. Change subject: check_compression_settings_valid: Do not test for LZ4 in LZO check

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-14 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email to look at the new patch set (#2). Change subject: t_client.sh: Allow to skip tests

[Openvpn-devel] [M] Change in openvpn[master]: Implement support for AEAD tag at the end

2024-02-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/506?usp=email ) Change subject: Implement support for AEAD tag at the end .. Patch Set

[Openvpn-devel] [M] Change in openvpn[master]: t_client.sh: Allow to skip tests

2024-02-13 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email to review the following change. Change subject: t_client.sh: Allow to skip tests

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2024-02-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email ) Change subject: Print SSL peer signature information in handshake debug details

[Openvpn-devel] [M] Change in openvpn[master]: Print SSL peer signature information in handshake debug details

2024-02-09 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/365?usp=email ) Change subject: Print SSL peer signature information in handshake debug details

  1   2   3   4   >