Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-10 Thread Selva Nair
Hi On Thu, Sep 10, 2020 at 3:10 AM Marvin Adeff wrote: > Selva, > > Please allow me to back up a moment and restate this: > 1. I installed the beta3 msi from the web site logged in as a user that > has admin privileges. But no elevation was used to install it, just > double-click on the file.

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-10 Thread Lev Stipakov
Hi Marvin, > 1. I installed the beta3 msi from the web site logged in as a user that has > admin privileges. But no elevation was used to install it, just double-click > on the file. > 2. I only used the GUI as installed, with no elevation, to start OpenVPN. > 3. With TAP selected in my

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-10 Thread Marvin Adeff
Selva, Please allow me to back up a moment and restate this: 1. I installed the beta3 msi from the web site logged in as a user that has admin privileges. But no elevation was used to install it, just double-click on the file. 2. I only used the GUI as installed, with no elevation, to start

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-09 Thread Selva Nair
Hi, On Thu, Sep 10, 2020 at 12:19 AM Marvin wrote: > Hi Selva, > > The GUI did not have this error unless run as administrator which you >> should not and will never work. > > So you are saying that if OpenVPN is installed by a user who has admin > privileges (as our case does) that v2.5 with

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-09 Thread Selva Nair
Hi On Wed, Sep 9, 2020 at 8:30 PM Marvin wrote: > Selva, > > Sorry for the wrong thread. I was replying to an earlier thread about > this same error on Beta1 and beta2. So i am a bit confused by your > statement that this error did not show up in earlier betas, because that's > what started

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-09 Thread Marvin
Selva, Sorry for the wrong thread. I was replying to an earlier thread about this same error on Beta1 and beta2. So i am a bit confused by your statement that this error did not show up in earlier betas, because that's what started this thread. Marvin On Wed, Sep 9, 2020 at 5:14 PM Selva Nair

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-09 Thread Selva Nair
Hi Marvin, This is the wrong thread, but... On Wed, Sep 9, 2020 at 7:54 PM Marvin wrote: > Hi Guys, > > I just tested beta3 on Win10. I am getting the exact same error with > wintun as before. TAP works normally. I tried with the GUI and by cli. > The GUI never generated this error even

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-09-09 Thread Marvin
Hi Guys, I just tested beta3 on Win10. I am getting the exact same error with wintun as before. TAP works normally. I tried with the GUI and by cli. 2020-09-09 16:23:20 us=991306 ERROR: Wintun requires SYSTEM privileges and therefore should be used with interactive service. If you want to

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-31 Thread Rafael Gava
Hi Gert, Glad that we could help! :-) If you guys need anything else that we can help, please let us know. BR Gava On Mon, Aug 31, 2020 at 10:23 AM Gert Doering wrote: > Hi, > > On Sun, Aug 30, 2020 at 09:26:10PM -0300, Rafael Gava wrote: > > Good news, it worked beautifully with tun and

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-31 Thread Gert Doering
Hi, On Sun, Aug 30, 2020 at 09:26:10PM -0300, Rafael Gava wrote: > Good news, it worked beautifully with tun and tap interfaces! > > Thank you very much Cool, thanks for testing. I have just tagged 2.5_beta3, and lev/mattock will go about building a beta3 .msi with it (and hopefully lots

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-30 Thread Rafael Gava
Hi Gert, Good news, it worked beautifully with tun and tap interfaces! Thank you very much BR Gava On Sun, Aug 30, 2020 at 5:37 PM Gert Doering wrote: > Hi, > > On Sun, Aug 30, 2020 at 02:07:03PM +0200, Gert Doering wrote: > > On Sat, Aug 29, 2020 at 09:42:46PM -0300, Rafael Gava wrote:

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-30 Thread Rafael Gava
Hi Gert, thanks for the prompt fix. Our server is an old appliance and I really don't know if it was compiled with "enable-small". I'll try to figure that. :-) Sure, I'll try the fix and let you know ASAP. BR Gava On Sun, Aug 30, 2020 at 5:37 PM Gert Doering wrote: > Hi, > > On Sun, Aug

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-30 Thread Gert Doering
Hi, On Sun, Aug 30, 2020 at 02:07:03PM +0200, Gert Doering wrote: > On Sat, Aug 29, 2020 at 09:42:46PM -0300, Rafael Gava wrote: [..] > If it still doesn't do that, you found a new bug :-) So - patch has been merged, and I think I have set up an appropriate testbed to verify this (2.5/master

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-30 Thread Arne Schwabe
Am 29.08.20 um 21:19 schrieb Rafael Gava: > Hi Arne, > > This thread has a could days but I'm testing the version 2.5-beta2 and > I'm getting the following error: > > 2020-08-29 16:02:53 us=643016 OPTIONS ERROR: failed to negotiate cipher > with server.  Add the server's cipher ('BF-CBC') to

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-30 Thread Gert Doering
Hi, On Sat, Aug 29, 2020 at 09:42:46PM -0300, Rafael Gava wrote: > Actually, I was testing Samuli's 2.5-beta2 installer from the link below: > Note sure if it's with the patch for data-ciphers but I guess so. > I'll pull the 2.5-beta2 code and build it in order to check if it's > working

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-29 Thread Rafael Gava
Hello tincanteksup, Thanks for sharing. I didn't know that wiki. I'll double check and see if I'm missing something. Actually, I haven't compiled the code, I was just trying the installer from the link below: https://build.openvpn.net/downloads/releases/OpenVPN-2.5-beta2-I601-amd64.msi

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-29 Thread Rafael Gava
Hi Gert, Actually, I was testing Samuli's 2.5-beta2 installer from the link below: Note sure if it's with the patch for data-ciphers but I guess so. I'll pull the 2.5-beta2 code and build it in order to check if it's working properly.

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-29 Thread Gert Doering
Hi, On Sat, Aug 29, 2020 at 04:19:07PM -0300, Rafael Gava wrote: > This thread has a could days but I'm testing the version 2.5-beta2 and I'm > getting the following error: > > 2020-08-29 16:02:53 us=643016 OPTIONS ERROR: failed to negotiate cipher > with server. Add the server's cipher

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-29 Thread tincanteksup
Hi, sorry to interrupt, Rafael could you please confirm if you find this document to be correct/incorrect for your use case: https://community.openvpn.net/openvpn/wiki/CipherNegotiation Also note, this patch has been merged so make sure your binary has been compiled with it. On 29/08/2020

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-29 Thread Rafael Gava
Hi Arne, This thread has a could days but I'm testing the version 2.5-beta2 and I'm getting the following error: 2020-08-29 16:02:53 us=643016 OPTIONS ERROR: failed to negotiate cipher with server. Add the server's cipher ('BF-CBC') to --data-ciphers (currently 'BF-CBC') if you want to connect

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-23 Thread tincanteksup
This is my suggestion for the commit message: -- This commit fixes two separate issues which are closely linked. First, a 2.5 client cannot connect to a server which does not support NCP and is not using one of the default --data-ciphers (AES-*-GCM). This is because the 2.5 client does not

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-22 Thread Steffan Karger
Hi, On 14-08-2020 10:06, Arne Schwabe wrote: > OpenVPN 2.5 clients do not correctly do a fallback to the server server. > This commit fixes that logic and also fixes --data-ciphers-fallback to > be used in situations other than no OCC cipher. > > To reproduce the error use a client with only

Re: [Openvpn-devel] [PATCH] Fix client's poor man NCP fallback

2020-08-14 Thread tincanteksup
Hi, I tested this patch and it does make --data-ciphers and --data-ciphers-fallback behave in their intended "fashion". Unfortunately, the commit message is grammatically incorrect and also logically misleading. The intended fashion is for --data-ciphers to recognise that the correct