[Openvpn-devel] Alignement crash on sparc64

2017-05-26 Thread Jeremie Courreges-Anglas
Hi, I am the maintainer of openvpn in the OpenBSD ports tree. Here's a report from Stefan Sperling (Cc'ed). > An openvpn server running on OpenBSD/sparc64 6.1 crashes when a client > connects and starts doing traffic. Is anyone else seeing this? > > (gdb) run > Starting program: /usr/local/sbi

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Gert Doering writes: > Hi, > > On Fri, May 26, 2017 at 04:30:53PM +0200, Jeremie Courreges-Anglas wrote: >> I am the maintainer of openvpn in the OpenBSD ports tree. Here's >> a report from Stefan Sperling (Cc'ed). >> >> > An openvpn server runnin

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Anatoly Pugachev writes: > On Fri, May 26, 2017 at 7:56 PM, Gert Doering wrote: >> Hi, >> >> On Fri, May 26, 2017 at 04:30:53PM +0200, Jeremie Courreges-Anglas wrote: >>> I am the maintainer of openvpn in the OpenBSD ports tree. Here's >>> a repor

[Openvpn-devel] Missing include for socket-flags TCP_NODELAY on OpenBSD

2017-06-10 Thread Jeremie Courreges-Anglas
CP_NODELAY on OpenBSD Signed-off-by: Jeremie Courreges-Anglas --- src/openvpn/syshead.h | 4 1 file changed, 4 insertions(+) diff --git a/src/openvpn/syshead.h b/src/openvpn/syshead.h index f4458648..14b6662a 100644 --- a/src/openvpn/syshead.h +++ b/src/openvpn/syshead.h @@ -288,6

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Gert Doering writes: > Hi, > > On Sat, Jun 10, 2017 at 06:16:13PM +0200, Jeremie Courreges-Anglas wrote: >> Loaded symbols for /usr/libexec/ld.so >> #0 write_tun_header (tt=0x1ddd4e1900, buf=0x1d336921c5 "E", len=84) at >> tun.c:1661 >> 1661

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Gert Doering writes: > Hi, > > On Sat, Jun 10, 2017 at 07:58:13PM +0200, Jeremie Courreges-Anglas wrote: >> OpenBSD: >> >> struct ip { >> #if _BYTE_ORDER == _LITTLE_ENDIAN >> u_int ip_hl:4, /* header length */ >>

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Gert Doering writes: > Hi, > > On Sat, Jun 10, 2017 at 07:58:13PM +0200, Jeremie Courreges-Anglas wrote: >> OpenBSD: >> >> struct ip { >> #if _BYTE_ORDER == _LITTLE_ENDIAN >> u_int ip_hl:4, /* header length */ >>

Re: [Openvpn-devel] Alignement crash on sparc64

2017-06-10 Thread Jeremie Courreges-Anglas
Jeremie Courreges-Anglas writes: > Gert Doering writes: > >> Hi, >> >> On Sat, Jun 10, 2017 at 07:58:13PM +0200, Jeremie Courreges-Anglas wrote: >>> OpenBSD: >>> >>> struct ip { >>> #if _BYTE_ORDER == _LITTLE_END

Re: [Openvpn-devel] [PATCH applied] Re: Missing include for socket-flags TCP_NODELAY on OpenBSD

2017-06-12 Thread Jeremie Courreges-Anglas
Gert Doering writes: > ACK, thanks. > > (While I'm not exactly happy with the mess we have in syshead.h, this > is not your fault - you just happen to add the 6th identical chunk...) > > Applying this to all branches to fix the bug, putting "rework syshead.h > for master, to clean up the zillion

Re: [Openvpn-devel] [PATCH v7 0/8] OpenSSL: support for version 1.1

2017-06-15 Thread Jeremie Courreges-Anglas
Hi, fwiw, this builds fine against LibreSSL, which seems to provide some but not all of the functions for which you wrote fallback implementations. LibreSSL as shipped in OpenBSD-current, ie the development version. make check passes, openvpn seems to behave correctly in client mode. -- jca |

Re: [Openvpn-devel] OpenVPN 2.4.3 released (with security fixes)

2017-06-21 Thread Jeremie Courreges-Anglas
Hi, Emmanuel Deloget writes: > Hi David, > > On Wed, Jun 21, 2017 at 11:06 PM, David Sommerseth < > open...@sf.lists.topphemmelig.net> wrote: > > ​​ > > >> But for reasons unknown to me, those tarballs got re-created somewhere >> later in the release chain. The contents of all tarballs are >>

[Openvpn-devel] [patch] Fix time_t printing

2017-10-04 Thread Jeremie Courreges-Anglas
Note that I did not audit the whole openvpn tree for other possible time_t problems, but I can't spot similar warnings in the build logs. >From d620431f661375d3564b60f110d1f69575ac78d7 Mon Sep 17 00:00:00 2001 From: Jeremie Courreges-Anglas Date: Thu, 5 Oct 2017 01:43:33 +0200 Subject: [PATCH]

Re: [Openvpn-devel] [patch] Fix time_t printing

2017-10-12 Thread Jeremie Courreges-Anglas
Hi, any opinion regarding this diff? -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE signature.asc Description: PGP signature -- Check out the vibrant tech community on one of the world'

Re: [Openvpn-devel] [patch] Fix time_t printing - NAK

2017-10-15 Thread Jeremie Courreges-Anglas
On Sun, Oct 15 2017, Matthias Andree wrote: > Am 05.10.2017 um 01:47 schrieb Jeremie Courreges-Anglas: >> When building openvpn-2.4.4 on OpenBSD, I noticed the following warning: >> >> --8<-- >> cc -DHAVE_CONFIG_H -I. >> -I/usr/ports/pobj/openvpn-2.4.4/open

Re: [Openvpn-devel] [patch] Fix time_t printing - NAK

2017-10-18 Thread Jeremie Courreges-Anglas
On Sun, Oct 15 2017, Jeremie Courreges-Anglas wrote: > On Sun, Oct 15 2017, Matthias Andree wrote: >> Am 05.10.2017 um 01:47 schrieb Jeremie Courreges-Anglas: >>> When building openvpn-2.4.4 on OpenBSD, I noticed the following warning: >>> >>> --8<-- >&

Re: [Openvpn-devel] [patch] Fix time_t printing - NAK

2017-10-25 Thread Jeremie Courreges-Anglas
Hi folks, any other feedback regarding this issue and the methods discussed to fix it? -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE signature.asc Description: PGP signature -- Check o

Re: [Openvpn-devel] [patch] Fix time_t printing - NAK

2017-10-26 Thread Jeremie Courreges-Anglas
On Thu, Oct 26 2017, Steffan Karger wrote: > Hi, > > Sorry for being late to respond. > > On 18-10-17 20:36, Jeremie Courreges-Anglas wrote: >> - there are other places when a time_t is printed in openvpn. Usually >> it is cast to (int), which is not a nice

Re: [Openvpn-devel] [PATCH applied] Re: Print time_t as long long and suseconds_t as long

2017-11-05 Thread Jeremie Courreges-Anglas
is in 2.4... FWIW I'm fine with whatever approach you prefer. openvpn-2.5.0 will hopefully be released before 2038. :) Here's another small diff, I forgot one suseconds_t occurrence. From cbe8237ff59129501e1e92c8fd6a3488d94c4c0f Mon Sep 17 00:00:00 2001 From: Jeremie Courreges-Anglas Date:

[Openvpn-devel] [PATCH] Use long long to format time_t-related environment variables

2017-11-05 Thread Jeremie Courreges-Anglas
Signed-off-by: Jeremie Courreges-Anglas --- src/openvpn/misc.c| 4 ++-- src/openvpn/misc.h| 2 +- src/openvpn/multi.c | 7 ++- src/openvpn/options.c | 2 +- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 8c7f6116

Re: [Openvpn-devel] [patch] Fix time_t printing

2017-11-16 Thread Jeremie Courreges-Anglas
FWIW I have added a "portability" section to the CodeStyle page, and a subsection about time_t & suseconds_t. https://community.openvpn.net/openvpn/wiki/CodeStyle#Printingtime_tandsuseconds_tvalues Feedback welcome. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E

Re: [Openvpn-devel] [PATCH applied] Re: Add --tls-cert-profile option for mbedtls builds

2017-11-19 Thread Jeremie Courreges-Anglas
ants to have a look :-) Here's a diff, master builds and seems to run fine as a client on OpenBSD-current. I can cook a similar diff for the remaining OPENSSL / LIBRESSL_VERSION_NUMBER #ifdef. From 15315d3c3b25814a426bfc8184c4dfd262f28768 Mon Sep 17 00:00:00 2001 From: Jeremie Courreges-Angla

Re: [Openvpn-devel] [PATCH applied] Re: Add --tls-cert-profile option for mbedtls builds

2017-11-19 Thread Jeremie Courreges-Anglas
On Sun, Nov 19 2017, Jeremie Courreges-Anglas wrote: > On Sun, Nov 19 2017, Gert Doering wrote: >> Hi, >> >> On Sun, Nov 19, 2017 at 09:37:56PM +0100, Gert Doering wrote: >>> .. of course this conflicts with o->renegotiate_seconds_min... >>> >>>

Re: [Openvpn-devel] [PATCH] Add a warning that we do not officially support LibreSSL

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, Steffan Karger wrote: > Hi, > > On 04-03-18 10:08, Gert Doering wrote: >> On Thu, Mar 01, 2018 at 12:11:23AM +0100, Steffan Karger wrote: >>> As discussed in the community meeting of 13-12-2017, we should warn our >>> users that LibreSSL is not officially supported. We expect

Re: [Openvpn-devel] LibreSSL support in OpenVPN 2.4.5

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, Gert Doering wrote: [...] > "Please note that LibreSSL is not a supported crypto backend. We > accept patches and we do test on OpenBSD 6.0 which comes with > LibreSSL, but if newer versions of LibreSSL break API compatibility > we do not take responsibility to fix that."

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, selva.n...@gmail.com wrote: > From: Selva Nair > > Openssl docs do not explicitly state these to be macros although they > are currently defined as such. Actually they are documented as macros by OpenSSL since day 1, see NOTES. > Use AC_CHECK_DECLS to test for these so that

Re: [Openvpn-devel] [PATCH applied] Re: Add --tls-cert-profile option for mbedtls builds

2018-03-04 Thread Jeremie Courreges-Anglas
: 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE From e6d80207bf7f1323670d0bc1102fa51309b1aa14 Mon Sep 17 00:00:00 2001 From: Jeremie Courreges-Anglas Date: Sun, 4 Mar 2018 19:24:36 +0100 Subject: [PATCH] Detect availability of SSL_CTX_get0_certificate instead of relying

Re: [Openvpn-devel] LibreSSL support in OpenVPN 2.4.5

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, Selva Nair wrote: [...] > Libressl developers break API compatibility with openssl in such > perverse ways that there are no easy ways to support it. Take, for > example, the patch I just sent out which checks for certain functions > instead of disabling using LIBRESSL_VERSI

Re: [Openvpn-devel] [PATCH] Do not assume that SSL_CTX_get/set_min/max_proto_version are macros

2018-03-04 Thread Jeremie Courreges-Anglas
On Sun, Mar 04 2018, Selva Nair wrote: > Hi, > > On Sun, Mar 4, 2018 at 1:48 PM, Jeremie Courreges-Anglas > wrote: >> On Sun, Mar 04 2018, selva.n...@gmail.com wrote: >>> From: Selva Nair >>> >>> Openssl docs do not explicitly state these to be macr

Re: [Openvpn-devel] [PATCH v3] Add Apache2 linking with for new commits

2023-05-15 Thread Jeremie Courreges-Anglas
On Wed, Apr 26 2023, Arne Schwabe wrote: > After first round of mailing people with more than 10 commits we have > almost all committers have agreed. This put this license in the realm > of having a realistic change to work. Had any of these contributers > disagreed, rewriting all their code might