From: Lev Stipakov
There are two flags to indicate peer-id usage, one is
in tls_multi struct and another one is in options.
For P2P mode we don't set this flag in options,
which is used in MTU calculation. As a result,
automatically calculated MSS value in P2P mode is wrong,
Fix by
From: Lev Stipakov
After successfult builds on all platforms,
start openvpn-build GHA which produces
Windows MSI installers.
Signed-off-by: Lev Stipakov
---
.github/workflows/build.yaml | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/.github
From: Lev Stipakov
After successfult builds on all platforms,
start openvpn-build GHA which produces
Windows MSI installers.
Signed-off-by: Lev Stipakov
---
v2:
- bring pull_request trigger back
- simplify trigger_openvpn_build run condition
.github/workflows/build.yaml | 19
As per discussion on https://github.com/OpenVPN/openvpn3/pull/218
Acked-by: Lev Stipakov
ti 7. kesäk. 2022 klo 20.30 Christopher Ng (fac...@gmail.com) kirjoitti:
> Signed-off-by: Christopher Ng
> ---
> openvpn/ovpnagent/win/ovpnagent.cpp | 6 --
> 1 file changed, 4 inse
As discussed at https://github.com/OpenVPN/openvpn3/pull/218
Acked-by: Lev Stipakov
ti 7. kesäk. 2022 klo 20.26 Christopher Ng (fac...@gmail.com) kirjoitti:
> Signed-off-by: Christopher Ng
> ---
> openvpn/omi/CMakeLists.txt | 9 +
> 1 file changed, 9 insertions(+)
>
Hi,
The problem this patch solves appeared on mingw-w64 for 32bit version
6.0.0, which is the latest version of mingw on Windows. When this
patch was written (April 2021), we still used travis/appveyor which
did mingw builds on Windows so back then patch made sense.
Since we moved to GHa since th
Hi,
> +if (dco_get_overlapped_result(handle, ov, &transferred,
> poll_interval_ms, FALSE) != 0)
With the removal of mingw compat patch ("dco-win: implement
GetOverlappedResultEx for mingw32"), this needs to be changed to
GetOverlappedResultEx (signature is the same).
-Lev
Hi,
I did some review / testing and suggest following changes to this patch:
> +if (!DeviceIoControl(tt->hand, OVPN_IOCTL_START_VPN, NULL, 0, NULL, 0,
> + &bytes_returned, NULL))
> +{
> +msg(M_ERR, "DeviceIoControl(OVPN_IOCTL_START_VPN) failed with code
>
Hi,
I did some testing and found out that this breaks when establishing
TCP connection to a server which cannot be reached:
> +*tt = dco_create_socket(sock->info.lsa->current_remote,
> +sock->bind_local,
> +sock->info.lsa->bind_local,
>
build with DCO in the
> first place. There is no DCO code yet in master but somehow we have the
> GH action for that :-D
>
> Anyway, can add a sentence to explain what is going on.
>
> Cheers,
>
> >
> > On Fri, Jun 24, 2022 at 10:38:09AM +0200, Antonio Qua
From: Lev Stipakov
This code reads the state of OpenVPNService,
such as startup mode and running, and sets MSI
property value. If that property is set, installer
selects OpenVPNService as a feature to be installed.
This has been superseded by change in installer:
https://github.com/OpenVPN
Hi,
> +static bool
> +can_preserve_tun(struct tuntap *tt)
> +{
> +#ifdef TARGET_ANDROID
> +return false;
> +#elif _WIN32
> +return tt && tt->dco.real_tun_init;
Looks like dco.real_tun_init has been added in the very next patch, 22/25.
___
Open
From: Lev Stipakov
Signed-off-by: Lev Stipakov
---
src/openvpn/tun.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 54f7d72c..f3152a52 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -745,7 +745,6 @@ init_tun(const char *dev
From: Lev Stipakov
Some adapters create multiple device interfaces
and we need to enumerate all of them.
Signed-off-by: Lev Stipakov
---
src/openvpn/tun.c | 37 +
src/openvpn/tun.h | 2 +-
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a
From: Lev Stipakov
Some adapters create multiple device interfaces
and we need to enumerate all of them.
Signed-off-by: Lev Stipakov
---
v2: uncrustify
src/openvpn/tun.c | 35 ---
src/openvpn/tun.h | 2 +-
2 files changed, 21 insertions(+), 16 deletions
Stared at the code and slightly tested on Windows.
Functionality hasn't changed and code is now easier to read.
Acked-by: Lev Stipakov
pe 12. elok. 2022 klo 16.08 Antonio Quartulli (a...@unstable.cc) kirjoitti:
> The current condition checking if the TUN interface was preserved is
>
Hi,
General note - this commit has no commit message and introduces a set of
functions which are not yet called. Does it really make sense to split
dco-win support into two commits?
src/openvpn/ovpn-dco-win.h | 108
>
We have ovpn_dco_linux.h and ovpn-dco-win.h. Should we unif
Oh and also:
6>C:\Users\lev\Projects\openvpn\src\openvpn\dco.c(280,27): error C2039:
'disable_dco': is not a member of 'tuntap_options'
6>C:\Users\lev\Projects\openvpn\src\openvpn\tun.h(64): message : see
declaration of 'tuntap_options'
-Lev
___
Openvpn
is in use.
>
> Signed-off-by: Antonio Quartulli
> Signed-off-by: Lev Stipakov
> ---
> src/openvpn/dco.c | 17 +++--
> src/openvpn/options.c | 5 +
> 2 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpn/dco.c b/src/ope
Hi,
+Getting started (Windows)
> +-
> +Getting started under windows is currently for brave people having
> experience
> +with windows development. You need to compile openvpn yourself and also
> need
> +to get the test driver installed on your system.
>
While I consider b
called yet - I am OK with that if it makes code easier to
review.
Disclaimer: I contributed some code to this commit, so I might be slightly
biased.
Acked-by: Lev Stipakov
la 13. elok. 2022 klo 23.43 Antonio Quartulli (a...@unstable.cc) kirjoitti:
> Signed-off-by: Arne Schwabe
> Sign
From: Lev Stipakov
This has been added in 2006 and as of now not used.
Signed-off-by: Lev Stipakov
---
src/openvpn/error.c | 9 -
src/openvpn/error.h | 5 -
2 files changed, 14 deletions(-)
diff --git a/src/openvpn/error.c b/src/openvpn/error.c
index 7cd35b17..c8c77358 100644
Again, this cannot be tested yet.
Stared at the code and tested with follow-up commits, looks good and works
as expected.
Acked-by: Lev Stipakov
la 13. elok. 2022 klo 23.43 Antonio Quartulli (a...@unstable.cc) kirjoitti:
> At the moment dco-win doesn't support --persist-tun and
ugh the OpenVPN function we use is called
"link_socket_write_win32()".
I would change the above mentioned comment to "normal Overlapped I/O".
Maybe this could be done at commit.
Also, as mentioned in chat, this should be merged before 3/7
("dco-win: implement ovpn-dco
interface, just by sending SIGUSR2, maybe
"multi.c: include DCO status in status version 2" would be better?
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
From: Lev Stipakov
Device interface is a path which is used by userspace
to access device. A driver can create one or more device
interfaces and specify "reference string", so that userspace
could enumerate all device interfaces in the list and pick
the corrct one which ends with
From: Lev Stipakov
The correct return type for those functions is int,
so adjust return type accordingly for the cases
when DCO is not defined.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/openvpn/dco.h b/src
From: Lev Stipakov
The correct return type for those functions is int,
so adjust return type accordingly for the cases
when DCO is not defined.
Signed-off-by: Lev Stipakov
---
v2: also do "return 0" in dco_p2p_add_new_peer()
src/openvpn/dco.h | 8
1 file changed, 4 insert
Hi,
I remember someone was explaining to me the necessity of verbose
commit messages.
Chi può essere?
> It seems to take an existing setup that builds an installer *with* DCO,
> and remove the DCO bits?
> ... so maybe we can have a better commit message that explains this?
We decided to move t
12.02 Gert Doering (g...@greenie.muc.de) kirjoitti:
>
> Hi,
>
> On Sat, Aug 13, 2022 at 10:42:20PM +0200, Antonio Quartulli wrote:
> > With this change it is possible to use ovpn-dco-win when running OpenVPN
> > in client or P2P mode.
> >
> > Signed-off-by:
From: Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN
in client or P2P mode.
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
---
Changes from v101:
* move tuntap_is_dco_win() check from init.c to open_tun
From: Lev Stipakov
This function is available starting from Windows 8. Calling it
"as is" causes startup error on Windows 7.
dco-win driver available on Windows 10 20H1 and newer. On older
systems installer will not show nor install the driver and dco-win code
won't be reached
From: Lev Stipakov
This allows us to use newer versions of
dependencies, such as openssl 3.0.2 -> 3.0.5.
Signed-off-by: Lev Stipakov
---
.github/workflows/build.yaml | 2 +-
src/openvpn/vcpkg.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workfl
elok. 2022 klo 19.06 Gert Doering (g...@greenie.muc.de) kirjoitti:
>
> Hi,
>
> On Fri, Aug 19, 2022 at 10:30:05PM +0300, Lev Stipakov wrote:
> > From: Antonio Quartulli
> >
> > With this change it is possible to use ovpn-dco-win when running OpenVPN
> > in c
From: Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN
in client or P2P mode.
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
---
Changes from v102:
* use "windows-driver ovpn-dco" without trai
verified that ChaCha20-Poly1305 (cipher supported starting from
Windows 11) works fine with the dco-win driver ,
as well as the good old AES-256-GCM.
More testers are very welcomed.
ma 22. elok. 2022 klo 11.56 Lev Stipakov (lstipa...@gmail.com) kirjoitti:
>
> From: Antonio Quartulli
>
&g
Another feedback - I asked our corp QA engineer to give this build a
try, here are results:
---
Testing OpenVPN GUI on Windows 11:
- install, remove and upgrade from 2.5.7 to
https://github.com/lstipakov/openvpn-build/actions/runs/2902240643
- Connection with `DCO` via autologin, user-locked, clou
From: Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN
in client or P2P mode.
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
---
Changes from v103:
* Query DCO code for default --data-ciphers only on
From: Antonio Quartulli
With this change it is possible to use ovpn-dco-win when running OpenVPN
in client or P2P mode.
Signed-off-by: Arne Schwabe
Signed-off-by: Lev Stipakov
Signed-off-by: Antonio Quartulli
---
Changes from v104:
* query first crypto library for chacha support and then
Dear all,
The DCO driver for Windows (https://github.com/openvpn/ovpn-dco-win)
implements OpenVPN data channel in kernel, eliminating context switch
and thus noticeably improves performance.
Support for dco-win driver has been merged into openvpn master branch
and openvpn installer:
x64:
htt
From: Lev Stipakov
Since version 0.8.0, dco-win driver added support for
DEL_PEER command, which enabled --persist-tun
implementation on client side.
Add real implementation for dco_del_peer on Windows,
which calls DEL_PEER, which clears peer state
on the driver without tearing tunnel down
From: Lev Stipakov
Since version 0.8.0, dco-win driver added support for
DEL_PEER command, which enabled --persist-tun
implementation on client side.
Add real implementation for dco_del_peer on Windows,
which calls DEL_PEER, which clears peer state
on the driver without tearing tunnel down
seen those for a while, which
> means that the previous driver version (0.7.6) is stable and new one (with
> persist tun support) is not.
>
> We’ll get back to this patch when I’ll fix the driver.
>
> Lähetetty iPhonesta
>
> > Lev Stipakov kirjoitti 29.8.2022 kello 14.51:
From: Lev Stipakov
Filters file defines custom logical folders in
Solution Explorer. We don't use this functionality
and it requires maintenance, so let's remove it.
While on it, remove dco linux files from VS project.
Signed-off-by: Lev Stipakov
---
src/openvpn/openvpn.vcxproj
From: Lev Stipakov
Filters file defines custom logical folders in
Solution Explorer. We don't use this functionality
and it requires maintenance, so let's remove those.
While on it, remove dco linux files from VS project.
Signed-off-by: Lev Stipakov
---
v2: remove .filters files
From: Lev Stipakov
Reverse if condition - this allows us to get rid of
indentation level, which makes code easier to read.
Signed-off-by: Lev Stipakov
---
src/openvpn/init.c | 88 --
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a
From: Lev Stipakov
Following options are set on startup and cannot be changed later:
- dev
- dev-type
- connections list
- mode
- topology
Same for system-wide availability of dco.
dco_check_option_conflict(), where those options
were checked, is also called in server mode when
client is
From: Lev Stipakov
Following options are set on startup and cannot be changed later:
- dev
- dev-type
- connections list
- mode
- topology
Same for system-wide availability of dco.
dco_check_option_conflict(), where those options
were checked, is also called in server mode when
client is
From: Lev Stipakov
On startup, check following conditions:
- ovpn-dco-win driver is installed. Perform this check
by trying to open adapter by symbolic name.
- options are compatible with dco. Same checks as on
Linux and FreeBSD. In addition, check that --mode server
is not used and
From: Lev Stipakov
On startup, check following conditions:
- ovpn-dco-win driver is installed. Perform this check
by trying to open adapter by symbolic name.
- options are compatible with dco. Same checks as on
Linux and FreeBSD. In addition, check that --mode server
is not used and
Hi,
> One general question about the patch: Whenever we have
> defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(_WIN32)
> in the DCO code, couldn't we just remove it completely?
> Since this is bascially "every time" anyway, isn't it?
Well, almost. There is also Mac and some other plat
From: Lev Stipakov
On startup, check following conditions:
- ovpn-dco-win driver is installed. Perform this check
by trying to open adapter by symbolic name.
- options are compatible with dco. Same checks as on
Linux and FreeBSD. In addition, check that --mode server
is not used and
From: Lev Stipakov
On startup, check following conditions:
- ovpn-dco-win driver is installed. Perform this check
by trying to open adapter by symbolic name.
- options are compatible with dco. Same checks as on
Linux and FreeBSD. In addition, check that --mode server
is not used and
From: Lev Stipakov
While on it, remove redundant sentence
and quotation from --windows-driver man
description.
Signed-off-by: Lev Stipakov
---
doc/man-sections/windows-options.rst | 8
src/openvpn/options.c| 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff
From: Lev Stipakov
While on it, remove redundant sentence
and quotation mark from --windows-driver man
description.
Signed-off-by: Lev Stipakov
---
v2:
- mark ovpn-dco adapter as default, instead
of tap-windows6
- mention that ovpn-dco requires --dev tun
doc/man-sections/windows
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
build/msvc/msvc-generate/Makefile.mak
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
build/msvc/msvc-generate/Makefile.mak
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v2:
- fix copyright year 2002 -> 2
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v2:
- fix copyright year 2002 -> 2
Hi,
I've sent v2 with copyright year and "not-a-git" -> "unknown" fix.
(I forgot to name master patch to PATCH v2)
Yes, when doing releases we do git checkout. I have tested MSI
installers produced by openvpn-build GitHub automation, which uses the
same script (build-and-package.ps1) which relea
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v3:
- properly handle branchnames like release
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v3:
- properly handle branchnames like
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v4:
- replace backslash with slash - instead
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v4:
- replace backslash with slash - instead
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v5:
- replace "detached" with "n
From: Lev Stipakov
Add a simple python script which generates header with
branch name and commit hash #defines.
While on it, fix filename in msvc-generate.vcxproj
and add proper copyright header to Makefile.mak.
Signed-off-by: Lev Stipakov
---
v5:
- replace "detached" with "n
NAK.
static inline int
link_socket_read_udp_win32(struct link_socket *sock,
struct buffer *buf,
struct link_socket_actual *from)
{
sockethandle_t sh = { .s = sock->sd };
if (sock->info.dco_installed)
2>C:\Users\lev\Projects\openvpn\src
Hi,
> @@ -1190,7 +1190,7 @@ link_socket_write(struct link_socket *sock,
>struct buffer *buf,
>struct link_socket_actual *to)
> {
> -if (proto_is_udp(sock->info.proto) || sock->info.dco_installed)
> +if (proto_is_udp(sock->info.proto) || to->dco_inst
From: Lev Stipakov
By removing builin-baseline constraint, we force
vcpkg to use latest versions of ports. As a side effect,
this bumps OpenSSL to 3.0.7.
While on it, update vcpkg commit in GHA.
We also have to apply a workaround for GHA
to make it use our vcpkg checkout instead of c:\vcpkg
From: Lev Stipakov
Properly detect process architecture and
machine architecture, including arm64.
Print process architecture and, if machine
architecture is different (we are running in
emulation), print that too.
Signed-off-by: Lev Stipakov
---
src/openvpn/win32.c | 123
11:02:47AM +0200, Lev Stipakov wrote:From: Lev Stipakov Properly detect process architecture andmachine architecture, including arm64.Print process architecture and, if machinearchitecture is different (we are running inemulation), print that too.This looks generally good, so definitely a "fe
Don't know if I can ack the patch to which I've contributed - but
anyway, the makefile change looks
good and the python script doesn't regenerate version header (which
would trigger recompilation of some files).
Tested locally and GHA is happy.
Acked-b
From: Lev Stipakov
Also slightly fix indent.
Signed-off-by: Lev Stipakov
---
INSTALL | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/INSTALL b/INSTALL
index da9b88e7..db24e98c 100644
--- a/INSTALL
+++ b/INSTALL
@@ -24,9 +24,9 @@ OpenVPN releases are
From: Lev Stipakov
At the moment Windows driver requires remote to work.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c
index 47fb0003..19a449ba 100644
--- a/src/openvpn/dco.c
+++ b/src
From: Lev Stipakov
In preparation of DCO stats support, simplify
call chains of bytecount routines. No functional changes.
Signed-off-by: Lev Stipakov
---
src/openvpn/forward.c | 4 +--
src/openvpn/manage.c | 64 -
src/openvpn/manage.h | 66
From: Lev Stipakov
At the moment BYTECOUNT in,out is pushed if there is traffic.
With DCO, userspace process doesn't see the traffic, so we need
to add a timer which periodically fetches stats from DCO and
pushes to management client. The timer interval is set by existing
"b
Hi,
This is good - I need an API to get stats to make openvpn-gui show
those (via the management interface).
I am not too much into FreeBSD parts, but
> +hash_iterator_init(m->hash, &hi);
> +
> +while ((he = hash_iterator_next(&hi)))
> +{
> +struct multi_instance *mi = (struc
From: Lev Stipakov
BYTECOUNT on management interface is used to display client stats,
for example by openvpn-gui. At the moment BYTECOUNT is sent if
there is a traffic. With DCO, userspace process doesn't see data
channel traffic, BYTECOUNT is not sent and therefore stats
are not updated.
From: Lev Stipakov
Existing API and implementation (FreeBSD only) are designed for
server usage. Rename it to *_multi to indicate that and not to mix
with upcoming client API/implementation.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco.h | 4 ++--
src/openvpn/dco_freebsd.c | 2
From: Lev Stipakov
Signed-off-by: Lev Stipakov
---
build/msvc/msvc-generate/msvc-generate.vcxproj | 12 ++--
src/compat/compat.vcxproj | 12 ++--
src/openvpn/openvpn.vcxproj| 12 ++--
src/openvpnmsica/openvpnmsica.vcxproj
From: Lev Stipakov
dco_get_peer_stats fetches stats for a single peer. This is mostly
useful in client mode. So far only Windows implements that.
Signed-off-by: Lev Stipakov
---
src/openvpn/dco.h | 13 +
src/openvpn/dco_freebsd.c | 7 +++
src/openvpn/dco_linux.c
Hi,
> Good to see this happening..
Turns out there is a bug in the driver at the moment - it doesn't
update OUT bytes. This particular API hasn't been used in a while.
> Does this data from the driver include both control and data channel bytes?
Yes, at the moment those are "link" bytes and th
> This data will also show up as stats on the adapter (device node) and should
> include all traffic that passes through it, no?
System adapter stats show only tun traffic - the one driver indicates
to NetAdapter. For BYTECOUNT we (userspace client) currently show link
traffic - encapsulated cont
From: Lev Stipakov
dco_get_peer_stats fetches stats for a single peer. This is mostly
useful in client mode. So far only Windows implements that.
Signed-off-by: Lev Stipakov
---
v2: fix error message text
src/openvpn/dco.h | 13 +
src/openvpn/dco_freebsd.c | 7
From: Lev Stipakov
BYTECOUNT on management interface is used to display client stats,
for example by openvpn-gui. At the moment BYTECOUNT is sent if
there is a traffic. With DCO, userspace process doesn't see data
channel traffic, BYTECOUNT is not sent and therefore stats
are not updated.
Hi,
Selva has asked about a build which includes this patch.
Here is MSI installer which incorporates required client patches
- management: add timer to output BYTECOUNT
- Introduce dco_get_peer_stats API and Windows implementation
and a new driver version (0.8.3) with stats fixes.
https://g
code of openvpn in
this patch. I haven't tested actual pkcs11 functionality.
Note that while applying "outside" patch "git am" complains about
whitespace errors, but "this is fine" - those are from the "inside"
patch.
Acked-by: Lev Stipakov
__
Hi,
> In non-dco use, the stats as persisted by the management interface are not
> reset throughout the lifetime of the process. With dco, what the driver
> provides is "Peer Stats" which is reset in OvpnPeerNew() (linux appears to
> do the same). A quick option > would be to move the zero-ing
Hi,
> So it seems as the timer activation got delayed somehow
> -> this is something we need to come back to, when Linux/FreeBSD DCO
> stats get implemented. Starting with "management-hold", then "bytecount",
> then "hold release" gave me counters right away. Mysteries...
This is because we do
From: Lev Stipakov
Git magic to get branch name
git rev-parse --symbolic-full-name HEAD
doesn't work when we're on tag, which is the case when
we build releases. In this case, use tag name as branch name
with another git magic:
git describe --tags
This fixes https://github.c
ve DCO
stats before tearing the tunnel down.
But anyway,
Code looks good, compiled and tested - stats are indeed preserved
across reconnect.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourcefor
From: Lev Stipakov
Git magic to get branch name
git rev-parse --symbolic-full-name HEAD
doesn't work when we're on tag, which is the case when
we build releases.
First, try to get tag name with
git describe --exact-match
and if this fails, get branch name as be
From: Lev Stipakov
Git magic to get branch name
git rev-parse --symbolic-full-name HEAD
doesn't work when we're on tag, which is the case when
we build releases.
First, try to get tag name with
git describe --exact-match
and if this fails, get branch name as be
Hi,
> The return value of MapViewOfFile must be passed to UnmapViewofFile,
> instead of the file handle.
Good catch!
> Fixes #206
Strangely enough, I am not able to reproduce this bug - I posted logs
to the GitHub issue.
Fix indeed makes sense. Indeed, according to docs, UnmapViewOfFile()
acce
Acked-by: Lev Stipakov
to 29. jouluk. 2022 klo 15.48 selva.n...@gmail.com kirjoitti:
>
> From: Selva Nair
>
> The return value of MapViewOfFile must be passed to UnmapViewofFile,
> instead of the file handle.
>
> Fixes #206
>
> v2: move *ring = NULL inside if {}
&g
ad of the list */
> static BOOL
> -CmpEngine(LPVOID item, LPVOID any)
> +CmpAny(LPVOID item, LPVOID any)
I wonder why it was called CmpEngine in the first place?
Code looks good, tested with wintun and dco driver (latter is not affected
by the change, but just to make sure).
Hi,
Indeed, no need to keep those handles for the duration of openvpn
process lifetime,
they're needed only for registration.
Compiled and tested.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
Hi,
> -else if (n > 0)
> +else
> {
> -sleep(n);
> +#ifdef _WIN32
> +win32_sleep(n);
> +#else
> +if (n > 0)
> +{
> +sleep(n);
My understanding is that we want to have interruptible sleep. In this case,
what is the point of calling win32_sle
\Projects\openvpn-build\src\openvpn\ARM64-Output\Debug\openvpn.exe
(process 11476) exited with code 0.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Hi,
Compiled and slightly tested - pinged server's tunnel IPv6 address.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
401 - 500 of 768 matches
Mail list logo
