Re: [Openvpn-devel] Visual Studio support?

2017-01-02 Thread Gisle Vanem
Fish Wang wrote: > I'm finishing up a patch to make sure OpenVPN compiles under Visual Studio. > I have several questions; I'm also compiling using TDM-MinGW and MSVC-2015. But since approx 2 years, the CL compiler breaks at compiling options.c: src/openvpn/options.c(7937): fatal error C1026: p

Re: [Openvpn-devel] Visual Studio support?

2017-01-02 Thread Samuli Seppänen
Hi, Il 01/01/2017 20:32, Fish Wang ha scritto: > Thanks for your (and Steffan's) reply. > > I also noticed that 2.4 and 2.5 only supports Vista+, so it might make sense > to remove dynamic function loading for WPF in openvpnserv (see all those > LoadLibrary and GetProcAddress code in [1]). But som

Re: [Openvpn-devel] Visual Studio support?

2017-01-02 Thread Fish Wang
Hi Samuli, I have my own building scripts. I think they are based on an old version of openvpn-build/msvc. I definitely made quite a few changes to make them work. Best, Fish -Original Message- From: Samuli Seppänen [mailto:sam...@openvpn.net] Sent: Monday, January 2, 2017 2:54 AM To: F

Re: [Openvpn-devel] Visual Studio support?

2017-01-02 Thread Илья Шипицин
2017-01-02 15:24 GMT+03:00 Fish Wang : > Hi Samuli, > > I have my own building scripts. I think they are based on an old version of > openvpn-build/msvc. I definitely made quite a few changes to make them > work. > can you try them at https://ci.appveyor.com ? if we will not run those scripts on

[Openvpn-devel] [PATCH] Remove deprecated --no-iv option

2017-01-02 Thread Steffan Karger
The --no-iv option was deprecated in OpenVPN 2.4 (commit 4969f0d6), and promised to be remove in 2.5. This patch fulfills that promise. Signed-off-by: Steffan Karger --- src/openvpn/crypto.c | 68 +-- src/openvpn/crypto.h | 14 +++ src/o

[Openvpn-devel] [PATCH v2] Remove deprecated --no-iv option

2017-01-02 Thread Steffan Karger
The --no-iv option was deprecated in OpenVPN 2.4 (commit 4969f0d6), and promised to be remove in 2.5. This patch fulfills that promise. Signed-off-by: Steffan Karger --- v2: fix error in --no-replay check (broke AEAD modes) src/openvpn/crypto.c | 69 +--

[Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread Alberto Gonzalez Iniesta
Hi there, I just got this [1] bug report on OpenVPN 2.4 threating all certs as expired when upgrading from 2.3. I find this quite weird, but until I have some time to test it I thought asking here would be faster. Thanks, Alberto [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849909 --

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread Gert Doering
Hi, On Mon, Jan 02, 2017 at 03:17:23PM +0100, Alberto Gonzalez Iniesta wrote: > I just got this [1] bug report on OpenVPN 2.4 threating all certs as > expired when upgrading from 2.3. I find this quite weird, but until I have > some time to test it I thought asking here would be faster. From the

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread Alberto Gonzalez Iniesta
On Mon, Jan 02, 2017 at 03:26:46PM +0100, Gert Doering wrote: > Hi, > > On Mon, Jan 02, 2017 at 03:17:23PM +0100, Alberto Gonzalez Iniesta wrote: > > I just got this [1] bug report on OpenVPN 2.4 threating all certs as > > expired when upgrading from 2.3. I find this quite weird, but until I have

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread Steffan Karger
On 02-01-17 15:26, Gert Doering wrote: > On Mon, Jan 02, 2017 at 03:17:23PM +0100, Alberto Gonzalez Iniesta wrote: >> I just got this [1] bug report on OpenVPN 2.4 threating all certs as >> expired when upgrading from 2.3. I find this quite weird, but until I have >> some time to test it I thought

[Openvpn-devel] Crash in options.c

2017-01-02 Thread Gisle Vanem
Just as an experiment, I compiled openvpn.exe using MinGW w/o 'ENABLE_CRYPTO' defined. Duh, you think. What would be the benefit of that? I ask myself the same. This code (at line 4079): #else /* ifdef ENABLE_CRYPTO */ fprintf(fp, usage_message, title_string, o.ce.conn

Re: [Openvpn-devel] Crash in options.c

2017-01-02 Thread Gert Doering
Hi, On Mon, Jan 02, 2017 at 03:28:58PM +0100, Gisle Vanem wrote: > Just as an experiment, I compiled openvpn.exe using MinGW w/o > 'ENABLE_CRYPTO' defined. Duh, you think. What would be the benefit of > that? I ask myself the same. This code (at line 4079): > > #else /* ifdef ENABLE_CRYPTO */ >

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread SviMik
> On 02-01-17 15:26, Gert Doering wrote: > > On Mon, Jan 02, 2017 at 03:17:23PM +0100, Alberto Gonzalez Iniesta wrote: > >> I just got this [1] bug report on OpenVPN 2.4 threating all certs as > >> expired when upgrading from 2.3. I find this quite weird, but until I have > >> some time to test it

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-01-02 Thread Steffan Karger
On 02-01-17 16:24, SviMik wrote: > >> On 02-01-17 15:26, Gert Doering wrote: >>> On Mon, Jan 02, 2017 at 03:17:23PM +0100, Alberto Gonzalez >>> Iniesta wrote: I just got this [1] bug report on OpenVPN 2.4 threating all certs as expired when upgrading from 2.3. I find this quite weir

Re: [Openvpn-devel] Visual Studio support?

2017-01-02 Thread Arne Schwabe
Am 02.01.17 um 11:23 schrieb Gisle Vanem: > Fish Wang wrote: > >> I'm finishing up a patch to make sure OpenVPN compiles under Visual Studio. >> I have several questions; > > I'm also compiling using TDM-MinGW and MSVC-2015. But since approx 2 years, > the CL compiler breaks at compiling options.

Re: [Openvpn-devel] Crash in options.c

2017-01-02 Thread Gisle Vanem
Gert Doering wrote: >> uses a 'title_string[]' as format with no parameters specified and >> thus crashes as expected. So is all code outside '!defined(ENABLE_CRYPTO)' >> really dead code or what? > > Actually, "usage_message" is the format string here... Ah, my bad. Then it's a simple fix: -