Re: [OpenWrt-Devel] block-mount overrides /etc/config/fstab as defined by target
Hi, On Thu, 2011-03-31 at 15:05 -0400, Daniel Dickinson wrote: Actually this is normal. Order is base-files, then target/base-files, then packages. It's doing target/base-files/etc/config/fstab that is wrong because block-mount is not base-files. It looks like a target-specific hack to block-mount is needed, because there is no mechanism for target-specific overrides to packages other than base-files. Ok, in that case, I cannot picture why there is an fstab included in block-mount, as it is inherently target specific, and without a way to override it I can only imagine it causing more pain then it is worth to have a template installed by default. Regards, Ithamar. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] block-mount overrides /etc/config/fstab as defined by target
On Fri, 01 Apr 2011 12:43:43 +0200 Ithamar R. Adema ithamar.ad...@team-embedded.nl wrote: Hi, On Thu, 2011-03-31 at 15:05 -0400, Daniel Dickinson wrote: Actually this is normal. Order is base-files, then target/base-files, then packages. It's doing target/base-files/etc/config/fstab that is wrong because block-mount is not base-files. It looks like a target-specific hack to block-mount is needed, because there is no mechanism for target-specific overrides to packages other than base-files. Ok, in that case, I cannot picture why there is an fstab included in block-mount, as it is inherently target specific, and without a way to override it I can only imagine it causing more pain then it is worth to have a template installed by default. Regards, How is it 'inherently target specific' ? It varies from device to device, but even within a target it differs, so we pick what is most likely to be used (/dev/sdXX). It works for most people, and it's easy enough to change. Extroot or external storage isn't something that belongs as an enabled by default option anyway. This doesn't deal with mounting the rootfs for something that needs it to boot (for that you need USB built into the kernel). Regards, Daniel -- erno hm. I've lost a machine.. literally _lost_. it responds to ping, it works completely, I just can't figure out where in my apartment it is. GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] block-mount overrides /etc/config/fstab as defined by target
On Wed, 30 Mar 2011 19:14:42 +0200 Ithamar R. Adema ithamar.ad...@team-embedded.nl wrote: Hello, After a recent upgrade to latest Backfire I bumped into an interesting problem. If a target has a /etc/config/fstab file in its base-files (target/linux/$(TARGET)/base-files/etc/config/fstab) and has block-mount as package enabled, it will get the fstab file from the block-mount package instead of the one under target/linux. Ok, let me see if I understand what you are seeing first. When you say block-mount as package you mean that it is NOT installed into the image, but rather as a separate package to be installed later? This looks to me like a regression, as first of all, it didn't happen in earlier backfire versions, and second, it seems pretty unlogical. I can work around it for now by removed the 'conffiles' definition from the block-mount package, so it won't be installed as part of the package, but I agree that isn't the proper fix. Do you also remove the $(INTALL_DATA) ./files/fstab.config $(1)/etc/config/fstab ? If not then the file should still be installed regardless of the conffiles. AFAIK conffiles just says don't overwrite if it already exists. Regards, Daniel -- erno hm. I've lost a machine.. literally _lost_. it responds to ping, it works completely, I just can't figure out where in my apartment it is. GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] block-mount overrides /etc/config/fstab as defined by target
On Thu, 31 Mar 2011 20:09:07 +0200 Ithamar R. Adema ithamar.ad...@team-embedded.nl wrote: Do you also remove the $(INTALL_DATA) ./files/fstab.config $(1)/etc/config/fstab ? If not then the file should still be installed regardless of the conffiles. AFAIK conffiles just says don't overwrite if it already exists. No, I had to remove the fstab install line as well, to get it to behave. I thought I hadn't when I wrote the mail, hence the confusion. For some reason, the fstab of block-mount get precedence over any other. I can hardly imagine this is wanted behavior ;-) Actually this is normal. Order is base-files, then target/base-files, then packages. It's doing target/base-files/etc/config/fstab that is wrong because block-mount is not base-files. It looks like a target-specific hack to block-mount is needed, because there is no mechanism for target-specific overrides to packages other than base-files. -- erno hm. I've lost a machine.. literally _lost_. it responds to ping, it works completely, I just can't figure out where in my apartment it is. GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org signature.asc Description: PGP signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] block-mount overrides /etc/config/fstab as defined by target
Hello, After a recent upgrade to latest Backfire I bumped into an interesting problem. If a target has a /etc/config/fstab file in its base-files (target/linux/$(TARGET)/base-files/etc/config/fstab) and has block-mount as package enabled, it will get the fstab file from the block-mount package instead of the one under target/linux. This looks to me like a regression, as first of all, it didn't happen in earlier backfire versions, and second, it seems pretty unlogical. I can work around it for now by removed the 'conffiles' definition from the block-mount package, so it won't be installed as part of the package, but I agree that isn't the proper fix. Anyone ideas on how to fix this properly? Regards, Ithamar. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
