Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-11 Thread Sven Roederer
Am Montag, 11. Januar 2021, 03:59:51 CET schrieb Alberto Bursi: > On 10/01/21 22:40, Sven Roederer wrote: > > Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: > >>> Same. I would personally like this as default sysupgrade procedure, as > >>> that's what makes most sense imho. > >>>

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-11 Thread Martin Schiller
On 2021-01-11 14:38, Stijn Segers wrote: Hi Alberto, Alberto Bursi schreef op 11 januari 2021 03:56:23 CET: On 10/01/21 22:50, Stijn Segers wrote: Hi Sven, Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer : Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers:  > @@

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-11 Thread Stijn Segers
Hi Alberto, Alberto Bursi schreef op 11 januari 2021 03:56:23 CET: > > >On 10/01/21 22:50, Stijn Segers wrote: >> Hi Sven, >> >> Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer >> : >>> Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers:  > @@ -228,6 +229,7 @@

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-11 Thread Eneas U de Queiroz
+1 I agree 100% with Adrian on this one. Enable by default, add option to disable. Disabled services are, intuitively, part of the configuration being saved. So, it should not be saved when '-n' is given. I may be stretching things a bit, but I would consider this a fix, not a feature change

RE: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-11 Thread Adrian Schmutzler
> There are just 2 people (me, Andrew Heider) that would like to see saving > service status done by default when sysupgrading, and other 2 people that > would like it in its own setting option (Stjin Segers and Paul Spooren). +1 for saving service status by default. This has always annoyed me

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 22:40, Sven Roederer wrote: Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: Same. I would personally like this as default sysupgrade procedure, as that's what makes most sense imho. If I have disabled a service it makes sense that after a firmware upgrade it

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 22:50, Stijn Segers wrote: Hi Sven, Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer : Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers:  > @@ -228,6 +229,7 @@ do_save_conffiles() {  >  > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then  > echo

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Stijn Segers
Hi Sven, Op zondag 10 januari 2021 om 22u28 schreef Sven Roederer : Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers: > @@ -228,6 +229,7 @@ do_save_conffiles() { > > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then > echo "${INSTALLED_PACKAGES}" >> "$CONFFILES" > +

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Paul Spooren
On So, Jan 10, 2021 at 22:40, Sven Roederer wrote: Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: > Same. I would personally like this as default sysupgrade procedure, as > that's what makes most sense imho. > If I have disabled a service it makes sense that after a

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Sven Roederer
Am Sonntag, 10. Januar 2021, 09:47:27 CET schrieb Andre Heider: > > Same. I would personally like this as default sysupgrade procedure, as > > that's what makes most sense imho. > > If I have disabled a service it makes sense that after a firmware > > upgrade it remains disabled. > > Seconded. >

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Sven Roederer
Am Samstag, 9. Januar 2021, 12:28:31 CET schrieb Stijn Segers: > > @@ -228,6 +229,7 @@ do_save_conffiles() { > > > > if [ "$SAVE_INSTALLED_PKGS" -eq 1 ]; then > > echo "${INSTALLED_PACKAGES}" >> "$CONFFILES" > > + echo "${SERVICE_STATUS}" >> "$CONFFILES" > > mkdir -p

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Luiz Angelo Daros de Luca
> When saving the list of installed pkgs, also store the status of the > system services. The list is created in the etc/backup folder also > and formated as: > > /etc/init.d/ {enable|disable} > > This way it can be sourced after sysupgrade, to restore the previous > state. I also liked the idea.

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Alberto Bursi
On 10/01/21 08:26, Reiner Karlsberg wrote: Am 10.01.2021 um 03:32 schrieb Alberto Bursi: > > > On 09/01/21 12:56, Reiner Karlsberg wrote: >> Am 09.01.2021 um 13:28 schrieb Stijn Segers: >> >>  > Currently all services get enabled during image creation. This can cause >>  > issues

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-10 Thread Andre Heider
On 10/01/2021 02:37, Alberto Bursi wrote: On 09/01/21 12:28, Stijn Segers wrote: Hi, Op zondag 3 januari 2021 om 23u14 schreef Sven Roederer : When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Reiner Karlsberg
Am 10.01.2021 um 03:32 schrieb Alberto Bursi: > > > On 09/01/21 12:56, Reiner Karlsberg wrote: >> Am 09.01.2021 um 13:28 schrieb Stijn Segers: >> >> > Currently all services get enabled during image creation. This can cause >> > issues after upgrade with services explicitly disabled by the

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Alberto Bursi
On 09/01/21 12:28, Stijn Segers wrote: Hi, Op zondag 3 januari 2021 om 23u14 schreef Sven Roederer : When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and formated as: /etc/init.d/ {enable|disable} This

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Alberto Bursi
On 09/01/21 12:56, Reiner Karlsberg wrote: Am 09.01.2021 um 13:28 schrieb Stijn Segers: > Currently all services get enabled during image creation. This can cause > issues after upgrade with services explicitly disabled by the user. > With this created list sourced by a simple

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Paul Spooren
On So, Jan 3, 2021 at 23:14, Sven Roederer wrote: When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and formated as: /etc/init.d/ {enable|disable} This way it can be sourced after sysupgrade, to restore

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Daniel Golle
On Sat, Jan 09, 2021 at 01:56:13PM +0200, Reiner Karlsberg wrote: > Am 09.01.2021 um 13:28 schrieb Stijn Segers: > > > Currently all services get enabled during image creation. This can cause > > issues after upgrade with services explicitly disabled by the user. > > With this created list

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Reiner Karlsberg
Am 09.01.2021 um 13:28 schrieb Stijn Segers: > Currently all services get enabled during image creation. This can cause > issues after upgrade with services explicitly disabled by the user. > With this created list sourced by a simple uci-defaults script the state > can be restored

Re: [PATCH] base-files: sysupgrade: store status of system-services

2021-01-09 Thread Stijn Segers
Hi, Op zondag 3 januari 2021 om 23u14 schreef Sven Roederer : When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and formated as: /etc/init.d/ {enable|disable} This way it can be sourced after sysupgrade, to

[PATCH] base-files: sysupgrade: store status of system-services

2021-01-03 Thread Sven Roederer
When saving the list of installed pkgs, also store the status of the system services. The list is created in the etc/backup folder also and formated as: /etc/init.d/ {enable|disable} This way it can be sourced after sysupgrade, to restore the previous state. Signed-off-by: Sven Roederer ---